nextcloud / server

lib/private/Session/CryptoSessionData.php

Spacing +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
 	public function __destruct() {
 		try {
 			$this->close();
-		} catch (SessionNotAvailableException $e){
+		} catch (SessionNotAvailableException $e) {
 			// This exception can occur if session is already closed
 			// So it is safe to ignore it and let the garbage collector to proceed
 		}
@@ -105,7 +105,7 @@ 
 	 * @return string|null Either the value or null
 	 */
 	public function get(string $key) {
-		if(isset($this->sessionValues[$key])) {
+		if (isset($this->sessionValues[$key])) {
 			return $this->sessionValues[$key];
 		}
 
@@ -171,7 +171,7 @@ 
 	 * Close the session and release the lock, also writes all changed data in batch
 	 */
 	public function close() {
-		if($this->isModified) {
+		if ($this->isModified) {
 			$encryptedValue = $this->crypto->encrypt(json_encode($this->sessionValues), $this->passphrase);
 			$this->session->set(self::encryptedSessionName, $encryptedValue);
 			$this->isModified = false;

lib/private/Session/Internal.php

Spacing +2 added lines, -2 removed lines

@@ -170,12 +170,12 @@
 	 */
 	private function invoke(string $functionName, array $parameters = [], bool $silence = false) {
 		try {
-			if($silence) {
+			if ($silence) {
 				return @call_user_func_array($functionName, $parameters);
 			} else {
 				return call_user_func_array($functionName, $parameters);
 			}
-		} catch(\Error $e) {
+		} catch (\Error $e) {
 			$this->trapError($e->getCode(), $e->getMessage());
 		}
 	}

lib/private/Security/IdentityProof/Signer.php

Spacing +3 added lines, -3 removed lines

@@ -81,7 +81,7 @@ 
 	 * @return bool
 	 */
 	public function verify(array $data): bool {
-		if(isset($data['message'])
+		if (isset($data['message'])
 			&& isset($data['signature'])
 			&& isset($data['message']['signer'])
 		) {
@@ -89,9 +89,9 @@ 
 			$userId = substr($data['message']['signer'], 0, $location);
 
 			$user = $this->userManager->get($userId);
-			if($user !== null) {
+			if ($user !== null) {
 				$key = $this->keyManager->getKey($user);
-				return (bool)openssl_verify(
+				return (bool) openssl_verify(
 					json_encode($data['message']),
 					base64_decode($data['signature']),
 					$key->getPublic(),

lib/private/Security/Hasher.php

Spacing +13 added lines, -13 removed lines

@@ -62,7 +62,7 @@ 
 		$this->config = $config;
 
 		$hashingCost = $this->config->getSystemValue('hashingCost', null);
-		if(!\is_null($hashingCost)) {
+		if (!\is_null($hashingCost)) {
 			$this->options['cost'] = $hashingCost;
 		}
 	}
@@ -77,9 +77,9 @@ 
 	 */
 	public function hash(string $message): string {
 		if (\defined('PASSWORD_ARGON2I')) {
-			return 2 . '|' . password_hash($message, PASSWORD_ARGON2I, $this->options);
+			return 2.'|'.password_hash($message, PASSWORD_ARGON2I, $this->options);
 		} else {
-			return 1 . '|' . password_hash($message, PASSWORD_BCRYPT, $this->options);
+			return 1.'|'.password_hash($message, PASSWORD_BCRYPT, $this->options);
 		}
 	}
 
@@ -90,9 +90,9 @@ 
 	 */
 	protected function splitHash(string $prefixedHash) {
 		$explodedString = explode('|', $prefixedHash, 2);
-		if(\count($explodedString) === 2) {
-			if((int)$explodedString[0] > 0) {
-				return ['version' => (int)$explodedString[0], 'hash' => $explodedString[1]];
+		if (\count($explodedString) === 2) {
+			if ((int) $explodedString[0] > 0) {
+				return ['version' => (int) $explodedString[0], 'hash' => $explodedString[1]];
 			}
 		}
 
@@ -107,13 +107,13 @@ 
 	 * @return bool Whether $hash is a valid hash of $message
 	 */
 	protected function legacyHashVerify($message, $hash, &$newHash = null): bool {
-		if(empty($this->legacySalt)) {
+		if (empty($this->legacySalt)) {
 			$this->legacySalt = $this->config->getSystemValue('passwordsalt', '');
 		}
 
 		// Verify whether it matches a legacy PHPass or SHA1 string
 		$hashLength = \strlen($hash);
-		if(($hashLength === 60 && password_verify($message.$this->legacySalt, $hash)) ||
+		if (($hashLength === 60 && password_verify($message.$this->legacySalt, $hash)) ||
 			($hashLength === 40 && hash_equals($hash, sha1($message)))) {
 			$newHash = $this->hash($message);
 			return true;
@@ -130,13 +130,13 @@ 
 	 * @return bool Whether $hash is a valid hash of $message
 	 */
 	protected function verifyHashV1(string $message, string $hash, &$newHash = null): bool {
-		if(password_verify($message, $hash)) {
+		if (password_verify($message, $hash)) {
 			$algo = PASSWORD_BCRYPT;
 			if (\defined('PASSWORD_ARGON2I')) {
 				$algo = PASSWORD_ARGON2I;
 			}
 
-			if(password_needs_rehash($hash, $algo, $this->options)) {
+			if (password_needs_rehash($hash, $algo, $this->options)) {
 				$newHash = $this->hash($message);
 			}
 			return true;
@@ -153,8 +153,8 @@ 
 	 * @return bool Whether $hash is a valid hash of $message
 	 */
 	protected function verifyHashV2(string $message, string $hash, &$newHash = null) : bool {
-		if(password_verify($message, $hash)) {
-			if(password_needs_rehash($hash, PASSWORD_ARGON2I, $this->options)) {
+		if (password_verify($message, $hash)) {
+			if (password_needs_rehash($hash, PASSWORD_ARGON2I, $this->options)) {
 				$newHash = $this->hash($message);
 			}
 			return true;
@@ -172,7 +172,7 @@ 
 	public function verify(string $message, string $hash, &$newHash = null): bool {
 		$splittedHash = $this->splitHash($hash);
 
-		if(isset($splittedHash['version'])) {
+		if (isset($splittedHash['version'])) {
 			switch ($splittedHash['version']) {
 				case 2:
 					return $this->verifyHashV2($message, $splittedHash['hash'], $newHash);

lib/private/Security/SecureRandom.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
 		$maxCharIndex = \strlen($characters) - 1;
 		$randomString = '';
 
-		while($length > 0) {
+		while ($length > 0) {
 			$randomNumber = \random_int(0, $maxCharIndex);
 			$randomString .= $characters[$randomNumber];
 			$length--;

lib/private/Security/CSRF/TokenStorage/SessionStorage.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 	 */
 	public function getToken(): string {
 		$token = $this->session->get('requesttoken');
-		if(empty($token)) {
+		if (empty($token)) {
 			throw new \Exception('Session does not contain a requesttoken');
 		}
 

lib/private/Security/CSRF/CsrfToken.php

Spacing +2 added lines, -2 removed lines

@@ -52,9 +52,9 @@
 	 * @return string
 	 */
 	public function getEncryptedValue(): string {
-		if($this->encryptedValue === '') {
+		if ($this->encryptedValue === '') {
 			$sharedSecret = random_bytes(\strlen($this->value));
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
+			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret).':'.base64_encode($sharedSecret);
 		}
 
 		return $this->encryptedValue;

lib/private/Security/CSRF/CsrfTokenManager.php

Spacing +3 added lines, -3 removed lines

@@ -54,11 +54,11 @@ 
 	 * @return CsrfToken
 	 */
 	public function getToken(): CsrfToken {
-		if(!\is_null($this->csrfToken)) {
+		if (!\is_null($this->csrfToken)) {
 			return $this->csrfToken;
 		}
 
-		if($this->sessionStorage->hasToken()) {
+		if ($this->sessionStorage->hasToken()) {
 			$value = $this->sessionStorage->getToken();
 		} else {
 			$value = $this->tokenGenerator->generateToken();
@@ -96,7 +96,7 @@ 
 	 * @return bool
 	 */
 	public function isTokenValid(CsrfToken $token): bool {
-		if(!$this->sessionStorage->hasToken()) {
+		if (!$this->sessionStorage->hasToken()) {
 			return false;
 		}
 

lib/private/Security/RateLimiting/Backend/MemoryCache.php

Spacing +5 added lines, -5 removed lines

@@ -57,7 +57,7 @@ 
 	 */
 	private function hash(string $methodIdentifier,
 						  string $userIdentifier): string {
-		return hash('sha512', $methodIdentifier . $userIdentifier);
+		return hash('sha512', $methodIdentifier.$userIdentifier);
 	}
 
 	/**
@@ -71,7 +71,7 @@ 
 		}
 
 		$cachedAttempts = json_decode($cachedAttempts, true);
-		if(\is_array($cachedAttempts)) {
+		if (\is_array($cachedAttempts)) {
 			return $cachedAttempts;
 		}
 
@@ -91,7 +91,7 @@ 
 		$currentTime = $this->timeFactory->getTime();
 		/** @var array $existingAttempts */
 		foreach ($existingAttempts as $attempt) {
-			if(($attempt + $seconds) > $currentTime) {
+			if (($attempt + $seconds) > $currentTime) {
 				$count++;
 			}
 		}
@@ -111,14 +111,14 @@ 
 
 		// Unset all attempts older than $period
 		foreach ($existingAttempts as $key => $attempt) {
-			if(($attempt + $period) < $currentTime) {
+			if (($attempt + $period) < $currentTime) {
 				unset($existingAttempts[$key]);
 			}
 		}
 		$existingAttempts = array_values($existingAttempts);
 
 		// Store the new attempt
-		$existingAttempts[] = (string)$currentTime;
+		$existingAttempts[] = (string) $currentTime;
 		$this->cache->set($identifier, json_encode($existingAttempts));
 	}
 }