Conditions | 18 |
Paths | 162 |
Total Lines | 156 |
Code Lines | 109 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
162 | public function onAddressbookUpdateShares(array $addressbookData, array $shares, array $add, array $remove): void { |
||
163 | $principal = explode('/', $addressbookData['principaluri']); |
||
164 | $owner = $principal[2]; |
||
165 | |||
166 | $currentUser = $this->userSession->getUser(); |
||
167 | if ($currentUser instanceof IUser) { |
||
168 | $currentUser = $currentUser->getUID(); |
||
169 | } else { |
||
170 | $currentUser = $owner; |
||
171 | } |
||
172 | |||
173 | $event = $this->activityManager->generateEvent(); |
||
174 | $event->setApp('dav') |
||
175 | ->setObject('addressbook', (int) $addressbookData['id']) |
||
176 | ->setType('addressbook') |
||
177 | ->setAuthor($currentUser); |
||
178 | |||
179 | foreach ($remove as $principal) { |
||
180 | // principal:principals/users/test |
||
181 | $parts = explode(':', $principal, 2); |
||
182 | if ($parts[0] !== 'principal') { |
||
183 | continue; |
||
184 | } |
||
185 | $principal = explode('/', $parts[1]); |
||
186 | |||
187 | if ($principal[1] === 'users') { |
||
188 | $this->triggerActivityUser( |
||
189 | $principal[2], |
||
190 | $event, |
||
191 | $addressbookData, |
||
192 | Addressbook::SUBJECT_UNSHARE_USER, |
||
193 | Addressbook::SUBJECT_DELETE . '_self' |
||
194 | ); |
||
195 | |||
196 | if ($owner !== $principal[2]) { |
||
197 | $parameters = [ |
||
198 | 'actor' => $event->getAuthor(), |
||
199 | 'addressbook' => [ |
||
200 | 'id' => (int) $addressbookData['id'], |
||
201 | 'uri' => $addressbookData['uri'], |
||
202 | 'name' => $addressbookData['{DAV:}displayname'], |
||
203 | ], |
||
204 | 'user' => $principal[2], |
||
205 | ]; |
||
206 | |||
207 | if ($owner === $event->getAuthor()) { |
||
208 | $subject = Addressbook::SUBJECT_UNSHARE_USER . '_you'; |
||
209 | } elseif ($principal[2] === $event->getAuthor()) { |
||
210 | $subject = Addressbook::SUBJECT_UNSHARE_USER . '_self'; |
||
211 | } else { |
||
212 | $event->setAffectedUser($event->getAuthor()) |
||
213 | ->setSubject(Addressbook::SUBJECT_UNSHARE_USER . '_you', $parameters); |
||
214 | $this->activityManager->publish($event); |
||
215 | |||
216 | $subject = Addressbook::SUBJECT_UNSHARE_USER . '_by'; |
||
217 | } |
||
218 | |||
219 | $event->setAffectedUser($owner) |
||
220 | ->setSubject($subject, $parameters); |
||
221 | $this->activityManager->publish($event); |
||
222 | } |
||
223 | } elseif ($principal[1] === 'groups') { |
||
224 | $this->triggerActivityGroup($principal[2], $event, $addressbookData, Addressbook::SUBJECT_UNSHARE_USER); |
||
225 | |||
226 | $parameters = [ |
||
227 | 'actor' => $event->getAuthor(), |
||
228 | 'addressbook' => [ |
||
229 | 'id' => (int) $addressbookData['id'], |
||
230 | 'uri' => $addressbookData['uri'], |
||
231 | 'name' => $addressbookData['{DAV:}displayname'], |
||
232 | ], |
||
233 | 'group' => $principal[2], |
||
234 | ]; |
||
235 | |||
236 | if ($owner === $event->getAuthor()) { |
||
237 | $subject = Addressbook::SUBJECT_UNSHARE_GROUP . '_you'; |
||
238 | } else { |
||
239 | $event->setAffectedUser($event->getAuthor()) |
||
240 | ->setSubject(Addressbook::SUBJECT_UNSHARE_GROUP . '_you', $parameters); |
||
241 | $this->activityManager->publish($event); |
||
242 | |||
243 | $subject = Addressbook::SUBJECT_UNSHARE_GROUP . '_by'; |
||
244 | } |
||
245 | |||
246 | $event->setAffectedUser($owner) |
||
247 | ->setSubject($subject, $parameters); |
||
248 | $this->activityManager->publish($event); |
||
249 | } |
||
250 | } |
||
251 | |||
252 | foreach ($add as $share) { |
||
253 | if ($this->isAlreadyShared($share['href'], $shares)) { |
||
254 | continue; |
||
255 | } |
||
256 | |||
257 | // principal:principals/users/test |
||
258 | $parts = explode(':', $share['href'], 2); |
||
259 | if ($parts[0] !== 'principal') { |
||
260 | continue; |
||
261 | } |
||
262 | $principal = explode('/', $parts[1]); |
||
263 | |||
264 | if ($principal[1] === 'users') { |
||
265 | $this->triggerActivityUser($principal[2], $event, $addressbookData, Addressbook::SUBJECT_SHARE_USER); |
||
266 | |||
267 | if ($owner !== $principal[2]) { |
||
268 | $parameters = [ |
||
269 | 'actor' => $event->getAuthor(), |
||
270 | 'addressbook' => [ |
||
271 | 'id' => (int) $addressbookData['id'], |
||
272 | 'uri' => $addressbookData['uri'], |
||
273 | 'name' => $addressbookData['{DAV:}displayname'], |
||
274 | ], |
||
275 | 'user' => $principal[2], |
||
276 | ]; |
||
277 | |||
278 | if ($owner === $event->getAuthor()) { |
||
279 | $subject = Addressbook::SUBJECT_SHARE_USER . '_you'; |
||
280 | } else { |
||
281 | $event->setAffectedUser($event->getAuthor()) |
||
282 | ->setSubject(Addressbook::SUBJECT_SHARE_USER . '_you', $parameters); |
||
283 | $this->activityManager->publish($event); |
||
284 | |||
285 | $subject = Addressbook::SUBJECT_SHARE_USER . '_by'; |
||
286 | } |
||
287 | |||
288 | $event->setAffectedUser($owner) |
||
289 | ->setSubject($subject, $parameters); |
||
290 | $this->activityManager->publish($event); |
||
291 | } |
||
292 | } elseif ($principal[1] === 'groups') { |
||
293 | $this->triggerActivityGroup($principal[2], $event, $addressbookData, Addressbook::SUBJECT_SHARE_USER); |
||
294 | |||
295 | $parameters = [ |
||
296 | 'actor' => $event->getAuthor(), |
||
297 | 'addressbook' => [ |
||
298 | 'id' => (int) $addressbookData['id'], |
||
299 | 'uri' => $addressbookData['uri'], |
||
300 | 'name' => $addressbookData['{DAV:}displayname'], |
||
301 | ], |
||
302 | 'group' => $principal[2], |
||
303 | ]; |
||
304 | |||
305 | if ($owner === $event->getAuthor()) { |
||
306 | $subject = Addressbook::SUBJECT_SHARE_GROUP . '_you'; |
||
307 | } else { |
||
308 | $event->setAffectedUser($event->getAuthor()) |
||
309 | ->setSubject(Addressbook::SUBJECT_SHARE_GROUP . '_you', $parameters); |
||
310 | $this->activityManager->publish($event); |
||
311 | |||
312 | $subject = Addressbook::SUBJECT_SHARE_GROUP . '_by'; |
||
313 | } |
||
314 | |||
315 | $event->setAffectedUser($owner) |
||
316 | ->setSubject($subject, $parameters); |
||
317 | $this->activityManager->publish($event); |
||
318 | } |
||
486 |