Completed
Push — master ( ede649...d3e7dd )
by Lukas
16:27
created
apps/user_ldap/lib/User/User.php 1 patch
Spacing   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -149,17 +149,17 @@  discard block
 block discarded – undo
149 149
 	 * @return null
150 150
 	 */
151 151
 	public function update() {
152
-		if(is_null($this->dn)) {
152
+		if (is_null($this->dn)) {
153 153
 			return null;
154 154
 		}
155 155
 
156 156
 		$hasLoggedIn = $this->config->getUserValue($this->uid, 'user_ldap',
157 157
 				self::USER_PREFKEY_FIRSTLOGIN, 0);
158 158
 
159
-		if($this->needsRefresh()) {
159
+		if ($this->needsRefresh()) {
160 160
 			$this->updateEmail();
161 161
 			$this->updateQuota();
162
-			if($hasLoggedIn !== 0) {
162
+			if ($hasLoggedIn !== 0) {
163 163
 				//we do not need to try it, when the user has not been logged in
164 164
 				//before, because the file system will not be ready.
165 165
 				$this->updateAvatar();
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 		$this->markRefreshTime();
179 179
 		//Quota
180 180
 		$attr = strtolower($this->connection->ldapQuotaAttribute);
181
-		if(isset($ldapEntry[$attr])) {
181
+		if (isset($ldapEntry[$attr])) {
182 182
 			$this->updateQuota($ldapEntry[$attr][0]);
183 183
 		} else {
184 184
 			if ($this->connection->ldapQuotaDefault !== '') {
@@ -190,11 +190,11 @@  discard block
 block discarded – undo
190 190
 		//displayName
191 191
 		$displayName = $displayName2 = '';
192 192
 		$attr = strtolower($this->connection->ldapUserDisplayName);
193
-		if(isset($ldapEntry[$attr])) {
193
+		if (isset($ldapEntry[$attr])) {
194 194
 			$displayName = strval($ldapEntry[$attr][0]);
195 195
 		}
196 196
 		$attr = strtolower($this->connection->ldapUserDisplayName2);
197
-		if(isset($ldapEntry[$attr])) {
197
+		if (isset($ldapEntry[$attr])) {
198 198
 			$displayName2 = strval($ldapEntry[$attr][0]);
199 199
 		}
200 200
 		if ($displayName !== '') {
@@ -211,22 +211,22 @@  discard block
 block discarded – undo
211 211
 		//email must be stored after displayname, because it would cause a user
212 212
 		//change event that will trigger fetching the display name again
213 213
 		$attr = strtolower($this->connection->ldapEmailAttribute);
214
-		if(isset($ldapEntry[$attr])) {
214
+		if (isset($ldapEntry[$attr])) {
215 215
 			$this->updateEmail($ldapEntry[$attr][0]);
216 216
 		}
217 217
 		unset($attr);
218 218
 
219 219
 		// LDAP Username, needed for s2s sharing
220
-		if(isset($ldapEntry['uid'])) {
220
+		if (isset($ldapEntry['uid'])) {
221 221
 			$this->storeLDAPUserName($ldapEntry['uid'][0]);
222
-		} else if(isset($ldapEntry['samaccountname'])) {
222
+		} else if (isset($ldapEntry['samaccountname'])) {
223 223
 			$this->storeLDAPUserName($ldapEntry['samaccountname'][0]);
224 224
 		}
225 225
 
226 226
 		//homePath
227
-		if(strpos($this->connection->homeFolderNamingRule, 'attr:') === 0) {
227
+		if (strpos($this->connection->homeFolderNamingRule, 'attr:') === 0) {
228 228
 			$attr = strtolower(substr($this->connection->homeFolderNamingRule, strlen('attr:')));
229
-			if(isset($ldapEntry[$attr])) {
229
+			if (isset($ldapEntry[$attr])) {
230 230
 				$this->access->cacheUserHome(
231 231
 					$this->getUsername(), $this->getHomePath($ldapEntry[$attr][0]));
232 232
 			}
@@ -235,15 +235,15 @@  discard block
 block discarded – undo
235 235
 		//memberOf groups
236 236
 		$cacheKey = 'getMemberOf'.$this->getUsername();
237 237
 		$groups = false;
238
-		if(isset($ldapEntry['memberof'])) {
238
+		if (isset($ldapEntry['memberof'])) {
239 239
 			$groups = $ldapEntry['memberof'];
240 240
 		}
241 241
 		$this->connection->writeToCache($cacheKey, $groups);
242 242
 
243 243
 		//Avatar
244 244
 		$attrs = array('jpegphoto', 'thumbnailphoto');
245
-		foreach ($attrs as $attr)  {
246
-			if(isset($ldapEntry[$attr])) {
245
+		foreach ($attrs as $attr) {
246
+			if (isset($ldapEntry[$attr])) {
247 247
 				$this->avatarImage = $ldapEntry[$attr][0];
248 248
 				// the call to the method that saves the avatar in the file
249 249
 				// system must be postponed after the login. It is to ensure
@@ -296,12 +296,12 @@  discard block
 block discarded – undo
296 296
 		if ($path !== '') {
297 297
 			//if attribute's value is an absolute path take this, otherwise append it to data dir
298 298
 			//check for / at the beginning or pattern c:\ resp. c:/
299
-			if(   '/' !== $path[0]
299
+			if ('/' !== $path[0]
300 300
 			   && !(3 < strlen($path) && ctype_alpha($path[0])
301 301
 			       && $path[1] === ':' && ('\\' === $path[2] || '/' === $path[2]))
302 302
 			) {
303 303
 				$path = $this->config->getSystemValue('datadirectory',
304
-						\OC::$SERVERROOT.'/data' ) . '/' . $path;
304
+						\OC::$SERVERROOT.'/data').'/'.$path;
305 305
 			}
306 306
 			//we need it to store it in the DB as well in case a user gets
307 307
 			//deleted so we can clean up afterwards
@@ -311,11 +311,11 @@  discard block
 block discarded – undo
311 311
 			return $path;
312 312
 		}
313 313
 
314
-		if(    !is_null($attr)
314
+		if (!is_null($attr)
315 315
 			&& $this->config->getAppValue('user_ldap', 'enforce_home_folder_naming_rule', true)
316 316
 		) {
317 317
 			// a naming rule attribute is defined, but it doesn't exist for that LDAP user
318
-			throw new \Exception('Home dir attribute can\'t be read from LDAP for uid: ' . $this->getUsername());
318
+			throw new \Exception('Home dir attribute can\'t be read from LDAP for uid: '.$this->getUsername());
319 319
 		}
320 320
 
321 321
 		//false will apply default behaviour as defined and done by OC_User
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 	public function getMemberOfGroups() {
327 327
 		$cacheKey = 'getMemberOf'.$this->getUsername();
328 328
 		$memberOfGroups = $this->connection->getFromCache($cacheKey);
329
-		if(!is_null($memberOfGroups)) {
329
+		if (!is_null($memberOfGroups)) {
330 330
 			return $memberOfGroups;
331 331
 		}
332 332
 		$groupDNs = $this->access->readAttribute($this->getDN(), 'memberOf');
@@ -339,15 +339,15 @@  discard block
 block discarded – undo
339 339
 	 * @return string data (provided by LDAP) | false
340 340
 	 */
341 341
 	public function getAvatarImage() {
342
-		if(!is_null($this->avatarImage)) {
342
+		if (!is_null($this->avatarImage)) {
343 343
 			return $this->avatarImage;
344 344
 		}
345 345
 
346 346
 		$this->avatarImage = false;
347 347
 		$attributes = array('jpegPhoto', 'thumbnailPhoto');
348
-		foreach($attributes as $attribute) {
348
+		foreach ($attributes as $attribute) {
349 349
 			$result = $this->access->readAttribute($this->dn, $attribute);
350
-			if($result !== false && is_array($result) && isset($result[0])) {
350
+			if ($result !== false && is_array($result) && isset($result[0])) {
351 351
 				$this->avatarImage = $result[0];
352 352
 				break;
353 353
 			}
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
 			self::USER_PREFKEY_LASTREFRESH, 0);
386 386
 
387 387
 		//TODO make interval configurable
388
-		if((time() - intval($lastChecked)) < 86400 ) {
388
+		if ((time() - intval($lastChecked)) < 86400) {
389 389
 			return false;
390 390
 		}
391 391
 		return  true;
@@ -411,8 +411,8 @@  discard block
 block discarded – undo
411 411
 	 */
412 412
 	public function composeAndStoreDisplayName($displayName, $displayName2 = '') {
413 413
 		$displayName2 = strval($displayName2);
414
-		if($displayName2 !== '') {
415
-			$displayName .= ' (' . $displayName2 . ')';
414
+		if ($displayName2 !== '') {
415
+			$displayName .= ' ('.$displayName2.')';
416 416
 		}
417 417
 		$this->store('displayName', $displayName);
418 418
 		return $displayName;
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 	 * @return bool
435 435
 	 */
436 436
 	private function wasRefreshed($feature) {
437
-		if(isset($this->refreshedFeatures[$feature])) {
437
+		if (isset($this->refreshedFeatures[$feature])) {
438 438
 			return true;
439 439
 		}
440 440
 		$this->refreshedFeatures[$feature] = 1;
@@ -447,15 +447,15 @@  discard block
 block discarded – undo
447 447
 	 * @return null
448 448
 	 */
449 449
 	public function updateEmail($valueFromLDAP = null) {
450
-		if($this->wasRefreshed('email')) {
450
+		if ($this->wasRefreshed('email')) {
451 451
 			return;
452 452
 		}
453 453
 		$email = strval($valueFromLDAP);
454
-		if(is_null($valueFromLDAP)) {
454
+		if (is_null($valueFromLDAP)) {
455 455
 			$emailAttribute = $this->connection->ldapEmailAttribute;
456 456
 			if ($emailAttribute !== '') {
457 457
 				$aEmail = $this->access->readAttribute($this->dn, $emailAttribute);
458
-				if(is_array($aEmail) && (count($aEmail) > 0)) {
458
+				if (is_array($aEmail) && (count($aEmail) > 0)) {
459 459
 					$email = strval($aEmail[0]);
460 460
 				}
461 461
 			}
@@ -492,20 +492,20 @@  discard block
 block discarded – undo
492 492
 	 * @return null
493 493
 	 */
494 494
 	public function updateQuota($valueFromLDAP = null) {
495
-		if($this->wasRefreshed('quota')) {
495
+		if ($this->wasRefreshed('quota')) {
496 496
 			return;
497 497
 		}
498 498
 
499 499
 		$quota = false;
500
-		if(is_null($valueFromLDAP)) {
500
+		if (is_null($valueFromLDAP)) {
501 501
 			$quotaAttribute = $this->connection->ldapQuotaAttribute;
502 502
 			if ($quotaAttribute !== '') {
503 503
 				$aQuota = $this->access->readAttribute($this->dn, $quotaAttribute);
504
-				if($aQuota && (count($aQuota) > 0)) {
504
+				if ($aQuota && (count($aQuota) > 0)) {
505 505
 					if ($this->verifyQuotaValue($aQuota[0])) {
506 506
 						$quota = $aQuota[0];
507 507
 					} else {
508
-						$this->log->log('not suitable LDAP quota found for user ' . $this->uid . ': [' . $aQuota[0] . ']', \OCP\Util::WARN);
508
+						$this->log->log('not suitable LDAP quota found for user '.$this->uid.': ['.$aQuota[0].']', \OCP\Util::WARN);
509 509
 					}
510 510
 				}
511 511
 			}
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 			if ($this->verifyQuotaValue($valueFromLDAP)) {
514 514
 				$quota = $valueFromLDAP;
515 515
 			} else {
516
-				$this->log->log('not suitable LDAP quota found for user ' . $this->uid . ': [' . $valueFromLDAP . ']', \OCP\Util::WARN);
516
+				$this->log->log('not suitable LDAP quota found for user '.$this->uid.': ['.$valueFromLDAP.']', \OCP\Util::WARN);
517 517
 			}
518 518
 		}
519 519
 
@@ -527,13 +527,13 @@  discard block
 block discarded – undo
527 527
 
528 528
 		$targetUser = $this->userManager->get($this->uid);
529 529
 		if ($targetUser) {
530
-			if($quota !== false) {
530
+			if ($quota !== false) {
531 531
 				$targetUser->setQuota($quota);
532 532
 			} else {
533
-				$this->log->log('not suitable default quota found for user ' . $this->uid . ': [' . $defaultQuota . ']', \OCP\Util::WARN);
533
+				$this->log->log('not suitable default quota found for user '.$this->uid.': ['.$defaultQuota.']', \OCP\Util::WARN);
534 534
 			}
535 535
 		} else {
536
-			$this->log->log('trying to set a quota for user ' . $this->uid . ' but the user is missing', \OCP\Util::ERROR);
536
+			$this->log->log('trying to set a quota for user '.$this->uid.' but the user is missing', \OCP\Util::ERROR);
537 537
 		}
538 538
 	}
539 539
 
@@ -547,7 +547,7 @@  discard block
 block discarded – undo
547 547
 	 * @param array $params
548 548
 	 */
549 549
 	public function updateAvatarPostLogin($params) {
550
-		if(isset($params['uid']) && $params['uid'] === $this->getUsername()) {
550
+		if (isset($params['uid']) && $params['uid'] === $this->getUsername()) {
551 551
 			$this->updateAvatar();
552 552
 		}
553 553
 	}
@@ -557,11 +557,11 @@  discard block
 block discarded – undo
557 557
 	 * @return null
558 558
 	 */
559 559
 	public function updateAvatar() {
560
-		if($this->wasRefreshed('avatar')) {
560
+		if ($this->wasRefreshed('avatar')) {
561 561
 			return;
562 562
 		}
563 563
 		$avatarImage = $this->getAvatarImage();
564
-		if($avatarImage === false) {
564
+		if ($avatarImage === false) {
565 565
 			//not set, nothing left to do;
566 566
 			return;
567 567
 		}
@@ -574,18 +574,18 @@  discard block
 block discarded – undo
574 574
 	 * @return null
575 575
 	 */
576 576
 	private function setOwnCloudAvatar() {
577
-		if(!$this->image->valid()) {
577
+		if (!$this->image->valid()) {
578 578
 			$this->log->log('jpegPhoto data invalid for '.$this->dn, \OCP\Util::ERROR);
579 579
 			return;
580 580
 		}
581 581
 		//make sure it is a square and not bigger than 128x128
582 582
 		$size = min(array($this->image->width(), $this->image->height(), 128));
583
-		if(!$this->image->centerCrop($size)) {
583
+		if (!$this->image->centerCrop($size)) {
584 584
 			$this->log->log('croping image for avatar failed for '.$this->dn, \OCP\Util::ERROR);
585 585
 			return;
586 586
 		}
587 587
 
588
-		if(!$this->fs->isLoaded()) {
588
+		if (!$this->fs->isLoaded()) {
589 589
 			$this->fs->setup($this->uid);
590 590
 		}
591 591
 
@@ -594,7 +594,7 @@  discard block
 block discarded – undo
594 594
 			$avatar->set($this->image);
595 595
 		} catch (\Exception $e) {
596 596
 			\OC::$server->getLogger()->notice(
597
-				'Could not set avatar for ' . $this->dn	. ', because: ' . $e->getMessage(),
597
+				'Could not set avatar for '.$this->dn.', because: '.$e->getMessage(),
598 598
 				['app' => 'user_ldap']);
599 599
 		}
600 600
 	}
@@ -607,17 +607,17 @@  discard block
 block discarded – undo
607 607
 	public function handlePasswordExpiry($params) {
608 608
 		$ppolicyDN = $this->connection->ldapDefaultPPolicyDN;
609 609
 		if (empty($ppolicyDN) || (intval($this->connection->turnOnPasswordChange) !== 1)) {
610
-			return;//password expiry handling disabled
610
+			return; //password expiry handling disabled
611 611
 		}
612 612
 		$uid = $params['uid'];
613
-		if(isset($uid) && $uid === $this->getUsername()) {
613
+		if (isset($uid) && $uid === $this->getUsername()) {
614 614
 			//retrieve relevant user attributes
615 615
 			$result = $this->access->search('objectclass=*', $this->dn, ['pwdpolicysubentry', 'pwdgraceusetime', 'pwdreset', 'pwdchangedtime']);
616 616
 			
617
-			if(array_key_exists('pwdpolicysubentry', $result[0])) {
617
+			if (array_key_exists('pwdpolicysubentry', $result[0])) {
618 618
 				$pwdPolicySubentry = $result[0]['pwdpolicysubentry'];
619
-				if($pwdPolicySubentry && (count($pwdPolicySubentry) > 0)){
620
-					$ppolicyDN = $pwdPolicySubentry[0];//custom ppolicy DN
619
+				if ($pwdPolicySubentry && (count($pwdPolicySubentry) > 0)) {
620
+					$ppolicyDN = $pwdPolicySubentry[0]; //custom ppolicy DN
621 621
 				}
622 622
 			}
623 623
 			
@@ -626,9 +626,9 @@  discard block
 block discarded – undo
626 626
 			$pwdChangedTime = array_key_exists('pwdchangedtime', $result[0]) ? $result[0]['pwdchangedtime'] : null;
627 627
 			
628 628
 			//retrieve relevant password policy attributes
629
-			$cacheKey = 'ppolicyAttributes' . $ppolicyDN;
629
+			$cacheKey = 'ppolicyAttributes'.$ppolicyDN;
630 630
 			$result = $this->connection->getFromCache($cacheKey);
631
-			if(is_null($result)) {
631
+			if (is_null($result)) {
632 632
 				$result = $this->access->search('objectclass=*', $ppolicyDN, ['pwdgraceauthnlimit', 'pwdmaxage', 'pwdexpirewarning']);
633 633
 				$this->connection->writeToCache($cacheKey, $result);
634 634
 			}
@@ -639,8 +639,8 @@  discard block
 block discarded – undo
639 639
 			
640 640
 			//handle grace login
641 641
 			$pwdGraceUseTimeCount = count($pwdGraceUseTime);
642
-			if($pwdGraceUseTime && $pwdGraceUseTimeCount > 0) { //was this a grace login?
643
-				if($pwdGraceAuthNLimit 
642
+			if ($pwdGraceUseTime && $pwdGraceUseTimeCount > 0) { //was this a grace login?
643
+				if ($pwdGraceAuthNLimit 
644 644
 					&& (count($pwdGraceAuthNLimit) > 0)
645 645
 					&&($pwdGraceUseTimeCount < intval($pwdGraceAuthNLimit[0]))) { //at least one more grace login available?
646 646
 					$this->config->setUserValue($uid, 'user_ldap', 'needsPasswordReset', 'true');
@@ -653,24 +653,24 @@  discard block
 block discarded – undo
653 653
 				exit();
654 654
 			}
655 655
 			//handle pwdReset attribute
656
-			if($pwdReset && (count($pwdReset) > 0) && $pwdReset[0] === 'TRUE') { //user must change his password
656
+			if ($pwdReset && (count($pwdReset) > 0) && $pwdReset[0] === 'TRUE') { //user must change his password
657 657
 				$this->config->setUserValue($uid, 'user_ldap', 'needsPasswordReset', 'true');
658 658
 				header('Location: '.\OC::$server->getURLGenerator()->linkToRouteAbsolute(
659 659
 				'user_ldap.renewPassword.showRenewPasswordForm', array('user' => $uid)));
660 660
 				exit();
661 661
 			}
662 662
 			//handle password expiry warning
663
-			if($pwdChangedTime && (count($pwdChangedTime) > 0)) {
664
-				if($pwdMaxAge && (count($pwdMaxAge) > 0)
663
+			if ($pwdChangedTime && (count($pwdChangedTime) > 0)) {
664
+				if ($pwdMaxAge && (count($pwdMaxAge) > 0)
665 665
 					&& $pwdExpireWarning && (count($pwdExpireWarning) > 0)) {
666 666
 					$pwdMaxAgeInt = intval($pwdMaxAge[0]);
667 667
 					$pwdExpireWarningInt = intval($pwdExpireWarning[0]);
668
-					if($pwdMaxAgeInt > 0 && $pwdExpireWarningInt > 0){
668
+					if ($pwdMaxAgeInt > 0 && $pwdExpireWarningInt > 0) {
669 669
 						$pwdChangedTimeDt = \DateTime::createFromFormat('YmdHisZ', $pwdChangedTime[0]);
670 670
 						$pwdChangedTimeDt->add(new \DateInterval('PT'.$pwdMaxAgeInt.'S'));
671 671
 						$currentDateTime = new \DateTime();
672 672
 						$secondsToExpiry = $pwdChangedTimeDt->getTimestamp() - $currentDateTime->getTimestamp();
673
-						if($secondsToExpiry <= $pwdExpireWarningInt) {
673
+						if ($secondsToExpiry <= $pwdExpireWarningInt) {
674 674
 							//remove last password expiry warning if any
675 675
 							$notification = $this->notificationManager->createNotification();
676 676
 							$notification->setApp('user_ldap')
Please login to merge, or discard this patch.
apps/user_ldap/lib/Mapping/AbstractMapping.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 * @return bool
54 54
 	 */
55 55
 	public function isColNameValid($col) {
56
-		switch($col) {
56
+		switch ($col) {
57 57
 			case 'ldap_dn':
58 58
 			case 'owncloud_name':
59 59
 			case 'directory_uuid':
@@ -72,19 +72,19 @@  discard block
 block discarded – undo
72 72
 	 * @return string|false
73 73
 	 */
74 74
 	protected function getXbyY($fetchCol, $compareCol, $search) {
75
-		if(!$this->isColNameValid($fetchCol)) {
75
+		if (!$this->isColNameValid($fetchCol)) {
76 76
 			//this is used internally only, but we don't want to risk
77 77
 			//having SQL injection at all.
78 78
 			throw new \Exception('Invalid Column Name');
79 79
 		}
80 80
 		$query = $this->dbc->prepare('
81
-			SELECT `' . $fetchCol . '`
82
-			FROM `'. $this->getTableName() .'`
83
-			WHERE `' . $compareCol . '` = ?
81
+			SELECT `' . $fetchCol.'`
82
+			FROM `'. $this->getTableName().'`
83
+			WHERE `' . $compareCol.'` = ?
84 84
 		');
85 85
 
86 86
 		$res = $query->execute(array($search));
87
-		if($res !== false) {
87
+		if ($res !== false) {
88 88
 			return $query->fetchColumn();
89 89
 		}
90 90
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	 */
121 121
 	public function setDNbyUUID($fdn, $uuid) {
122 122
 		$query = $this->dbc->prepare('
123
-			UPDATE `' . $this->getTableName() . '`
123
+			UPDATE `' . $this->getTableName().'`
124 124
 			SET `ldap_dn` = ?
125 125
 			WHERE `directory_uuid` = ?
126 126
 		');
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	 */
140 140
 	public function setUUIDbyDN($uuid, $fdn) {
141 141
 		$query = $this->dbc->prepare('
142
-			UPDATE `' . $this->getTableName() . '`
142
+			UPDATE `' . $this->getTableName().'`
143 143
 			SET `directory_uuid` = ?
144 144
 			WHERE `ldap_dn` = ?
145 145
 		');
@@ -166,14 +166,14 @@  discard block
 block discarded – undo
166 166
 	public function getNamesBySearch($search, $prefixMatch = "", $postfixMatch = "") {
167 167
 		$query = $this->dbc->prepare('
168 168
 			SELECT `owncloud_name`
169
-			FROM `'. $this->getTableName() .'`
169
+			FROM `'. $this->getTableName().'`
170 170
 			WHERE `owncloud_name` LIKE ?
171 171
 		');
172 172
 
173 173
 		$res = $query->execute(array($prefixMatch.$this->dbc->escapeLikeParameter($search).$postfixMatch));
174 174
 		$names = array();
175
-		if($res !== false) {
176
-			while($row = $query->fetch()) {
175
+		if ($res !== false) {
176
+			while ($row = $query->fetch()) {
177 177
 				$names[] = $row['owncloud_name'];
178 178
 			}
179 179
 		}
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
 				`ldap_dn` AS `dn`,
212 212
 				`owncloud_name` AS `name`,
213 213
 				`directory_uuid` AS `uuid`
214
-			FROM `' . $this->getTableName() . '`',
214
+			FROM `' . $this->getTableName().'`',
215 215
 			$limit,
216 216
 			$offset
217 217
 		);
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
 	 * @return bool
229 229
 	 */
230 230
 	public function map($fdn, $name, $uuid) {
231
-		if(mb_strlen($fdn) > 255) {
231
+		if (mb_strlen($fdn) > 255) {
232 232
 			\OC::$server->getLogger()->error(
233 233
 				'Cannot map, because the DN exceeds 255 characters: {dn}',
234 234
 				[
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
 		try {
249 249
 			$result = $this->dbc->insertIfNotExist($this->getTableName(), $row);
250 250
 			// insertIfNotExist returns values as int
251
-			return (bool)$result;
251
+			return (bool) $result;
252 252
 		} catch (\Exception $e) {
253 253
 			return false;
254 254
 		}
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 	 */
262 262
 	public function unmap($name) {
263 263
 		$query = $this->dbc->prepare('
264
-			DELETE FROM `'. $this->getTableName() .'`
264
+			DELETE FROM `'. $this->getTableName().'`
265 265
 			WHERE `owncloud_name` = ?');
266 266
 
267 267
 		return $this->modify($query, array($name));
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
 	public function clear() {
275 275
 		$sql = $this->dbc
276 276
 			->getDatabasePlatform()
277
-			->getTruncateTableSQL('`' . $this->getTableName() . '`');
277
+			->getTruncateTableSQL('`'.$this->getTableName().'`');
278 278
 		return $this->dbc->prepare($sql)->execute();
279 279
 	}
280 280
 
@@ -290,6 +290,6 @@  discard block
 block discarded – undo
290 290
 		$res = $query->execute();
291 291
 		$count = $res->fetchColumn();
292 292
 		$res->closeCursor();
293
-		return (int)$count;
293
+		return (int) $count;
294 294
 	}
295 295
 }
Please login to merge, or discard this patch.
apps/user_ldap/composer/composer/autoload_classmap.php 1 patch
Spacing   +56 added lines, -56 removed lines patch added patch discarded remove patch
@@ -6,60 +6,60 @@
 block discarded – undo
6 6
 $baseDir = $vendorDir;
7 7
 
8 8
 return array(
9
-    'OCA\\User_LDAP\\Access' => $baseDir . '/../lib/Access.php',
10
-    'OCA\\User_LDAP\\AppInfo\\Application' => $baseDir . '/../lib/AppInfo/Application.php',
11
-    'OCA\\User_LDAP\\BackendUtility' => $baseDir . '/../lib/BackendUtility.php',
12
-    'OCA\\User_LDAP\\Command\\CheckUser' => $baseDir . '/../lib/Command/CheckUser.php',
13
-    'OCA\\User_LDAP\\Command\\CreateEmptyConfig' => $baseDir . '/../lib/Command/CreateEmptyConfig.php',
14
-    'OCA\\User_LDAP\\Command\\DeleteConfig' => $baseDir . '/../lib/Command/DeleteConfig.php',
15
-    'OCA\\User_LDAP\\Command\\Search' => $baseDir . '/../lib/Command/Search.php',
16
-    'OCA\\User_LDAP\\Command\\SetConfig' => $baseDir . '/../lib/Command/SetConfig.php',
17
-    'OCA\\User_LDAP\\Command\\ShowConfig' => $baseDir . '/../lib/Command/ShowConfig.php',
18
-    'OCA\\User_LDAP\\Command\\ShowRemnants' => $baseDir . '/../lib/Command/ShowRemnants.php',
19
-    'OCA\\User_LDAP\\Command\\TestConfig' => $baseDir . '/../lib/Command/TestConfig.php',
20
-    'OCA\\User_LDAP\\Configuration' => $baseDir . '/../lib/Configuration.php',
21
-    'OCA\\User_LDAP\\Connection' => $baseDir . '/../lib/Connection.php',
22
-    'OCA\\User_LDAP\\Controller\\ConfigAPIController' => $baseDir . '/../lib/Controller/ConfigAPIController.php',
23
-    'OCA\\User_LDAP\\Controller\\RenewPasswordController' => $baseDir . '/../lib/Controller/RenewPasswordController.php',
24
-    'OCA\\User_LDAP\\Exceptions\\ConstraintViolationException' => $baseDir . '/../lib/Exceptions/ConstraintViolationException.php',
25
-    'OCA\\User_LDAP\\Exceptions\\NotOnLDAP' => $baseDir . '/../lib/Exceptions/NotOnLDAP.php',
26
-    'OCA\\User_LDAP\\FilesystemHelper' => $baseDir . '/../lib/FilesystemHelper.php',
27
-    'OCA\\User_LDAP\\GroupPluginManager' => $baseDir . '/../lib/GroupPluginManager.php',
28
-    'OCA\\User_LDAP\\Group_LDAP' => $baseDir . '/../lib/Group_LDAP.php',
29
-    'OCA\\User_LDAP\\Group_Proxy' => $baseDir . '/../lib/Group_Proxy.php',
30
-    'OCA\\User_LDAP\\Helper' => $baseDir . '/../lib/Helper.php',
31
-    'OCA\\User_LDAP\\IGroupLDAP' => $baseDir . '/../lib/IGroupLDAP.php',
32
-    'OCA\\User_LDAP\\ILDAPGroupPlugin' => $baseDir . '/../lib/ILDAPGroupPlugin.php',
33
-    'OCA\\User_LDAP\\ILDAPUserPlugin' => $baseDir . '/../lib/ILDAPUserPlugin.php',
34
-    'OCA\\User_LDAP\\ILDAPWrapper' => $baseDir . '/../lib/ILDAPWrapper.php',
35
-    'OCA\\User_LDAP\\IUserLDAP' => $baseDir . '/../lib/IUserLDAP.php',
36
-    'OCA\\User_LDAP\\Jobs\\CleanUp' => $baseDir . '/../lib/Jobs/CleanUp.php',
37
-    'OCA\\User_LDAP\\Jobs\\Sync' => $baseDir . '/../lib/Jobs/Sync.php',
38
-    'OCA\\User_LDAP\\Jobs\\UpdateGroups' => $baseDir . '/../lib/Jobs/UpdateGroups.php',
39
-    'OCA\\User_LDAP\\LDAP' => $baseDir . '/../lib/LDAP.php',
40
-    'OCA\\User_LDAP\\LDAPProvider' => $baseDir . '/../lib/LDAPProvider.php',
41
-    'OCA\\User_LDAP\\LDAPProviderFactory' => $baseDir . '/../lib/LDAPProviderFactory.php',
42
-    'OCA\\User_LDAP\\LDAPUtility' => $baseDir . '/../lib/LDAPUtility.php',
43
-    'OCA\\User_LDAP\\LogWrapper' => $baseDir . '/../lib/LogWrapper.php',
44
-    'OCA\\User_LDAP\\Mapping\\AbstractMapping' => $baseDir . '/../lib/Mapping/AbstractMapping.php',
45
-    'OCA\\User_LDAP\\Mapping\\GroupMapping' => $baseDir . '/../lib/Mapping/GroupMapping.php',
46
-    'OCA\\User_LDAP\\Mapping\\UserMapping' => $baseDir . '/../lib/Mapping/UserMapping.php',
47
-    'OCA\\User_LDAP\\Migration\\UUIDFix' => $baseDir . '/../lib/Migration/UUIDFix.php',
48
-    'OCA\\User_LDAP\\Migration\\UUIDFixGroup' => $baseDir . '/../lib/Migration/UUIDFixGroup.php',
49
-    'OCA\\User_LDAP\\Migration\\UUIDFixInsert' => $baseDir . '/../lib/Migration/UUIDFixInsert.php',
50
-    'OCA\\User_LDAP\\Migration\\UUIDFixUser' => $baseDir . '/../lib/Migration/UUIDFixUser.php',
51
-    'OCA\\User_LDAP\\Notification\\Notifier' => $baseDir . '/../lib/Notification/Notifier.php',
52
-    'OCA\\User_LDAP\\Proxy' => $baseDir . '/../lib/Proxy.php',
53
-    'OCA\\User_LDAP\\Settings\\Admin' => $baseDir . '/../lib/Settings/Admin.php',
54
-    'OCA\\User_LDAP\\Settings\\Section' => $baseDir . '/../lib/Settings/Section.php',
55
-    'OCA\\User_LDAP\\UserPluginManager' => $baseDir . '/../lib/UserPluginManager.php',
56
-    'OCA\\User_LDAP\\User\\DeletedUsersIndex' => $baseDir . '/../lib/User/DeletedUsersIndex.php',
57
-    'OCA\\User_LDAP\\User\\IUserTools' => $baseDir . '/../lib/User/IUserTools.php',
58
-    'OCA\\User_LDAP\\User\\Manager' => $baseDir . '/../lib/User/Manager.php',
59
-    'OCA\\User_LDAP\\User\\OfflineUser' => $baseDir . '/../lib/User/OfflineUser.php',
60
-    'OCA\\User_LDAP\\User\\User' => $baseDir . '/../lib/User/User.php',
61
-    'OCA\\User_LDAP\\User_LDAP' => $baseDir . '/../lib/User_LDAP.php',
62
-    'OCA\\User_LDAP\\User_Proxy' => $baseDir . '/../lib/User_Proxy.php',
63
-    'OCA\\User_LDAP\\Wizard' => $baseDir . '/../lib/Wizard.php',
64
-    'OCA\\User_LDAP\\WizardResult' => $baseDir . '/../lib/WizardResult.php',
9
+    'OCA\\User_LDAP\\Access' => $baseDir.'/../lib/Access.php',
10
+    'OCA\\User_LDAP\\AppInfo\\Application' => $baseDir.'/../lib/AppInfo/Application.php',
11
+    'OCA\\User_LDAP\\BackendUtility' => $baseDir.'/../lib/BackendUtility.php',
12
+    'OCA\\User_LDAP\\Command\\CheckUser' => $baseDir.'/../lib/Command/CheckUser.php',
13
+    'OCA\\User_LDAP\\Command\\CreateEmptyConfig' => $baseDir.'/../lib/Command/CreateEmptyConfig.php',
14
+    'OCA\\User_LDAP\\Command\\DeleteConfig' => $baseDir.'/../lib/Command/DeleteConfig.php',
15
+    'OCA\\User_LDAP\\Command\\Search' => $baseDir.'/../lib/Command/Search.php',
16
+    'OCA\\User_LDAP\\Command\\SetConfig' => $baseDir.'/../lib/Command/SetConfig.php',
17
+    'OCA\\User_LDAP\\Command\\ShowConfig' => $baseDir.'/../lib/Command/ShowConfig.php',
18
+    'OCA\\User_LDAP\\Command\\ShowRemnants' => $baseDir.'/../lib/Command/ShowRemnants.php',
19
+    'OCA\\User_LDAP\\Command\\TestConfig' => $baseDir.'/../lib/Command/TestConfig.php',
20
+    'OCA\\User_LDAP\\Configuration' => $baseDir.'/../lib/Configuration.php',
21
+    'OCA\\User_LDAP\\Connection' => $baseDir.'/../lib/Connection.php',
22
+    'OCA\\User_LDAP\\Controller\\ConfigAPIController' => $baseDir.'/../lib/Controller/ConfigAPIController.php',
23
+    'OCA\\User_LDAP\\Controller\\RenewPasswordController' => $baseDir.'/../lib/Controller/RenewPasswordController.php',
24
+    'OCA\\User_LDAP\\Exceptions\\ConstraintViolationException' => $baseDir.'/../lib/Exceptions/ConstraintViolationException.php',
25
+    'OCA\\User_LDAP\\Exceptions\\NotOnLDAP' => $baseDir.'/../lib/Exceptions/NotOnLDAP.php',
26
+    'OCA\\User_LDAP\\FilesystemHelper' => $baseDir.'/../lib/FilesystemHelper.php',
27
+    'OCA\\User_LDAP\\GroupPluginManager' => $baseDir.'/../lib/GroupPluginManager.php',
28
+    'OCA\\User_LDAP\\Group_LDAP' => $baseDir.'/../lib/Group_LDAP.php',
29
+    'OCA\\User_LDAP\\Group_Proxy' => $baseDir.'/../lib/Group_Proxy.php',
30
+    'OCA\\User_LDAP\\Helper' => $baseDir.'/../lib/Helper.php',
31
+    'OCA\\User_LDAP\\IGroupLDAP' => $baseDir.'/../lib/IGroupLDAP.php',
32
+    'OCA\\User_LDAP\\ILDAPGroupPlugin' => $baseDir.'/../lib/ILDAPGroupPlugin.php',
33
+    'OCA\\User_LDAP\\ILDAPUserPlugin' => $baseDir.'/../lib/ILDAPUserPlugin.php',
34
+    'OCA\\User_LDAP\\ILDAPWrapper' => $baseDir.'/../lib/ILDAPWrapper.php',
35
+    'OCA\\User_LDAP\\IUserLDAP' => $baseDir.'/../lib/IUserLDAP.php',
36
+    'OCA\\User_LDAP\\Jobs\\CleanUp' => $baseDir.'/../lib/Jobs/CleanUp.php',
37
+    'OCA\\User_LDAP\\Jobs\\Sync' => $baseDir.'/../lib/Jobs/Sync.php',
38
+    'OCA\\User_LDAP\\Jobs\\UpdateGroups' => $baseDir.'/../lib/Jobs/UpdateGroups.php',
39
+    'OCA\\User_LDAP\\LDAP' => $baseDir.'/../lib/LDAP.php',
40
+    'OCA\\User_LDAP\\LDAPProvider' => $baseDir.'/../lib/LDAPProvider.php',
41
+    'OCA\\User_LDAP\\LDAPProviderFactory' => $baseDir.'/../lib/LDAPProviderFactory.php',
42
+    'OCA\\User_LDAP\\LDAPUtility' => $baseDir.'/../lib/LDAPUtility.php',
43
+    'OCA\\User_LDAP\\LogWrapper' => $baseDir.'/../lib/LogWrapper.php',
44
+    'OCA\\User_LDAP\\Mapping\\AbstractMapping' => $baseDir.'/../lib/Mapping/AbstractMapping.php',
45
+    'OCA\\User_LDAP\\Mapping\\GroupMapping' => $baseDir.'/../lib/Mapping/GroupMapping.php',
46
+    'OCA\\User_LDAP\\Mapping\\UserMapping' => $baseDir.'/../lib/Mapping/UserMapping.php',
47
+    'OCA\\User_LDAP\\Migration\\UUIDFix' => $baseDir.'/../lib/Migration/UUIDFix.php',
48
+    'OCA\\User_LDAP\\Migration\\UUIDFixGroup' => $baseDir.'/../lib/Migration/UUIDFixGroup.php',
49
+    'OCA\\User_LDAP\\Migration\\UUIDFixInsert' => $baseDir.'/../lib/Migration/UUIDFixInsert.php',
50
+    'OCA\\User_LDAP\\Migration\\UUIDFixUser' => $baseDir.'/../lib/Migration/UUIDFixUser.php',
51
+    'OCA\\User_LDAP\\Notification\\Notifier' => $baseDir.'/../lib/Notification/Notifier.php',
52
+    'OCA\\User_LDAP\\Proxy' => $baseDir.'/../lib/Proxy.php',
53
+    'OCA\\User_LDAP\\Settings\\Admin' => $baseDir.'/../lib/Settings/Admin.php',
54
+    'OCA\\User_LDAP\\Settings\\Section' => $baseDir.'/../lib/Settings/Section.php',
55
+    'OCA\\User_LDAP\\UserPluginManager' => $baseDir.'/../lib/UserPluginManager.php',
56
+    'OCA\\User_LDAP\\User\\DeletedUsersIndex' => $baseDir.'/../lib/User/DeletedUsersIndex.php',
57
+    'OCA\\User_LDAP\\User\\IUserTools' => $baseDir.'/../lib/User/IUserTools.php',
58
+    'OCA\\User_LDAP\\User\\Manager' => $baseDir.'/../lib/User/Manager.php',
59
+    'OCA\\User_LDAP\\User\\OfflineUser' => $baseDir.'/../lib/User/OfflineUser.php',
60
+    'OCA\\User_LDAP\\User\\User' => $baseDir.'/../lib/User/User.php',
61
+    'OCA\\User_LDAP\\User_LDAP' => $baseDir.'/../lib/User_LDAP.php',
62
+    'OCA\\User_LDAP\\User_Proxy' => $baseDir.'/../lib/User_Proxy.php',
63
+    'OCA\\User_LDAP\\Wizard' => $baseDir.'/../lib/Wizard.php',
64
+    'OCA\\User_LDAP\\WizardResult' => $baseDir.'/../lib/WizardResult.php',
65 65
 );
Please login to merge, or discard this patch.
apps/user_ldap/composer/composer/autoload_static.php 1 patch
Spacing   +63 added lines, -63 removed lines patch added patch discarded remove patch
@@ -6,82 +6,82 @@
 block discarded – undo
6 6
 
7 7
 class ComposerStaticInitUser_LDAP
8 8
 {
9
-    public static $prefixLengthsPsr4 = array (
9
+    public static $prefixLengthsPsr4 = array(
10 10
         'O' => 
11
-        array (
11
+        array(
12 12
             'OCA\\User_LDAP\\' => 14,
13 13
         ),
14 14
     );
15 15
 
16
-    public static $prefixDirsPsr4 = array (
16
+    public static $prefixDirsPsr4 = array(
17 17
         'OCA\\User_LDAP\\' => 
18
-        array (
19
-            0 => __DIR__ . '/..' . '/../lib',
18
+        array(
19
+            0 => __DIR__.'/..'.'/../lib',
20 20
         ),
21 21
     );
22 22
 
23
-    public static $classMap = array (
24
-        'OCA\\User_LDAP\\Access' => __DIR__ . '/..' . '/../lib/Access.php',
25
-        'OCA\\User_LDAP\\AppInfo\\Application' => __DIR__ . '/..' . '/../lib/AppInfo/Application.php',
26
-        'OCA\\User_LDAP\\BackendUtility' => __DIR__ . '/..' . '/../lib/BackendUtility.php',
27
-        'OCA\\User_LDAP\\Command\\CheckUser' => __DIR__ . '/..' . '/../lib/Command/CheckUser.php',
28
-        'OCA\\User_LDAP\\Command\\CreateEmptyConfig' => __DIR__ . '/..' . '/../lib/Command/CreateEmptyConfig.php',
29
-        'OCA\\User_LDAP\\Command\\DeleteConfig' => __DIR__ . '/..' . '/../lib/Command/DeleteConfig.php',
30
-        'OCA\\User_LDAP\\Command\\Search' => __DIR__ . '/..' . '/../lib/Command/Search.php',
31
-        'OCA\\User_LDAP\\Command\\SetConfig' => __DIR__ . '/..' . '/../lib/Command/SetConfig.php',
32
-        'OCA\\User_LDAP\\Command\\ShowConfig' => __DIR__ . '/..' . '/../lib/Command/ShowConfig.php',
33
-        'OCA\\User_LDAP\\Command\\ShowRemnants' => __DIR__ . '/..' . '/../lib/Command/ShowRemnants.php',
34
-        'OCA\\User_LDAP\\Command\\TestConfig' => __DIR__ . '/..' . '/../lib/Command/TestConfig.php',
35
-        'OCA\\User_LDAP\\Configuration' => __DIR__ . '/..' . '/../lib/Configuration.php',
36
-        'OCA\\User_LDAP\\Connection' => __DIR__ . '/..' . '/../lib/Connection.php',
37
-        'OCA\\User_LDAP\\Controller\\ConfigAPIController' => __DIR__ . '/..' . '/../lib/Controller/ConfigAPIController.php',
38
-        'OCA\\User_LDAP\\Controller\\RenewPasswordController' => __DIR__ . '/..' . '/../lib/Controller/RenewPasswordController.php',
39
-        'OCA\\User_LDAP\\Exceptions\\ConstraintViolationException' => __DIR__ . '/..' . '/../lib/Exceptions/ConstraintViolationException.php',
40
-        'OCA\\User_LDAP\\Exceptions\\NotOnLDAP' => __DIR__ . '/..' . '/../lib/Exceptions/NotOnLDAP.php',
41
-        'OCA\\User_LDAP\\FilesystemHelper' => __DIR__ . '/..' . '/../lib/FilesystemHelper.php',
42
-        'OCA\\User_LDAP\\GroupPluginManager' => __DIR__ . '/..' . '/../lib/GroupPluginManager.php',
43
-        'OCA\\User_LDAP\\Group_LDAP' => __DIR__ . '/..' . '/../lib/Group_LDAP.php',
44
-        'OCA\\User_LDAP\\Group_Proxy' => __DIR__ . '/..' . '/../lib/Group_Proxy.php',
45
-        'OCA\\User_LDAP\\Helper' => __DIR__ . '/..' . '/../lib/Helper.php',
46
-        'OCA\\User_LDAP\\IGroupLDAP' => __DIR__ . '/..' . '/../lib/IGroupLDAP.php',
47
-        'OCA\\User_LDAP\\ILDAPGroupPlugin' => __DIR__ . '/..' . '/../lib/ILDAPGroupPlugin.php',
48
-        'OCA\\User_LDAP\\ILDAPUserPlugin' => __DIR__ . '/..' . '/../lib/ILDAPUserPlugin.php',
49
-        'OCA\\User_LDAP\\ILDAPWrapper' => __DIR__ . '/..' . '/../lib/ILDAPWrapper.php',
50
-        'OCA\\User_LDAP\\IUserLDAP' => __DIR__ . '/..' . '/../lib/IUserLDAP.php',
51
-        'OCA\\User_LDAP\\Jobs\\CleanUp' => __DIR__ . '/..' . '/../lib/Jobs/CleanUp.php',
52
-        'OCA\\User_LDAP\\Jobs\\Sync' => __DIR__ . '/..' . '/../lib/Jobs/Sync.php',
53
-        'OCA\\User_LDAP\\Jobs\\UpdateGroups' => __DIR__ . '/..' . '/../lib/Jobs/UpdateGroups.php',
54
-        'OCA\\User_LDAP\\LDAP' => __DIR__ . '/..' . '/../lib/LDAP.php',
55
-        'OCA\\User_LDAP\\LDAPProvider' => __DIR__ . '/..' . '/../lib/LDAPProvider.php',
56
-        'OCA\\User_LDAP\\LDAPProviderFactory' => __DIR__ . '/..' . '/../lib/LDAPProviderFactory.php',
57
-        'OCA\\User_LDAP\\LDAPUtility' => __DIR__ . '/..' . '/../lib/LDAPUtility.php',
58
-        'OCA\\User_LDAP\\LogWrapper' => __DIR__ . '/..' . '/../lib/LogWrapper.php',
59
-        'OCA\\User_LDAP\\Mapping\\AbstractMapping' => __DIR__ . '/..' . '/../lib/Mapping/AbstractMapping.php',
60
-        'OCA\\User_LDAP\\Mapping\\GroupMapping' => __DIR__ . '/..' . '/../lib/Mapping/GroupMapping.php',
61
-        'OCA\\User_LDAP\\Mapping\\UserMapping' => __DIR__ . '/..' . '/../lib/Mapping/UserMapping.php',
62
-        'OCA\\User_LDAP\\Migration\\UUIDFix' => __DIR__ . '/..' . '/../lib/Migration/UUIDFix.php',
63
-        'OCA\\User_LDAP\\Migration\\UUIDFixGroup' => __DIR__ . '/..' . '/../lib/Migration/UUIDFixGroup.php',
64
-        'OCA\\User_LDAP\\Migration\\UUIDFixInsert' => __DIR__ . '/..' . '/../lib/Migration/UUIDFixInsert.php',
65
-        'OCA\\User_LDAP\\Migration\\UUIDFixUser' => __DIR__ . '/..' . '/../lib/Migration/UUIDFixUser.php',
66
-        'OCA\\User_LDAP\\Notification\\Notifier' => __DIR__ . '/..' . '/../lib/Notification/Notifier.php',
67
-        'OCA\\User_LDAP\\Proxy' => __DIR__ . '/..' . '/../lib/Proxy.php',
68
-        'OCA\\User_LDAP\\Settings\\Admin' => __DIR__ . '/..' . '/../lib/Settings/Admin.php',
69
-        'OCA\\User_LDAP\\Settings\\Section' => __DIR__ . '/..' . '/../lib/Settings/Section.php',
70
-        'OCA\\User_LDAP\\UserPluginManager' => __DIR__ . '/..' . '/../lib/UserPluginManager.php',
71
-        'OCA\\User_LDAP\\User\\DeletedUsersIndex' => __DIR__ . '/..' . '/../lib/User/DeletedUsersIndex.php',
72
-        'OCA\\User_LDAP\\User\\IUserTools' => __DIR__ . '/..' . '/../lib/User/IUserTools.php',
73
-        'OCA\\User_LDAP\\User\\Manager' => __DIR__ . '/..' . '/../lib/User/Manager.php',
74
-        'OCA\\User_LDAP\\User\\OfflineUser' => __DIR__ . '/..' . '/../lib/User/OfflineUser.php',
75
-        'OCA\\User_LDAP\\User\\User' => __DIR__ . '/..' . '/../lib/User/User.php',
76
-        'OCA\\User_LDAP\\User_LDAP' => __DIR__ . '/..' . '/../lib/User_LDAP.php',
77
-        'OCA\\User_LDAP\\User_Proxy' => __DIR__ . '/..' . '/../lib/User_Proxy.php',
78
-        'OCA\\User_LDAP\\Wizard' => __DIR__ . '/..' . '/../lib/Wizard.php',
79
-        'OCA\\User_LDAP\\WizardResult' => __DIR__ . '/..' . '/../lib/WizardResult.php',
23
+    public static $classMap = array(
24
+        'OCA\\User_LDAP\\Access' => __DIR__.'/..'.'/../lib/Access.php',
25
+        'OCA\\User_LDAP\\AppInfo\\Application' => __DIR__.'/..'.'/../lib/AppInfo/Application.php',
26
+        'OCA\\User_LDAP\\BackendUtility' => __DIR__.'/..'.'/../lib/BackendUtility.php',
27
+        'OCA\\User_LDAP\\Command\\CheckUser' => __DIR__.'/..'.'/../lib/Command/CheckUser.php',
28
+        'OCA\\User_LDAP\\Command\\CreateEmptyConfig' => __DIR__.'/..'.'/../lib/Command/CreateEmptyConfig.php',
29
+        'OCA\\User_LDAP\\Command\\DeleteConfig' => __DIR__.'/..'.'/../lib/Command/DeleteConfig.php',
30
+        'OCA\\User_LDAP\\Command\\Search' => __DIR__.'/..'.'/../lib/Command/Search.php',
31
+        'OCA\\User_LDAP\\Command\\SetConfig' => __DIR__.'/..'.'/../lib/Command/SetConfig.php',
32
+        'OCA\\User_LDAP\\Command\\ShowConfig' => __DIR__.'/..'.'/../lib/Command/ShowConfig.php',
33
+        'OCA\\User_LDAP\\Command\\ShowRemnants' => __DIR__.'/..'.'/../lib/Command/ShowRemnants.php',
34
+        'OCA\\User_LDAP\\Command\\TestConfig' => __DIR__.'/..'.'/../lib/Command/TestConfig.php',
35
+        'OCA\\User_LDAP\\Configuration' => __DIR__.'/..'.'/../lib/Configuration.php',
36
+        'OCA\\User_LDAP\\Connection' => __DIR__.'/..'.'/../lib/Connection.php',
37
+        'OCA\\User_LDAP\\Controller\\ConfigAPIController' => __DIR__.'/..'.'/../lib/Controller/ConfigAPIController.php',
38
+        'OCA\\User_LDAP\\Controller\\RenewPasswordController' => __DIR__.'/..'.'/../lib/Controller/RenewPasswordController.php',
39
+        'OCA\\User_LDAP\\Exceptions\\ConstraintViolationException' => __DIR__.'/..'.'/../lib/Exceptions/ConstraintViolationException.php',
40
+        'OCA\\User_LDAP\\Exceptions\\NotOnLDAP' => __DIR__.'/..'.'/../lib/Exceptions/NotOnLDAP.php',
41
+        'OCA\\User_LDAP\\FilesystemHelper' => __DIR__.'/..'.'/../lib/FilesystemHelper.php',
42
+        'OCA\\User_LDAP\\GroupPluginManager' => __DIR__.'/..'.'/../lib/GroupPluginManager.php',
43
+        'OCA\\User_LDAP\\Group_LDAP' => __DIR__.'/..'.'/../lib/Group_LDAP.php',
44
+        'OCA\\User_LDAP\\Group_Proxy' => __DIR__.'/..'.'/../lib/Group_Proxy.php',
45
+        'OCA\\User_LDAP\\Helper' => __DIR__.'/..'.'/../lib/Helper.php',
46
+        'OCA\\User_LDAP\\IGroupLDAP' => __DIR__.'/..'.'/../lib/IGroupLDAP.php',
47
+        'OCA\\User_LDAP\\ILDAPGroupPlugin' => __DIR__.'/..'.'/../lib/ILDAPGroupPlugin.php',
48
+        'OCA\\User_LDAP\\ILDAPUserPlugin' => __DIR__.'/..'.'/../lib/ILDAPUserPlugin.php',
49
+        'OCA\\User_LDAP\\ILDAPWrapper' => __DIR__.'/..'.'/../lib/ILDAPWrapper.php',
50
+        'OCA\\User_LDAP\\IUserLDAP' => __DIR__.'/..'.'/../lib/IUserLDAP.php',
51
+        'OCA\\User_LDAP\\Jobs\\CleanUp' => __DIR__.'/..'.'/../lib/Jobs/CleanUp.php',
52
+        'OCA\\User_LDAP\\Jobs\\Sync' => __DIR__.'/..'.'/../lib/Jobs/Sync.php',
53
+        'OCA\\User_LDAP\\Jobs\\UpdateGroups' => __DIR__.'/..'.'/../lib/Jobs/UpdateGroups.php',
54
+        'OCA\\User_LDAP\\LDAP' => __DIR__.'/..'.'/../lib/LDAP.php',
55
+        'OCA\\User_LDAP\\LDAPProvider' => __DIR__.'/..'.'/../lib/LDAPProvider.php',
56
+        'OCA\\User_LDAP\\LDAPProviderFactory' => __DIR__.'/..'.'/../lib/LDAPProviderFactory.php',
57
+        'OCA\\User_LDAP\\LDAPUtility' => __DIR__.'/..'.'/../lib/LDAPUtility.php',
58
+        'OCA\\User_LDAP\\LogWrapper' => __DIR__.'/..'.'/../lib/LogWrapper.php',
59
+        'OCA\\User_LDAP\\Mapping\\AbstractMapping' => __DIR__.'/..'.'/../lib/Mapping/AbstractMapping.php',
60
+        'OCA\\User_LDAP\\Mapping\\GroupMapping' => __DIR__.'/..'.'/../lib/Mapping/GroupMapping.php',
61
+        'OCA\\User_LDAP\\Mapping\\UserMapping' => __DIR__.'/..'.'/../lib/Mapping/UserMapping.php',
62
+        'OCA\\User_LDAP\\Migration\\UUIDFix' => __DIR__.'/..'.'/../lib/Migration/UUIDFix.php',
63
+        'OCA\\User_LDAP\\Migration\\UUIDFixGroup' => __DIR__.'/..'.'/../lib/Migration/UUIDFixGroup.php',
64
+        'OCA\\User_LDAP\\Migration\\UUIDFixInsert' => __DIR__.'/..'.'/../lib/Migration/UUIDFixInsert.php',
65
+        'OCA\\User_LDAP\\Migration\\UUIDFixUser' => __DIR__.'/..'.'/../lib/Migration/UUIDFixUser.php',
66
+        'OCA\\User_LDAP\\Notification\\Notifier' => __DIR__.'/..'.'/../lib/Notification/Notifier.php',
67
+        'OCA\\User_LDAP\\Proxy' => __DIR__.'/..'.'/../lib/Proxy.php',
68
+        'OCA\\User_LDAP\\Settings\\Admin' => __DIR__.'/..'.'/../lib/Settings/Admin.php',
69
+        'OCA\\User_LDAP\\Settings\\Section' => __DIR__.'/..'.'/../lib/Settings/Section.php',
70
+        'OCA\\User_LDAP\\UserPluginManager' => __DIR__.'/..'.'/../lib/UserPluginManager.php',
71
+        'OCA\\User_LDAP\\User\\DeletedUsersIndex' => __DIR__.'/..'.'/../lib/User/DeletedUsersIndex.php',
72
+        'OCA\\User_LDAP\\User\\IUserTools' => __DIR__.'/..'.'/../lib/User/IUserTools.php',
73
+        'OCA\\User_LDAP\\User\\Manager' => __DIR__.'/..'.'/../lib/User/Manager.php',
74
+        'OCA\\User_LDAP\\User\\OfflineUser' => __DIR__.'/..'.'/../lib/User/OfflineUser.php',
75
+        'OCA\\User_LDAP\\User\\User' => __DIR__.'/..'.'/../lib/User/User.php',
76
+        'OCA\\User_LDAP\\User_LDAP' => __DIR__.'/..'.'/../lib/User_LDAP.php',
77
+        'OCA\\User_LDAP\\User_Proxy' => __DIR__.'/..'.'/../lib/User_Proxy.php',
78
+        'OCA\\User_LDAP\\Wizard' => __DIR__.'/..'.'/../lib/Wizard.php',
79
+        'OCA\\User_LDAP\\WizardResult' => __DIR__.'/..'.'/../lib/WizardResult.php',
80 80
     );
81 81
 
82 82
     public static function getInitializer(ClassLoader $loader)
83 83
     {
84
-        return \Closure::bind(function () use ($loader) {
84
+        return \Closure::bind(function() use ($loader) {
85 85
             $loader->prefixLengthsPsr4 = ComposerStaticInitUser_LDAP::$prefixLengthsPsr4;
86 86
             $loader->prefixDirsPsr4 = ComposerStaticInitUser_LDAP::$prefixDirsPsr4;
87 87
             $loader->classMap = ComposerStaticInitUser_LDAP::$classMap;
Please login to merge, or discard this patch.
apps/user_ldap/lib/Jobs/Sync.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 			$pagingSize = $this->config->getAppValue('user_ldap', $configKey, $minPagingSize);
107 107
 			$minPagingSize = $minPagingSize === null ? $pagingSize : min($minPagingSize, $pagingSize);
108 108
 		}
109
-		return (int)$minPagingSize;
109
+		return (int) $minPagingSize;
110 110
 	}
111 111
 
112 112
 	/**
@@ -117,20 +117,20 @@  discard block
 block discarded – undo
117 117
 
118 118
 		$isBackgroundJobModeAjax = $this->config
119 119
 				->getAppValue('core', 'backgroundjobs_mode', 'ajax') === 'ajax';
120
-		if($isBackgroundJobModeAjax) {
120
+		if ($isBackgroundJobModeAjax) {
121 121
 			return;
122 122
 		}
123 123
 
124 124
 		$cycleData = $this->getCycle();
125
-		if($cycleData === null) {
125
+		if ($cycleData === null) {
126 126
 			$cycleData = $this->determineNextCycle();
127
-			if($cycleData === null) {
127
+			if ($cycleData === null) {
128 128
 				$this->updateInterval();
129 129
 				return;
130 130
 			}
131 131
 		}
132 132
 
133
-		if(!$this->qualifiesToRun($cycleData)) {
133
+		if (!$this->qualifiesToRun($cycleData)) {
134 134
 			$this->updateInterval();
135 135
 			return;
136 136
 		}
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
 		$filter = $access->combineFilterWithAnd(array(
161 161
 			$access->connection->ldapUserFilter,
162
-			$access->connection->ldapUserDisplayName . '=*',
162
+			$access->connection->ldapUserDisplayName.'=*',
163 163
 			$access->getFilterPartForUserSearch('')
164 164
 		));
165 165
 		$results = $access->fetchListOfUsers(
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 			true
171 171
 		);
172 172
 
173
-		if($connection->ldapPagingSize === 0) {
173
+		if ($connection->ldapPagingSize === 0) {
174 174
 			return true;
175 175
 		}
176 176
 		return count($results) !== $connection->ldapPagingSize;
@@ -184,16 +184,16 @@  discard block
 block discarded – undo
184 184
 	 */
185 185
 	public function getCycle() {
186 186
 		$prefixes = $this->ldapHelper->getServerConfigurationPrefixes(true);
187
-		if(count($prefixes) === 0) {
187
+		if (count($prefixes) === 0) {
188 188
 			return null;
189 189
 		}
190 190
 
191 191
 		$cycleData = [
192 192
 			'prefix' => $this->config->getAppValue('user_ldap', 'background_sync_prefix', null),
193
-			'offset' => (int)$this->config->getAppValue('user_ldap', 'background_sync_offset', 0),
193
+			'offset' => (int) $this->config->getAppValue('user_ldap', 'background_sync_offset', 0),
194 194
 		];
195 195
 
196
-		if(
196
+		if (
197 197
 			$cycleData['prefix'] !== null
198 198
 			&& in_array($cycleData['prefix'], $prefixes)
199 199
 		) {
@@ -222,14 +222,14 @@  discard block
 block discarded – undo
222 222
 	 */
223 223
 	public function determineNextCycle(array $cycleData = null) {
224 224
 		$prefixes = $this->ldapHelper->getServerConfigurationPrefixes(true);
225
-		if(count($prefixes) === 0) {
225
+		if (count($prefixes) === 0) {
226 226
 			return null;
227 227
 		}
228 228
 
229 229
 		// get the next prefix in line and remember it
230 230
 		$oldPrefix = $cycleData === null ? null : $cycleData['prefix'];
231 231
 		$prefix = $this->getNextPrefix($oldPrefix);
232
-		if($prefix === null) {
232
+		if ($prefix === null) {
233 233
 			return null;
234 234
 		}
235 235
 		$cycleData['prefix'] = $prefix;
@@ -247,8 +247,8 @@  discard block
 block discarded – undo
247 247
 	 * @return bool
248 248
 	 */
249 249
 	protected function qualifiesToRun($cycleData) {
250
-		$lastChange = $this->config->getAppValue('user_ldap', $cycleData['prefix'] . '_lastChange', 0);
251
-		if((time() - $lastChange) > 60 * 30) {
250
+		$lastChange = $this->config->getAppValue('user_ldap', $cycleData['prefix'].'_lastChange', 0);
251
+		if ((time() - $lastChange) > 60 * 30) {
252 252
 			return true;
253 253
 		}
254 254
 		return false;
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 	 */
262 262
 	protected function increaseOffset($cycleData) {
263 263
 		$ldapConfig = new Configuration($cycleData['prefix']);
264
-		$cycleData['offset'] += (int)$ldapConfig->ldapPagingSize;
264
+		$cycleData['offset'] += (int) $ldapConfig->ldapPagingSize;
265 265
 		$this->setCycle($cycleData);
266 266
 	}
267 267
 
@@ -274,17 +274,17 @@  discard block
 block discarded – undo
274 274
 	protected function getNextPrefix($lastPrefix) {
275 275
 		$prefixes = $this->ldapHelper->getServerConfigurationPrefixes(true);
276 276
 		$noOfPrefixes = count($prefixes);
277
-		if($noOfPrefixes === 0) {
277
+		if ($noOfPrefixes === 0) {
278 278
 			return null;
279 279
 		}
280 280
 		$i = $lastPrefix === null ? false : array_search($lastPrefix, $prefixes, true);
281
-		if($i === false) {
281
+		if ($i === false) {
282 282
 			$i = -1;
283 283
 		} else {
284 284
 			$i++;
285 285
 		}
286 286
 
287
-		if(!isset($prefixes[$i])) {
287
+		if (!isset($prefixes[$i])) {
288 288
 			$i = 0;
289 289
 		}
290 290
 		return $prefixes[$i];
@@ -296,49 +296,49 @@  discard block
 block discarded – undo
296 296
 	 * @param array $argument
297 297
 	 */
298 298
 	public function setArgument($argument) {
299
-		if(isset($argument['config'])) {
299
+		if (isset($argument['config'])) {
300 300
 			$this->config = $argument['config'];
301 301
 		} else {
302 302
 			$this->config = \OC::$server->getConfig();
303 303
 		}
304 304
 
305
-		if(isset($argument['helper'])) {
305
+		if (isset($argument['helper'])) {
306 306
 			$this->ldapHelper = $argument['helper'];
307 307
 		} else {
308 308
 			$this->ldapHelper = new Helper($this->config);
309 309
 		}
310 310
 
311
-		if(isset($argument['ldapWrapper'])) {
311
+		if (isset($argument['ldapWrapper'])) {
312 312
 			$this->ldap = $argument['ldapWrapper'];
313 313
 		} else {
314 314
 			$this->ldap = new LDAP();
315 315
 		}
316 316
 
317
-		if(isset($argument['avatarManager'])) {
317
+		if (isset($argument['avatarManager'])) {
318 318
 			$this->avatarManager = $argument['avatarManager'];
319 319
 		} else {
320 320
 			$this->avatarManager = \OC::$server->getAvatarManager();
321 321
 		}
322 322
 
323
-		if(isset($argument['dbc'])) {
323
+		if (isset($argument['dbc'])) {
324 324
 			$this->dbc = $argument['dbc'];
325 325
 		} else {
326 326
 			$this->dbc = \OC::$server->getDatabaseConnection();
327 327
 		}
328 328
 
329
-		if(isset($argument['ncUserManager'])) {
329
+		if (isset($argument['ncUserManager'])) {
330 330
 			$this->ncUserManager = $argument['ncUserManager'];
331 331
 		} else {
332 332
 			$this->ncUserManager = \OC::$server->getUserManager();
333 333
 		}
334 334
 
335
-		if(isset($argument['notificationManager'])) {
335
+		if (isset($argument['notificationManager'])) {
336 336
 			$this->notificationManager = $argument['notificationManager'];
337 337
 		} else {
338 338
 			$this->notificationManager = \OC::$server->getNotificationManager();
339 339
 		}
340 340
 
341
-		if(isset($argument['userManager'])) {
341
+		if (isset($argument['userManager'])) {
342 342
 			$this->userManager = $argument['userManager'];
343 343
 		} else {
344 344
 			$this->userManager = new Manager(
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
 			);
354 354
 		}
355 355
 
356
-		if(isset($argument['mapper'])) {
356
+		if (isset($argument['mapper'])) {
357 357
 			$this->mapper = $argument['mapper'];
358 358
 		} else {
359 359
 			$this->mapper = new UserMapping($this->dbc);
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Spacing   +168 added lines, -168 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 	 * @return AbstractMapping
125 125
 	 */
126 126
 	public function getUserMapper() {
127
-		if(is_null($this->userMapper)) {
127
+		if (is_null($this->userMapper)) {
128 128
 			throw new \Exception('UserMapper was not assigned to this Access instance.');
129 129
 		}
130 130
 		return $this->userMapper;
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * @return AbstractMapping
145 145
 	 */
146 146
 	public function getGroupMapper() {
147
-		if(is_null($this->groupMapper)) {
147
+		if (is_null($this->groupMapper)) {
148 148
 			throw new \Exception('GroupMapper was not assigned to this Access instance.');
149 149
 		}
150 150
 		return $this->groupMapper;
@@ -175,14 +175,14 @@  discard block
 block discarded – undo
175 175
 	 *          array if $attr is empty, false otherwise
176 176
 	 */
177 177
 	public function readAttribute($dn, $attr, $filter = 'objectClass=*') {
178
-		if(!$this->checkConnection()) {
178
+		if (!$this->checkConnection()) {
179 179
 			\OCP\Util::writeLog('user_ldap',
180 180
 				'No LDAP Connector assigned, access impossible for readAttribute.',
181 181
 				\OCP\Util::WARN);
182 182
 			return false;
183 183
 		}
184 184
 		$cr = $this->connection->getConnectionResource();
185
-		if(!$this->ldap->isResource($cr)) {
185
+		if (!$this->ldap->isResource($cr)) {
186 186
 			//LDAP not available
187 187
 			\OCP\Util::writeLog('user_ldap', 'LDAP resource not available.', \OCP\Util::DEBUG);
188 188
 			return false;
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 		$isRangeRequest = false;
206 206
 		do {
207 207
 			$result = $this->executeRead($cr, $dn, $attrToRead, $filter, $maxResults);
208
-			if(is_bool($result)) {
208
+			if (is_bool($result)) {
209 209
 				// when an exists request was run and it was successful, an empty
210 210
 				// array must be returned
211 211
 				return $result ? [] : false;
@@ -222,22 +222,22 @@  discard block
 block discarded – undo
222 222
 			$result = $this->extractRangeData($result, $attr);
223 223
 			if (!empty($result)) {
224 224
 				$normalizedResult = $this->extractAttributeValuesFromResult(
225
-					[ $attr => $result['values'] ],
225
+					[$attr => $result['values']],
226 226
 					$attr
227 227
 				);
228 228
 				$values = array_merge($values, $normalizedResult);
229 229
 
230
-				if($result['rangeHigh'] === '*') {
230
+				if ($result['rangeHigh'] === '*') {
231 231
 					// when server replies with * as high range value, there are
232 232
 					// no more results left
233 233
 					return $values;
234 234
 				} else {
235
-					$low  = $result['rangeHigh'] + 1;
236
-					$attrToRead = $result['attributeName'] . ';range=' . $low . '-*';
235
+					$low = $result['rangeHigh'] + 1;
236
+					$attrToRead = $result['attributeName'].';range='.$low.'-*';
237 237
 					$isRangeRequest = true;
238 238
 				}
239 239
 			}
240
-		} while($isRangeRequest);
240
+		} while ($isRangeRequest);
241 241
 
242 242
 		\OCP\Util::writeLog('user_ldap', 'Requested attribute '.$attr.' not found for '.$dn, \OCP\Util::DEBUG);
243 243
 		return false;
@@ -262,13 +262,13 @@  discard block
 block discarded – undo
262 262
 		if (!$this->ldap->isResource($rr)) {
263 263
 			if ($attribute !== '') {
264 264
 				//do not throw this message on userExists check, irritates
265
-				\OCP\Util::writeLog('user_ldap', 'readAttribute failed for DN ' . $dn, \OCP\Util::DEBUG);
265
+				\OCP\Util::writeLog('user_ldap', 'readAttribute failed for DN '.$dn, \OCP\Util::DEBUG);
266 266
 			}
267 267
 			//in case an error occurs , e.g. object does not exist
268 268
 			return false;
269 269
 		}
270 270
 		if ($attribute === '' && ($filter === 'objectclass=*' || $this->invokeLDAPMethod('countEntries', $cr, $rr) === 1)) {
271
-			\OCP\Util::writeLog('user_ldap', 'readAttribute: ' . $dn . ' found', \OCP\Util::DEBUG);
271
+			\OCP\Util::writeLog('user_ldap', 'readAttribute: '.$dn.' found', \OCP\Util::DEBUG);
272 272
 			return true;
273 273
 		}
274 274
 		$er = $this->invokeLDAPMethod('firstEntry', $cr, $rr);
@@ -293,12 +293,12 @@  discard block
 block discarded – undo
293 293
 	 */
294 294
 	public function extractAttributeValuesFromResult($result, $attribute) {
295 295
 		$values = [];
296
-		if(isset($result[$attribute]) && $result[$attribute]['count'] > 0) {
296
+		if (isset($result[$attribute]) && $result[$attribute]['count'] > 0) {
297 297
 			$lowercaseAttribute = strtolower($attribute);
298
-			for($i=0;$i<$result[$attribute]['count'];$i++) {
299
-				if($this->resemblesDN($attribute)) {
298
+			for ($i = 0; $i < $result[$attribute]['count']; $i++) {
299
+				if ($this->resemblesDN($attribute)) {
300 300
 					$values[] = $this->helper->sanitizeDN($result[$attribute][$i]);
301
-				} elseif($lowercaseAttribute === 'objectguid' || $lowercaseAttribute === 'guid') {
301
+				} elseif ($lowercaseAttribute === 'objectguid' || $lowercaseAttribute === 'guid') {
302 302
 					$values[] = $this->convertObjectGUID2Str($result[$attribute][$i]);
303 303
 				} else {
304 304
 					$values[] = $result[$attribute][$i];
@@ -320,10 +320,10 @@  discard block
 block discarded – undo
320 320
 	 */
321 321
 	public function extractRangeData($result, $attribute) {
322 322
 		$keys = array_keys($result);
323
-		foreach($keys as $key) {
324
-			if($key !== $attribute && strpos($key, $attribute) === 0) {
323
+		foreach ($keys as $key) {
324
+			if ($key !== $attribute && strpos($key, $attribute) === 0) {
325 325
 				$queryData = explode(';', $key);
326
-				if(strpos($queryData[1], 'range=') === 0) {
326
+				if (strpos($queryData[1], 'range=') === 0) {
327 327
 					$high = substr($queryData[1], 1 + strpos($queryData[1], '-'));
328 328
 					$data = [
329 329
 						'values' => $result[$key],
@@ -348,18 +348,18 @@  discard block
 block discarded – undo
348 348
 	 * @throws \Exception
349 349
 	 */
350 350
 	public function setPassword($userDN, $password) {
351
-		if(intval($this->connection->turnOnPasswordChange) !== 1) {
351
+		if (intval($this->connection->turnOnPasswordChange) !== 1) {
352 352
 			throw new \Exception('LDAP password changes are disabled.');
353 353
 		}
354 354
 		$cr = $this->connection->getConnectionResource();
355
-		if(!$this->ldap->isResource($cr)) {
355
+		if (!$this->ldap->isResource($cr)) {
356 356
 			//LDAP not available
357 357
 			\OCP\Util::writeLog('user_ldap', 'LDAP resource not available.', \OCP\Util::DEBUG);
358 358
 			return false;
359 359
 		}
360 360
 		try {
361 361
 			return @$this->invokeLDAPMethod('modReplace', $cr, $userDN, $password);
362
-		} catch(ConstraintViolationException $e) {
362
+		} catch (ConstraintViolationException $e) {
363 363
 			throw new HintException('Password change rejected.', \OC::$server->getL10N('user_ldap')->t('Password change rejected. Hint: ').$e->getMessage(), $e->getCode());
364 364
 		}
365 365
 	}
@@ -401,17 +401,17 @@  discard block
 block discarded – undo
401 401
 	 */
402 402
 	public function getDomainDNFromDN($dn) {
403 403
 		$allParts = $this->ldap->explodeDN($dn, 0);
404
-		if($allParts === false) {
404
+		if ($allParts === false) {
405 405
 			//not a valid DN
406 406
 			return '';
407 407
 		}
408 408
 		$domainParts = array();
409 409
 		$dcFound = false;
410
-		foreach($allParts as $part) {
411
-			if(!$dcFound && strpos($part, 'dc=') === 0) {
410
+		foreach ($allParts as $part) {
411
+			if (!$dcFound && strpos($part, 'dc=') === 0) {
412 412
 				$dcFound = true;
413 413
 			}
414
-			if($dcFound) {
414
+			if ($dcFound) {
415 415
 				$domainParts[] = $part;
416 416
 			}
417 417
 		}
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 
439 439
 		//Check whether the DN belongs to the Base, to avoid issues on multi-
440 440
 		//server setups
441
-		if(is_string($fdn) && $this->isDNPartOfBase($fdn, $this->connection->ldapBaseUsers)) {
441
+		if (is_string($fdn) && $this->isDNPartOfBase($fdn, $this->connection->ldapBaseUsers)) {
442 442
 			return $fdn;
443 443
 		}
444 444
 
@@ -455,7 +455,7 @@  discard block
 block discarded – undo
455 455
 		//To avoid bypassing the base DN settings under certain circumstances
456 456
 		//with the group support, check whether the provided DN matches one of
457 457
 		//the given Bases
458
-		if(!$this->isDNPartOfBase($fdn, $this->connection->ldapBaseGroups)) {
458
+		if (!$this->isDNPartOfBase($fdn, $this->connection->ldapBaseGroups)) {
459 459
 			return false;
460 460
 		}
461 461
 
@@ -472,11 +472,11 @@  discard block
 block discarded – undo
472 472
 	 */
473 473
 	public function groupsMatchFilter($groupDNs) {
474 474
 		$validGroupDNs = [];
475
-		foreach($groupDNs as $dn) {
475
+		foreach ($groupDNs as $dn) {
476 476
 			$cacheKey = 'groupsMatchFilter-'.$dn;
477 477
 			$groupMatchFilter = $this->connection->getFromCache($cacheKey);
478
-			if(!is_null($groupMatchFilter)) {
479
-				if($groupMatchFilter) {
478
+			if (!is_null($groupMatchFilter)) {
479
+				if ($groupMatchFilter) {
480 480
 					$validGroupDNs[] = $dn;
481 481
 				}
482 482
 				continue;
@@ -484,13 +484,13 @@  discard block
 block discarded – undo
484 484
 
485 485
 			// Check the base DN first. If this is not met already, we don't
486 486
 			// need to ask the server at all.
487
-			if(!$this->isDNPartOfBase($dn, $this->connection->ldapBaseGroups)) {
487
+			if (!$this->isDNPartOfBase($dn, $this->connection->ldapBaseGroups)) {
488 488
 				$this->connection->writeToCache($cacheKey, false);
489 489
 				continue;
490 490
 			}
491 491
 
492 492
 			$result = $this->readAttribute($dn, 'cn', $this->connection->ldapGroupFilter);
493
-			if(is_array($result)) {
493
+			if (is_array($result)) {
494 494
 				$this->connection->writeToCache($cacheKey, true);
495 495
 				$validGroupDNs[] = $dn;
496 496
 			} else {
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
 		//To avoid bypassing the base DN settings under certain circumstances
512 512
 		//with the group support, check whether the provided DN matches one of
513 513
 		//the given Bases
514
-		if(!$this->isDNPartOfBase($fdn, $this->connection->ldapBaseUsers)) {
514
+		if (!$this->isDNPartOfBase($fdn, $this->connection->ldapBaseUsers)) {
515 515
 			return false;
516 516
 		}
517 517
 
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
 	 */
531 531
 	public function dn2ocname($fdn, $ldapName = null, $isUser = true, &$newlyMapped = null, array $record = null) {
532 532
 		$newlyMapped = false;
533
-		if($isUser) {
533
+		if ($isUser) {
534 534
 			$mapper = $this->getUserMapper();
535 535
 			$nameAttribute = $this->connection->ldapUserDisplayName;
536 536
 		} else {
@@ -540,15 +540,15 @@  discard block
 block discarded – undo
540 540
 
541 541
 		//let's try to retrieve the Nextcloud name from the mappings table
542 542
 		$ncName = $mapper->getNameByDN($fdn);
543
-		if(is_string($ncName)) {
543
+		if (is_string($ncName)) {
544 544
 			return $ncName;
545 545
 		}
546 546
 
547 547
 		//second try: get the UUID and check if it is known. Then, update the DN and return the name.
548 548
 		$uuid = $this->getUUID($fdn, $isUser, $record);
549
-		if(is_string($uuid)) {
549
+		if (is_string($uuid)) {
550 550
 			$ncName = $mapper->getNameByUUID($uuid);
551
-			if(is_string($ncName)) {
551
+			if (is_string($ncName)) {
552 552
 				$mapper->setDNbyUUID($fdn, $uuid);
553 553
 				return $ncName;
554 554
 			}
@@ -558,16 +558,16 @@  discard block
 block discarded – undo
558 558
 			return false;
559 559
 		}
560 560
 
561
-		if(is_null($ldapName)) {
561
+		if (is_null($ldapName)) {
562 562
 			$ldapName = $this->readAttribute($fdn, $nameAttribute);
563
-			if(!isset($ldapName[0]) && empty($ldapName[0])) {
563
+			if (!isset($ldapName[0]) && empty($ldapName[0])) {
564 564
 				\OCP\Util::writeLog('user_ldap', 'No or empty name for '.$fdn.'.', \OCP\Util::INFO);
565 565
 				return false;
566 566
 			}
567 567
 			$ldapName = $ldapName[0];
568 568
 		}
569 569
 
570
-		if($isUser) {
570
+		if ($isUser) {
571 571
 			$usernameAttribute = strval($this->connection->ldapExpertUsernameAttr);
572 572
 			if ($usernameAttribute !== '') {
573 573
 				$username = $this->readAttribute($fdn, $usernameAttribute);
@@ -586,9 +586,9 @@  discard block
 block discarded – undo
586 586
 		// outside of core user management will still cache the user as non-existing.
587 587
 		$originalTTL = $this->connection->ldapCacheTTL;
588 588
 		$this->connection->setConfiguration(array('ldapCacheTTL' => 0));
589
-		if(($isUser && !\OCP\User::userExists($intName))
589
+		if (($isUser && !\OCP\User::userExists($intName))
590 590
 			|| (!$isUser && !\OC::$server->getGroupManager()->groupExists($intName))) {
591
-			if($mapper->map($fdn, $intName, $uuid)) {
591
+			if ($mapper->map($fdn, $intName, $uuid)) {
592 592
 				$this->connection->setConfiguration(array('ldapCacheTTL' => $originalTTL));
593 593
 				$newlyMapped = true;
594 594
 				return $intName;
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
 		$this->connection->setConfiguration(array('ldapCacheTTL' => $originalTTL));
598 598
 
599 599
 		$altName = $this->createAltInternalOwnCloudName($intName, $isUser);
600
-		if(is_string($altName) && $mapper->map($fdn, $altName, $uuid)) {
600
+		if (is_string($altName) && $mapper->map($fdn, $altName, $uuid)) {
601 601
 			$newlyMapped = true;
602 602
 			return $altName;
603 603
 		}
@@ -635,7 +635,7 @@  discard block
 block discarded – undo
635 635
 	 * @return array
636 636
 	 */
637 637
 	private function ldap2NextcloudNames($ldapObjects, $isUsers) {
638
-		if($isUsers) {
638
+		if ($isUsers) {
639 639
 			$nameAttribute = $this->connection->ldapUserDisplayName;
640 640
 			$sndAttribute  = $this->connection->ldapUserDisplayName2;
641 641
 		} else {
@@ -643,9 +643,9 @@  discard block
 block discarded – undo
643 643
 		}
644 644
 		$nextcloudNames = array();
645 645
 
646
-		foreach($ldapObjects as $ldapObject) {
646
+		foreach ($ldapObjects as $ldapObject) {
647 647
 			$nameByLDAP = null;
648
-			if(    isset($ldapObject[$nameAttribute])
648
+			if (isset($ldapObject[$nameAttribute])
649 649
 				&& is_array($ldapObject[$nameAttribute])
650 650
 				&& isset($ldapObject[$nameAttribute][0])
651 651
 			) {
@@ -654,12 +654,12 @@  discard block
 block discarded – undo
654 654
 			}
655 655
 
656 656
 			$ncName = $this->dn2ocname($ldapObject['dn'][0], $nameByLDAP, $isUsers);
657
-			if($ncName) {
657
+			if ($ncName) {
658 658
 				$nextcloudNames[] = $ncName;
659
-				if($isUsers) {
659
+				if ($isUsers) {
660 660
 					//cache the user names so it does not need to be retrieved
661 661
 					//again later (e.g. sharing dialogue).
662
-					if(is_null($nameByLDAP)) {
662
+					if (is_null($nameByLDAP)) {
663 663
 						continue;
664 664
 					}
665 665
 					$sndName = isset($ldapObject[$sndAttribute][0])
@@ -697,7 +697,7 @@  discard block
 block discarded – undo
697 697
 	 */
698 698
 	public function cacheUserDisplayName($ocName, $displayName, $displayName2 = '') {
699 699
 		$user = $this->userManager->get($ocName);
700
-		if($user === null) {
700
+		if ($user === null) {
701 701
 			return;
702 702
 		}
703 703
 		$displayName = $user->composeAndStoreDisplayName($displayName, $displayName2);
@@ -717,9 +717,9 @@  discard block
 block discarded – undo
717 717
 		$attempts = 0;
718 718
 		//while loop is just a precaution. If a name is not generated within
719 719
 		//20 attempts, something else is very wrong. Avoids infinite loop.
720
-		while($attempts < 20){
721
-			$altName = $name . '_' . rand(1000,9999);
722
-			if(!\OCP\User::userExists($altName)) {
720
+		while ($attempts < 20) {
721
+			$altName = $name.'_'.rand(1000, 9999);
722
+			if (!\OCP\User::userExists($altName)) {
723 723
 				return $altName;
724 724
 			}
725 725
 			$attempts++;
@@ -741,25 +741,25 @@  discard block
 block discarded – undo
741 741
 	 */
742 742
 	private function _createAltInternalOwnCloudNameForGroups($name) {
743 743
 		$usedNames = $this->groupMapper->getNamesBySearch($name, "", '_%');
744
-		if(!($usedNames) || count($usedNames) === 0) {
744
+		if (!($usedNames) || count($usedNames) === 0) {
745 745
 			$lastNo = 1; //will become name_2
746 746
 		} else {
747 747
 			natsort($usedNames);
748 748
 			$lastName = array_pop($usedNames);
749 749
 			$lastNo = intval(substr($lastName, strrpos($lastName, '_') + 1));
750 750
 		}
751
-		$altName = $name.'_'.strval($lastNo+1);
751
+		$altName = $name.'_'.strval($lastNo + 1);
752 752
 		unset($usedNames);
753 753
 
754 754
 		$attempts = 1;
755
-		while($attempts < 21){
755
+		while ($attempts < 21) {
756 756
 			// Check to be really sure it is unique
757 757
 			// while loop is just a precaution. If a name is not generated within
758 758
 			// 20 attempts, something else is very wrong. Avoids infinite loop.
759
-			if(!\OC::$server->getGroupManager()->groupExists($altName)) {
759
+			if (!\OC::$server->getGroupManager()->groupExists($altName)) {
760 760
 				return $altName;
761 761
 			}
762
-			$altName = $name . '_' . ($lastNo + $attempts);
762
+			$altName = $name.'_'.($lastNo + $attempts);
763 763
 			$attempts++;
764 764
 		}
765 765
 		return false;
@@ -774,7 +774,7 @@  discard block
 block discarded – undo
774 774
 	private function createAltInternalOwnCloudName($name, $isUser) {
775 775
 		$originalTTL = $this->connection->ldapCacheTTL;
776 776
 		$this->connection->setConfiguration(array('ldapCacheTTL' => 0));
777
-		if($isUser) {
777
+		if ($isUser) {
778 778
 			$altName = $this->_createAltInternalOwnCloudNameForUsers($name);
779 779
 		} else {
780 780
 			$altName = $this->_createAltInternalOwnCloudNameForGroups($name);
@@ -824,7 +824,7 @@  discard block
 block discarded – undo
824 824
 	public function fetchListOfUsers($filter, $attr, $limit = null, $offset = null, $forceApplyAttributes = false) {
825 825
 		$ldapRecords = $this->searchUsers($filter, $attr, $limit, $offset);
826 826
 		$recordsToUpdate = $ldapRecords;
827
-		if(!$forceApplyAttributes) {
827
+		if (!$forceApplyAttributes) {
828 828
 			$isBackgroundJobModeAjax = $this->config
829 829
 					->getAppValue('core', 'backgroundjobs_mode', 'ajax') === 'ajax';
830 830
 			$recordsToUpdate = array_filter($ldapRecords, function($record) use ($isBackgroundJobModeAjax) {
@@ -843,20 +843,20 @@  discard block
 block discarded – undo
843 843
 	 * and their values
844 844
 	 * @param array $ldapRecords
845 845
 	 */
846
-	public function batchApplyUserAttributes(array $ldapRecords){
846
+	public function batchApplyUserAttributes(array $ldapRecords) {
847 847
 		$displayNameAttribute = strtolower($this->connection->ldapUserDisplayName);
848
-		foreach($ldapRecords as $userRecord) {
849
-			if(!isset($userRecord[$displayNameAttribute])) {
848
+		foreach ($ldapRecords as $userRecord) {
849
+			if (!isset($userRecord[$displayNameAttribute])) {
850 850
 				// displayName is obligatory
851 851
 				continue;
852 852
 			}
853
-			$ocName  = $this->dn2ocname($userRecord['dn'][0], null, true);
854
-			if($ocName === false) {
853
+			$ocName = $this->dn2ocname($userRecord['dn'][0], null, true);
854
+			if ($ocName === false) {
855 855
 				continue;
856 856
 			}
857 857
 			$this->cacheUserExists($ocName);
858 858
 			$user = $this->userManager->get($ocName);
859
-			if($user instanceof OfflineUser) {
859
+			if ($user instanceof OfflineUser) {
860 860
 				$user->unmark();
861 861
 				$user = $this->userManager->get($ocName);
862 862
 			}
@@ -888,8 +888,8 @@  discard block
 block discarded – undo
888 888
 	 * @return array
889 889
 	 */
890 890
 	private function fetchList($list, $manyAttributes) {
891
-		if(is_array($list)) {
892
-			if($manyAttributes) {
891
+		if (is_array($list)) {
892
+			if ($manyAttributes) {
893 893
 				return $list;
894 894
 			} else {
895 895
 				$list = array_reduce($list, function($carry, $item) {
@@ -987,7 +987,7 @@  discard block
 block discarded – undo
987 987
 		// php no longer supports call-time pass-by-reference
988 988
 		// thus cannot support controlPagedResultResponse as the third argument
989 989
 		// is a reference
990
-		$doMethod = function () use ($command, &$arguments) {
990
+		$doMethod = function() use ($command, &$arguments) {
991 991
 			if ($command == 'controlPagedResultResponse') {
992 992
 				throw new \InvalidArgumentException('Invoker does not support controlPagedResultResponse, call LDAP Wrapper directly instead.');
993 993
 			} else {
@@ -1005,7 +1005,7 @@  discard block
 block discarded – undo
1005 1005
 			$this->connection->resetConnectionResource();
1006 1006
 			$cr = $this->connection->getConnectionResource();
1007 1007
 
1008
-			if(!$this->ldap->isResource($cr)) {
1008
+			if (!$this->ldap->isResource($cr)) {
1009 1009
 				// Seems like we didn't find any resource.
1010 1010
 				\OCP\Util::writeLog('user_ldap', "Could not $command, because resource is missing.", \OCP\Util::DEBUG);
1011 1011
 				throw $e;
@@ -1026,13 +1026,13 @@  discard block
 block discarded – undo
1026 1026
 	 * @throws \OC\ServerNotAvailableException
1027 1027
 	 */
1028 1028
 	private function executeSearch($filter, $base, &$attr = null, $limit = null, $offset = null) {
1029
-		if(!is_null($attr) && !is_array($attr)) {
1029
+		if (!is_null($attr) && !is_array($attr)) {
1030 1030
 			$attr = array(mb_strtolower($attr, 'UTF-8'));
1031 1031
 		}
1032 1032
 
1033 1033
 		// See if we have a resource, in case not cancel with message
1034 1034
 		$cr = $this->connection->getConnectionResource();
1035
-		if(!$this->ldap->isResource($cr)) {
1035
+		if (!$this->ldap->isResource($cr)) {
1036 1036
 			// Seems like we didn't find any resource.
1037 1037
 			// Return an empty array just like before.
1038 1038
 			\OCP\Util::writeLog('user_ldap', 'Could not search, because resource is missing.', \OCP\Util::DEBUG);
@@ -1046,7 +1046,7 @@  discard block
 block discarded – undo
1046 1046
 		$sr = $this->invokeLDAPMethod('search', $linkResources, $base, $filter, $attr);
1047 1047
 		// cannot use $cr anymore, might have changed in the previous call!
1048 1048
 		$error = $this->ldap->errno($this->connection->getConnectionResource());
1049
-		if(!is_array($sr) || $error !== 0) {
1049
+		if (!is_array($sr) || $error !== 0) {
1050 1050
 			\OCP\Util::writeLog('user_ldap', 'Attempt for Paging?  '.print_r($pagedSearchOK, true), \OCP\Util::ERROR);
1051 1051
 			return false;
1052 1052
 		}
@@ -1069,26 +1069,26 @@  discard block
 block discarded – undo
1069 1069
 	 */
1070 1070
 	private function processPagedSearchStatus($sr, $filter, $base, $iFoundItems, $limit, $offset, $pagedSearchOK, $skipHandling) {
1071 1071
 		$cookie = null;
1072
-		if($pagedSearchOK) {
1072
+		if ($pagedSearchOK) {
1073 1073
 			$cr = $this->connection->getConnectionResource();
1074
-			foreach($sr as $key => $res) {
1075
-				if($this->ldap->controlPagedResultResponse($cr, $res, $cookie)) {
1074
+			foreach ($sr as $key => $res) {
1075
+				if ($this->ldap->controlPagedResultResponse($cr, $res, $cookie)) {
1076 1076
 					$this->setPagedResultCookie($base[$key], $filter, $limit, $offset, $cookie);
1077 1077
 				}
1078 1078
 			}
1079 1079
 
1080 1080
 			//browsing through prior pages to get the cookie for the new one
1081
-			if($skipHandling) {
1081
+			if ($skipHandling) {
1082 1082
 				return false;
1083 1083
 			}
1084 1084
 			// if count is bigger, then the server does not support
1085 1085
 			// paged search. Instead, he did a normal search. We set a
1086 1086
 			// flag here, so the callee knows how to deal with it.
1087
-			if($iFoundItems <= $limit) {
1087
+			if ($iFoundItems <= $limit) {
1088 1088
 				$this->pagedSearchedSuccessful = true;
1089 1089
 			}
1090 1090
 		} else {
1091
-			if(!is_null($limit)) {
1091
+			if (!is_null($limit)) {
1092 1092
 				\OCP\Util::writeLog('user_ldap', 'Paged search was not available', \OCP\Util::INFO);
1093 1093
 			}
1094 1094
 		}
@@ -1117,7 +1117,7 @@  discard block
 block discarded – undo
1117 1117
 		\OCP\Util::writeLog('user_ldap', 'Count filter:  '.print_r($filter, true), \OCP\Util::DEBUG);
1118 1118
 
1119 1119
 		$limitPerPage = intval($this->connection->ldapPagingSize);
1120
-		if(!is_null($limit) && $limit < $limitPerPage && $limit > 0) {
1120
+		if (!is_null($limit) && $limit < $limitPerPage && $limit > 0) {
1121 1121
 			$limitPerPage = $limit;
1122 1122
 		}
1123 1123
 
@@ -1128,7 +1128,7 @@  discard block
 block discarded – undo
1128 1128
 		do {
1129 1129
 			$search = $this->executeSearch($filter, $base, $attr,
1130 1130
 										   $limitPerPage, $offset);
1131
-			if($search === false) {
1131
+			if ($search === false) {
1132 1132
 				return $counter > 0 ? $counter : false;
1133 1133
 			}
1134 1134
 			list($sr, $pagedSearchOK) = $search;
@@ -1147,7 +1147,7 @@  discard block
 block discarded – undo
1147 1147
 			 * Continue now depends on $hasMorePages value
1148 1148
 			 */
1149 1149
 			$continue = $pagedSearchOK && $hasMorePages;
1150
-		} while($continue && (is_null($limit) || $limit <= 0 || $limit > $counter));
1150
+		} while ($continue && (is_null($limit) || $limit <= 0 || $limit > $counter));
1151 1151
 
1152 1152
 		return $counter;
1153 1153
 	}
@@ -1159,7 +1159,7 @@  discard block
 block discarded – undo
1159 1159
 	private function countEntriesInSearchResults($searchResults) {
1160 1160
 		$counter = 0;
1161 1161
 
1162
-		foreach($searchResults as $res) {
1162
+		foreach ($searchResults as $res) {
1163 1163
 			$count = intval($this->invokeLDAPMethod('countEntries', $this->connection->getConnectionResource(), $res));
1164 1164
 			$counter += $count;
1165 1165
 		}
@@ -1179,7 +1179,7 @@  discard block
 block discarded – undo
1179 1179
 	 */
1180 1180
 	public function search($filter, $base, $attr = null, $limit = null, $offset = null, $skipHandling = false) {
1181 1181
 		$limitPerPage = intval($this->connection->ldapPagingSize);
1182
-		if(!is_null($limit) && $limit < $limitPerPage && $limit > 0) {
1182
+		if (!is_null($limit) && $limit < $limitPerPage && $limit > 0) {
1183 1183
 			$limitPerPage = $limit;
1184 1184
 		}
1185 1185
 
@@ -1193,13 +1193,13 @@  discard block
 block discarded – undo
1193 1193
 		$savedoffset = $offset;
1194 1194
 		do {
1195 1195
 			$search = $this->executeSearch($filter, $base, $attr, $limitPerPage, $offset);
1196
-			if($search === false) {
1196
+			if ($search === false) {
1197 1197
 				return array();
1198 1198
 			}
1199 1199
 			list($sr, $pagedSearchOK) = $search;
1200 1200
 			$cr = $this->connection->getConnectionResource();
1201 1201
 
1202
-			if($skipHandling) {
1202
+			if ($skipHandling) {
1203 1203
 				//i.e. result do not need to be fetched, we just need the cookie
1204 1204
 				//thus pass 1 or any other value as $iFoundItems because it is not
1205 1205
 				//used
@@ -1210,7 +1210,7 @@  discard block
 block discarded – undo
1210 1210
 			}
1211 1211
 
1212 1212
 			$iFoundItems = 0;
1213
-			foreach($sr as $res) {
1213
+			foreach ($sr as $res) {
1214 1214
 				$findings = array_merge($findings, $this->invokeLDAPMethod('getEntries', $cr, $res));
1215 1215
 				$iFoundItems = max($iFoundItems, $findings['count']);
1216 1216
 				unset($findings['count']);
@@ -1226,25 +1226,25 @@  discard block
 block discarded – undo
1226 1226
 
1227 1227
 		// if we're here, probably no connection resource is returned.
1228 1228
 		// to make Nextcloud behave nicely, we simply give back an empty array.
1229
-		if(is_null($findings)) {
1229
+		if (is_null($findings)) {
1230 1230
 			return array();
1231 1231
 		}
1232 1232
 
1233
-		if(!is_null($attr)) {
1233
+		if (!is_null($attr)) {
1234 1234
 			$selection = array();
1235 1235
 			$i = 0;
1236
-			foreach($findings as $item) {
1237
-				if(!is_array($item)) {
1236
+			foreach ($findings as $item) {
1237
+				if (!is_array($item)) {
1238 1238
 					continue;
1239 1239
 				}
1240 1240
 				$item = \OCP\Util::mb_array_change_key_case($item, MB_CASE_LOWER, 'UTF-8');
1241
-				foreach($attr as $key) {
1241
+				foreach ($attr as $key) {
1242 1242
 					$key = mb_strtolower($key, 'UTF-8');
1243
-					if(isset($item[$key])) {
1244
-						if(is_array($item[$key]) && isset($item[$key]['count'])) {
1243
+					if (isset($item[$key])) {
1244
+						if (is_array($item[$key]) && isset($item[$key]['count'])) {
1245 1245
 							unset($item[$key]['count']);
1246 1246
 						}
1247
-						if($key !== 'dn') {
1247
+						if ($key !== 'dn') {
1248 1248
 							$selection[$i][$key] = $this->resemblesDN($key) ?
1249 1249
 								$this->helper->sanitizeDN($item[$key])
1250 1250
 								: $key === 'objectguid' || $key === 'guid' ?
@@ -1263,7 +1263,7 @@  discard block
 block discarded – undo
1263 1263
 		//we slice the findings, when
1264 1264
 		//a) paged search unsuccessful, though attempted
1265 1265
 		//b) no paged search, but limit set
1266
-		if((!$this->getPagedSearchResultState()
1266
+		if ((!$this->getPagedSearchResultState()
1267 1267
 			&& $pagedSearchOK)
1268 1268
 			|| (
1269 1269
 				!$pagedSearchOK
@@ -1280,7 +1280,7 @@  discard block
 block discarded – undo
1280 1280
 	 * @return bool|mixed|string
1281 1281
 	 */
1282 1282
 	public function sanitizeUsername($name) {
1283
-		if($this->connection->ldapIgnoreNamingRules) {
1283
+		if ($this->connection->ldapIgnoreNamingRules) {
1284 1284
 			return $name;
1285 1285
 		}
1286 1286
 
@@ -1305,13 +1305,13 @@  discard block
 block discarded – undo
1305 1305
 	*/
1306 1306
 	public function escapeFilterPart($input, $allowAsterisk = false) {
1307 1307
 		$asterisk = '';
1308
-		if($allowAsterisk && strlen($input) > 0 && $input[0] === '*') {
1308
+		if ($allowAsterisk && strlen($input) > 0 && $input[0] === '*') {
1309 1309
 			$asterisk = '*';
1310 1310
 			$input = mb_substr($input, 1, null, 'UTF-8');
1311 1311
 		}
1312 1312
 		$search  = array('*', '\\', '(', ')');
1313 1313
 		$replace = array('\\*', '\\\\', '\\(', '\\)');
1314
-		return $asterisk . str_replace($search, $replace, $input);
1314
+		return $asterisk.str_replace($search, $replace, $input);
1315 1315
 	}
1316 1316
 
1317 1317
 	/**
@@ -1341,13 +1341,13 @@  discard block
 block discarded – undo
1341 1341
 	 */
1342 1342
 	private function combineFilter($filters, $operator) {
1343 1343
 		$combinedFilter = '('.$operator;
1344
-		foreach($filters as $filter) {
1344
+		foreach ($filters as $filter) {
1345 1345
 			if ($filter !== '' && $filter[0] !== '(') {
1346 1346
 				$filter = '('.$filter.')';
1347 1347
 			}
1348
-			$combinedFilter.=$filter;
1348
+			$combinedFilter .= $filter;
1349 1349
 		}
1350
-		$combinedFilter.=')';
1350
+		$combinedFilter .= ')';
1351 1351
 		return $combinedFilter;
1352 1352
 	}
1353 1353
 
@@ -1383,17 +1383,17 @@  discard block
 block discarded – undo
1383 1383
 	 * @throws \Exception
1384 1384
 	 */
1385 1385
 	private function getAdvancedFilterPartForSearch($search, $searchAttributes) {
1386
-		if(!is_array($searchAttributes) || count($searchAttributes) < 2) {
1386
+		if (!is_array($searchAttributes) || count($searchAttributes) < 2) {
1387 1387
 			throw new \Exception('searchAttributes must be an array with at least two string');
1388 1388
 		}
1389 1389
 		$searchWords = explode(' ', trim($search));
1390 1390
 		$wordFilters = array();
1391
-		foreach($searchWords as $word) {
1391
+		foreach ($searchWords as $word) {
1392 1392
 			$word = $this->prepareSearchTerm($word);
1393 1393
 			//every word needs to appear at least once
1394 1394
 			$wordMatchOneAttrFilters = array();
1395
-			foreach($searchAttributes as $attr) {
1396
-				$wordMatchOneAttrFilters[] = $attr . '=' . $word;
1395
+			foreach ($searchAttributes as $attr) {
1396
+				$wordMatchOneAttrFilters[] = $attr.'='.$word;
1397 1397
 			}
1398 1398
 			$wordFilters[] = $this->combineFilterWithOr($wordMatchOneAttrFilters);
1399 1399
 		}
@@ -1411,10 +1411,10 @@  discard block
 block discarded – undo
1411 1411
 	private function getFilterPartForSearch($search, $searchAttributes, $fallbackAttribute) {
1412 1412
 		$filter = array();
1413 1413
 		$haveMultiSearchAttributes = (is_array($searchAttributes) && count($searchAttributes) > 0);
1414
-		if($haveMultiSearchAttributes && strpos(trim($search), ' ') !== false) {
1414
+		if ($haveMultiSearchAttributes && strpos(trim($search), ' ') !== false) {
1415 1415
 			try {
1416 1416
 				return $this->getAdvancedFilterPartForSearch($search, $searchAttributes);
1417
-			} catch(\Exception $e) {
1417
+			} catch (\Exception $e) {
1418 1418
 				\OCP\Util::writeLog(
1419 1419
 					'user_ldap',
1420 1420
 					'Creating advanced filter for search failed, falling back to simple method.',
@@ -1424,17 +1424,17 @@  discard block
 block discarded – undo
1424 1424
 		}
1425 1425
 
1426 1426
 		$search = $this->prepareSearchTerm($search);
1427
-		if(!is_array($searchAttributes) || count($searchAttributes) === 0) {
1427
+		if (!is_array($searchAttributes) || count($searchAttributes) === 0) {
1428 1428
 			if ($fallbackAttribute === '') {
1429 1429
 				return '';
1430 1430
 			}
1431
-			$filter[] = $fallbackAttribute . '=' . $search;
1431
+			$filter[] = $fallbackAttribute.'='.$search;
1432 1432
 		} else {
1433
-			foreach($searchAttributes as $attribute) {
1434
-				$filter[] = $attribute . '=' . $search;
1433
+			foreach ($searchAttributes as $attribute) {
1434
+				$filter[] = $attribute.'='.$search;
1435 1435
 			}
1436 1436
 		}
1437
-		if(count($filter) === 1) {
1437
+		if (count($filter) === 1) {
1438 1438
 			return '('.$filter[0].')';
1439 1439
 		}
1440 1440
 		return $this->combineFilterWithOr($filter);
@@ -1455,7 +1455,7 @@  discard block
 block discarded – undo
1455 1455
 		if ($term === '') {
1456 1456
 			$result = '*';
1457 1457
 		} else if ($allowEnum !== 'no') {
1458
-			$result = $term . '*';
1458
+			$result = $term.'*';
1459 1459
 		}
1460 1460
 		return $result;
1461 1461
 	}
@@ -1467,7 +1467,7 @@  discard block
 block discarded – undo
1467 1467
 	public function getFilterForUserCount() {
1468 1468
 		$filter = $this->combineFilterWithAnd(array(
1469 1469
 			$this->connection->ldapUserFilter,
1470
-			$this->connection->ldapUserDisplayName . '=*'
1470
+			$this->connection->ldapUserDisplayName.'=*'
1471 1471
 		));
1472 1472
 
1473 1473
 		return $filter;
@@ -1485,7 +1485,7 @@  discard block
 block discarded – undo
1485 1485
 			'ldapAgentName' => $name,
1486 1486
 			'ldapAgentPassword' => $password
1487 1487
 		);
1488
-		if(!$testConnection->setConfiguration($credentials)) {
1488
+		if (!$testConnection->setConfiguration($credentials)) {
1489 1489
 			return false;
1490 1490
 		}
1491 1491
 		return $testConnection->bind();
@@ -1507,30 +1507,30 @@  discard block
 block discarded – undo
1507 1507
 			// Sacrebleu! The UUID attribute is unknown :( We need first an
1508 1508
 			// existing DN to be able to reliably detect it.
1509 1509
 			$result = $this->search($filter, $base, ['dn'], 1);
1510
-			if(!isset($result[0]) || !isset($result[0]['dn'])) {
1510
+			if (!isset($result[0]) || !isset($result[0]['dn'])) {
1511 1511
 				throw new \Exception('Cannot determine UUID attribute');
1512 1512
 			}
1513 1513
 			$dn = $result[0]['dn'][0];
1514
-			if(!$this->detectUuidAttribute($dn, true)) {
1514
+			if (!$this->detectUuidAttribute($dn, true)) {
1515 1515
 				throw new \Exception('Cannot determine UUID attribute');
1516 1516
 			}
1517 1517
 		} else {
1518 1518
 			// The UUID attribute is either known or an override is given.
1519 1519
 			// By calling this method we ensure that $this->connection->$uuidAttr
1520 1520
 			// is definitely set
1521
-			if(!$this->detectUuidAttribute('', true)) {
1521
+			if (!$this->detectUuidAttribute('', true)) {
1522 1522
 				throw new \Exception('Cannot determine UUID attribute');
1523 1523
 			}
1524 1524
 		}
1525 1525
 
1526 1526
 		$uuidAttr = $this->connection->ldapUuidUserAttribute;
1527
-		if($uuidAttr === 'guid' || $uuidAttr === 'objectguid') {
1527
+		if ($uuidAttr === 'guid' || $uuidAttr === 'objectguid') {
1528 1528
 			$uuid = $this->formatGuid2ForFilterUser($uuid);
1529 1529
 		}
1530 1530
 
1531
-		$filter = $uuidAttr . '=' . $uuid;
1531
+		$filter = $uuidAttr.'='.$uuid;
1532 1532
 		$result = $this->searchUsers($filter, ['dn'], 2);
1533
-		if(is_array($result) && isset($result[0]) && isset($result[0]['dn']) && count($result) === 1) {
1533
+		if (is_array($result) && isset($result[0]) && isset($result[0]['dn']) && count($result) === 1) {
1534 1534
 			// we put the count into account to make sure that this is
1535 1535
 			// really unique
1536 1536
 			return $result[0]['dn'][0];
@@ -1549,7 +1549,7 @@  discard block
 block discarded – undo
1549 1549
 	 * @return bool true on success, false otherwise
1550 1550
 	 */
1551 1551
 	private function detectUuidAttribute($dn, $isUser = true, $force = false, array $ldapRecord = null) {
1552
-		if($isUser) {
1552
+		if ($isUser) {
1553 1553
 			$uuidAttr     = 'ldapUuidUserAttribute';
1554 1554
 			$uuidOverride = $this->connection->ldapExpertUUIDUserAttr;
1555 1555
 		} else {
@@ -1557,7 +1557,7 @@  discard block
 block discarded – undo
1557 1557
 			$uuidOverride = $this->connection->ldapExpertUUIDGroupAttr;
1558 1558
 		}
1559 1559
 
1560
-		if(($this->connection->$uuidAttr !== 'auto') && !$force) {
1560
+		if (($this->connection->$uuidAttr !== 'auto') && !$force) {
1561 1561
 			return true;
1562 1562
 		}
1563 1563
 
@@ -1566,10 +1566,10 @@  discard block
 block discarded – undo
1566 1566
 			return true;
1567 1567
 		}
1568 1568
 
1569
-		foreach(self::UUID_ATTRIBUTES as $attribute) {
1570
-			if($ldapRecord !== null) {
1569
+		foreach (self::UUID_ATTRIBUTES as $attribute) {
1570
+			if ($ldapRecord !== null) {
1571 1571
 				// we have the info from LDAP already, we don't need to talk to the server again
1572
-				if(isset($ldapRecord[$attribute])) {
1572
+				if (isset($ldapRecord[$attribute])) {
1573 1573
 					$this->connection->$uuidAttr = $attribute;
1574 1574
 					return true;
1575 1575
 				} else {
@@ -1578,7 +1578,7 @@  discard block
 block discarded – undo
1578 1578
 			}
1579 1579
 
1580 1580
 			$value = $this->readAttribute($dn, $attribute);
1581
-			if(is_array($value) && isset($value[0]) && !empty($value[0])) {
1581
+			if (is_array($value) && isset($value[0]) && !empty($value[0])) {
1582 1582
 				\OCP\Util::writeLog('user_ldap',
1583 1583
 									'Setting '.$attribute.' as '.$uuidAttr,
1584 1584
 									\OCP\Util::DEBUG);
@@ -1600,7 +1600,7 @@  discard block
 block discarded – undo
1600 1600
 	 * @return bool|string
1601 1601
 	 */
1602 1602
 	public function getUUID($dn, $isUser = true, $ldapRecord = null) {
1603
-		if($isUser) {
1603
+		if ($isUser) {
1604 1604
 			$uuidAttr     = 'ldapUuidUserAttribute';
1605 1605
 			$uuidOverride = $this->connection->ldapExpertUUIDUserAttr;
1606 1606
 		} else {
@@ -1609,10 +1609,10 @@  discard block
 block discarded – undo
1609 1609
 		}
1610 1610
 
1611 1611
 		$uuid = false;
1612
-		if($this->detectUuidAttribute($dn, $isUser, false, $ldapRecord)) {
1612
+		if ($this->detectUuidAttribute($dn, $isUser, false, $ldapRecord)) {
1613 1613
 			$attr = $this->connection->$uuidAttr;
1614 1614
 			$uuid = isset($ldapRecord[$attr]) ? $ldapRecord[$attr] : $this->readAttribute($dn, $attr);
1615
-			if( !is_array($uuid)
1615
+			if (!is_array($uuid)
1616 1616
 				&& $uuidOverride !== ''
1617 1617
 				&& $this->detectUuidAttribute($dn, $isUser, true, $ldapRecord))
1618 1618
 			{
@@ -1620,7 +1620,7 @@  discard block
 block discarded – undo
1620 1620
 					? $ldapRecord[$this->connection->$uuidAttr]
1621 1621
 					: $this->readAttribute($dn, $this->connection->$uuidAttr);
1622 1622
 			}
1623
-			if(is_array($uuid) && isset($uuid[0]) && !empty($uuid[0])) {
1623
+			if (is_array($uuid) && isset($uuid[0]) && !empty($uuid[0])) {
1624 1624
 				$uuid = $uuid[0];
1625 1625
 			}
1626 1626
 		}
@@ -1637,19 +1637,19 @@  discard block
 block discarded – undo
1637 1637
 	private function convertObjectGUID2Str($oguid) {
1638 1638
 		$hex_guid = bin2hex($oguid);
1639 1639
 		$hex_guid_to_guid_str = '';
1640
-		for($k = 1; $k <= 4; ++$k) {
1640
+		for ($k = 1; $k <= 4; ++$k) {
1641 1641
 			$hex_guid_to_guid_str .= substr($hex_guid, 8 - 2 * $k, 2);
1642 1642
 		}
1643 1643
 		$hex_guid_to_guid_str .= '-';
1644
-		for($k = 1; $k <= 2; ++$k) {
1644
+		for ($k = 1; $k <= 2; ++$k) {
1645 1645
 			$hex_guid_to_guid_str .= substr($hex_guid, 12 - 2 * $k, 2);
1646 1646
 		}
1647 1647
 		$hex_guid_to_guid_str .= '-';
1648
-		for($k = 1; $k <= 2; ++$k) {
1648
+		for ($k = 1; $k <= 2; ++$k) {
1649 1649
 			$hex_guid_to_guid_str .= substr($hex_guid, 16 - 2 * $k, 2);
1650 1650
 		}
1651
-		$hex_guid_to_guid_str .= '-' . substr($hex_guid, 16, 4);
1652
-		$hex_guid_to_guid_str .= '-' . substr($hex_guid, 20);
1651
+		$hex_guid_to_guid_str .= '-'.substr($hex_guid, 16, 4);
1652
+		$hex_guid_to_guid_str .= '-'.substr($hex_guid, 20);
1653 1653
 
1654 1654
 		return strtoupper($hex_guid_to_guid_str);
1655 1655
 	}
@@ -1666,11 +1666,11 @@  discard block
 block discarded – undo
1666 1666
 	 * @return string
1667 1667
 	 */
1668 1668
 	public function formatGuid2ForFilterUser($guid) {
1669
-		if(!is_string($guid)) {
1669
+		if (!is_string($guid)) {
1670 1670
 			throw new \InvalidArgumentException('String expected');
1671 1671
 		}
1672 1672
 		$blocks = explode('-', $guid);
1673
-		if(count($blocks) !== 5) {
1673
+		if (count($blocks) !== 5) {
1674 1674
 			/*
1675 1675
 			 * Why not throw an Exception instead? This method is a utility
1676 1676
 			 * called only when trying to figure out whether a "missing" known
@@ -1683,20 +1683,20 @@  discard block
 block discarded – undo
1683 1683
 			 * user. Instead we write a log message.
1684 1684
 			 */
1685 1685
 			\OC::$server->getLogger()->info(
1686
-				'Passed string does not resemble a valid GUID. Known UUID ' .
1686
+				'Passed string does not resemble a valid GUID. Known UUID '.
1687 1687
 				'({uuid}) probably does not match UUID configuration.',
1688
-				[ 'app' => 'user_ldap', 'uuid' => $guid ]
1688
+				['app' => 'user_ldap', 'uuid' => $guid]
1689 1689
 			);
1690 1690
 			return $guid;
1691 1691
 		}
1692
-		for($i=0; $i < 3; $i++) {
1692
+		for ($i = 0; $i < 3; $i++) {
1693 1693
 			$pairs = str_split($blocks[$i], 2);
1694 1694
 			$pairs = array_reverse($pairs);
1695 1695
 			$blocks[$i] = implode('', $pairs);
1696 1696
 		}
1697
-		for($i=0; $i < 5; $i++) {
1697
+		for ($i = 0; $i < 5; $i++) {
1698 1698
 			$pairs = str_split($blocks[$i], 2);
1699
-			$blocks[$i] = '\\' . implode('\\', $pairs);
1699
+			$blocks[$i] = '\\'.implode('\\', $pairs);
1700 1700
 		}
1701 1701
 		return implode('', $blocks);
1702 1702
 	}
@@ -1710,12 +1710,12 @@  discard block
 block discarded – undo
1710 1710
 		$domainDN = $this->getDomainDNFromDN($dn);
1711 1711
 		$cacheKey = 'getSID-'.$domainDN;
1712 1712
 		$sid = $this->connection->getFromCache($cacheKey);
1713
-		if(!is_null($sid)) {
1713
+		if (!is_null($sid)) {
1714 1714
 			return $sid;
1715 1715
 		}
1716 1716
 
1717 1717
 		$objectSid = $this->readAttribute($domainDN, 'objectsid');
1718
-		if(!is_array($objectSid) || empty($objectSid)) {
1718
+		if (!is_array($objectSid) || empty($objectSid)) {
1719 1719
 			$this->connection->writeToCache($cacheKey, false);
1720 1720
 			return false;
1721 1721
 		}
@@ -1773,12 +1773,12 @@  discard block
 block discarded – undo
1773 1773
 		$belongsToBase = false;
1774 1774
 		$bases = $this->helper->sanitizeDN($bases);
1775 1775
 
1776
-		foreach($bases as $base) {
1776
+		foreach ($bases as $base) {
1777 1777
 			$belongsToBase = true;
1778
-			if(mb_strripos($dn, $base, 0, 'UTF-8') !== (mb_strlen($dn, 'UTF-8')-mb_strlen($base, 'UTF-8'))) {
1778
+			if (mb_strripos($dn, $base, 0, 'UTF-8') !== (mb_strlen($dn, 'UTF-8') - mb_strlen($base, 'UTF-8'))) {
1779 1779
 				$belongsToBase = false;
1780 1780
 			}
1781
-			if($belongsToBase) {
1781
+			if ($belongsToBase) {
1782 1782
 				break;
1783 1783
 			}
1784 1784
 		}
@@ -1789,7 +1789,7 @@  discard block
 block discarded – undo
1789 1789
 	 * resets a running Paged Search operation
1790 1790
 	 */
1791 1791
 	private function abandonPagedSearch() {
1792
-		if($this->connection->hasPagedResultSupport) {
1792
+		if ($this->connection->hasPagedResultSupport) {
1793 1793
 			$cr = $this->connection->getConnectionResource();
1794 1794
 			$this->invokeLDAPMethod('controlPagedResult', $cr, 0, false, $this->lastCookie);
1795 1795
 			$this->getPagedSearchResultState();
@@ -1807,16 +1807,16 @@  discard block
 block discarded – undo
1807 1807
 	 * @return string containing the key or empty if none is cached
1808 1808
 	 */
1809 1809
 	private function getPagedResultCookie($base, $filter, $limit, $offset) {
1810
-		if($offset === 0) {
1810
+		if ($offset === 0) {
1811 1811
 			return '';
1812 1812
 		}
1813 1813
 		$offset -= $limit;
1814 1814
 		//we work with cache here
1815
-		$cacheKey = 'lc' . crc32($base) . '-' . crc32($filter) . '-' . intval($limit) . '-' . intval($offset);
1815
+		$cacheKey = 'lc'.crc32($base).'-'.crc32($filter).'-'.intval($limit).'-'.intval($offset);
1816 1816
 		$cookie = '';
1817
-		if(isset($this->cookies[$cacheKey])) {
1817
+		if (isset($this->cookies[$cacheKey])) {
1818 1818
 			$cookie = $this->cookies[$cacheKey];
1819
-			if(is_null($cookie)) {
1819
+			if (is_null($cookie)) {
1820 1820
 				$cookie = '';
1821 1821
 			}
1822 1822
 		}
@@ -1834,11 +1834,11 @@  discard block
 block discarded – undo
1834 1834
 	 * @return bool
1835 1835
 	 */
1836 1836
 	public function hasMoreResults() {
1837
-		if(!$this->connection->hasPagedResultSupport) {
1837
+		if (!$this->connection->hasPagedResultSupport) {
1838 1838
 			return false;
1839 1839
 		}
1840 1840
 
1841
-		if(empty($this->lastCookie) && $this->lastCookie !== '0') {
1841
+		if (empty($this->lastCookie) && $this->lastCookie !== '0') {
1842 1842
 			// as in RFC 2696, when all results are returned, the cookie will
1843 1843
 			// be empty.
1844 1844
 			return false;
@@ -1858,8 +1858,8 @@  discard block
 block discarded – undo
1858 1858
 	 */
1859 1859
 	private function setPagedResultCookie($base, $filter, $limit, $offset, $cookie) {
1860 1860
 		// allow '0' for 389ds
1861
-		if(!empty($cookie) || $cookie === '0') {
1862
-			$cacheKey = 'lc' . crc32($base) . '-' . crc32($filter) . '-' .intval($limit) . '-' . intval($offset);
1861
+		if (!empty($cookie) || $cookie === '0') {
1862
+			$cacheKey = 'lc'.crc32($base).'-'.crc32($filter).'-'.intval($limit).'-'.intval($offset);
1863 1863
 			$this->cookies[$cacheKey] = $cookie;
1864 1864
 			$this->lastCookie = $cookie;
1865 1865
 		}
@@ -1886,22 +1886,22 @@  discard block
 block discarded – undo
1886 1886
 	 */
1887 1887
 	private function initPagedSearch($filter, $bases, $attr, $limit, $offset) {
1888 1888
 		$pagedSearchOK = false;
1889
-		if($this->connection->hasPagedResultSupport && ($limit !== 0)) {
1889
+		if ($this->connection->hasPagedResultSupport && ($limit !== 0)) {
1890 1890
 			$offset = intval($offset); //can be null
1891 1891
 			\OCP\Util::writeLog('user_ldap',
1892 1892
 				'initializing paged search for  Filter '.$filter.' base '.print_r($bases, true)
1893
-				.' attr '.print_r($attr, true). ' limit ' .$limit.' offset '.$offset,
1893
+				.' attr '.print_r($attr, true).' limit '.$limit.' offset '.$offset,
1894 1894
 				\OCP\Util::DEBUG);
1895 1895
 			//get the cookie from the search for the previous search, required by LDAP
1896
-			foreach($bases as $base) {
1896
+			foreach ($bases as $base) {
1897 1897
 
1898 1898
 				$cookie = $this->getPagedResultCookie($base, $filter, $limit, $offset);
1899
-				if(empty($cookie) && $cookie !== "0" && ($offset > 0)) {
1899
+				if (empty($cookie) && $cookie !== "0" && ($offset > 0)) {
1900 1900
 					// no cookie known from a potential previous search. We need
1901 1901
 					// to start from 0 to come to the desired page. cookie value
1902 1902
 					// of '0' is valid, because 389ds
1903 1903
 					$reOffset = 0;
1904
-					while($reOffset < $offset) {
1904
+					while ($reOffset < $offset) {
1905 1905
 						$this->search($filter, array($base), $attr, $limit, $reOffset, true);
1906 1906
 						$reOffset += $limit;
1907 1907
 					}
@@ -1909,17 +1909,17 @@  discard block
 block discarded – undo
1909 1909
 					//still no cookie? obviously, the server does not like us. Let's skip paging efforts.
1910 1910
 					// '0' is valid, because 389ds
1911 1911
 					//TODO: remember this, probably does not change in the next request...
1912
-					if(empty($cookie) && $cookie !== '0') {
1912
+					if (empty($cookie) && $cookie !== '0') {
1913 1913
 						$cookie = null;
1914 1914
 					}
1915 1915
 				}
1916
-				if(!is_null($cookie)) {
1916
+				if (!is_null($cookie)) {
1917 1917
 					//since offset = 0, this is a new search. We abandon other searches that might be ongoing.
1918 1918
 					$this->abandonPagedSearch();
1919 1919
 					$pagedSearchOK = $this->invokeLDAPMethod('controlPagedResult',
1920 1920
 						$this->connection->getConnectionResource(), $limit,
1921 1921
 						false, $cookie);
1922
-					if(!$pagedSearchOK) {
1922
+					if (!$pagedSearchOK) {
1923 1923
 						return false;
1924 1924
 					}
1925 1925
 					\OCP\Util::writeLog('user_ldap', 'Ready for a paged search', \OCP\Util::DEBUG);
@@ -1936,7 +1936,7 @@  discard block
 block discarded – undo
1936 1936
 		 * So we added "&& !empty($this->lastCookie)" to this test to ignore pagination
1937 1937
 		 * if we don't have a previous paged search.
1938 1938
 		 */
1939
-		} else if($this->connection->hasPagedResultSupport && $limit === 0 && !empty($this->lastCookie)) {
1939
+		} else if ($this->connection->hasPagedResultSupport && $limit === 0 && !empty($this->lastCookie)) {
1940 1940
 			// a search without limit was requested. However, if we do use
1941 1941
 			// Paged Search once, we always must do it. This requires us to
1942 1942
 			// initialize it with the configured page size.
Please login to merge, or discard this patch.
apps/user_ldap/lib/Connection.php 1 patch
Spacing   +60 added lines, -60 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 		$this->configuration = new Configuration($configPrefix,
100 100
 												 !is_null($configID));
101 101
 		$memcache = \OC::$server->getMemCacheFactory();
102
-		if($memcache->isAvailable()) {
102
+		if ($memcache->isAvailable()) {
103 103
 			$this->cache = $memcache->create();
104 104
 		}
105 105
 		$helper = new Helper(\OC::$server->getConfig());
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	}
112 112
 
113 113
 	public function __destruct() {
114
-		if(!$this->dontDestruct && $this->ldap->isResource($this->ldapConnectionRes)) {
114
+		if (!$this->dontDestruct && $this->ldap->isResource($this->ldapConnectionRes)) {
115 115
 			@$this->ldap->unbind($this->ldapConnectionRes);
116 116
 		};
117 117
 	}
@@ -131,11 +131,11 @@  discard block
 block discarded – undo
131 131
 	 * @return bool|mixed
132 132
 	 */
133 133
 	public function __get($name) {
134
-		if(!$this->configured) {
134
+		if (!$this->configured) {
135 135
 			$this->readConfiguration();
136 136
 		}
137 137
 
138
-		if($name === 'hasPagedResultSupport') {
138
+		if ($name === 'hasPagedResultSupport') {
139 139
 			return $this->hasPagedResultSupport;
140 140
 		}
141 141
 
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 		$before = $this->configuration->$name;
152 152
 		$this->configuration->$name = $value;
153 153
 		$after = $this->configuration->$name;
154
-		if($before !== $after) {
154
+		if ($before !== $after) {
155 155
 			if ($this->configID !== '' && $this->configID !== null) {
156 156
 				$this->configuration->saveConfiguration();
157 157
 			}
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 	 * @param bool $state
167 167
 	 */
168 168
 	public function setIgnoreValidation($state) {
169
-		$this->ignoreValidation = (bool)$state;
169
+		$this->ignoreValidation = (bool) $state;
170 170
 	}
171 171
 
172 172
 	/**
@@ -182,14 +182,14 @@  discard block
 block discarded – undo
182 182
 	 * Returns the LDAP handler
183 183
 	 */
184 184
 	public function getConnectionResource() {
185
-		if(!$this->ldapConnectionRes) {
185
+		if (!$this->ldapConnectionRes) {
186 186
 			$this->init();
187
-		} else if(!$this->ldap->isResource($this->ldapConnectionRes)) {
187
+		} else if (!$this->ldap->isResource($this->ldapConnectionRes)) {
188 188
 			$this->ldapConnectionRes = null;
189 189
 			$this->establishConnection();
190 190
 		}
191
-		if(is_null($this->ldapConnectionRes)) {
192
-			\OCP\Util::writeLog('user_ldap', 'No LDAP Connection to server ' . $this->configuration->ldapHost, \OCP\Util::ERROR);
191
+		if (is_null($this->ldapConnectionRes)) {
192
+			\OCP\Util::writeLog('user_ldap', 'No LDAP Connection to server '.$this->configuration->ldapHost, \OCP\Util::ERROR);
193 193
 			throw new ServerNotAvailableException('Connection to LDAP server could not be established');
194 194
 		}
195 195
 		return $this->ldapConnectionRes;
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 	 * resets the connection resource
200 200
 	 */
201 201
 	public function resetConnectionResource() {
202
-		if(!is_null($this->ldapConnectionRes)) {
202
+		if (!is_null($this->ldapConnectionRes)) {
203 203
 			@$this->ldap->unbind($this->ldapConnectionRes);
204 204
 			$this->ldapConnectionRes = null;
205 205
 		}
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
 	 */
212 212
 	private function getCacheKey($key) {
213 213
 		$prefix = 'LDAP-'.$this->configID.'-'.$this->configPrefix.'-';
214
-		if(is_null($key)) {
214
+		if (is_null($key)) {
215 215
 			return $prefix;
216 216
 		}
217 217
 		return $prefix.md5($key);
@@ -222,10 +222,10 @@  discard block
 block discarded – undo
222 222
 	 * @return mixed|null
223 223
 	 */
224 224
 	public function getFromCache($key) {
225
-		if(!$this->configured) {
225
+		if (!$this->configured) {
226 226
 			$this->readConfiguration();
227 227
 		}
228
-		if(is_null($this->cache) || !$this->configuration->ldapCacheTTL) {
228
+		if (is_null($this->cache) || !$this->configuration->ldapCacheTTL) {
229 229
 			return null;
230 230
 		}
231 231
 		$key = $this->getCacheKey($key);
@@ -240,10 +240,10 @@  discard block
 block discarded – undo
240 240
 	 * @return string
241 241
 	 */
242 242
 	public function writeToCache($key, $value) {
243
-		if(!$this->configured) {
243
+		if (!$this->configured) {
244 244
 			$this->readConfiguration();
245 245
 		}
246
-		if(is_null($this->cache)
246
+		if (is_null($this->cache)
247 247
 			|| !$this->configuration->ldapCacheTTL
248 248
 			|| !$this->configuration->ldapConfigurationActive) {
249 249
 			return null;
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 	}
255 255
 
256 256
 	public function clearCache() {
257
-		if(!is_null($this->cache)) {
257
+		if (!is_null($this->cache)) {
258 258
 			$this->cache->clear($this->getCacheKey(null));
259 259
 		}
260 260
 	}
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	 * @return null
267 267
 	 */
268 268
 	private function readConfiguration($force = false) {
269
-		if((!$this->configured || $force) && !is_null($this->configID)) {
269
+		if ((!$this->configured || $force) && !is_null($this->configID)) {
270 270
 			$this->configuration->readConfiguration();
271 271
 			$this->configured = $this->validateConfiguration();
272 272
 		}
@@ -279,12 +279,12 @@  discard block
 block discarded – undo
279 279
 	 * @return boolean true if config validates, false otherwise. Check with $setParameters for detailed success on single parameters
280 280
 	 */
281 281
 	public function setConfiguration($config, &$setParameters = null) {
282
-		if(is_null($setParameters)) {
282
+		if (is_null($setParameters)) {
283 283
 			$setParameters = array();
284 284
 		}
285 285
 		$this->doNotValidate = false;
286 286
 		$this->configuration->setConfiguration($config, $setParameters);
287
-		if(count($setParameters) > 0) {
287
+		if (count($setParameters) > 0) {
288 288
 			$this->configured = $this->validateConfiguration();
289 289
 		}
290 290
 
@@ -311,10 +311,10 @@  discard block
 block discarded – undo
311 311
 		$config = $this->configuration->getConfiguration();
312 312
 		$cta = $this->configuration->getConfigTranslationArray();
313 313
 		$result = array();
314
-		foreach($cta as $dbkey => $configkey) {
315
-			switch($configkey) {
314
+		foreach ($cta as $dbkey => $configkey) {
315
+			switch ($configkey) {
316 316
 				case 'homeFolderNamingRule':
317
-					if(strpos($config[$configkey], 'attr:') === 0) {
317
+					if (strpos($config[$configkey], 'attr:') === 0) {
318 318
 						$result[$dbkey] = substr($config[$configkey], 5);
319 319
 					} else {
320 320
 						$result[$dbkey] = '';
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 				case 'ldapBaseGroups':
326 326
 				case 'ldapAttributesForUserSearch':
327 327
 				case 'ldapAttributesForGroupSearch':
328
-					if(is_array($config[$configkey])) {
328
+					if (is_array($config[$configkey])) {
329 329
 						$result[$dbkey] = implode("\n", $config[$configkey]);
330 330
 						break;
331 331
 					} //else follows default
@@ -338,23 +338,23 @@  discard block
 block discarded – undo
338 338
 
339 339
 	private function doSoftValidation() {
340 340
 		//if User or Group Base are not set, take over Base DN setting
341
-		foreach(array('ldapBaseUsers', 'ldapBaseGroups') as $keyBase) {
341
+		foreach (array('ldapBaseUsers', 'ldapBaseGroups') as $keyBase) {
342 342
 			$val = $this->configuration->$keyBase;
343
-			if(empty($val)) {
343
+			if (empty($val)) {
344 344
 				$this->configuration->$keyBase = $this->configuration->ldapBase;
345 345
 			}
346 346
 		}
347 347
 
348
-		foreach(array('ldapExpertUUIDUserAttr'  => 'ldapUuidUserAttribute',
348
+		foreach (array('ldapExpertUUIDUserAttr'  => 'ldapUuidUserAttribute',
349 349
 					  'ldapExpertUUIDGroupAttr' => 'ldapUuidGroupAttribute')
350 350
 				as $expertSetting => $effectiveSetting) {
351 351
 			$uuidOverride = $this->configuration->$expertSetting;
352
-			if(!empty($uuidOverride)) {
352
+			if (!empty($uuidOverride)) {
353 353
 				$this->configuration->$effectiveSetting = $uuidOverride;
354 354
 			} else {
355 355
 				$uuidAttributes = Access::UUID_ATTRIBUTES;
356 356
 				array_unshift($uuidAttributes, 'auto');
357
-				if(!in_array($this->configuration->$effectiveSetting,
357
+				if (!in_array($this->configuration->$effectiveSetting,
358 358
 							$uuidAttributes)
359 359
 					&& (!is_null($this->configID))) {
360 360
 					$this->configuration->$effectiveSetting = 'auto';
@@ -376,14 +376,14 @@  discard block
 block discarded – undo
376 376
 		//make sure empty search attributes are saved as simple, empty array
377 377
 		$saKeys = array('ldapAttributesForUserSearch',
378 378
 						'ldapAttributesForGroupSearch');
379
-		foreach($saKeys as $key) {
379
+		foreach ($saKeys as $key) {
380 380
 			$val = $this->configuration->$key;
381
-			if(is_array($val) && count($val) === 1 && empty($val[0])) {
381
+			if (is_array($val) && count($val) === 1 && empty($val[0])) {
382 382
 				$this->configuration->$key = array();
383 383
 			}
384 384
 		}
385 385
 
386
-		if((stripos($this->configuration->ldapHost, 'ldaps://') === 0)
386
+		if ((stripos($this->configuration->ldapHost, 'ldaps://') === 0)
387 387
 			&& $this->configuration->ldapTLS) {
388 388
 			$this->configuration->ldapTLS = false;
389 389
 			\OCP\Util::writeLog('user_ldap',
@@ -404,10 +404,10 @@  discard block
 block discarded – undo
404 404
 		//options that shall not be empty
405 405
 		$options = array('ldapHost', 'ldapPort', 'ldapUserDisplayName',
406 406
 						 'ldapGroupDisplayName', 'ldapLoginFilter');
407
-		foreach($options as $key) {
407
+		foreach ($options as $key) {
408 408
 			$val = $this->configuration->$key;
409
-			if(empty($val)) {
410
-				switch($key) {
409
+			if (empty($val)) {
410
+				switch ($key) {
411 411
 					case 'ldapHost':
412 412
 						$subj = 'LDAP Host';
413 413
 						break;
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 		$agent = $this->configuration->ldapAgentName;
439 439
 		$pwd = $this->configuration->ldapAgentPassword;
440 440
 		if (
441
-			($agent === ''  && $pwd !== '')
441
+			($agent === '' && $pwd !== '')
442 442
 			|| ($agent !== '' && $pwd === '')
443 443
 		) {
444 444
 			\OCP\Util::writeLog('user_ldap',
@@ -453,14 +453,14 @@  discard block
 block discarded – undo
453 453
 		$baseUsers = $this->configuration->ldapBaseUsers;
454 454
 		$baseGroups = $this->configuration->ldapBaseGroups;
455 455
 
456
-		if(empty($base) && empty($baseUsers) && empty($baseGroups)) {
456
+		if (empty($base) && empty($baseUsers) && empty($baseGroups)) {
457 457
 			\OCP\Util::writeLog('user_ldap',
458 458
 								$errorStr.'Not a single Base DN given.',
459 459
 								\OCP\Util::WARN);
460 460
 			$configurationOK = false;
461 461
 		}
462 462
 
463
-		if(mb_strpos($this->configuration->ldapLoginFilter, '%uid', 0, 'UTF-8')
463
+		if (mb_strpos($this->configuration->ldapLoginFilter, '%uid', 0, 'UTF-8')
464 464
 		   === false) {
465 465
 			\OCP\Util::writeLog('user_ldap',
466 466
 								$errorStr.'login filter does not contain %uid '.
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
 	 */
479 479
 	private function validateConfiguration() {
480 480
 
481
-		if($this->doNotValidate) {
481
+		if ($this->doNotValidate) {
482 482
 			//don't do a validation if it is a new configuration with pure
483 483
 			//default values. Will be allowed on changes via __set or
484 484
 			//setConfiguration
@@ -499,21 +499,21 @@  discard block
 block discarded – undo
499 499
 	 * Connects and Binds to LDAP
500 500
 	 */
501 501
 	private function establishConnection() {
502
-		if(!$this->configuration->ldapConfigurationActive) {
502
+		if (!$this->configuration->ldapConfigurationActive) {
503 503
 			return null;
504 504
 		}
505 505
 		static $phpLDAPinstalled = true;
506
-		if(!$phpLDAPinstalled) {
506
+		if (!$phpLDAPinstalled) {
507 507
 			return false;
508 508
 		}
509
-		if(!$this->ignoreValidation && !$this->configured) {
509
+		if (!$this->ignoreValidation && !$this->configured) {
510 510
 			\OCP\Util::writeLog('user_ldap',
511 511
 								'Configuration is invalid, cannot connect',
512 512
 								\OCP\Util::WARN);
513 513
 			return false;
514 514
 		}
515
-		if(!$this->ldapConnectionRes) {
516
-			if(!$this->ldap->areLDAPFunctionsAvailable()) {
515
+		if (!$this->ldapConnectionRes) {
516
+			if (!$this->ldap->areLDAPFunctionsAvailable()) {
517 517
 				$phpLDAPinstalled = false;
518 518
 				\OCP\Util::writeLog('user_ldap',
519 519
 									'function ldap_connect is not available. Make '.
@@ -522,8 +522,8 @@  discard block
 block discarded – undo
522 522
 
523 523
 				return false;
524 524
 			}
525
-			if($this->configuration->turnOffCertCheck) {
526
-				if(putenv('LDAPTLS_REQCERT=never')) {
525
+			if ($this->configuration->turnOffCertCheck) {
526
+				if (putenv('LDAPTLS_REQCERT=never')) {
527 527
 					\OCP\Util::writeLog('user_ldap',
528 528
 						'Turned off SSL certificate validation successfully.',
529 529
 						\OCP\Util::DEBUG);
@@ -547,23 +547,23 @@  discard block
 block discarded – undo
547 547
 					$error = $this->ldap->isResource($this->ldapConnectionRes) ?
548 548
 						$this->ldap->errno($this->ldapConnectionRes) : -1;
549 549
 				}
550
-				if($bindStatus === true) {
550
+				if ($bindStatus === true) {
551 551
 					return $bindStatus;
552 552
 				}
553 553
 			} catch (ServerNotAvailableException $e) {
554
-				if(!$isBackupHost) {
554
+				if (!$isBackupHost) {
555 555
 					throw $e;
556 556
 				}
557 557
 			}
558 558
 
559 559
 			//if LDAP server is not reachable, try the Backup (Replica!) Server
560
-			if($isBackupHost && ($error !== 0 || $isOverrideMainServer)) {
560
+			if ($isBackupHost && ($error !== 0 || $isOverrideMainServer)) {
561 561
 				$this->doConnect($this->configuration->ldapBackupHost,
562 562
 								 $this->configuration->ldapBackupPort);
563 563
 				$bindStatus = $this->bind();
564 564
 				$error = $this->ldap->isResource($this->ldapConnectionRes) ?
565 565
 					$this->ldap->errno($this->ldapConnectionRes) : -1;
566
-				if($bindStatus && $error === 0 && !$this->getFromCache('overrideMainServer')) {
566
+				if ($bindStatus && $error === 0 && !$this->getFromCache('overrideMainServer')) {
567 567
 					//when bind to backup server succeeded and failed to main server,
568 568
 					//skip contacting him until next cache refresh
569 569
 					$this->writeToCache('overrideMainServer', true);
@@ -588,17 +588,17 @@  discard block
 block discarded – undo
588 588
 
589 589
 		$this->ldapConnectionRes = $this->ldap->connect($host, $port);
590 590
 
591
-		if(!$this->ldap->setOption($this->ldapConnectionRes, LDAP_OPT_PROTOCOL_VERSION, 3)) {
591
+		if (!$this->ldap->setOption($this->ldapConnectionRes, LDAP_OPT_PROTOCOL_VERSION, 3)) {
592 592
 			throw new ServerNotAvailableException('Could not set required LDAP Protocol version.');
593 593
 		}
594 594
 
595
-		if(!$this->ldap->setOption($this->ldapConnectionRes, LDAP_OPT_REFERRALS, 0)) {
595
+		if (!$this->ldap->setOption($this->ldapConnectionRes, LDAP_OPT_REFERRALS, 0)) {
596 596
 			throw new ServerNotAvailableException('Could not disable LDAP referrals.');
597 597
 		}
598 598
 
599
-		if($this->configuration->ldapTLS) {
600
-			if(!$this->ldap->startTls($this->ldapConnectionRes)) {
601
-				throw new ServerNotAvailableException('Start TLS failed, when connecting to LDAP host ' . $host . '.');
599
+		if ($this->configuration->ldapTLS) {
600
+			if (!$this->ldap->startTls($this->ldapConnectionRes)) {
601
+				throw new ServerNotAvailableException('Start TLS failed, when connecting to LDAP host '.$host.'.');
602 602
 			}
603 603
 		}
604 604
 
@@ -609,25 +609,25 @@  discard block
 block discarded – undo
609 609
 	 * Binds to LDAP
610 610
 	 */
611 611
 	public function bind() {
612
-		if(!$this->configuration->ldapConfigurationActive) {
612
+		if (!$this->configuration->ldapConfigurationActive) {
613 613
 			return false;
614 614
 		}
615 615
 		$cr = $this->getConnectionResource();
616
-		if(!$this->ldap->isResource($cr)) {
616
+		if (!$this->ldap->isResource($cr)) {
617 617
 			return false;
618 618
 		}
619 619
 		$ldapLogin = @$this->ldap->bind($cr,
620 620
 										$this->configuration->ldapAgentName,
621 621
 										$this->configuration->ldapAgentPassword);
622
-		if(!$ldapLogin) {
622
+		if (!$ldapLogin) {
623 623
 			$errno = $this->ldap->errno($cr);
624 624
 
625 625
 			\OCP\Util::writeLog('user_ldap',
626
-				'Bind failed: ' . $errno . ': ' . $this->ldap->error($cr),
626
+				'Bind failed: '.$errno.': '.$this->ldap->error($cr),
627 627
 				\OCP\Util::WARN);
628 628
 
629 629
 			// Set to failure mode, if LDAP error code is not LDAP_SUCCESS or LDAP_INVALID_CREDENTIALS
630
-			if($errno !== 0x00 && $errno !== 0x31) {
630
+			if ($errno !== 0x00 && $errno !== 0x31) {
631 631
 				$this->ldapConnectionRes = null;
632 632
 			}
633 633
 
Please login to merge, or discard this patch.