nextcloud / server

apps/settings/lib/SetupChecks/WellKnownUrls.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
 		];
 
 		$requestOptions = ['httpErrors' => false, 'options' => ['allow_redirects' => ['track_redirects' => true]]];
-		foreach ($urls as [$verb,$url,$validStatuses,$checkCustomHeader]) {
+		foreach ($urls as [$verb, $url, $validStatuses, $checkCustomHeader]) {
 			$works = null;
 			foreach ($this->runRequest($verb, $url, $requestOptions, isRootRequest: true) as $response) {
 				// Check that the response status matches
@@ -76,7 +76,7 @@ 
 			// If 'works' is null then we could not connect to the server
 			if ($works === null) {
 				return SetupResult::info(
-					$this->l10n->t('Could not check that your web server serves `.well-known` correctly. Please check manually.') . "\n" . $this->serverConfigHelp(),
+					$this->l10n->t('Could not check that your web server serves `.well-known` correctly. Please check manually.')."\n".$this->serverConfigHelp(),
 					$this->urlGenerator->linkToDocs('admin-setup-well-known-URL'),
 				);
 			}

apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php

Spacing +2 added lines, -2 removed lines

@@ -62,10 +62,10 @@
 		} else {
 			$list = '';
 			foreach ($missingColumns as $missingColumn) {
-				$list .= "\n" . $this->l10n->t('Missing optional column "%s" in table "%s".', [$missingColumn['columnName'], $missingColumn['tableName']]);
+				$list .= "\n".$this->l10n->t('Missing optional column "%s" in table "%s".', [$missingColumn['columnName'], $missingColumn['tableName']]);
 			}
 			return SetupResult::warning(
-				$this->l10n->t('The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.') . $list
+				$this->l10n->t('The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.').$list
 			);
 		}
 	}

apps/settings/lib/SetupChecks/CronInfo.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
 						'type' => 'highlight',
 						'id' => 'backgroundjobs',
 						'name' => 'Check the background job settings',
-						'link' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'server']) . '#backgroundjobs',
+						'link' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'server']).'#backgroundjobs',
 					],
 				],
 			);

apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php

Spacing +2 added lines, -2 removed lines

@@ -79,13 +79,13 @@
 			$list = $this->l10n->t('Missing indices:');
 			foreach ($missingIndices as $missingIndex) {
 				$processed++;
-				$list .= "\n " . $this->l10n->t('"%s" in table "%s"', [$missingIndex['indexName'], $missingIndex['tableName']]);
+				$list .= "\n ".$this->l10n->t('"%s" in table "%s"', [$missingIndex['indexName'], $missingIndex['tableName']]);
 				if (count($missingIndices) > $processed) {
 					$list .= ', ';
 				}
 			}
 			return SetupResult::warning(
-				$this->l10n->t('Detected some missing optional indices. Occasionally new indices are added (by Nextcloud or installed applications) to improve database performance. Adding indices can sometimes take awhile and temporarily hurt performance so this is not done automatically during upgrades. Once the indices are added, queries to those tables should be faster. Use the command `occ db:add-missing-indices` to add them.') . "\n" . $list,
+				$this->l10n->t('Detected some missing optional indices. Occasionally new indices are added (by Nextcloud or installed applications) to improve database performance. Adding indices can sometimes take awhile and temporarily hurt performance so this is not done automatically during upgrades. Once the indices are added, queries to those tables should be faster. Use the command `occ db:add-missing-indices` to add them.')."\n".$list,
 				$this->urlGenerator->linkToDocs('admin-long-running-migration-steps')
 			);
 		}

apps/settings/lib/SetupChecks/TempSpaceAvailable.php

Spacing +3 added lines, -3 removed lines

@@ -78,14 +78,14 @@ 
 
 		/** Build details data about temporary directory, either one or two of them */
 		$freeSpaceInTempInGB = $freeSpaceInTemp / 1024 / 1024 / 1024;
-		$spaceDetail = $this->l10n->t('- %.1f GiB available in %s (PHP temporary directory)', [round($freeSpaceInTempInGB, 1),$phpTempPath]);
+		$spaceDetail = $this->l10n->t('- %.1f GiB available in %s (PHP temporary directory)', [round($freeSpaceInTempInGB, 1), $phpTempPath]);
 		if ($nextcloudTempPath !== $phpTempPath) {
 			$freeSpaceInNextcloudTemp = disk_free_space($nextcloudTempPath);
 			if ($freeSpaceInNextcloudTemp === false) {
 				return SetupResult::error($this->l10n->t('Error while checking the available disk space of temporary PHP path or no free disk space returned. Temporary path: %s', [$nextcloudTempPath]));
 			}
 			$freeSpaceInNextcloudTempInGB = $freeSpaceInNextcloudTemp / 1024 / 1024 / 1024;
-			$spaceDetail .= "\n" . $this->l10n->t('- %.1f GiB available in %s (Nextcloud temporary directory)', [round($freeSpaceInNextcloudTempInGB, 1),$nextcloudTempPath]);
+			$spaceDetail .= "\n".$this->l10n->t('- %.1f GiB available in %s (Nextcloud temporary directory)', [round($freeSpaceInNextcloudTempInGB, 1), $nextcloudTempPath]);
 		}
 
 		if (!$this->isPrimaryStorageS3()) {
@@ -106,7 +106,7 @@ 
 		return SetupResult::warning(
 			$this->l10n->t(
 				"This instance uses an S3 based object store as primary storage. The uploaded files are stored temporarily on the server and thus it is recommended to have 50 GiB of free space available in the temp directory of PHP. To improve this please change the temporary directory in the php.ini or make more space available in that path. \nChecking the available space in the temporary path resulted in %.1f GiB instead of the recommended 50 GiB. Path: %s",
-				[round($freeSpaceInTempInGB, 1),$phpTempPath]
+				[round($freeSpaceInTempInGB, 1), $phpTempPath]
 			)
 		);
 	}

apps/settings/lib/SetupChecks/DataDirectoryProtected.php

Spacing +4 added lines, -4 removed lines

@@ -41,11 +41,11 @@ 
 	}
 
 	public function run(): SetupResult {
-		$dataDir = str_replace(\OC::$SERVERROOT . '/', '', $this->config->getSystemValueString('datadirectory', ''));
-		$dataUrl = $this->urlGenerator->linkTo('', $dataDir . '/.ncdata');
+		$dataDir = str_replace(\OC::$SERVERROOT.'/', '', $this->config->getSystemValueString('datadirectory', ''));
+		$dataUrl = $this->urlGenerator->linkTo('', $dataDir.'/.ncdata');
 
 		$noResponse = true;
-		foreach ($this->runRequest('GET', $dataUrl, [ 'httpErrors' => false ]) as $response) {
+		foreach ($this->runRequest('GET', $dataUrl, ['httpErrors' => false]) as $response) {
 			$noResponse = false;
 			if ($response->getStatusCode() < 400) {
 				// Read the response body
@@ -63,7 +63,7 @@ 
 		}
 
 		if ($noResponse) {
-			return SetupResult::warning($this->l10n->t('Could not check that the data directory is protected. Please check manually that your server does not allow access to the data directory.') . "\n" . $this->serverConfigHelp());
+			return SetupResult::warning($this->l10n->t('Could not check that the data directory is protected. Please check manually that your server does not allow access to the data directory.')."\n".$this->serverConfigHelp());
 		}
 		return SetupResult::success();
 		

apps/settings/lib/SetupChecks/MemcacheConfigured.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 		$memcacheDistributedClass = $this->config->getSystemValue('memcache.distributed', null);
 		$memcacheLockingClass = $this->config->getSystemValue('memcache.locking', null);
 		$memcacheLocalClass = $this->config->getSystemValue('memcache.local', null);
-		$caches = array_filter([$memcacheDistributedClass,$memcacheLockingClass,$memcacheLocalClass]);
+		$caches = array_filter([$memcacheDistributedClass, $memcacheLockingClass, $memcacheLocalClass]);
 		if (in_array(Memcached::class, array_map(fn (string $class) => ltrim($class, '\\'), $caches))) {
 			// wrong PHP module is installed
 			if (extension_loaded('memcache') && !extension_loaded('memcached')) {

apps/settings/lib/SetupChecks/DatabasePendingBigIntConversions.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 				$isAutoIncrement = $column->getAutoincrement();
 				$isAutoIncrementOnSqlite = $isSqlite && $isAutoIncrement;
 				if (!($column->getType() instanceof BigIntType) && !$isAutoIncrementOnSqlite) {
-					$pendingColumns[] = $tableName . '.' . $columnName;
+					$pendingColumns[] = $tableName.'.'.$columnName;
 				}
 			}
 		}
@@ -74,7 +74,7 @@ 
 			}
 			$list .= "\n";
 			return SetupResult::info(
-				$this->l10n->t('Some columns in the database are missing a conversion to big int. Due to the fact that changing column types on big tables could take some time they were not changed automatically. By running "occ db:convert-filecache-bigint" those pending changes could be applied manually. This operation needs to be made while the instance is offline.') . $list,
+				$this->l10n->t('Some columns in the database are missing a conversion to big int. Due to the fact that changing column types on big tables could take some time they were not changed automatically. By running "occ db:convert-filecache-bigint" those pending changes could be applied manually. This operation needs to be made while the instance is offline.').$list,
 				$this->urlGenerator->linkToDocs('admin-bigint-conversion')
 			);
 		}

apps/settings/lib/SetupChecks/OcxProviders.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
 
 		if (count($testedProviders) < count($providers)) {
 			return SetupResult::warning(
-				$this->l10n->t('Could not check if your web server properly resolves the OCM and OCS provider URLs.', ) . "\n" . $this->serverConfigHelp(),
+				$this->l10n->t('Could not check if your web server properly resolves the OCM and OCS provider URLs.',)."\n".$this->serverConfigHelp(),
 			);
 		}
 
@@ -76,7 +76,7 @@ 
 			$this->l10n->t('Your web server is not properly set up to resolve %1$s.
 This is most likely related to a web server configuration that was not updated to deliver this folder directly.
 Please compare your configuration against the shipped rewrite rules in ".htaccess" for Apache or the provided one in the documentation for Nginx.
-On Nginx those are typically the lines starting with "location ~" that need an update.', [join(', ', array_map(fn ($s) => '"' . $s . '"', $missingProviders))]),
+On Nginx those are typically the lines starting with "location ~" that need an update.', [join(', ', array_map(fn ($s) => '"'.$s.'"', $missingProviders))]),
 			$this->urlGenerator->linkToDocs('admin-nginx'),
 		);
 	}