Completed
Push — master ( 9dc235...b580c3 )
by Raghu
18:07 queued 08:16
created
lib/private/Settings/Manager.php 1 patch
Doc Comments   +13 added lines, -2 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	/**
130 130
 	 * returns the registerd classes in the given table
131 131
 	 *
132
-	 * @param $table
132
+	 * @param string $table
133 133
 	 * @return string[]
134 134
 	 */
135 135
 	private function getClasses($table) {
@@ -225,6 +225,11 @@  discard block
 block discarded – undo
225 225
 		);
226 226
 	}
227 227
 
228
+	/**
229
+	 * @param string $table
230
+	 * @param string $idCol
231
+	 * @param string $id
232
+	 */
228 233
 	private function update($table, $idCol, $id, $values) {
229 234
 		$query = $this->dbc->getQueryBuilder();
230 235
 		$query->update($table);
@@ -275,7 +280,7 @@  discard block
 block discarded – undo
275 280
 	/**
276 281
 	 * deletes an settings or admin entry from the given table
277 282
 	 *
278
-	 * @param $table
283
+	 * @param string $table
279 284
 	 * @param $className
280 285
 	 */
281 286
 	private function remove($table, $className) {
@@ -358,6 +363,9 @@  discard block
 block discarded – undo
358 363
 		return $sections;
359 364
 	}
360 365
 
366
+	/**
367
+	 * @param string $section
368
+	 */
361 369
 	private function getBuiltInAdminSettings($section) {
362 370
 		$forms = [];
363 371
 		try {
@@ -397,6 +405,9 @@  discard block
 block discarded – undo
397 405
 		return $forms;
398 406
 	}
399 407
 
408
+	/**
409
+	 * @param string $section
410
+	 */
400 411
 	private function getAdminSettingsFromDB($section, &$settings) {
401 412
 		$query = $this->dbc->getQueryBuilder();
402 413
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.
settings/Controller/CertificateController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 *
73 73
 	 * @NoAdminRequired
74 74
 	 * @NoSubadminRequired
75
-	 * @return array
75
+	 * @return DataResponse
76 76
 	 */
77 77
 	public function addPersonalRootCertificate() {
78 78
 		return $this->addCertificate($this->userCertificateManager);
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 	/**
161 161
 	 * Add a new personal root certificate to the system's trust store
162 162
 	 *
163
-	 * @return array
163
+	 * @return DataResponse
164 164
 	 */
165 165
 	public function addSystemRootCertificate() {
166 166
 		return $this->addCertificate($this->systemCertificateManager);
Please login to merge, or discard this patch.
apps/files_sharing/lib/sharedstorage.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,6 @@
 block discarded – undo
36 36
 use OCA\Files_Sharing\ISharedStorage;
37 37
 use OCP\Constants;
38 38
 use OCP\Files\Cache\ICacheEntry;
39
-use OCP\Files\Storage\IStorage;
40 39
 use OCP\Lock\ILockingProvider;
41 40
 
42 41
 /**
Please login to merge, or discard this patch.
lib/private/Cache/File.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	 * @param string $key
96 96
 	 * @param mixed $value
97 97
 	 * @param int $ttl
98
-	 * @return bool|mixed
98
+	 * @return boolean
99 99
 	 * @throws \OC\ForbiddenException
100 100
 	 */
101 101
 	public function set($key, $value, $ttl = 0) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesAPIController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@
 block discarded – undo
335 335
 	 * split user and remote from federated cloud id
336 336
 	 *
337 337
 	 * @param string $address federated share address
338
-	 * @return array [user, remoteURL]
338
+	 * @return string[] [user, remoteURL]
339 339
 	 * @throws \Exception
340 340
 	 */
341 341
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.