Version16000Date20190212081545::changeSchema() - Code Metrics - Inspection of "Merge pull request #14161 from nextcloud/enh/14050..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5df640...0c0e41 )

by Roeland

created 2019-02-25 07:05 UTC

Version16000Date20190212081545::changeSchema() A

↳ Parent: Version16000Date20190212081545

Complexity

Conditions	1
Paths	1

Size

Total Lines	60
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	45
nc	1
nop	3
dl	0
loc	60
rs	9.2
c	0
b	0
f	0

How to fix Long Method

<?php
declare(strict_types=1);
/**
 * @copyright Copyright (c) 2018 Roeland Jago Douma <[email protected]>
 *
 * @author Roeland Jago Douma <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OC\Core\Migrations;

use Closure;
use Doctrine\DBAL\Types\Type;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\SimpleMigrationStep;
use OCP\Migration\IOutput;

class Version16000Date20190212081545 extends SimpleMigrationStep {
	/**
	 * @param IOutput $output
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	 * @param array $options
	 * @return null|ISchemaWrapper
	 */
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ISchemaWrapper {
		/** @var ISchemaWrapper $schema */
		$schema = $schemaClosure();

		$table = $schema->createTable('login_flow_v2');
		$table->addColumn('id', Type::BIGINT, [
			'autoincrement' => true,
			'notnull' => true,
			'length' => 20,
			'unsigned' => true,
		]);
		$table->addColumn('timestamp', Type::BIGINT, [
			'notnull' => true,
			'length' => 20,
			'unsigned' => true,
		]);
		$table->addColumn('started', Type::SMALLINT, [
			'notnull' => true,
			'length' => 1,
			'unsigned' => true,
			'default' => 0,
		]);
		$table->addColumn('poll_token', Type::STRING, [
			'notnull' => true,
			'length' => 255,
		]);
		$table->addColumn('login_token', Type::STRING, [
			'notnull' => true,
			'length' => 255,
		]);
		$table->addColumn('public_key', Type::TEXT, [
			'notnull' => true,
			'length' => 32768,
		]);
		$table->addColumn('private_key', Type::TEXT, [
			'notnull' => true,
			'length' => 32768,
		]);
		$table->addColumn('client_name', Type::STRING, [
			'notnull' => true,
			'length' => 255,
		]);
		$table->addColumn('login_name', Type::STRING, [
			'notnull' => false,
			'length' => 255,
		]);
		$table->addColumn('server', Type::STRING, [
			'notnull' => false,
			'length' => 255,
		]);
		$table->addColumn('app_password', Type::STRING, [
			'notnull' => false,
			'length' => 1024,
		]);
		$table->setPrimaryKey(['id']);
		$table->addUniqueIndex(['poll_token']);
		$table->addUniqueIndex(['login_token']);
		$table->addIndex(['timestamp']);

		return $schema;
	}
}


1			<?php
2			declare(strict_types=1);
3			/**
4			* @copyright Copyright (c) 2018 Roeland Jago Douma <[email protected]>
5			*
6			* @author Roeland Jago Douma <[email protected]>
7			*
8			* @license GNU AGPL version 3 or any later version
9			*
10			* This program is free software: you can redistribute it and/or modify
11			* it under the terms of the GNU Affero General Public License as
12			* published by the Free Software Foundation, either version 3 of the
13			* License, or (at your option) any later version.
14			*
15			* This program is distributed in the hope that it will be useful,
16			* but WITHOUT ANY WARRANTY; without even the implied warranty of
17			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			* GNU Affero General Public License for more details.
19			*
20			* You should have received a copy of the GNU Affero General Public License
21			* along with this program. If not, see <http://www.gnu.org/licenses/>.
22			*
23			*/
24
25			namespace OC\Core\Migrations;
26
27			use Closure;
28			use Doctrine\DBAL\Types\Type;
29			use OCP\DB\ISchemaWrapper;
30			use OCP\Migration\SimpleMigrationStep;
31			use OCP\Migration\IOutput;
32
33			class Version16000Date20190212081545 extends SimpleMigrationStep {
34			/**
35			* @param IOutput $output
36			* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
37			* @param array $options
38			* @return null\|ISchemaWrapper
39			*/
40			public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ISchemaWrapper {
41			/** @var ISchemaWrapper $schema */
42			$schema = $schemaClosure();
43
44			$table = $schema->createTable('login_flow_v2');
45			$table->addColumn('id', Type::BIGINT, [
46			'autoincrement' => true,
47			'notnull' => true,
48			'length' => 20,
49			'unsigned' => true,
50			]);
51			$table->addColumn('timestamp', Type::BIGINT, [
52			'notnull' => true,
53			'length' => 20,
54			'unsigned' => true,
55			]);
56			$table->addColumn('started', Type::SMALLINT, [
57			'notnull' => true,
58			'length' => 1,
59			'unsigned' => true,
60			'default' => 0,
61			]);
62			$table->addColumn('poll_token', Type::STRING, [
63			'notnull' => true,
64			'length' => 255,
65			]);
66			$table->addColumn('login_token', Type::STRING, [
67			'notnull' => true,
68			'length' => 255,
69			]);
70			$table->addColumn('public_key', Type::TEXT, [
71			'notnull' => true,
72			'length' => 32768,
73			]);
74			$table->addColumn('private_key', Type::TEXT, [
75			'notnull' => true,
76			'length' => 32768,
77			]);
78			$table->addColumn('client_name', Type::STRING, [
79			'notnull' => true,
80			'length' => 255,
81			]);
82			$table->addColumn('login_name', Type::STRING, [
83			'notnull' => false,
84			'length' => 255,
85			]);
86			$table->addColumn('server', Type::STRING, [
87			'notnull' => false,
88			'length' => 255,
89			]);
90			$table->addColumn('app_password', Type::STRING, [
91			'notnull' => false,
92			'length' => 1024,
93			]);
94			$table->setPrimaryKey(['id']);
95			$table->addUniqueIndex(['poll_token']);
96			$table->addUniqueIndex(['login_token']);
97			$table->addIndex(['timestamp']);
98
99			return $schema;
100			}
101			}
102

nextcloud / server

Push — master ( 5df640...0c0e41 )

Version16000Date20190212081545::changeSchema() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like