nextcloud /
server
| Total Complexity | 46 |
| Total Lines | 306 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like ProviderFactory often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ProviderFactory, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 54 | class ProviderFactory implements IProviderFactory { |
||
| 55 | |||
| 56 | /** @var IServerContainer */ |
||
| 57 | private $serverContainer; |
||
| 58 | /** @var DefaultShareProvider */ |
||
| 59 | private $defaultProvider = null; |
||
| 60 | /** @var FederatedShareProvider */ |
||
| 61 | private $federatedProvider = null; |
||
| 62 | /** @var ShareByMailProvider */ |
||
| 63 | private $shareByMailProvider; |
||
| 64 | /** @var \OCA\Circles\ShareByCircleProvider */ |
||
|
|
|||
| 65 | private $shareByCircleProvider = null; |
||
| 66 | /** @var bool */ |
||
| 67 | private $circlesAreNotAvailable = false; |
||
| 68 | /** @var \OCA\Talk\Share\RoomShareProvider */ |
||
| 69 | private $roomShareProvider = null; |
||
| 70 | |||
| 71 | private $registeredShareProviders = []; |
||
| 72 | |||
| 73 | private $shareProviders = []; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * IProviderFactory constructor. |
||
| 77 | * |
||
| 78 | * @param IServerContainer $serverContainer |
||
| 79 | */ |
||
| 80 | public function __construct(IServerContainer $serverContainer) { |
||
| 81 | $this->serverContainer = $serverContainer; |
||
| 82 | } |
||
| 83 | |||
| 84 | public function registerProvider(string $shareProviderClass): void { |
||
| 85 | $this->registeredShareProviders[] = $shareProviderClass; |
||
| 86 | } |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Create the default share provider. |
||
| 90 | * |
||
| 91 | * @return DefaultShareProvider |
||
| 92 | */ |
||
| 93 | protected function defaultShareProvider() { |
||
| 94 | if ($this->defaultProvider === null) { |
||
| 95 | $this->defaultProvider = new DefaultShareProvider( |
||
| 96 | $this->serverContainer->getDatabaseConnection(), |
||
| 97 | $this->serverContainer->getUserManager(), |
||
| 98 | $this->serverContainer->getGroupManager(), |
||
| 99 | $this->serverContainer->getLazyRootFolder(), |
||
| 100 | $this->serverContainer->getMailer(), |
||
| 101 | $this->serverContainer->query(Defaults::class), |
||
| 102 | $this->serverContainer->getL10NFactory(), |
||
| 103 | $this->serverContainer->getURLGenerator(), |
||
| 104 | $this->serverContainer->getConfig() |
||
| 105 | ); |
||
| 106 | } |
||
| 107 | |||
| 108 | return $this->defaultProvider; |
||
| 109 | } |
||
| 110 | |||
| 111 | /** |
||
| 112 | * Create the federated share provider |
||
| 113 | * |
||
| 114 | * @return FederatedShareProvider |
||
| 115 | */ |
||
| 116 | protected function federatedShareProvider() { |
||
| 117 | if ($this->federatedProvider === null) { |
||
| 118 | /* |
||
| 119 | * Check if the app is enabled |
||
| 120 | */ |
||
| 121 | $appManager = $this->serverContainer->getAppManager(); |
||
| 122 | if (!$appManager->isEnabledForUser('federatedfilesharing')) { |
||
| 123 | return null; |
||
| 124 | } |
||
| 125 | |||
| 126 | /* |
||
| 127 | * TODO: add factory to federated sharing app |
||
| 128 | */ |
||
| 129 | $l = $this->serverContainer->getL10N('federatedfilesharing'); |
||
| 130 | $addressHandler = new AddressHandler( |
||
| 131 | $this->serverContainer->getURLGenerator(), |
||
| 132 | $l, |
||
| 133 | $this->serverContainer->getCloudIdManager() |
||
| 134 | ); |
||
| 135 | $notifications = new Notifications( |
||
| 136 | $addressHandler, |
||
| 137 | $this->serverContainer->getHTTPClientService(), |
||
| 138 | $this->serverContainer->query(\OCP\OCS\IDiscoveryService::class), |
||
| 139 | $this->serverContainer->getJobList(), |
||
| 140 | \OC::$server->getCloudFederationProviderManager(), |
||
| 141 | \OC::$server->getCloudFederationFactory(), |
||
| 142 | $this->serverContainer->query(IEventDispatcher::class) |
||
| 143 | ); |
||
| 144 | $tokenHandler = new TokenHandler( |
||
| 145 | $this->serverContainer->getSecureRandom() |
||
| 146 | ); |
||
| 147 | |||
| 148 | $this->federatedProvider = new FederatedShareProvider( |
||
| 149 | $this->serverContainer->getDatabaseConnection(), |
||
| 150 | $addressHandler, |
||
| 151 | $notifications, |
||
| 152 | $tokenHandler, |
||
| 153 | $l, |
||
| 154 | $this->serverContainer->getLogger(), |
||
| 155 | $this->serverContainer->getLazyRootFolder(), |
||
| 156 | $this->serverContainer->getConfig(), |
||
| 157 | $this->serverContainer->getUserManager(), |
||
| 158 | $this->serverContainer->getCloudIdManager(), |
||
| 159 | $this->serverContainer->getGlobalScaleConfig(), |
||
| 160 | $this->serverContainer->getCloudFederationProviderManager() |
||
| 161 | ); |
||
| 162 | } |
||
| 163 | |||
| 164 | return $this->federatedProvider; |
||
| 165 | } |
||
| 166 | |||
| 167 | /** |
||
| 168 | * Create the federated share provider |
||
| 169 | * |
||
| 170 | * @return ShareByMailProvider |
||
| 171 | */ |
||
| 172 | protected function getShareByMailProvider() { |
||
| 173 | if ($this->shareByMailProvider === null) { |
||
| 174 | /* |
||
| 175 | * Check if the app is enabled |
||
| 176 | */ |
||
| 177 | $appManager = $this->serverContainer->getAppManager(); |
||
| 178 | if (!$appManager->isEnabledForUser('sharebymail')) { |
||
| 179 | return null; |
||
| 180 | } |
||
| 181 | |||
| 182 | $settingsManager = new SettingsManager($this->serverContainer->getConfig()); |
||
| 183 | |||
| 184 | $this->shareByMailProvider = new ShareByMailProvider( |
||
| 185 | $this->serverContainer->getDatabaseConnection(), |
||
| 186 | $this->serverContainer->getSecureRandom(), |
||
| 187 | $this->serverContainer->getUserManager(), |
||
| 188 | $this->serverContainer->getLazyRootFolder(), |
||
| 189 | $this->serverContainer->getL10N('sharebymail'), |
||
| 190 | $this->serverContainer->getLogger(), |
||
| 191 | $this->serverContainer->getMailer(), |
||
| 192 | $this->serverContainer->getURLGenerator(), |
||
| 193 | $this->serverContainer->getActivityManager(), |
||
| 194 | $settingsManager, |
||
| 195 | $this->serverContainer->query(Defaults::class), |
||
| 196 | $this->serverContainer->getHasher(), |
||
| 197 | $this->serverContainer->get(IEventDispatcher::class) |
||
| 198 | ); |
||
| 199 | } |
||
| 200 | |||
| 201 | return $this->shareByMailProvider; |
||
| 202 | } |
||
| 203 | |||
| 204 | |||
| 205 | /** |
||
| 206 | * Create the circle share provider |
||
| 207 | * |
||
| 208 | * @return FederatedShareProvider |
||
| 209 | * |
||
| 210 | * @suppress PhanUndeclaredClassMethod |
||
| 211 | */ |
||
| 212 | protected function getShareByCircleProvider() { |
||
| 213 | if ($this->circlesAreNotAvailable) { |
||
| 214 | return null; |
||
| 215 | } |
||
| 216 | |||
| 217 | if (!$this->serverContainer->getAppManager()->isEnabledForUser('circles') || |
||
| 218 | !class_exists('\OCA\Circles\ShareByCircleProvider') |
||
| 219 | ) { |
||
| 220 | $this->circlesAreNotAvailable = true; |
||
| 221 | return null; |
||
| 222 | } |
||
| 223 | |||
| 224 | if ($this->shareByCircleProvider === null) { |
||
| 225 | $this->shareByCircleProvider = new \OCA\Circles\ShareByCircleProvider( |
||
| 226 | $this->serverContainer->getDatabaseConnection(), |
||
| 227 | $this->serverContainer->getSecureRandom(), |
||
| 228 | $this->serverContainer->getUserManager(), |
||
| 229 | $this->serverContainer->getLazyRootFolder(), |
||
| 230 | $this->serverContainer->getL10N('circles'), |
||
| 231 | $this->serverContainer->getLogger(), |
||
| 232 | $this->serverContainer->getURLGenerator() |
||
| 233 | ); |
||
| 234 | } |
||
| 235 | |||
| 236 | return $this->shareByCircleProvider; |
||
| 237 | } |
||
| 238 | |||
| 239 | /** |
||
| 240 | * Create the room share provider |
||
| 241 | * |
||
| 242 | * @return RoomShareProvider |
||
| 243 | */ |
||
| 244 | protected function getRoomShareProvider() { |
||
| 245 | if ($this->roomShareProvider === null) { |
||
| 246 | /* |
||
| 247 | * Check if the app is enabled |
||
| 248 | */ |
||
| 249 | $appManager = $this->serverContainer->getAppManager(); |
||
| 250 | if (!$appManager->isEnabledForUser('spreed')) { |
||
| 251 | return null; |
||
| 252 | } |
||
| 253 | |||
| 254 | try { |
||
| 255 | $this->roomShareProvider = $this->serverContainer->query('\OCA\Talk\Share\RoomShareProvider'); |
||
| 256 | } catch (\OCP\AppFramework\QueryException $e) { |
||
| 257 | return null; |
||
| 258 | } |
||
| 259 | } |
||
| 260 | |||
| 261 | return $this->roomShareProvider; |
||
| 262 | } |
||
| 263 | |||
| 264 | /** |
||
| 265 | * @inheritdoc |
||
| 266 | */ |
||
| 267 | public function getProvider($id) { |
||
| 300 | } |
||
| 301 | |||
| 302 | /** |
||
| 303 | * @inheritdoc |
||
| 304 | */ |
||
| 305 | public function getProviderForType($shareType) { |
||
| 306 | $provider = null; |
||
| 331 | } |
||
| 332 | |||
| 333 | public function getAllProviders() { |
||
| 360 | } |
||
| 361 | } |
||
| 362 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths