Completed
Pull Request — master (#3044)
by Thomas
08:29
created
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -105,6 +105,9 @@
 block discarded – undo
105 105
 		return $result;
106 106
 	}
107 107
 
108
+	/**
109
+	 * @param string $value
110
+	 */
108 111
 	private function getServersConfig($value) {
109 112
 		$regex = '/' . $value . '$/S';
110 113
 
Please login to merge, or discard this patch.
lib/private/Repair/Collation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 	}
91 91
 
92 92
 	/**
93
-	 * @param \Doctrine\DBAL\Connection $connection
93
+	 * @param IDBConnection $connection
94 94
 	 * @return string[]
95 95
 	 */
96 96
 	protected function getAllNonUTF8BinTables($connection) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	 * The deserialize method is called during xml parsing.
62 62
 	 *
63 63
 	 * @param Reader $reader
64
-	 * @return mixed
64
+	 * @return null|ShareTypeList
65 65
 	 */
66 66
 	static function xmlDeserialize(Reader $reader) {
67 67
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 	 * the next element.
81 81
 	 *
82 82
 	 * @param Reader $reader
83
-	 * @return mixed
83
+	 * @return null|TagList
84 84
 	 */
85 85
 	static function xmlDeserialize(Reader $reader) {
86 86
 		$tags = [];
Please login to merge, or discard this patch.
lib/private/Share/MailNotifications.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 
31 31
 namespace OC\Share;
32 32
 
33
-use DateTime;
34 33
 use OCP\IL10N;
35 34
 use OCP\IURLGenerator;
36 35
 use OCP\IUser;
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 	 * @param bool $isLoggedIn
92 92
 	 * @param bool $isAdminUser
93 93
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
94
-	 * @param CSRFTokenManager $csrfTokenManager
94
+	 * @param CsrfTokenManager $csrfTokenManager
95 95
 	 */
96 96
 	public function __construct(IRequest $request,
97 97
 								ControllerMethodReflector $reflector,
Please login to merge, or discard this patch.
lib/private/legacy/app.php 2 patches
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1036,7 +1036,7 @@  discard block
 block discarded – undo
1036 1036
 	 * @param string $app
1037 1037
 	 * @param \OCP\IConfig $config
1038 1038
 	 * @param \OCP\IL10N $l
1039
-	 * @return bool
1039
+	 * @return string
1040 1040
 	 *
1041 1041
 	 * @throws Exception if app is not compatible with this version of ownCloud
1042 1042
 	 * @throws Exception if no app-name was specified
@@ -1216,6 +1216,9 @@  discard block
 block discarded – undo
1216 1216
 		}
1217 1217
 	}
1218 1218
 
1219
+	/**
1220
+	 * @param string $lang
1221
+	 */
1219 1222
 	protected static function findBestL10NOption($options, $lang) {
1220 1223
 		$fallback = $similarLangFallback = $englishFallback = false;
1221 1224
 
@@ -1310,8 +1313,8 @@  discard block
 block discarded – undo
1310 1313
 	}
1311 1314
 
1312 1315
 	/**
1313
-	 * @param $config
1314
-	 * @param $l
1316
+	 * @param OCP\IConfig $config
1317
+	 * @param OCP\IL10N $l
1315 1318
 	 * @param $info
1316 1319
 	 * @throws Exception
1317 1320
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,6 @@
 block discarded – undo
51 51
 use OC\App\InfoParser;
52 52
 use OC\App\Platform;
53 53
 use OC\Installer;
54
-use OC\OCSClient;
55 54
 use OC\Repair;
56 55
 use OCP\App\ManagerEvent;
57 56
 
Please login to merge, or discard this patch.
lib/private/L10N/Factory.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -318,6 +318,11 @@
 block discarded – undo
318 318
 	 */
319 319
 	// FIXME This method is only public, until OC_L10N does not need it anymore,
320 320
 	// FIXME This is also the reason, why it is not in the public interface
321
+
322
+	/**
323
+	 * @param string $app
324
+	 * @param string $lang
325
+	 */
321 326
 	public function getL10nFilesForApp($app, $lang) {
322 327
 		$languageFiles = [];
323 328
 
Please login to merge, or discard this patch.
lib/private/Installer.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,6 @@
 block discarded – undo
45 45
 use OC\App\CodeChecker\CodeChecker;
46 46
 use OC\App\CodeChecker\EmptyCheck;
47 47
 use OC\App\CodeChecker\PrivateCheck;
48
-use OC\Archive\Archive;
49 48
 use OC\Archive\TAR;
50 49
 use OC_App;
51 50
 use OC_DB;
Please login to merge, or discard this patch.