Code Duplication - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

server

Code Duplication Length = 5-7 lines in 2 locations

lib/private/api.php 2 locations



		foreach($responses as $response) {
			if($response['shipped'] || ($response['app'] === 'core')) {
				if($response['response']->succeeded()) {
					$shipped['succeeded'][$response['app']] = $response;
				} else {
					$shipped['failed'][$response['app']] = $response;
				}
			} else {
				if($response['response']->succeeded()) {
					$thirdparty['succeeded'][$response['app']] = $response;

				} else {
					$shipped['failed'][$response['app']] = $response;
				}
			} else {
				if($response['response']->succeeded()) {
					$thirdparty['succeeded'][$response['app']] = $response;
				} else {
					$thirdparty['failed'][$response['app']] = $response;
				}
			}
		}

		// Remove any error responses if there is one shipped response that succeeded

		@@ 207-211 (lines=5) @@
204
205		foreach($responses as $response) {
206		if($response['shipped'] \|\| ($response['app'] === 'core')) {
207		if($response['response']->succeeded()) {
208		$shipped['succeeded'][$response['app']] = $response;
209		} else {
210		$shipped['failed'][$response['app']] = $response;
211		}
212		} else {
213		if($response['response']->succeeded()) {
214		$thirdparty['succeeded'][$response['app']] = $response;
		@@ 212-218 (lines=7) @@
209		} else {
210		$shipped['failed'][$response['app']] = $response;
211		}
212		} else {
213		if($response['response']->succeeded()) {
214		$thirdparty['succeeded'][$response['app']] = $response;
215		} else {
216		$thirdparty['failed'][$response['app']] = $response;
217		}
218		}
219		}
220
221		// Remove any error responses if there is one shipped response that succeeded

nextcloud / server

Code Duplication Length = 5-7 lines in 2 locations

lib/private/api.php 2 locations