Conditions | 24 |
Paths | 139 |
Total Lines | 67 |
Code Lines | 52 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
74 | public function parse($language, IEvent $event, IEvent $previousEvent = null): IEvent { |
||
75 | if ($event->getApp() !== 'dav' || $event->getType() !== 'contacts') { |
||
76 | throw new \InvalidArgumentException(); |
||
77 | } |
||
78 | |||
79 | $l = $this->languageFactory->get('dav', $language); |
||
80 | |||
81 | if ($this->activityManager->getRequirePNG()) { |
||
82 | $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'places/contacts-dark.png'))); |
||
83 | } else { |
||
84 | $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'places/contacts.svg'))); |
||
85 | } |
||
86 | |||
87 | if ($event->getSubject() === self::SUBJECT_ADD) { |
||
88 | $subject = $l->t('{actor} created address book {addressbook}'); |
||
89 | } elseif ($event->getSubject() === self::SUBJECT_ADD . '_self') { |
||
90 | $subject = $l->t('You created address book {addressbook}'); |
||
91 | } elseif ($event->getSubject() === self::SUBJECT_DELETE) { |
||
92 | $subject = $l->t('{actor} deleted address book {addressbook}'); |
||
93 | } elseif ($event->getSubject() === self::SUBJECT_DELETE . '_self') { |
||
94 | $subject = $l->t('You deleted address book {addressbook}'); |
||
95 | } elseif ($event->getSubject() === self::SUBJECT_UPDATE) { |
||
96 | $subject = $l->t('{actor} updated address book {addressbook}'); |
||
97 | } elseif ($event->getSubject() === self::SUBJECT_UPDATE . '_self') { |
||
98 | $subject = $l->t('You updated address book {addressbook}'); |
||
99 | } elseif ($event->getSubject() === self::SUBJECT_SHARE_USER) { |
||
100 | $subject = $l->t('{actor} shared address book {addressbook} with you'); |
||
101 | } elseif ($event->getSubject() === self::SUBJECT_SHARE_USER . '_you') { |
||
102 | $subject = $l->t('You shared address book {addressbook} with {user}'); |
||
103 | } elseif ($event->getSubject() === self::SUBJECT_SHARE_USER . '_by') { |
||
104 | $subject = $l->t('{actor} shared address book {addressbook} with {user}'); |
||
105 | } elseif ($event->getSubject() === self::SUBJECT_UNSHARE_USER) { |
||
106 | $subject = $l->t('{actor} unshared address book {addressbook} from you'); |
||
107 | } elseif ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_you') { |
||
108 | $subject = $l->t('You unshared address book {addressbook} from {user}'); |
||
109 | } elseif ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_by') { |
||
110 | $subject = $l->t('{actor} unshared address book {addressbook} from {user}'); |
||
111 | } elseif ($event->getSubject() === self::SUBJECT_UNSHARE_USER . '_self') { |
||
112 | $subject = $l->t('{actor} unshared address book {addressbook} from themselves'); |
||
113 | } elseif ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_you') { |
||
114 | $subject = $l->t('You shared address book {addressbook} with group {group}'); |
||
115 | } elseif ($event->getSubject() === self::SUBJECT_SHARE_GROUP . '_by') { |
||
116 | $subject = $l->t('{actor} shared address book {addressbook} with group {group}'); |
||
117 | } elseif ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_you') { |
||
118 | $subject = $l->t('You unshared address book {addressbook} from group {group}'); |
||
119 | } elseif ($event->getSubject() === self::SUBJECT_UNSHARE_GROUP . '_by') { |
||
120 | $subject = $l->t('{actor} unshared address book {addressbook} from group {group}'); |
||
121 | } else { |
||
122 | throw new \InvalidArgumentException(); |
||
123 | } |
||
124 | |||
125 | $parsedParameters = $this->getParameters($event, $l); |
||
126 | $this->setSubjects($event, $subject, $parsedParameters); |
||
127 | |||
128 | $event = $this->eventMerger->mergeEvents('addressbook', $event, $previousEvent); |
||
129 | |||
130 | if ($event->getChildEvent() === null) { |
||
131 | if (isset($parsedParameters['user'])) { |
||
132 | // Couldn't group by calendar, maybe we can group by users |
||
133 | $event = $this->eventMerger->mergeEvents('user', $event, $previousEvent); |
||
134 | } elseif (isset($parsedParameters['group'])) { |
||
135 | // Couldn't group by calendar, maybe we can group by groups |
||
136 | $event = $this->eventMerger->mergeEvents('group', $event, $previousEvent); |
||
137 | } |
||
138 | } |
||
139 | |||
140 | return $event; |
||
141 | } |
||
192 |