Issues in Admin.php (master) - Issues in master - nextcloud/richdocuments - Measure and Improve Code Quality continuously with Scrutinizer

Issues (213)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Settings/Admin.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright Copyright (c) 2016 Lukas Reschke <[email protected]>
 *
 * @author Lukas Reschke <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Richdocuments\Settings;

use OCA\Richdocuments\AppConfig;
use OCA\Richdocuments\Capabilities;
use OCA\Richdocuments\Service\DemoService;
use OCA\Richdocuments\TemplateManager;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\IConfig;
use OCP\Settings\ISettings;

class Admin implements ISettings {

	/** @var IConfig */
	private $config;

	/** @var AppConfig */
	private $appConfig;

	/** @var TemplateManager */
	private $manager;

	/** @var array */
	private $capabilities;

	/** @var DemoService */
	private $demoService;

	/**
	 * Admin template settings
	 *
	 * @param IConfig $config
	 * @param TemplateManager $manager
	 * @param Capabilities $capabilities
	 */
	public function __construct(
		IConfig $config,
		AppConfig $appConfig,
		TemplateManager $manager,
		Capabilities $capabilities,
		DemoService $demoService
	) {
		$this->config  = $config;
		$this->appConfig = $appConfig;
		$this->manager = $manager;
		$this->capabilities = $capabilities->getCapabilities()['richdocuments'];
		$this->demoService = $demoService;
	}
	/**
	 * @return TemplateResponse
	 */
	public function getForm() {
		$demoServers = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		return new TemplateResponse(
			'richdocuments',
			'admin',
			[
				'settings' => [
					'wopi_url'           => $this->config->getAppValue('richdocuments', 'wopi_url'),
					'edit_groups'        => $this->config->getAppValue('richdocuments', 'edit_groups'),
					'use_groups'         => $this->config->getAppValue('richdocuments', 'use_groups'),
					'doc_format'         => $this->config->getAppValue('richdocuments', 'doc_format'),
					'external_apps'      => $this->config->getAppValue('richdocuments', 'external_apps'),
					'canonical_webroot'  => $this->config->getAppValue('richdocuments', 'canonical_webroot'),
					'disable_certificate_verification' => $this->config->getAppValue('richdocuments', 'disable_certificate_verification', '') === 'yes',
					'templates'          => $this->manager->getSystemFormatted(),
					'templatesAvailable' => array_key_exists('templates', $this->capabilities) && $this->capabilities['templates'],
					'settings' => $this->appConfig->getAppSettings(),
					'demo_servers' => $this->demoService->fetchDemoServers(),
					'web_server' => strtolower($_SERVER['SERVER_SOFTWARE']),
					'os_family' => PHP_VERSION_ID >= 70200 ? PHP_OS_FAMILY : PHP_OS,
					'platform' => php_uname('m')
				]
			],
			'blank'
		);
	}
	/**
	 * @return string the section ID, e.g. 'sharing'
	 */
	public function getSection() {
		return 'richdocuments';
	}
	/**
	 * @return int whether the form should be rather on the top or bottom of
	 * the admin section. The forms are arranged in ascending order of the
	 * priority values. It is required to return a value between 0 and 100.
	 *
	 * keep the server setting at the top, right after "server settings"
	 */
	public function getPriority() {
		return 0;
	}

}


1			<?php
2			/**
3			* @copyright Copyright (c) 2016 Lukas Reschke <[email protected]>
4			*
5			* @author Lukas Reschke <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Richdocuments\Settings;
25
26			use OCA\Richdocuments\AppConfig;
27			use OCA\Richdocuments\Capabilities;
28			use OCA\Richdocuments\Service\DemoService;
29			use OCA\Richdocuments\TemplateManager;
30			use OCP\AppFramework\Http\TemplateResponse;
31			use OCP\IConfig;
32			use OCP\Settings\ISettings;
33
34			class Admin implements ISettings {
35
36			/** @var IConfig */
37			private $config;
38
39			/** @var AppConfig */
40			private $appConfig;
41
42			/** @var TemplateManager */
43			private $manager;
44
45			/** @var array */
46			private $capabilities;
47
48			/** @var DemoService */
49			private $demoService;
50
51			/**
52			* Admin template settings
53			*
54			* @param IConfig $config
55			* @param TemplateManager $manager
56			* @param Capabilities $capabilities
57			*/
58			public function __construct(
59			IConfig $config,
60			AppConfig $appConfig,
61			TemplateManager $manager,
62			Capabilities $capabilities,
63			DemoService $demoService
64			) {
65			$this->config = $config;
66			$this->appConfig = $appConfig;
67			$this->manager = $manager;
68			$this->capabilities = $capabilities->getCapabilities()['richdocuments'];
69			$this->demoService = $demoService;
70			}
71			/**
72			* @return TemplateResponse
73			*/
74			public function getForm() {
75			$demoServers = [];
			0 ignored issues – show Unused Code introduced 2020-01-23 18:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$demoServers` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
76
77			return new TemplateResponse(
78			'richdocuments',
79			'admin',
80			[
81			'settings' => [
82			'wopi_url' => $this->config->getAppValue('richdocuments', 'wopi_url'),
83			'edit_groups' => $this->config->getAppValue('richdocuments', 'edit_groups'),
84			'use_groups' => $this->config->getAppValue('richdocuments', 'use_groups'),
85			'doc_format' => $this->config->getAppValue('richdocuments', 'doc_format'),
86			'external_apps' => $this->config->getAppValue('richdocuments', 'external_apps'),
87			'canonical_webroot' => $this->config->getAppValue('richdocuments', 'canonical_webroot'),
88			'disable_certificate_verification' => $this->config->getAppValue('richdocuments', 'disable_certificate_verification', '') === 'yes',
89			'templates' => $this->manager->getSystemFormatted(),
90			'templatesAvailable' => array_key_exists('templates', $this->capabilities) && $this->capabilities['templates'],
91			'settings' => $this->appConfig->getAppSettings(),
92			'demo_servers' => $this->demoService->fetchDemoServers(),
93			'web_server' => strtolower($_SERVER['SERVER_SOFTWARE']),
94			'os_family' => PHP_VERSION_ID >= 70200 ? PHP_OS_FAMILY : PHP_OS,
95			'platform' => php_uname('m')
96			]
97			],
98			'blank'
99			);
100			}
101			/**
102			* @return string the section ID, e.g. 'sharing'
103			*/
104			public function getSection() {
105			return 'richdocuments';
106			}
107			/**
108			* @return int whether the form should be rather on the top or bottom of
109			* the admin section. The forms are arranged in ascending order of the
110			* priority values. It is required to return a value between 0 and 100.
111			*
112			* keep the server setting at the top, right after "server settings"
113			*/
114			public function getPriority() {
115			return 0;
116			}
117
118			}
119

nextcloud / richdocuments

Issues (213)

Security Analysis not enabled

lib/Settings/Admin.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like