OCA\Richdocuments\WOPI\Parser

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getUrlSrc()	0	17	3

<?php
/**
 * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Richdocuments\WOPI;

class Parser {
	/** @var DiscoveryManager */
	private $discoveryManager;

	/**
	 * @param DiscoveryManager $discoveryManager
	 */
	public function __construct(DiscoveryManager $discoveryManager) {
		$this->discoveryManager = $discoveryManager;
	}

	/**
	 * @param $mimetype
	 * @return array
	 * @throws \Exception
	 */
	public function getUrlSrc($mimetype) {
		$discovery = $this->discoveryManager->get();
		$loadEntities = libxml_disable_entity_loader(true);
		$discoveryParsed = simplexml_load_string($discovery);
		libxml_disable_entity_loader($loadEntities);

		$result = $discoveryParsed->xpath(sprintf('/wopi-discovery/net-zone/app[@name=\'%s\']/action', $mimetype));
		if ($result && count($result) > 0) {

The expression $result of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			return [
				'urlsrc' => (string)$result[0]['urlsrc'],
				'action' => (string)$result[0]['name'],
			];
		}

		throw new \Exception('Could not find urlsrc in WOPI');

	}

}