UserScopeService - Code Metrics - Inspection of "Introduce a user scope service to properly perform..." - nextcloud/richdocuments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 23419f...3c3a4e )

by Julius

created 2019-12-18 19:35 UTC

UserScopeService A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	0
dl	0
loc	22
ccs	0
cts	11
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	setUserScope()	0	7	2

<?php
/**
 * @copyright Copyright (c) 2019 Julius Härtl <[email protected]>
 *
 * @author Julius Härtl <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Richdocuments\Service;


use OCP\IUserManager;
use OCP\IUserSession;

class UserScopeService {

	public function __construct(IUserSession $userSession, IUserManager $userManager) {
		$this->userSession = $userSession;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->userManager = $userManager;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	/**
	 * Set a valid user in IUserSession since lots of server logic is relying on obtaining
	 * the current acting user from that
	 *
	 * @param $uid
	 * @throws \InvalidArgumentException
	 */
	public function setUserScope(string $uid) {
		$user = $this->userManager->get($uid);
		if ($user === null) {
			throw new \InvalidArgumentException('No user found for the uid ' . $uid);
		}
		$this->userSession->setUser($user);
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2019 Julius Härtl <[email protected]>
4			*
5			* @author Julius Härtl <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Richdocuments\Service;
25
26
27			use OCP\IUserManager;
28			use OCP\IUserSession;
29
30			class UserScopeService {
31
32			public function __construct(IUserSession $userSession, IUserManager $userManager) {
33			$this->userSession = $userSession;
			0 ignored issues – show Bug introduced 2019-12-18 14:22 UTC by Report Bug Copy Issue Report The property `userSession` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34			$this->userManager = $userManager;
			0 ignored issues – show Bug introduced 2019-12-18 14:22 UTC by Report Bug Copy Issue Report The property `userManager` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			}
36
37			/**
38			* Set a valid user in IUserSession since lots of server logic is relying on obtaining
39			* the current acting user from that
40			*
41			* @param $uid
42			* @throws \InvalidArgumentException
43			*/
44			public function setUserScope(string $uid) {
45			$user = $this->userManager->get($uid);
46			if ($user === null) {
47			throw new \InvalidArgumentException('No user found for the uid ' . $uid);
48			}
49			$this->userSession->setUser($user);
50			}
51			}
52

nextcloud / richdocuments

Push — master ( 23419f...3c3a4e )

UserScopeService A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like