SettingsController::__construct() - Code Metrics - Inspection of "Merge pull request #417 from nextcloud/enhancement..." - nextcloud/richdocuments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3dcbe0...f8e908 )

by Julius

created 2019-03-01 15:04 UTC

SettingsController::__construct() A

↳ Parent: SettingsController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	16
cp	0
rs	9.7333
c	0
b	0
f	0
cc	1
nc	1
nop	8
crap	2

How to fix Many Parameters

<?php
/**
 * ownCloud - Richdocuments App
 *
 * @author Victor Dubiniuk
 * @copyright 2014 Victor Dubiniuk [email protected]
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 */

namespace OCA\Richdocuments\Controller;

use OCA\Richdocuments\Service\CapabilitiesService;
use OCA\Richdocuments\WOPI\DiscoveryManager;
use \OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\Http\JSONResponse;
use \OCP\IRequest;
use \OCP\IL10N;
use OCA\Richdocuments\AppConfig;
use OCP\IConfig;
use OCP\PreConditionNotMetException;

class SettingsController extends Controller{
	/** @var IL10N */
	private $l10n;
	/** @var AppConfig */
	private $appConfig;
	/** @var IConfig */
	private $config;
	/** @var DiscoveryManager  */
	private $discoveryManager;
	/** @var string */
	private $userId;
	/** @var CapabilitiesService */
	private $capabilitiesService;

	/**
	 * @param string $appName
	 * @param IRequest $request
	 * @param IL10N $l10n
	 * @param AppConfig $appConfig
	 * @param IConfig $config
	 * @param DiscoveryManager $discoveryManager
	 * @param string $userId
	 */
	public function __construct($appName,
								IRequest $request,
								IL10N $l10n,
								AppConfig $appConfig,
								IConfig $config,
								DiscoveryManager $discoveryManager,
								$userId,
								CapabilitiesService $capabilitiesService) {
		parent::__construct($appName, $request);
		$this->l10n = $l10n;
		$this->appConfig = $appConfig;
		$this->config = $config;
		$this->discoveryManager = $discoveryManager;
		$this->userId = $userId;
		$this->capabilitiesService = $capabilitiesService;
	}

	/**
	 * @PublicPage
	 * @NoCSRFRequired
	 * @throws \Exception
	 */
	public function checkSettings() {
		try {
			$response = $this->discoveryManager->fetchFromRemote();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		} catch (\Exception $e) {
			return new DataResponse([
				'status' => $e->getCode(),
				'message' => $e->getMessage()
			], $e->getCode());
		}

		return new DataResponse();
	}

	/**
	 * @NoAdminRequired
	 *
	 * @return JSONResponse
	 */
	public function getSettings() {
		return new JSONResponse([
			'wopi_url' => $this->appConfig->getAppValue('wopi_url'),
			'disable_certificate_verification' => $this->appConfig->getAppValue('disable_certificate_verification'),
			'edit_groups' => $this->appConfig->getAppValue('edit_groups'),
			'use_groups' => $this->appConfig->getAppValue('use_groups'),
			'doc_format' => $this->appConfig->getAppValue('doc_format'),
		]);
	}

	/**
	 * @param string $wopi_url
	 * @param string $disable_certificate_verification
	 * @param string $edit_groups
	 * @param string $use_groups
	 * @param string $doc_format
	 * @param string $external_apps
	 * @param string $canonical_webroot
	 * @return JSONResponse
	 */
	public function setSettings($wopi_url,
	                            $disable_certificate_verification,
	                            $edit_groups,
	                            $use_groups,
	                            $doc_format,
	                            $external_apps,
	                            $canonical_webroot) {
		$message = $this->l10n->t('Saved');

		if ($wopi_url !== null){
			$this->appConfig->setAppValue('wopi_url', $wopi_url);

			$colon = strpos($wopi_url, ':', 0);
			if ($this->request->getServerProtocol() !== substr($wopi_url, 0, $colon)){
				$message = $this->l10n->t('Saved with error: Collabora Online should use the same protocol as the server installation.');
			}
		}

		if ($disable_certificate_verification !== null) {
			$this->appConfig->setAppValue(
				'disable_certificate_verification',
				$disable_certificate_verification === 'true' ? 'yes' : ''
			);
		}

		if ($edit_groups !== null){
			$this->appConfig->setAppValue('edit_groups', $edit_groups);
		}

		if ($use_groups !== null){
			$this->appConfig->setAppValue('use_groups', $use_groups);
		}

		if ($doc_format !== null) {
			$this->appConfig->setAppValue('doc_format', $doc_format);
		}

		if ($external_apps !== null) {
			$this->appConfig->setAppValue('external_apps', $external_apps);
		}

		if ($canonical_webroot !== null) {
			$this->appConfig->setAppValue('canonical_webroot', $canonical_webroot);
		}

		$this->discoveryManager->refretch();
		$this->capabilitiesService->refretch();

		$response = [
			'status' => 'success',
			'data' => ['message' => $message]
		];

		return new JSONResponse($response);
	}

	/**
	 * @NoAdminRequired
	 *
	 * @param $key
	 * @param $value
	 * @return JSONResponse
	 */
	public function setPersonalSettings($templateFolder) {
		$message = $this->l10n->t('Saved');
		$status = 'success';

		if ($templateFolder !== null){
			try {
				$this->config->setUserValue($this->userId, 'richdocuments', 'templateFolder', $templateFolder);
			} catch (PreConditionNotMetException $e) {

				$message = $this->l10n->t('Error when saving');
				$status = 'error';
			}
		}

		$response = [
			'status' => $status,
			'data' => ['message' => $message]
		];

		return new JSONResponse($response);

	}
}


1			<?php
2			/**
3			* ownCloud - Richdocuments App
4			*
5			* @author Victor Dubiniuk
6			* @copyright 2014 Victor Dubiniuk [email protected]
7			*
8			* This file is licensed under the Affero General Public License version 3 or
9			* later.
10			*/
11
12			namespace OCA\Richdocuments\Controller;
13
14			use OCA\Richdocuments\Service\CapabilitiesService;
15			use OCA\Richdocuments\WOPI\DiscoveryManager;
16			use \OCP\AppFramework\Controller;
17			use OCP\AppFramework\Http;
18			use OCP\AppFramework\Http\DataResponse;
19			use OCP\AppFramework\Http\JSONResponse;
20			use \OCP\IRequest;
21			use \OCP\IL10N;
22			use OCA\Richdocuments\AppConfig;
23			use OCP\IConfig;
24			use OCP\PreConditionNotMetException;
25
26			class SettingsController extends Controller{
27			/** @var IL10N */
28			private $l10n;
29			/** @var AppConfig */
30			private $appConfig;
31			/** @var IConfig */
32			private $config;
33			/** @var DiscoveryManager */
34			private $discoveryManager;
35			/** @var string */
36			private $userId;
37			/** @var CapabilitiesService */
38			private $capabilitiesService;
39
40			/**
41			* @param string $appName
42			* @param IRequest $request
43			* @param IL10N $l10n
44			* @param AppConfig $appConfig
45			* @param IConfig $config
46			* @param DiscoveryManager $discoveryManager
47			* @param string $userId
48			*/
49			public function __construct($appName,
50			IRequest $request,
51			IL10N $l10n,
52			AppConfig $appConfig,
53			IConfig $config,
54			DiscoveryManager $discoveryManager,
55			$userId,
56			CapabilitiesService $capabilitiesService) {
57			parent::__construct($appName, $request);
58			$this->l10n = $l10n;
59			$this->appConfig = $appConfig;
60			$this->config = $config;
61			$this->discoveryManager = $discoveryManager;
62			$this->userId = $userId;
63			$this->capabilitiesService = $capabilitiesService;
64			}
65
66			/**
67			* @PublicPage
68			* @NoCSRFRequired
69			* @throws \Exception
70			*/
71			public function checkSettings() {
72			try {
73			$response = $this->discoveryManager->fetchFromRemote();
			0 ignored issues – show Unused Code introduced 2019-02-27 18:54 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
74			} catch (\Exception $e) {
75			return new DataResponse([
76			'status' => $e->getCode(),
77			'message' => $e->getMessage()
78			], $e->getCode());
79			}
80
81			return new DataResponse();
82			}
83
84			/**
85			* @NoAdminRequired
86			*
87			* @return JSONResponse
88			*/
89			public function getSettings() {
90			return new JSONResponse([
91			'wopi_url' => $this->appConfig->getAppValue('wopi_url'),
92			'disable_certificate_verification' => $this->appConfig->getAppValue('disable_certificate_verification'),
93			'edit_groups' => $this->appConfig->getAppValue('edit_groups'),
94			'use_groups' => $this->appConfig->getAppValue('use_groups'),
95			'doc_format' => $this->appConfig->getAppValue('doc_format'),
96			]);
97			}
98
99			/**
100			* @param string $wopi_url
101			* @param string $disable_certificate_verification
102			* @param string $edit_groups
103			* @param string $use_groups
104			* @param string $doc_format
105			* @param string $external_apps
106			* @param string $canonical_webroot
107			* @return JSONResponse
108			*/
109			public function setSettings($wopi_url,
110			$disable_certificate_verification,
111			$edit_groups,
112			$use_groups,
113			$doc_format,
114			$external_apps,
115			$canonical_webroot) {
116			$message = $this->l10n->t('Saved');
117
118			if ($wopi_url !== null){
119			$this->appConfig->setAppValue('wopi_url', $wopi_url);
120
121			$colon = strpos($wopi_url, ':', 0);
122			if ($this->request->getServerProtocol() !== substr($wopi_url, 0, $colon)){
123			$message = $this->l10n->t('Saved with error: Collabora Online should use the same protocol as the server installation.');
124			}
125			}
126
127			if ($disable_certificate_verification !== null) {
128			$this->appConfig->setAppValue(
129			'disable_certificate_verification',
130			$disable_certificate_verification === 'true' ? 'yes' : ''
131			);
132			}
133
134			if ($edit_groups !== null){
135			$this->appConfig->setAppValue('edit_groups', $edit_groups);
136			}
137
138			if ($use_groups !== null){
139			$this->appConfig->setAppValue('use_groups', $use_groups);
140			}
141
142			if ($doc_format !== null) {
143			$this->appConfig->setAppValue('doc_format', $doc_format);
144			}
145
146			if ($external_apps !== null) {
147			$this->appConfig->setAppValue('external_apps', $external_apps);
148			}
149
150			if ($canonical_webroot !== null) {
151			$this->appConfig->setAppValue('canonical_webroot', $canonical_webroot);
152			}
153
154			$this->discoveryManager->refretch();
155			$this->capabilitiesService->refretch();
156
157			$response = [
158			'status' => 'success',
159			'data' => ['message' => $message]
160			];
161
162			return new JSONResponse($response);
163			}
164
165			/**
166			* @NoAdminRequired
167			*
168			* @param $key
169			* @param $value
170			* @return JSONResponse
171			*/
172			public function setPersonalSettings($templateFolder) {
173			$message = $this->l10n->t('Saved');
174			$status = 'success';
175
176			if ($templateFolder !== null){
177			try {
178			$this->config->setUserValue($this->userId, 'richdocuments', 'templateFolder', $templateFolder);
179			} catch (PreConditionNotMetException $e) {
			0 ignored issues – show Bug introduced 2018-11-08 16:16 UTC by Report Bug Copy Issue Report The class `OCP\PreConditionNotMetException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
180			$message = $this->l10n->t('Error when saving');
181			$status = 'error';
182			}
183			}
184
185			$response = [
186			'status' => $status,
187			'data' => ['message' => $message]
188			];
189
190			return new JSONResponse($response);
191
192			}
193			}
194

nextcloud / richdocuments

Push — master ( 3dcbe0...f8e908 )

SettingsController::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like