nextcloud / richdocuments

lib/Controller/DocumentController.php

Unused Use Statements -2 removed lines

@@ -11,10 +11,8 @@
 
 namespace OCA\Richdocuments\Controller;
 
-use OCA\Richdocuments\Db\WopiMapper;
 use OCA\Richdocuments\Service\FederationService;
 use OCA\Richdocuments\TokenManager;
-use OCA\Richdocuments\WOPI\Parser;
 use \OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\JSONResponse;

lib/Controller/FederationController.php

Unused Use Statements -3 removed lines

@@ -26,11 +26,8 @@
 use \OCP\AppFramework\OCSController;
 use OCA\Richdocuments\Db\WopiMapper;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\AppFramework\OCS\OCSNotFoundException;
-use OCP\Files\NotFoundException;
 use OCP\IConfig;
 use OCP\IRequest;
-use OCP\Share\Exceptions\ShareNotFound;
 use OCP\Share\IManager;
 
 class FederationController extends OCSController {

lib/Service/FederationService.php

Doc Comments +1 added lines

@@ -126,6 +126,7 @@
 
 	/**
 	 * @param File $item
+	 * @param \OCA\Richdocuments\Db\Direct $direct
 	 * @return string|null
 	 * @throws NotFoundException
 	 * @throws InvalidPathException

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCA\Federation\TrustedServers;
 use OCA\Files_Sharing\External\Storage as SharingExternalStorage;
 use OCA\Richdocuments\TokenManager;
-use OCP\AppFramework\Http\RedirectResponse;
 use OCP\AppFramework\QueryException;
 use OCP\Files\File;
 use OCP\Files\InvalidPathException;

lib/AppConfig.php

Doc Comments +4 added lines, -1 removed lines

@@ -40,6 +40,9 @@ 
 		$this->config = $config;
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getAppNamespace($key) {
 		if (strpos($key, 'watermark_') === 0) {
 			return self::WATERMARK_APP_NAMESPACE;
@@ -61,7 +64,7 @@ 
 	}
 
 	/**
-	 * @param $key
+	 * @param string $key
 	 * @return array
 	 */
 	public function getAppValueArray($key) {

lib/Controller/WopiController.php

Doc Comments +7 added lines

@@ -215,6 +215,9 @@ 
 		return new JSONResponse($response);
 	}
 
+	/**
+	 * @param Wopi $wopi
+	 */
 	private function setFederationFileInfo($wopi, $response) {
 		$remoteUserId = $wopi->getGuestDisplayname();
 		$cloudID = \OC::$server->getCloudIdManager()->resolveCloudId($remoteUserId);
@@ -235,6 +238,10 @@ 
 		return $response;
 	}
 
+	/**
+	 * @param boolean $isPublic
+	 * @param string $userId
+	 */
 	private function shouldWatermark($isPublic, $userId, $fileId, Wopi $wopi) {
 		if ($this->config->getAppValue(AppConfig::WATERMARK_APP_NAMESPACE, 'watermark_enabled', 'no') === 'no') {
 			return false;

lib/Preview/Office.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
  */
 namespace OCA\Richdocuments\Preview;
 
-use GuzzleHttp\Psr7\LimitStream;
 use function GuzzleHttp\Psr7\stream_for;
 use OC\Preview\Provider;
 use OCA\Richdocuments\Capabilities;

tests/features/bootstrap/FeatureContext.php

Doc Comments +5 added lines, -1 removed lines

@@ -255,6 +255,11 @@ 
     	return $this->davPath . '/files/' . $user;
 	}
 
+	/**
+	 * @param string $user
+	 * @param string $method
+	 * @param string $path
+	 */
 	public function makeDavRequest($user, $method, $path, $headers, $body = null) {
     	$fullUrl = $this->baseUrl . $this->getDavFilesPath($user) . "$path";
 
@@ -281,7 +286,6 @@ 
 
 	/**
 	 * @Given Using web as guest
-	 * @param string $user
 	 */
 	public function usingWebasGuest() {
 		return $this->loggingInUsingWebAs(null);

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 require __DIR__ . '/../../vendor/autoload.php';
 
 use Behat\Behat\Context\Context;
-use Behat\Gherkin\Node\PyStringNode;
-use Behat\Gherkin\Node\TableNode;
 use GuzzleHttp\Client;
 use GuzzleHttp\Psr7\Response;
 use Sabre\DAV\Client as SabreClient;

tests/features/bootstrap/UserTrait.php

Doc Comments +3 added lines

@@ -77,6 +77,9 @@
 		$this->assertStatusCode($response, 200);
 	}
 
+	/**
+	 * @param string $user
+	 */
 	private function userExists($user) {
 		$client = new Client();
 		$options = [

Unused Use Statements -2 removed lines

@@ -22,8 +22,6 @@
  */
 
 use GuzzleHttp\Client;
-use GuzzleHttp\Cookie\CookieJar;
-use GuzzleHttp\Message\ResponseInterface;
 
 trait UserTrait {