OptionController::update() - Code Metrics - Inspection of "Confirm options" - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#929)

by René
created 2020-05-13 11:11 UTC
OptionController::update() B

↳ Parent: OptionController
Complexity

Conditions	6
Paths	42
Size

Total Lines	36
Code Lines	21
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	42
Importance

Changes	2
Bugs	1	Features	0
Metric	Value
cc	6
eloc	21
nc	42
nop	1
dl	0
loc	36
ccs	0
cts	26
cp	0
crap	42
rs	8.9617
c	2
b	1
f	0
<?php
/**
 * @copyright Copyright (c) 2017 Vinzenz Rosenkranz <[email protected]>
 *
 * @author René Gieling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Polls\Controller;

use Exception;
use OCP\AppFramework\Db\DoesNotExistException;

use OCP\IRequest;
use OCP\ILogger;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;

use OCP\IGroupManager;
use OCP\Security\ISecureRandom;

use OCA\Polls\Db\Poll;
use OCA\Polls\Db\PollMapper;
use OCA\Polls\Db\Option;
use OCA\Polls\Db\OptionMapper;
use OCA\Polls\Service\LogService;
use OCA\Polls\Model\Acl;

class OptionController extends Controller {

	private $userId;
	private $optionMapper;

	private $groupManager;
	private $pollMapper;
	private $logger;
	private $logService;
	private $acl;

	/**
	 * OptionController constructor.
	 * @param string $appName
	 * @param $UserId
	 * @param IRequest $request
	 * @param ILogger $logger
	 * @param OptionMapper $optionMapper
	 * @param IGroupManager $groupManager
	 * @param PollMapper $pollMapper
	 * @param LogService $logService
	 * @param Acl $acl
	 */

	public function __construct(
		string $appName,
		$UserId,
		IRequest $request,
		OptionMapper $optionMapper,
		IGroupManager $groupManager,
		PollMapper $pollMapper,
		ILogger $logger,
		LogService $logService,
		Acl $acl
	) {
		parent::__construct($appName, $request);
		$this->userId = $UserId;
		$this->optionMapper = $optionMapper;
		$this->groupManager = $groupManager;
		$this->pollMapper = $pollMapper;
		$this->logger = $logger;
		$this->logService = $logService;
		$this->acl = $acl;
	}


	/**
	 * Get all options of given poll
	 * @NoAdminRequired
	 * @param integer $pollId
	 * @return array Array of Option objects
	 */
	public function get($pollId) {

		try {

			if (!$this->acl->getFoundByToken()) {
				$this->acl->setPollId($pollId);
			}

			return new DataResponse($this->optionMapper->findByPoll($pollId), Http::STATUS_OK);

		} catch (DoesNotExistException $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}
	}


	/**
	 * getByToken
	 * Read all options of a poll based on a share token and return list as array
	 * @NoAdminRequired
	 * @PublicPage
	 * @NoCSRFRequired
	 * @param string $token
	 * @return DataResponse
	 */
	public function getByToken($token) {

		try {
			$this->acl->setToken($token);
			return $this->get($this->acl->getPollId());

		} catch (DoesNotExistException $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}
	}

	/**
	 * Add a new Option to poll
	 * @NoAdminRequired
	 * @param Option $option
	 * @return DataResponse
	 */
	public function add($option) {

		try {

			if (!$this->acl->setPollId($option['pollId'])->getAllowEdit()) {
				return new DataResponse(null, Http::STATUS_UNAUTHORIZED);
			}

			$NewOption = new Option();

			$NewOption->setPollId($option['pollId']);
			$NewOption->setPollOptionText(trim(htmlspecialchars($option['pollOptionText'])));
			$NewOption->setTimestamp($option['timestamp']);

			if ($option['timestamp'] === 0) {
				$NewOption->setOrder($option['order']);
                setOrder($option['order']);
			} else {
				$NewOption->setOrder($option['timestamp']);
			}

			$this->optionMapper->insert($NewOption);
			$this->logService->setLog($option['pollId'], 'addOption');
			return new DataResponse($NewOption, Http::STATUS_OK);

		} catch (Exception $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}

	}

	/**
	 * Update poll option
	 * @NoAdminRequired
	 * @param Option $option
	 * @return DataResponse
	 */
	public function update($option) {

		try {
			$this->logger->alert(json_encode($option));
			$updateOption = $this->optionMapper->find($option['id']);

			if (!$this->acl->setPollId($option['pollId'])->getAllowEdit()) {
				return new DataResponse(null, Http::STATUS_UNAUTHORIZED);
			}

			$updateOption->setPollOptionText(trim(htmlspecialchars($option['pollOptionText'])));
			$updateOption->setTimestamp($option['timestamp']);

			if ($option['timestamp'] === 0) {
				$updateOption->setOrder($option['order']);
                   setOrder($option['order']);
			} else {
				$updateOption->setOrder($option['timestamp']);
			}

			if ($option['confirmed']) {
				// do not update confirmation date, if option is already confirmed
				if (!$updateOption->setConfirmed()){
				if (!$updateOption->/** @scrutinizer ignore-call */ setConfirmed()){
					$updateOption->setConfirmed(time());
				}

			} else {
				$updateOption->setConfirmed(0);
			}

			$this->optionMapper->update($updateOption);
			$this->logService->setLog($option['pollId'], 'updateOption');

			return new DataResponse($updateOption, Http::STATUS_OK);

		} catch (Exception $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}
	}

	/**
	 * Remove a single option
	 * @NoAdminRequired
	 * @param Option $option
	 * @return DataResponse
	 */
	public function remove($option) {
		try {

			if (!$this->acl->setPollId($option['pollId'])->getAllowEdit()) {
				return new DataResponse(null, Http::STATUS_UNAUTHORIZED);
			}

			$this->optionMapper->remove($option['id']);
			$this->logService->setLog($option['pollId'], 'deleteOption');

			return new DataResponse(array(
				'action' => 'deleted',
				'optionId' => $option['id']
			), Http::STATUS_OK);

		} catch (Exception $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}

	}

}

nextcloud / polls

Pull Request — master (#929)

OptionController::update() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
