PollController::getByToken() - Code Metrics - Inspection of "refactor acl" - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#1254)

by René
created 2020-11-26 20:11 UTC
PollController::getByToken() A

↳ Parent: PollController
Complexity

Conditions	1
Paths	1
Size

Total Lines	6
Code Lines	5
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
eloc	5
c	0
b	0
f	0
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	10
cc	1
nc	1
nop	1
crap	2
<?php
/**
 * @copyright Copyright (c) 2017 Vinzenz Rosenkranz <[email protected]>
 *
 * @author René Gieling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Polls\Controller;

use OCP\AppFramework\Db\DoesNotExistException;
use OCA\Polls\Exceptions\Exception;

use OCP\IRequest;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;

use OCA\Polls\DB\Share;
use OCA\Polls\Service\PollService;
use OCA\Polls\Service\CommentService;
use OCA\Polls\Service\OptionService;
use OCA\Polls\Service\ShareService;
use OCA\Polls\Service\VoteService;
use OCA\Polls\Model\Acl;

class PollController extends Controller {

	/** @var PollService */
	private $pollService;

	/** @var CommentService */
	private $commentService;

	/** @var OptionService */
	private $optionService;

	/** @var ShareService */
	private $shareService;

	/** @var Share */
	private $share;

	/** @var VoteService */
	private $voteService;

	/** @var Acl */
	private $acl;

	use ResponseHandle;

	/**
	 * PollController constructor.
	 * @param string $appName
	 * @param IRequest $request
	 * @param PollService $pollService
	 * @param CommentService $commentService
	 * @param OptionService $optionService
	 * @param ShareService $shareService
	 * @param VoteService $voteService
	 * @param Share $share
	 * @param Acl $acl
	 */

	public function __construct(
		string $appName,
		IRequest $request,
		PollService $pollService,
		CommentService $commentService,
		OptionService $optionService,
		ShareService $shareService,
		VoteService $voteService,
		Share $share,
		Acl $acl
	) {
		parent::__construct($appName, $request);
		$this->pollService = $pollService;
		$this->commentService = $commentService;
		$this->optionService = $optionService;
		$this->shareService = $shareService;
		$this->voteService = $voteService;
		$this->share = $share;
		$this->acl = $acl;
	}

	/**
	 * Get list of polls
	 * @NoAdminRequired
	 * @return DataResponse
	 */

	public function list() {
		return $this->response(function () {
			return $this->pollService->list();
		});
	}


	/**
	 * get complete poll
	 * @NoAdminRequired
	 * @PublicPage
	 * @deprecated use getByToken/getById
	 * @param int $pollId
	 * @param string $token
	 * @return DataResponse
	 */
	public function get(int $pollId = 0, string $token = '') {
		if ($token) {
			return $this->getByToken($token);
		} else {
			return $this->getByPollId($pollId);
		}
	}

	/**
	 * get complete poll via token
	 * @NoAdminRequired
	 * @PublicPage
	 * @param string $token
	 * @return DataResponse
	 */
	public function getByToken(string $token) {
		return $this->response(function () use ($token) {
			$this->share = $this->shareService->get($token);
			$this->acl->setShare($this->share);
			$this->poll = $this->pollService->get($this->share->getPollId());

			return $this->build();
		});
	}

	/**
	 * get complete poll via pollId
	 * @NoAdminRequired
	 * @param int $pollId
	 * @return DataResponse
	 */
	public function getByPollId(int $pollId) {
		return $this->response(function () use ($pollId) {
			$this->share = null;
			$this->poll = $this->pollService->get($pollId);

			$this->acl->setPoll($this->poll);
			return $this->build();
		});
	}

	/**
	 * get complete poll
	 * @NoAdminRequired
	 * @PublicPage
	 * @param int $pollId
	 * @param string $token
	 * @return Array
	 */
	private function build() {
		try {
			$comments = $this->commentService->list($this->poll->getId());
		} catch (Exception $e) {
			$comments = [];
		}

		try {
			$options = $this->optionService->list($this->poll->getId());
		} catch (Exception $e) {
			$options = [];
		}

		try {
			$votes = $this->voteService->list($this->poll->getId());
		} catch (Exception $e) {
			$votes = [];
		}

		try {
			$shares = $this->shareService->list($this->poll->getId());
		} catch (Exception $e) {
			$shares = [];
		}

		return [
			'acl' => $this->acl,
			'poll' => $this->poll,
			'comments' => $comments,
			'options' => $options,
			'share' => $this->share,
			'shares' => $shares,
			'votes' => $votes,
		];
	}

	/**
	 * Add poll
	 * @NoAdminRequired
	 * @param string $type
	 * @param string $title
	 * @return DataResponse
	 */

	public function add($type, $title) {
		return $this->responseCreate(function () use ($type, $title) {
			return $this->pollService->add($type, $title);
		});
	}

	/**
	 * Update poll configuration
	 * @NoAdminRequired
	 * @param int $pollId
	 * @param array $poll
	 * @return DataResponse
	 */

	public function update($pollId, $poll) {
		return $this->response(function () use ($pollId, $poll) {
			return $this->pollService->update($pollId, $poll);
		});
	}

	/**
	 * Switch deleted status (move to deleted polls)
	 * @NoAdminRequired
	 * @param int $pollId
	 * @return DataResponse
	 */

	public function delete($pollId) {
		return $this->response(function () use ($pollId) {
			return $this->pollService->update($pollId);
			return $this->pollService->/** @scrutinizer ignore-call */ update($pollId);
		});
	}

	/**
	 * Delete poll
	 * @NoAdminRequired
	 * @param Array $poll
	 * @return DataResponse
	 */

	public function deletePermanently($pollId) {
		return $this->responseDeleteTolerant(function () use ($pollId) {
			return $this->pollService->deletePermanently($pollId);
		});
	}

	/**
	 * Clone poll
	 * @NoAdminRequired
	 * @param int $pollId
	 * @return DataResponse
	 */
	public function clone($pollId) {
		return $this->response(function () use ($pollId) {
			$poll = $this->pollService->clone($pollId);
			$this->optionService->clone($pollId, $poll->getId());

			return $poll;
		});
	}

	/**
	 * Collect email addresses from particitipants
	 * @NoAdminRequired
	 * @param Array $poll
	 * @return DataResponse
	 */

	public function getParticipantsEmailAddresses($pollId) {
		return $this->response(function () use ($pollId) {
			return $this->pollService->getParticipantsEmailAddresses($pollId);
		});
		try {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
			return new DataResponse($this->pollService->getParticipantsEmailAddresses($pollId), Http::STATUS_OK);
		} catch (DoesNotExistException $e) {
			return new DataResponse(['error' => 'Poll not found'], Http::STATUS_NOT_FOUND);
		} catch (Exception $e) {
			return new DataResponse(['message' => $e->getMessage()], $e->getStatus());
		}
	}
}

nextcloud / polls

Pull Request — master (#1254)

PollController::getByToken() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
