create_edit.js ➔ deselectItem - Code Metrics - Inspection of "Changes" - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dartcafe-patch-1 ( f494f9...656c1d )

by René

created 2017-10-16 05:41 UTC

create_edit.js ➔ deselectItem B

↳ Parent: js/create_edit.js

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	24
rs	8.6845

var g_chosen_datetimes = [];
var g_chosen_texts = [];
var g_chosen_groups = [];
var g_chosen_users = [];
var chosen_type = 'event';
var access_type = '';
var isAnonymous;
var hideNames;

function selectItem(cell) {
	cell.removeClass('icon-close');

	cell.addClass('icon-checkmark');
	cell.removeClass('date-text-not-selected');
	cell.addClass('date-text-selected');
	if (cell.attr('class').indexOf('is-text') > -1) {
		var id = cell.attr('id');
		g_chosen_texts.push(id.substring(id.indexOf('_') + 1));
	} else {
		var dateId = cell.parent().attr('id'); //timestamp of date
		var timeId = cell.attr('id');
		g_chosen_datetimes.push(parseInt(dateId) + parseInt(timeId));
	}
}

function deselectItem(cell) {
	var id;

	var index;
	var dateId;
	var timeId;
	cell.removeClass('icon-checkmark');
	cell.addClass('icon-close');
	cell.removeClass('date-text-selected');
	cell.addClass('date-text-not-selected');
	if (cell.attr('class').indexOf('is-text') > -1) {
		id = cell.attr('id');
		index = g_chosen_texts.indexOf(id.substring(id.indexOf('_') + 1));
		if (index > -1) {
			g_chosen_texts.splice(index, 1);
		}
	} else {
		dateId = cell.parent().attr('id'); //timestamp of date
		timeId = cell.attr('id');
		index = g_chosen_datetimes.indexOf(parseInt(dateId) + parseInt(timeId));
		if (index > -1) {
			g_chosen_datetimes.splice(index, 1);
		}
	}
}

function insertText(text, set) {
	if (typeof set === 'undefined') {

		set = false;
	}
	var table = document.getElementById('selected-texts-table');
	var tr = table.insertRow(-1);
	var td = tr.insertCell(-1);
	td.innerHTML = text;
	td.className = 'text-row';
	td = tr.insertCell(-1);
	if (set) {
		td.className = 'icon-checkmark is-text date-text-selected';
	} else {
		td.className = 'icon-close is-text date-text-not-selected';
	}
	td.id = 'text_' + text;
}

function addRowToList(ts, text, timeTs) {
	if (typeof timeTs === 'undefined') {

		timeTs = -1;
	}
	var table = document.getElementById('selected-dates-table');
	var rows = table.rows;
	var td, tr, tdId;
	var i, j;
	var curr;
	if (rows.length == 0) {

		tr = table.insertRow(-1); //start new header
		tr.insertCell(-1);
		tr = table.insertRow(-1); //append new row
		tr.id = ts;
		tr.className = 'toggleable-row';
		td = tr.insertCell(-1);
		td.className = 'date-row';
		td.innerHTML = text;
		return;
	}
	for ( i=1; i<rows.length; i++) {
		curr = rows[i];
		if (curr.id == ts) {

			for (j=1; j<curr.cells.length; j++) {
				td = curr.cells[j];
				 tdId = curr.cells[j].id;
				if ( timeTs == tdId) {

					td.className = 'icon-checkmark date-text-selected';
				}
			}
			return; //already in table, cancel
		} else if (curr.id > ts) {
			tr = table.insertRow(i); //insert row at current index
			tr.id = ts;
			tr.className = 'toggleable-row';
			td = tr.insertCell(-1);
			td.className = 'date-row';
			td.innerHTML = text;
			for (j=1; j<rows[0].cells.length; j++) {
				tdId = rows[0].cells[j].id;
				td = tr.insertCell(-1);
				if (timeTs == tdId) {

					td.className = 'icon-checkmark date-text-selected';
				}  else { 
					td.className = 'icon-close date-text-not-selected';
				}
				td.id = tdId;
				td.innerHTML = '';
			}
			return;
		}
	}
	tr = table.insertRow(-1); //highest value, append new row
	tr.id = ts;
	tr.className = 'toggleable-row';
	td = tr.insertCell(-1);
	td.className = 'date-row';
	td.innerHTML = text;
	for (j=1; j<rows[0].cells.length; j++) {
		tdId = rows[0].cells[j].id;
		td = tr.insertCell(-1);
		if (timeTs == tdId) {

			td.className = 'icon-checkmark date-text-selected';
		} else {
			td.className = 'icon-close date-text-not-selected';
		}
		td.id = tdId;
		td.innerHTML = '';
	}
}

function addColToList(ts, text, dateTs) {
	if (typeof dateTs === 'undefined') {

		dateTs = -1;
	}
	var table = document.getElementById('selected-dates-table');
	var rows = table.rows;
	var tr, row, td, cells, tmpRow;
	var i, curr;
	var index = -1;
	if (rows.length == 0) {

		tr = table.insertRow(-1);
		tr.insertCell(-1);
	}
	rows = table.rows;
	tmpRow = rows[0];
	for (i=0; i<tmpRow.cells.length; i++) {
		curr = tmpRow.cells[i];
		if (curr.id == ts) {

			return; //already in table, cancel
		} else if (curr.id > ts) {
			index = i;
			break;
		}
	}

	for (i=0; i<rows.length; i++) {
		row = rows[i];
		cells = row.cells;
		td = row.insertCell(index);
		//only display time in header row
		if (i==0) {

			td.innerHTML = text;
			td.className = 'date-col';
		} else {
			td.innerHTML = '';
			if (row.id == dateTs) {

				td.className = 'icon-checkmark date-text-selected';
			} else { 
				td.className = 'icon-close date-text-not-selected';
			}
		}
		td.id = ts;
	}
}

function debounce(f, wait, immediate) {
	var timeout;

	return function() {
		var context = this;
		var args = arguments;
		var later = function() {
			timeout = null;
			if (!immediate) {
				f.apply(context, args);
			}
		};
		var callNow = immediate && !timeout;
		clearTimeout(timeout);

		timeout = setTimeout(later, wait);
		if (callNow) {
			f.apply(context, args);
		}
	}

}

$(document).ready(function () {
	// enable / disable date picker
	$('#id_expire_set').click(function(){

		$('#id_expire_date').prop("disabled", !this.checked);
		if (this.checked) {
		   $("#id_expire_date").focus();
		}
	});

	var anonOptions = document.getElementById('anonOptions');
	$('#hideNames').click(function() {
		hideNames = this.checked;
	});

	$('#isAnonymous').click(function() {
		isAnonymous = this.checked;
		if (isAnonymous) {
			anonOptions.style.display = 'inline';
		} else {
			anonOptions.style.display = 'none';
		}
	});

	var privateRadio = document.getElementById('private');
	var hiddenRadio = document.getElementById('hidden');
	var publicRadio = document.getElementById('public');
	var selectRadio = document.getElementById('select');
	if (privateRadio.checked) {
		access_type = 'registered';
	} else if (hiddenRadio.checked) {
		access_type = 'hidden';
	} else if (publicRadio.checked) {
		access_type = 'public';
	} else if (selectRadio.checked) {
		access_type = 'select';
	}

	isAnonymous = document.getElementById('isAnonymous').checked;
	hideNames = anonOptions.checked;

	var accessValues = document.getElementById('accessValues');
	if (accessValues.value.length > 0) {
		var list = document.getElementById('selected-search-list-id');
		var accessValueArr = accessValues.value.split(';');
		for (var i=0; i<accessValueArr.length; i++) {
			var val = accessValueArr[i];
			if (val == '') {

				continue;
			}
			var li = document.createElement('li');
			li.id = val;
			li.className = 'cl_item cl_access_item selected';
			var index = val.indexOf('group_');
			if (index == 0) {

				g_chosen_groups.push(val);
				li.className += ' is-group';
				li.appendChild(document.createTextNode(val.substring(6) + " (group)"));
				list.appendChild(li);
			} else {
				index = val.indexOf('user_');
				if (index == 0) {

					g_chosen_users.push(val);
					li.className = 'cl_item cl_access_item selected';
					var username = val.substring(5);
					$.post(OC.generateUrl('/apps/polls/get/displayname'), {username: username}, function(data) {
var funcs = [];
for (var i=0; i<10; i++) {
    funcs.push(function() {
        alert(i);
    });
}

funcs[0](); // alert(10);
funcs[1](); // alert(10);
/// ...
funcs[9](); // alert(10);
						li.appendChild(document.createTextNode(username + " (" + data + ")"));

						list.appendChild(li);
					});
				}
			}
		}
	}

	var chosenDates = document.getElementById('chosenDates').value;
	var chosen = '';
	if (chosenDates.length > 0) {
		chosen = JSON.parse(chosenDates);
	}
	var text = document.getElementById('text');
	var event = document.getElementById('event');
	if (event.checked) {
		chosen_type = event.value;
		if (chosenDates.length > 0) {
			g_chosen_datetimes = chosen;
		}
		for (var i=0; i<chosen.length; i++) {

			var date = new Date(chosen[i]*1000);
			var year = date.getFullYear();
			var month = date.getMonth();
			var day = date.getDate();
			var newDate = new Date(year, month, day).getTime(); //save timestamp without time of day
			month = '0' + (month+1); //month is 0-11, so +1
			day = '0' + day;
			var dateStr = day.substr(-2) + '.' + month.substr(-2) + '.' + year;
			var hours = date.getHours();
			var minutes = date.getMinutes();
			var ms = (hours * 60 * 60 * 1000) + (minutes * 60 * 1000); //time of day in milliseconds
			hours = '0' + hours;
			minutes = '0' + minutes;
			var timeStr = hours.substr(-2) + ':' + minutes.substr(-2);
			addRowToList(newDate/1000, dateStr, ms/1000);
			addColToList(ms/1000, timeStr, newDate/1000);
		}
	} else {
		chosen_type = text.value;
		if (chosenDates.length > 0) {
			g_chosen_texts = chosen;
		}
		for (var i=0; i<chosen.length; i++) {

			insertText(chosen[i], true);
		}
	}

	var expirepicker = jQuery('#id_expire_date').datetimepicker({

		inline: false,
		onSelectDate: function(date) {
			var year = date.getFullYear();
			var month = date.getMonth();
			var day = date.getDate();
			var newDate = new Date(year, month, day).getTime()/1000;
			document.getElementById('expireTs').value = newDate;
		},
		timepicker: false,
		format: 'd.m.Y'
	});

	var datepicker = jQuery('#datetimepicker').datetimepicker({

		inline:true,
		step: 15,
		todayButton: true,
		onSelectDate: function(date) {
			var year = date.getFullYear();
			var month = date.getMonth();
			var day = date.getDate();
			var newDate = new Date(year, month, day).getTime(); //save timestamp without time of day
			month = '0' + (month+1); //month is 0-11, so +1
			day = '0' + day;
			var dateStr = day.substr(-2) + '.' + month.substr(-2) + '.' + year;
			addRowToList(newDate/1000, dateStr);
		},
		onSelectTime: function(date) {
			var hours = date.getHours();
			var minutes = date.getMinutes();
			var ms = (hours * 60 * 60 * 1000) + (minutes * 60 * 1000); //time of day in milliseconds
			hours = '0' + hours;
			minutes = '0' + minutes;
			var timeStr = hours.substr(-2) + ':' + minutes.substr(-2);
			addColToList(ms/1000, timeStr);
		}
	});

	$(document).on('click', '.date-row', function() {
		var tr = $(this).parent();
		var dateId = parseInt(tr.attr('id'));
		var index = tr.index();
		var cells = tr[0].cells; //convert jQuery object to DOM
		for (var i=1; i<cells.length; i++) {
			var cell = cells[i];
			var delIndex = g_chosen_datetimes.indexOf(dateId + parseInt(cell.id));
			if (delIndex > -1) {
				g_chosen_datetimes.splice(delIndex, 1);
			}
		}
		var table = document.getElementById('selected-dates-table');
		table.deleteRow(index);
	});

	$(document).on('click', '.date-col', function() {
		var cellIndex = $(this).index();
		var timeId = parseInt($(this).attr('id'));
		var table = document.getElementById('selected-dates-table');
		var rows = table.rows;
		rows[0].deleteCell(cellIndex);
		for (var i=1; i<rows.length; i++) {
			var row = rows[i];
			var delIndex = g_chosen_datetimes.indexOf(parseInt(row.id) + timeId);
			if (delIndex > -1) {
				g_chosen_datetimes.splice(delIndex, 1);
			}
			row.deleteCell(cellIndex);
		}
	});

	$(document).on('click', '.text-row', function() {
		var tr = $(this).parent();
		var rowIndex = tr.index();
		var name = $(this).html();
		var delIndex = g_chosen_texts.indexOf(name);
		if (delIndex > -1) {
			g_chosen_texts.splice(delIndex, 1);
		}
		var table = document.getElementById('selected-texts-table');
		table.deleteRow(rowIndex);
	});

	$(document).on('click', '.icon-close', function() {
		selectItem($(this));
	});

	$(document).on('click', '.icon-checkmark', function() {
		deselectItem($(this));
	});

	$(document).on('click', '#text-submit', function() {
		var text = document.getElementById('text-title');
		if (text.value.length == 0) {

			alert('Please enter a text!');
			return false;
		}
		insertText(text.value);
		text.value = '';

	});

	$(document).on('click', '.cl_item', function() {
		var index;
		var list = document.getElementById('selected-search-list-id');
		var isGroup = $(this).hasClass('is-group');
		if ($(this).hasClass('selected')) {
			if (isGroup) {
				index = g_chosen_groups.indexOf(this.id);
			}
			else { 
				index = g_chosen_users.indexOf(this.id);
			}
			if (index > -1) {
				if (isGroup) {
					g_chosen_groups.splice(index, 1);
				}
				else {
					g_chosen_users.splice(index, 1);
				}
				$(this).remove();
			}
		} else {
			if (!isGroup) {
				var text = this.id.replace('user_', '');
				g_chosen_users.push(this.id);
			} else {
				g_chosen_groups.push(this.id);
			}
			document.getElementById('user-group-search-box').value = '';
			var li = document.createElement('li');
			li.id = this.id;
			li.className = 'cl_item cl_access_item selected' + (isGroup ? ' is-group' : '');
			if (!isGroup) {
				$.post(OC.generateUrl('/apps/polls/get/displayname'), {username: text}, function(data) {
function someFunction() {
    (function() {
        var i = 0;
    })();

    // i is not defined.
    alert(i);
}

// This can be fixed by moving the var statement to the outer scope.

function someFunction() {
    var i;
    (function() {
        i = 1;
    })();

    alert(i);
};
					li.appendChild(document.createTextNode(text + " (" + data + ")"));

					list.appendChild(li);
				});
			} else {
				li.appendChild(document.createTextNode($(this).html()));
				list.appendChild(li);
			}
			$(this).remove();
		}
	});

	$('.toggleable-row').hover(
		function() {
			var td = this.insertCell(-1);
			td.className = 'toggle-all selected-all';
		}, function() {
			$(this).find('td:last-child').remove();
		}
	);

	$(document).on('click', '.toggle-all', function() {
		var children;
		var i;
		if ($(this).attr('class').indexOf('selected-all') > -1) {
			children = $(this).parent().children('.icon-checkmark');
			for (i=0; i<children.length; i++) {
				deselectItem($(children[i]));
			}
			$(this).removeClass('selected-all');
			$(this).addClass('selected-none');
		} else {
			children = $(this).parent().children('.icon-close');
			for (i=0; i<children.length; i++) {
				selectItem($(children[i]));
			}
			$(this).removeClass('selected-none');
			$(this).addClass('selected-all');
		}
	});

	$('input[type=radio][name=pollType]').change(function() {
		if (this.value == 'event') {

			chosen_type = 'event';
			document.getElementById('text-select-container').style.display = 'none';
			document.getElementById('date-select-container').style.display = 'inline';
		} else {
			chosen_type = 'text';
			document.getElementById('text-select-container').style.display = 'inline';
			document.getElementById('date-select-container').style.display = 'none';
		}
	});

	$('input[type=radio][name=accessType]').click(function() {
		access_type = this.value;
		if (access_type == 'select') {

			$("#access_rights").show();
			$("#selected_access").show();
		} else {
			$("#access_rights").hide();
			$("#selected_access").hide();
		}
	});

	$('input[type=checkbox][name=check_expire]').change(function() {
		if (!$(this).is(':checked')) {
			document.getElementById('expireTs').value = '';
		}
	});

	$('#user-group-search-box').on('input', debounce(function() {
		var ul = document.getElementById('live-search-list-id');
		while(ul.firstChild) {
			ul.removeChild(ul.firstChild);
		}
		var val = $(this).val();
		if (val.length < 3) {
			return;
		}
		var formData = {
			searchTerm: val,
			groups: JSON.stringify(g_chosen_groups),
			users: JSON.stringify(g_chosen_users);

		}
		$.post(OC.generateUrl('/apps/polls/search'), formData, function(data) {

			for (var i=0; i<data.length; i++) {
				var ug = data[i];
				var li = document.createElement('li');
				li.className = 'cl_item cl_access_item';
				if (ug.isGroup) {
					li.id = 'group_' + ug.gid;
					li.className += ' is-group';
					li.appendChild(document.createTextNode(ug.gid + " (group)"));
					ul.appendChild(li);
				} else {
					li.id = 'user_' + ug.uid;
					li.appendChild(document.createTextNode(ug.uid + " (" + ug.displayName + ")"));
					var span = document.createElement('span');
					span.id = 'sec_name';
					span.appendChild(document.createTextNode(ug.uid));
					li.appendChild(span);
					ul.appendChild(li);
				}
			}
		});

	}, 250));
function someFunction(x) {
    (x > 0) ? callFoo() : callBar();
}

// JSHint expects you to assign the result to a variable:
function someFunction(x) {
    var rs = (x > 0) ? callFoo() : callBar();
}

// If you do not use the result, you could also use if statements in the
// case above.
function someFunction(x) {
    if (x > 0) {
        callFoo();
    } else {
        callBar();
    }
}

	$('.live-search-list-user li').each(function(){
	$(this).attr('data-search-term', $(this).text().toLowerCase());

	});

	$('.live-search-box-user').on('keyup', function(){
	var searchTerm = $(this).val().toLowerCase();

		$('.live-search-list-user li').each(function(){
			if ($(this).filter('[data-search-term *= ' + searchTerm + ']').length > 0  || searchTerm.length < 1) {
				$(this).show();
			} else {
				$(this).hide();
			}
		});
	});

	$('.live-search-list-group li').each(function(){
		$(this).attr('data-search-term', $(this).text().toLowerCase());

	});
 
	$('.live-search-box-group').on('keyup', function(){
	var searchTerm = $(this).val().toLowerCase();

		$('.live-search-list-group li').each(function(){
			if ($(this).filter('[data-search-term *= ' + searchTerm + ']').length > 0 || searchTerm.length < 1) {
				$(this).show();
			} else {
				$(this).hide();
			}
		});
	}); 

	var form = document.finish_poll;
	var submit_finish_poll = document.getElementById('submit_finish_poll');
	if (submit_finish_poll != null) {

		submit_finish_poll.onclick = function() {
			if (g_chosen_datetimes.length === 0 && g_chosen_texts.length == 0) {

				alert(t('polls', 'Nothing selected!\nClick on cells to turn them green.'));
				return false;
			}
			if (chosen_type == 'event') {

				form.elements.chosenDates.value = JSON.stringify(g_chosen_datetimes);
			}
			else {
				form.elements['chosenDates'].value = JSON.stringify(g_chosen_texts);
var obj = { };
obj['foo'] = 'bar'; // Bad
obj.foo = 'bar'; // Good
			}
			var title = document.getElementById('pollTitle');
			if (title == null || title.value.length == 0) {

				alert(t('polls', 'You must enter at least a title for the new poll.'));
				return false;
			}

			if (access_type == 'select') {

				if (g_chosen_groups.length == 0 && g_chosen_users == 0) {

					alert(t('polls', 'Please select at least one user or group!'));
					return false;
				}
				form.elements.accessValues.value = JSON.stringify({
					groups: g_chosen_groups,
					users: g_chosen_users
				});
			}
			form.elements.isAnonymous.value = isAnonymous;
			form.elements.hideNames.value = hideNames;
			form.submit();

		};
	}

});



1			var g_chosen_datetimes = [];
2			var g_chosen_texts = [];
3			var g_chosen_groups = [];
4			var g_chosen_users = [];
5			var chosen_type = 'event';
6			var access_type = '';
7			var isAnonymous;
8			var hideNames;
9
10			function selectItem(cell) {
11			cell.removeClass('icon-close');
			0 ignored issues – show Coding Style introduced 2017-10-15 17:01 UTC by Report Bug Copy Issue Report This function should enable strict mode with `use strict`. Strict mode is a way to opt-in to a restricted variant of JavaScript. It eliminates some common pitfalls by being less lenient and raising more errors. Besides, it is also used to fix certain mistakes which made it difficult for JavaScript runtimes to perform certain optimizations. We generally recommend to only enable strict mode on the function scope and not in the global scope as that might break third-party scripts on your website. Loading history...
12			cell.addClass('icon-checkmark');
13			cell.removeClass('date-text-not-selected');
14			cell.addClass('date-text-selected');
15			if (cell.attr('class').indexOf('is-text') > -1) {
16			var id = cell.attr('id');
17			g_chosen_texts.push(id.substring(id.indexOf('_') + 1));
18			} else {
19			var dateId = cell.parent().attr('id'); //timestamp of date
20			var timeId = cell.attr('id');
21			g_chosen_datetimes.push(parseInt(dateId) + parseInt(timeId));
22			}
23			}
24
25			function deselectItem(cell) {
26			var id;
			0 ignored issues – show Coding Style introduced 2017-10-16 05:43 UTC by Report Bug Copy Issue Report This function should enable strict mode with `use strict`. Strict mode is a way to opt-in to a restricted variant of JavaScript. It eliminates some common pitfalls by being less lenient and raising more errors. Besides, it is also used to fix certain mistakes which made it difficult for JavaScript runtimes to perform certain optimizations. We generally recommend to only enable strict mode on the function scope and not in the global scope as that might break third-party scripts on your website. Loading history...
27			var index;
28			var dateId;
29			var timeId;
30			cell.removeClass('icon-checkmark');
31			cell.addClass('icon-close');
32			cell.removeClass('date-text-selected');
33			cell.addClass('date-text-not-selected');
34			if (cell.attr('class').indexOf('is-text') > -1) {
35			id = cell.attr('id');
36			index = g_chosen_texts.indexOf(id.substring(id.indexOf('_') + 1));
37			if (index > -1) {
38			g_chosen_texts.splice(index, 1);

nextcloud / polls

Push — dartcafe-patch-1 ( f494f9...656c1d )

create_edit.js ➔ deselectItem B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like