PageControllerTest::setUp() - Code Metrics - Inspection of "Merge pull request #423 from nextcloud/better-emai..." - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 272230...88722c )

by René

created 2018-11-25 17:38 UTC

PageControllerTest::setUp() B

↳ Parent: PageControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	68
Code Lines	66

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	66
nc	1
nop	0
dl	0
loc	68
rs	8.7418
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * @copyright Copyright (c) 2017 Kai Schröer <[email protected]>
 *
 * @author Kai Schröer <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Polls\Tests\Unit\Controller;

use OCA\Polls\Controller\PageController;
use OCA\Polls\Tests\Unit\UnitTestCase;
use OCP\AppFramework\Http\TemplateResponse;

class PageControllerTest extends UnitTestCase {

	/** @var PageController */
	private $controller;

	private $userId = 'john';

	/**
	 * {@inheritDoc}
	 */
	public function setUp() {
		$avatarManager = $this->getMockBuilder('OCP\IAvatarManager')
			->disableOriginalConstructor()
			->getMock();
		$config = $this->getMockBuilder('OCP\IConfig')
			->disableOriginalConstructor()
			->getMock();
		$groupManager = $this->getMockBuilder('OCP\IGroupManager')
			->disableOriginalConstructor()
			->getMock();
		$l10n = $this->getMockBuilder('OCP\IL10N')
			->disableOriginalConstructor()
			->getMock();
		$logger = $this->getMockBuilder('OCP\ILogger')
			->disableOriginalConstructor()
			->getMock();
		$request = $this->getMockBuilder('OCP\IRequest')
			->disableOriginalConstructor()
			->getMock();
		$urlGenerator = $this->getMockBuilder('OCP\IURLGenerator')
			->disableOriginalConstructor()
			->getMock();
		$user = $this->getMockBuilder('OCP\IUser')

			->disableOriginalConstructor()
			->getMock();
		$userManager = $this->getMockBuilder('OCP\IUserManager')
			->disableOriginalConstructor()
			->getMock();
		$transFactory = $this->getMockBuilder('OCP\L10N\IFactory')
			->disableOriginalConstructor()
			->getMock();
		$mailer = $this->getMockBuilder('OCP\Mail\IMailer')
			->disableOriginalConstructor()
			->getMock();
		$commentMapper = $this->getMockBuilder('OCA\Polls\Db\CommentMapper')
			->disableOriginalConstructor()
			->getMock();
		$optionsMapper = $this->getMockBuilder('OCA\Polls\Db\OptionsMapper')
			->disableOriginalConstructor()
			->getMock();
		$eventMapper = $this->getMockBuilder('OCA\Polls\Db\EventMapper')
			->disableOriginalConstructor()
			->getMock();
		$notificationMapper = $this->getMockBuilder('OCA\Polls\Db\NotificationMapper')
			->disableOriginalConstructor()
			->getMock();
		$votesMapper = $this->getMockBuilder('OCA\Polls\Db\VotesMapper')
			->disableOriginalConstructor()
			->getMock();

		$this->controller = new PageController(
			'polls',
			$request,
			$config,
			$userManager,
			$groupManager,
			$avatarManager,
			$logger,
			$l10n,
			$transFactory,
			$urlGenerator,
			$this->userId,
			$commentMapper,
			$optionsMapper,
			$eventMapper,
			$notificationMapper,
			$votesMapper,
			$mailer
		);
	}

	/**
	 * Basic controller index route test.
	 */
	public function testIndex() {
		$result = $this->controller->index();

		$this->assertEquals('main.tmpl', $result->getTemplateName());
		$this->assertInstanceOf(TemplateResponse::class, $result);
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2017 Kai Schröer <[email protected]>
4			*
5			* @author Kai Schröer <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Polls\Tests\Unit\Controller;
25
26			use OCA\Polls\Controller\PageController;
27			use OCA\Polls\Tests\Unit\UnitTestCase;
28			use OCP\AppFramework\Http\TemplateResponse;
29
30			class PageControllerTest extends UnitTestCase {
31
32			/** @var PageController */
33			private $controller;
34
35			private $userId = 'john';
36
37			/**
38			* {@inheritDoc}
39			*/
40			public function setUp() {
41			$avatarManager = $this->getMockBuilder('OCP\IAvatarManager')
42			->disableOriginalConstructor()
43			->getMock();
44			$config = $this->getMockBuilder('OCP\IConfig')
45			->disableOriginalConstructor()
46			->getMock();
47			$groupManager = $this->getMockBuilder('OCP\IGroupManager')
48			->disableOriginalConstructor()
49			->getMock();
50			$l10n = $this->getMockBuilder('OCP\IL10N')
51			->disableOriginalConstructor()
52			->getMock();
53			$logger = $this->getMockBuilder('OCP\ILogger')
54			->disableOriginalConstructor()
55			->getMock();
56			$request = $this->getMockBuilder('OCP\IRequest')
57			->disableOriginalConstructor()
58			->getMock();
59			$urlGenerator = $this->getMockBuilder('OCP\IURLGenerator')
60			->disableOriginalConstructor()
61			->getMock();
62			$user = $this->getMockBuilder('OCP\IUser')
			0 ignored issues – show Unused Code introduced 2018-11-16 06:24 UTC by Report Bug Copy Issue Report The assignment to `$user` is dead and can be removed. Loading history...
63			->disableOriginalConstructor()
64			->getMock();
65			$userManager = $this->getMockBuilder('OCP\IUserManager')
66			->disableOriginalConstructor()
67			->getMock();
68			$transFactory = $this->getMockBuilder('OCP\L10N\IFactory')
69			->disableOriginalConstructor()
70			->getMock();
71			$mailer = $this->getMockBuilder('OCP\Mail\IMailer')
72			->disableOriginalConstructor()
73			->getMock();
74			$commentMapper = $this->getMockBuilder('OCA\Polls\Db\CommentMapper')
75			->disableOriginalConstructor()
76			->getMock();
77			$optionsMapper = $this->getMockBuilder('OCA\Polls\Db\OptionsMapper')
78			->disableOriginalConstructor()
79			->getMock();
80			$eventMapper = $this->getMockBuilder('OCA\Polls\Db\EventMapper')
81			->disableOriginalConstructor()
82			->getMock();
83			$notificationMapper = $this->getMockBuilder('OCA\Polls\Db\NotificationMapper')
84			->disableOriginalConstructor()
85			->getMock();
86			$votesMapper = $this->getMockBuilder('OCA\Polls\Db\VotesMapper')
87			->disableOriginalConstructor()
88			->getMock();
89
90			$this->controller = new PageController(
91			'polls',
92			$request,
93			$config,
94			$userManager,
95			$groupManager,
96			$avatarManager,
97			$logger,
98			$l10n,
99			$transFactory,
100			$urlGenerator,
101			$this->userId,
102			$commentMapper,
103			$optionsMapper,
104			$eventMapper,
105			$notificationMapper,
106			$votesMapper,
107			$mailer
108			);
109			}
110
111			/**
112			* Basic controller index route test.
113			*/
114			public function testIndex() {
115			$result = $this->controller->index();
116
117			$this->assertEquals('main.tmpl', $result->getTemplateName());
118			$this->assertInstanceOf(TemplateResponse::class, $result);
119			}
120			}
121

nextcloud / polls

Push — master ( 272230...88722c )

PageControllerTest::setUp() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like