PollController::__construct() - Code Metrics - Inspection of "Merge pull request #731 from nextcloud/clonePoll" - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 432e3d...cf972b )

by René
created 2020-01-12 15:08 UTC
PollController::__construct() A

↳ Parent: PollController
Complexity

Conditions	1
Paths	1
Size

Total Lines	27
Code Lines	12
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
cc	1
eloc	12
nc	1
nop	13
dl	0
loc	27
ccs	0
cts	27
cp	0
crap	2
rs	9.8666
c	0
b	0
f	0
How to fix Many Parameters

<?php
/**
 * @copyright Copyright (c) 2017 Vinzenz Rosenkranz <[email protected]>
 *
 * @author René Gieling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Polls\Controller;

use Exception;
use OCP\AppFramework\Db\DoesNotExistException;

use OCP\IRequest;
use OCP\ILogger;
use OCP\IL10N;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;

use OCP\IGroupManager;
use OCP\IUser;
use OCP\IUserManager;
use OCP\Security\ISecureRandom;

use OCA\Polls\Db\Poll;
use OCA\Polls\Db\PollMapper;
use OCA\Polls\Db\Option;
use OCA\Polls\Db\OptionMapper;
use OCA\Polls\Service\LogService;
use OCA\Polls\Service\MailService;
use OCA\Polls\Model\Acl;

class PollController extends Controller {

	private $userId;
	private $pollMapper;
	private $trans;
	private $logger;
	private $groupManager;
	private $userManager;
	private $poll;
	private $logService;
	private $mailService;
	private $acl;

	/**
	 * CommentController constructor.
	 * @param string $appName
	 * @param $userId
	 * @param IRequest $request
	 * @param ILogger $logger
	 * @param IL10N $trans
	 * @param PollMapper $pollMapper
	 * @param OptionsMapper $optionMapper
filter:
    dependency_paths: ["lib/*"]
	 * @param IGroupManager $groupManager
	 * @param IUserManager $userManager
	 * @param LogService $logService
	 * @param MailService $mailService
	 * @param Acl $acl
	 */

	public function __construct(
		string $appName,
		$userId,
		IRequest $request,
		ILogger $logger,
		IL10N $trans,
		PollMapper $pollMapper,
		OptionMapper $optionMapper,
		Poll $poll,
		IGroupManager $groupManager,
		IUserManager $userManager,
		LogService $logService,
		MailService $mailService,
		Acl $acl
	) {
		parent::__construct($appName, $request);
		$this->userId = $userId;
		$this->trans = $trans;
		$this->pollMapper = $pollMapper;
		$this->optionMapper = $optionMapper;

		$this->logger = $logger;
		$this->groupManager = $groupManager;
		$this->userManager = $userManager;
		$this->poll = $poll;
		$this->logService = $logService;
		$this->mailService = $mailService;
		$this->acl = $acl;
	}

	/**
	 * list
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 * @return DataResponse
	 */

	public function list() {
		if (\OC::$server->getUserSession()->isLoggedIn()) {
			try {
				$polls = array_values(array_filter($this->pollMapper->findAll(), function($item) {
					return $this->acl->setPollId($item->getId())->getAllowView();
				}));
				return new DataResponse($polls, Http::STATUS_OK);
			} catch (DoesNotExistException $e) {
				return new DataResponse($e, Http::STATUS_NOT_FOUND);
			}
		}
	}

	/**
	 * get
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 * @param integer $pollId
	 * @return array
	 */
 	public function get($pollId) {

 		try {
			if (!$this->acl->getFoundByToken()) {
				$this->acl->setPollId($pollId);
			}
			$this->poll = $this->pollMapper->find($pollId);

			return new DataResponse([
				'poll' => $this->poll,
				'acl' => $this->acl
			], Http::STATUS_OK);

		} catch (DoesNotExistException $e) {
			$this->logger->info('Poll ' . $pollId . ' not found!', ['app' => 'polls']);
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
 		}
 	}

	/**
	 * getByToken
	 * Read all options of a poll based on a share token and return list as array
	 * @NoAdminRequired
	 * @PublicPage
	 * @NoCSRFRequired
	 * @param string $token
	 * @return DataResponse
	 */
	public function getByToken($token) {

		try {
			return $this->get($this->acl->setToken($token)->getPollId());
		} catch (DoesNotExistException $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}

	}

	/**
	 * delete
	 * @NoAdminRequired
	 * @param Array $poll
	 * @return DataResponse
	 */

	public function delete($pollId) {

		try {
			// Find existing poll
			$this->poll = $this->pollMapper->find($pollId);
			$this->acl->setPollId($this->poll->getId());

			if (!$this->acl->getAllowEdit()) {
				$this->logger->alert('Unauthorized delete attempt from user ' . $this->userId);
				return new DataResponse(['message' => 'Unauthorized write attempt.'], Http::STATUS_UNAUTHORIZED);
			}

			if ($this->poll->getDeleted()) {
				$this->poll->setDeleted(0);
			} else {
				$this->poll->setDeleted(time());
			}

			$this->pollMapper->update($this->poll);
			$this->logService->setLog($this->poll->getId(), 'deletePoll');
			return new DataResponse([
				'deleted' => $pollId
			], Http::STATUS_OK);

		} catch (Exception $e) {
			return new DataResponse($e, Http::STATUS_NOT_FOUND);
		}
	}

	/**
	 * write
	 * @NoAdminRequired
	 * @param Array $poll
	 * @return DataResponse
	 */

	public function write($poll) {

		try {
			// Find existing poll
			$this->poll = $this->pollMapper->find($poll['id']);
			$this->acl->setPollId($this->poll->getId());
			if (!$this->acl->getAllowEdit()) {
				$this->logger->alert('Unauthorized write attempt from user ' . $this->userId);
				return new DataResponse(['message' => 'Unauthorized write attempt.'], Http::STATUS_UNAUTHORIZED);
			}

		} catch (Exception $e) {
			$this->poll = new Poll();

			$this->poll->setType($poll['type']);
			$this->poll->setOwner($this->userId);
			$this->poll->setCreated(time());
		} finally {
			$this->poll->setTitle($poll['title']);
			$this->poll->setDescription($poll['description']);
			$this->poll->setAccess($poll['access']);
			$this->poll->setExpire($poll['expire']);
			$this->poll->setAnonymous(intval($poll['anonymous']));
			$this->poll->setFullAnonymous(intval($poll['fullAnonymous']) * $this->poll->getAnonymous());
			$this->poll->setAllowMaybe(intval($poll['allowMaybe']));
			$this->poll->setVoteLimit(intval($poll['voteLimit']));
			$this->poll->setSettings('');
			$this->poll->setOptions('');
			$this->poll->setShowResults($poll['showResults']);
			$this->poll->setDeleted($poll['deleted']);
			$this->poll->setAdminAccess($poll['adminAccess']);

			if ($this->poll->getId() > 0) {
				$this->pollMapper->update($this->poll);
				$this->logService->setLog($this->poll->getId(), 'updatePoll');
			} else {
				$this->pollMapper->insert($this->poll);
				$this->logService->setLog($this->poll->getId(), 'addPoll');
			}
			$this->acl->setPollId($this->poll->getId());
			return new DataResponse([
				'poll' => $this->poll,
				'acl' => $this->acl
			], Http::STATUS_OK);
		}
	}

	/**
	 * clone
	 * @NoAdminRequired
	 * @param integer $pollId
	 * @return DataResponse
	 */
	public function clone($pollId) {
		$this->poll = $this->pollMapper->find($pollId);

		$clonePoll = new Poll();
		$clonePoll->setOwner($this->userId);
		$clonePoll->setCreated(time());
		$clonePoll->setTitle('Clone of ' . $this->poll->getTitle());
		$clonePoll->setDeleted(0);

		$clonePoll->setType($this->poll->getType());
		$clonePoll->setDescription($this->poll->getDescription());
		$clonePoll->setAccess($this->poll->getAccess());
		$clonePoll->setExpire($this->poll->getExpire());
		$clonePoll->setExpire(/** @scrutinizer ignore-type */ $this->poll->getExpire());
		$clonePoll->setAnonymous(intval($this->poll->getAnonymous()));
		$clonePoll->setFullAnonymous(intval($this->poll->getFullAnonymous())  * $clonePoll->getAnonymous());
		$clonePoll->setAllowMaybe(intval($this->poll->getAllowMaybe()));
		$clonePoll->setVoteLimit(intval($this->poll->getVoteLimit()));
		$clonePoll->setSettings('');
		$clonePoll->setOptions('');
		$clonePoll->setShowResults($this->poll->getShowResults());
		$clonePoll->setAdminAccess($this->poll->getAdminAccess());

		$this->pollMapper->insert($clonePoll);
		$this->logService->setLog($clonePoll->getId(), 'addPoll');

		foreach ($this->optionMapper->findByPoll($pollId) as $option) {
			$newOption = new Option();
			$newOption->setPollId($clonePoll->getId());
			$newOption->setPollOptionText($option->getPollOptionText());
			$newOption->setTimestamp($option->getTimestamp());

			$this->optionMapper->insert($newOption);
		}
		return new DataResponse([
			'pollId' => $clonePoll->getId()
		], Http::STATUS_OK);

	}

}

nextcloud / polls

Push — master ( 432e3d...cf972b )

PollController::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
