OCA\Polls\Model\User

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getUserIsDisabled()	0	2	1
A	listRaw()	0	2	1
A	__construct()	0	13	1
A	search()	0	8	3

<?php
/**
 * @copyright Copyright (c) 2017 Vinzenz Rosenkranz <vinzenz.rosenkranz@gmail.com>
 *
 * @author René Gieling <github@dartcafe.de>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */


namespace OCA\Polls\Model;


class User extends UserGroupClass  {
	public const TYPE = 'user';
	public const ICON = 'icon-user';

	/**
	 * User constructor.
	 * @param $id
	 */
	public function __construct(
		$id
	) {
		parent::__construct($id, self::TYPE);
		$this->icon = self::ICON;
		$this->isNoUser = false;

The property $isNoUser was declared of type string, but false is of type false. Maybe add a type cast?

		$this->user = \OC::$server->getUserManager()->get($this->id);

The property user does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->language = \OC::$server->getConfig()->getUserValue($this->id, 'core', 'lang');

		$this->displayName = \OC::$server->getUserManager()->get($this->id)->getDisplayName();
		$this->description = \OC::$server->getL10N('polls')->t('User');
		$this->emailAddress = $this->user->getEMailAddress();
	}

	/**
	 * getUserIsDisabled
	 * @NoAdminRequired
	 * @return Boolean
	 */
	public function getUserIsDisabled() {
		return !\OC::$server->getUserManager()->get($this->id)->isEnabled();
	}

	/**
	 * listRaw
	 * @NoAdminRequired
	 * @param string $query
	 * @return Array
	 */
	public static function listRaw($query = '') {
		return \OC::$server->getUserManager()->search($query);
	}

	/**
	 * search
	 * @NoAdminRequired
	 * @param string $query
	 * @param array $skip - group names to skip in return array
	 * @return User[]
	 */
	public static function search($query = '', $skip = []) {
		$users = [];
		foreach (self::listRaw($query) as $user) {
			if (!in_array($user->getUID(), $skip)) {
				$users[] = new Self($user->getUID());
			}
		}
		return $users;
	}
}