nextcloud /
polls
| Conditions | 22 |
| Paths | 128 |
| Total Lines | 68 |
| Code Lines | 37 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 45 | public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) { |
||
| 46 | /** @var ISchemaWrapper $schema */ |
||
| 47 | $schema = $schemaClosure(); |
||
| 48 | |||
| 49 | if ($schema->hasTable('polls_options')) { |
||
| 50 | $table = $schema->getTable('polls_options'); |
||
| 51 | foreach ($table->getIndexes() as $index) { |
||
| 52 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 53 | $table->dropIndex($index->getName()); |
||
| 54 | } |
||
| 55 | } |
||
| 56 | } |
||
| 57 | |||
| 58 | if ($schema->hasTable('polls_log')) { |
||
| 59 | $table = $schema->getTable('polls_log'); |
||
| 60 | foreach ($table->getIndexes() as $index) { |
||
| 61 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 62 | $table->dropIndex($index->getName()); |
||
| 63 | } |
||
| 64 | } |
||
| 65 | } |
||
| 66 | |||
| 67 | if ($schema->hasTable('polls_notif')) { |
||
| 68 | $table = $schema->getTable('polls_notif'); |
||
| 69 | foreach ($table->getIndexes() as $index) { |
||
| 70 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 71 | $table->dropIndex($index->getName()); |
||
| 72 | } |
||
| 73 | } |
||
| 74 | } |
||
| 75 | |||
| 76 | if ($schema->hasTable('polls_share')) { |
||
| 77 | $table = $schema->getTable('polls_share'); |
||
| 78 | foreach ($table->getIndexes() as $index) { |
||
| 79 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 80 | $table->dropIndex($index->getName()); |
||
| 81 | } |
||
| 82 | } |
||
| 83 | } |
||
| 84 | |||
| 85 | if ($schema->hasTable('polls_votes')) { |
||
| 86 | $table = $schema->getTable('polls_votes'); |
||
| 87 | foreach ($table->getIndexes() as $index) { |
||
| 88 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 89 | $table->dropIndex($index->getName()); |
||
| 90 | } |
||
| 91 | } |
||
| 92 | } |
||
| 93 | |||
| 94 | if ($schema->hasTable('polls_preferences')) { |
||
| 95 | $table = $schema->getTable('polls_preferences'); |
||
| 96 | foreach ($table->getIndexes() as $index) { |
||
| 97 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 98 | $table->dropIndex($index->getName()); |
||
| 99 | } |
||
| 100 | } |
||
| 101 | } |
||
| 102 | |||
| 103 | if ($schema->hasTable('polls_watch')) { |
||
| 104 | $table = $schema->getTable('polls_watch'); |
||
| 105 | foreach ($table->getIndexes() as $index) { |
||
| 106 | if (strpos($index->getName(), 'UNIQ_') === 0) { |
||
| 107 | $table->dropIndex($index->getName()); |
||
| 108 | } |
||
| 109 | } |
||
| 110 | } |
||
| 111 | |||
| 112 | return $schema; |
||
| 113 | } |
||
| 115 |
