Inspection of "[WIP] Unit tests" - nextcloud/polls - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#224)

by Kai

created 2017-10-28 17:50 UTC

Status

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -29,17 +29,17 @@
 block discarded – undo
 
 class ParticipationMapperTest extends UnitTestCase {
 
-	/** @var IDBConnection */
-	private $con;
-	/** @var ParticipationMapper */
-	private $participationMapper;
+    /** @var IDBConnection */
+    private $con;
+    /** @var ParticipationMapper */
+    private $participationMapper;
 
-	/**
-	 * {@inheritDoc}
-	 */
-	public function setUp() {
-		parent::setUp();
-		$this->con = \OC::$server->getDatabaseConnection();
-		$this->participationMapper = new ParticipationMapper($this->con);
-	}
+    /**
+     * {@inheritDoc}
+     */
+    public function setUp() {
+        parent::setUp();
+        $this->con = \OC::$server->getDatabaseConnection();
+        $this->participationMapper = new ParticipationMapper($this->con);
+    }
 }

Please login to merge, or discard this patch.

tests/Unit/Db/TextMapperTest.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -29,17 +29,17 @@
 block discarded – undo
 
 class TextMapperTest extends UnitTestCase {
 
-	/** @var IDBConnection */
-	private $con;
-	/** @var TextMapper */
-	private $textMapper;
+    /** @var IDBConnection */
+    private $con;
+    /** @var TextMapper */
+    private $textMapper;
 
-	/**
-	 * {@inheritDoc}
-	 */
-	public function setUp() {
-		parent::setUp();
-		$this->con = \OC::$server->getDatabaseConnection();
-		$this->textMapper = new TextMapper($this->con);
-	}
+    /**
+     * {@inheritDoc}
+     */
+    public function setUp() {
+        parent::setUp();
+        $this->con = \OC::$server->getDatabaseConnection();
+        $this->textMapper = new TextMapper($this->con);
+    }
 }

Please login to merge, or discard this patch.

tests/Unit/Controller/PageControllerTest.php 1 patch

Indentation +76 added lines, -76 removed lines patch added patch discarded remove patch

@@ -29,85 +29,85 @@
 block discarded – undo
 
 class PageControllerTest extends UnitTestCase {
 
-	/** @var PageController */
-	private $controller;
+    /** @var PageController */
+    private $controller;
 
-	private $userId = 'john';
+    private $userId = 'john';
 
-	/**
-	 * {@inheritDoc}
-	 */
-	public function setUp() {
-		$request = $this->getMockBuilder('OCP\IRequest')
-			->disableOriginalConstructor()
-			->getMock();
-		$userManager = $this->getMockBuilder('OCP\IUserManager')
-			->disableOriginalConstructor()
-			->getMock();
-		$groupManager = $this->getMockBuilder('OCP\IGroupManager')
-			->disableOriginalConstructor()
-			->getMock();
-		$avatarManager = $this->getMockBuilder('OCP\IAvatarManager')
-			->disableOriginalConstructor()
-			->getMock();
-		$logger = $this->getMockBuilder('OCP\ILogger')
-			->disableOriginalConstructor()
-			->getMock();
-		$l10n = $this->getMockBuilder('OCP\IL10N')
-			->disableOriginalConstructor()
-			->getMock();
-		$urlGenerator = $this->getMockBuilder('OCP\IURLGenerator')
-			->disableOriginalConstructor()
-			->getMock();
-		$commentMapper = $this->getMockBuilder('OCA\Polls\Db\CommentMapper')
-			->disableOriginalConstructor()
-			->getMock();
-		$dateMapper = $this->getMockBuilder('OCA\Polls\Db\DateMapper')
-			->disableOriginalConstructor()
-			->getMock();
-		$eventMapper = $this->getMockBuilder('OCA\Polls\Db\EventMapper')
-			->disableOriginalConstructor()
-			->getMock();
-		$notificationMapper = $this->getMockBuilder('OCA\Polls\Db\NotificationMapper')
-			->disableOriginalConstructor()
-			->getMock();
-		$participationMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationMapper')
-			->disableOriginalConstructor()
-			->getMock();
-		$participationTextMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationTextMapper')
-			->disableOriginalConstructor()
-			->getMock();
-		$textMapper = $this->getMockBuilder('OCA\Polls\Db\TextMapper')
-			->disableOriginalConstructor()
-			->getMock();
+    /**
+     * {@inheritDoc}
+     */
+    public function setUp() {
+        $request = $this->getMockBuilder('OCP\IRequest')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $userManager = $this->getMockBuilder('OCP\IUserManager')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $groupManager = $this->getMockBuilder('OCP\IGroupManager')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $avatarManager = $this->getMockBuilder('OCP\IAvatarManager')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $logger = $this->getMockBuilder('OCP\ILogger')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $l10n = $this->getMockBuilder('OCP\IL10N')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $urlGenerator = $this->getMockBuilder('OCP\IURLGenerator')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $commentMapper = $this->getMockBuilder('OCA\Polls\Db\CommentMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $dateMapper = $this->getMockBuilder('OCA\Polls\Db\DateMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $eventMapper = $this->getMockBuilder('OCA\Polls\Db\EventMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $notificationMapper = $this->getMockBuilder('OCA\Polls\Db\NotificationMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $participationMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $participationTextMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationTextMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $textMapper = $this->getMockBuilder('OCA\Polls\Db\TextMapper')
+            ->disableOriginalConstructor()
+            ->getMock();
 
-		$this->controller = new PageController(
-			'polls',
-			$request,
-			$userManager,
-			$groupManager,
-			$avatarManager,
-			$logger,
-			$l10n,
-			$urlGenerator,
-			$this->userId,
-			$commentMapper,
-			$dateMapper,
-			$eventMapper,
-			$notificationMapper,
-			$participationMapper,
-			$participationTextMapper,
-			$textMapper
-		);
-	}
+        $this->controller = new PageController(
+            'polls',
+            $request,
+            $userManager,
+            $groupManager,
+            $avatarManager,
+            $logger,
+            $l10n,
+            $urlGenerator,
+            $this->userId,
+            $commentMapper,
+            $dateMapper,
+            $eventMapper,
+            $notificationMapper,
+            $participationMapper,
+            $participationTextMapper,
+            $textMapper
+        );
+    }
 
-	/**
-	 * Basic controller index route test.
-	 */
-	public function testIndex() {
-		$result = $this->controller->index();
+    /**
+     * Basic controller index route test.
+     */
+    public function testIndex() {
+        $result = $this->controller->index();
 
-		$this->assertEquals('main.tmpl', $result->getTemplateName());
-		$this->assertInstanceOf(TemplateResponse::class, $result);
-	}
+        $this->assertEquals('main.tmpl', $result->getTemplateName());
+        $this->assertInstanceOf(TemplateResponse::class, $result);
+    }
 }

Please login to merge, or discard this patch.

tests/Unit/UnitTestCase.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -28,15 +28,15 @@
 block discarded – undo
 
 abstract class UnitTestCase extends PHPUnit_Framework_TestCase {
 
-	/** @var FactoryMuffin */
-	protected $fm;
+    /** @var FactoryMuffin */
+    protected $fm;
 
-	/**
-	 * {@inheritDoc}
-	 */
-	public function setUp() {
-		parent::setUp();
-		$this->fm = new FactoryMuffin();
-		$this->fm->loadFactories(__DIR__ . '/Factories');
-	}
+    /**
+     * {@inheritDoc}
+     */
+    public function setUp() {
+        parent::setUp();
+        $this->fm = new FactoryMuffin();
+        $this->fm->loadFactories(__DIR__ . '/Factories');
+    }
 }

Please login to merge, or discard this patch.

		@@ -29,17 +29,17 @@
		block discarded – undo
29	29
30	30	class ParticipationMapperTest extends UnitTestCase {
31	31
32		- /** @var IDBConnection */
33		- private $con;
34		- /** @var ParticipationMapper */
35		- private $participationMapper;
	32	+ /** @var IDBConnection */
	33	+ private $con;
	34	+ /** @var ParticipationMapper */
	35	+ private $participationMapper;
36	36
37		- /**
38		- * {@inheritDoc}
39		- */
40		- public function setUp() {
41		- parent::setUp();
42		- $this->con = \OC::$server->getDatabaseConnection();
43		- $this->participationMapper = new ParticipationMapper($this->con);
44		- }
	37	+ /**
	38	+ * {@inheritDoc}
	39	+ */
	40	+ public function setUp() {
	41	+ parent::setUp();
	42	+ $this->con = \OC::$server->getDatabaseConnection();
	43	+ $this->participationMapper = new ParticipationMapper($this->con);
	44	+ }
45	45	}

		@@ -29,17 +29,17 @@
		block discarded – undo
29	29
30	30	class TextMapperTest extends UnitTestCase {
31	31
32		- /** @var IDBConnection */
33		- private $con;
34		- /** @var TextMapper */
35		- private $textMapper;
	32	+ /** @var IDBConnection */
	33	+ private $con;
	34	+ /** @var TextMapper */
	35	+ private $textMapper;
36	36
37		- /**
38		- * {@inheritDoc}
39		- */
40		- public function setUp() {
41		- parent::setUp();
42		- $this->con = \OC::$server->getDatabaseConnection();
43		- $this->textMapper = new TextMapper($this->con);
44		- }
	37	+ /**
	38	+ * {@inheritDoc}
	39	+ */
	40	+ public function setUp() {
	41	+ parent::setUp();
	42	+ $this->con = \OC::$server->getDatabaseConnection();
	43	+ $this->textMapper = new TextMapper($this->con);
	44	+ }
45	45	}

		@@ -29,85 +29,85 @@
		block discarded – undo
29	29
30	30	class PageControllerTest extends UnitTestCase {
31	31
32		- /** @var PageController */
33		- private $controller;
	32	+ /** @var PageController */
	33	+ private $controller;
34	34
35		- private $userId = 'john';
	35	+ private $userId = 'john';
36	36
37		- /**
38		- * {@inheritDoc}
39		- */
40		- public function setUp() {
41		- $request = $this->getMockBuilder('OCP\IRequest')
42		- ->disableOriginalConstructor()
43		- ->getMock();
44		- $userManager = $this->getMockBuilder('OCP\IUserManager')
45		- ->disableOriginalConstructor()
46		- ->getMock();
47		- $groupManager = $this->getMockBuilder('OCP\IGroupManager')
48		- ->disableOriginalConstructor()
49		- ->getMock();
50		- $avatarManager = $this->getMockBuilder('OCP\IAvatarManager')
51		- ->disableOriginalConstructor()
52		- ->getMock();
53		- $logger = $this->getMockBuilder('OCP\ILogger')
54		- ->disableOriginalConstructor()
55		- ->getMock();
56		- $l10n = $this->getMockBuilder('OCP\IL10N')
57		- ->disableOriginalConstructor()
58		- ->getMock();
59		- $urlGenerator = $this->getMockBuilder('OCP\IURLGenerator')
60		- ->disableOriginalConstructor()
61		- ->getMock();
62		- $commentMapper = $this->getMockBuilder('OCA\Polls\Db\CommentMapper')
63		- ->disableOriginalConstructor()
64		- ->getMock();
65		- $dateMapper = $this->getMockBuilder('OCA\Polls\Db\DateMapper')
66		- ->disableOriginalConstructor()
67		- ->getMock();
68		- $eventMapper = $this->getMockBuilder('OCA\Polls\Db\EventMapper')
69		- ->disableOriginalConstructor()
70		- ->getMock();
71		- $notificationMapper = $this->getMockBuilder('OCA\Polls\Db\NotificationMapper')
72		- ->disableOriginalConstructor()
73		- ->getMock();
74		- $participationMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationMapper')
75		- ->disableOriginalConstructor()
76		- ->getMock();
77		- $participationTextMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationTextMapper')
78		- ->disableOriginalConstructor()
79		- ->getMock();
80		- $textMapper = $this->getMockBuilder('OCA\Polls\Db\TextMapper')
81		- ->disableOriginalConstructor()
82		- ->getMock();
	37	+ /**
	38	+ * {@inheritDoc}
	39	+ */
	40	+ public function setUp() {
	41	+ $request = $this->getMockBuilder('OCP\IRequest')
	42	+ ->disableOriginalConstructor()
	43	+ ->getMock();
	44	+ $userManager = $this->getMockBuilder('OCP\IUserManager')
	45	+ ->disableOriginalConstructor()
	46	+ ->getMock();
	47	+ $groupManager = $this->getMockBuilder('OCP\IGroupManager')
	48	+ ->disableOriginalConstructor()
	49	+ ->getMock();
	50	+ $avatarManager = $this->getMockBuilder('OCP\IAvatarManager')
	51	+ ->disableOriginalConstructor()
	52	+ ->getMock();
	53	+ $logger = $this->getMockBuilder('OCP\ILogger')
	54	+ ->disableOriginalConstructor()
	55	+ ->getMock();
	56	+ $l10n = $this->getMockBuilder('OCP\IL10N')
	57	+ ->disableOriginalConstructor()
	58	+ ->getMock();
	59	+ $urlGenerator = $this->getMockBuilder('OCP\IURLGenerator')
	60	+ ->disableOriginalConstructor()
	61	+ ->getMock();
	62	+ $commentMapper = $this->getMockBuilder('OCA\Polls\Db\CommentMapper')
	63	+ ->disableOriginalConstructor()
	64	+ ->getMock();
	65	+ $dateMapper = $this->getMockBuilder('OCA\Polls\Db\DateMapper')
	66	+ ->disableOriginalConstructor()
	67	+ ->getMock();
	68	+ $eventMapper = $this->getMockBuilder('OCA\Polls\Db\EventMapper')
	69	+ ->disableOriginalConstructor()
	70	+ ->getMock();
	71	+ $notificationMapper = $this->getMockBuilder('OCA\Polls\Db\NotificationMapper')
	72	+ ->disableOriginalConstructor()
	73	+ ->getMock();
	74	+ $participationMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationMapper')
	75	+ ->disableOriginalConstructor()
	76	+ ->getMock();
	77	+ $participationTextMapper = $this->getMockBuilder('OCA\Polls\Db\ParticipationTextMapper')
	78	+ ->disableOriginalConstructor()
	79	+ ->getMock();
	80	+ $textMapper = $this->getMockBuilder('OCA\Polls\Db\TextMapper')
	81	+ ->disableOriginalConstructor()
	82	+ ->getMock();
83	83
84		- $this->controller = new PageController(
85		- 'polls',
86		- $request,
87		- $userManager,
88		- $groupManager,
89		- $avatarManager,
90		- $logger,
91		- $l10n,
92		- $urlGenerator,
93		- $this->userId,
94		- $commentMapper,
95		- $dateMapper,
96		- $eventMapper,
97		- $notificationMapper,
98		- $participationMapper,
99		- $participationTextMapper,
100		- $textMapper
101		- );
102		- }
	84	+ $this->controller = new PageController(
	85	+ 'polls',
	86	+ $request,
	87	+ $userManager,
	88	+ $groupManager,
	89	+ $avatarManager,
	90	+ $logger,
	91	+ $l10n,
	92	+ $urlGenerator,
	93	+ $this->userId,
	94	+ $commentMapper,
	95	+ $dateMapper,
	96	+ $eventMapper,
	97	+ $notificationMapper,
	98	+ $participationMapper,
	99	+ $participationTextMapper,
	100	+ $textMapper
	101	+ );
	102	+ }
103	103
104		- /**
105		- * Basic controller index route test.
106		- */
107		- public function testIndex() {
108		- $result = $this->controller->index();
	104	+ /**
	105	+ * Basic controller index route test.
	106	+ */
	107	+ public function testIndex() {
	108	+ $result = $this->controller->index();
109	109
110		- $this->assertEquals('main.tmpl', $result->getTemplateName());
111		- $this->assertInstanceOf(TemplateResponse::class, $result);
112		- }
	110	+ $this->assertEquals('main.tmpl', $result->getTemplateName());
	111	+ $this->assertInstanceOf(TemplateResponse::class, $result);
	112	+ }
113	113	}

		@@ -28,15 +28,15 @@
		block discarded – undo
28	28
29	29	abstract class UnitTestCase extends PHPUnit_Framework_TestCase {
30	30
31		- /** @var FactoryMuffin */
32		- protected $fm;
	31	+ /** @var FactoryMuffin */
	32	+ protected $fm;
33	33
34		- /**
35		- * {@inheritDoc}
36		- */
37		- public function setUp() {
38		- parent::setUp();
39		- $this->fm = new FactoryMuffin();
40		- $this->fm->loadFactories(__DIR__ . '/Factories');
41		- }
	34	+ /**
	35	+ * {@inheritDoc}
	36	+ */
	37	+ public function setUp() {
	38	+ parent::setUp();
	39	+ $this->fm = new FactoryMuffin();
	40	+ $this->fm->loadFactories(__DIR__ . '/Factories');
	41	+ }
42	42	}

nextcloud / polls

Pull Request — master (#224)

Status

Category

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +76 added lines, -76 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch