js/importers/importer-enpass.js - Code Metrics - Inspection of "Fix share button, fix shared_key not added to stor..." - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Branch — v2.1.0 (e76e15)

by Sander

created 2017-02-17 11:25 UTC

js/importers/importer-enpass.js B

↳ Parent: js/importers/importer-enpass.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
nc	2
nop	3
dl	0
loc	91
rs	8.518
c	2
b	0
f	0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	PassmanImporter.EnPassTXT.readFile	0	52	1
B	importer-enpass.js ➔ parseEnpass	0	26	5

How to fix Long Method

/**
 * Nextcloud - passman
 *
 * @copyright Copyright (c) 2016, Sander Brand ([email protected])
 * @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

// Importers should always start with this
/** global: PassmanImporter */
var PassmanImporter = PassmanImporter || {};

(function(window, $, PassmanImporter) {
	'use strict';
	// Define the importer
	PassmanImporter.EnPassTXT = {
		info: {
			name: 'EnPass text file',
			id: 'EnPassTXT',
			description: 'Access your Enpass Database. Select "File" > "Export" > "As Text"'
		}
	};

	function parseEnpass(fileData){
		var lastProperty, matches,loginBlocks;
		loginBlocks = fileData.replaceAll("Title :","<~passman~>\nTitle :").split('<~passman~>\n').clean("");
		var regex = /(.*) : (.*)/;
		var results = [];
		for(var l = 0; l < loginBlocks.length; l++){
			var loginBlock = loginBlocks[l];
			var lrow = loginBlock.split('\n');
			var result = {};
			for(var r = 0; r < lrow.length; r++){
				var row = lrow[r];
				matches = regex.exec(row);
				if(matches){
					var property = matches[1];
					result[property] = matches[2];
				} else {
					if(lastProperty){
						result[lastProperty] += "\n" + row;
					}
				}
				lastProperty = property;
function someFunction() {
    (function() {
        var i = 0;
    })();

    // i is not defined.
    alert(i);
}

// This can be fixed by moving the var statement to the outer scope.

function someFunction() {
    var i;
    (function() {
        i = 1;
    })();

    alert(i);
};
			}
			results.push(result)

		}
		return results

	}

	PassmanImporter.EnPassTXT.readFile = function (file_data) {
		var mapper = {
			'Title': 'label',
			'Username': 'username',
			'Password': 'password',
			'Email': 'email',
			'Url': 'url',
			'Note': 'description'
		};

		var secret_fields = ['cvc', 'pin', 'security answer'];

		return new C_Promise(function(){

			var credential_list = [];
			var credentials = parseEnpass(file_data);
			for (var i = 0; i < credentials.length; i++) {
				var enpass_credential = credentials[i];
				var new_credential = PassmanImporter.newCredential();
				for(var key in enpass_credential){
					if(!enpass_credential.hasOwnProperty(key)){
						continue;
					}

					if(mapper.hasOwnProperty(key)){
						var prop = mapper[key];
						new_credential[prop] = enpass_credential[key];
					} else {
						var isSecret = (secret_fields.indexOf(key.toLowerCase()) !== -1) ? 1 : 0;
						new_credential.custom_fields.push({
							'label': key,
							'value': enpass_credential[key],
							'secret': isSecret
						})

					}
				}

				if(enpass_credential.hasOwnProperty('TOTP')){
					new_credential.otp.secret = enpass_credential['TOTP'];
var obj = { };
obj['foo'] = 'bar'; // Bad
obj.foo = 'bar'; // Good
				}

				var progress = {
					percent: i/credentials.length*100,
					loaded: i,
					total: credentials.length
				};

				credential_list.push(new_credential);
				this.call_progress(progress);
			}
			this.call_then(credential_list);
		});
	};
})(window, $, PassmanImporter);

1			/**
2			* Nextcloud - passman
3			*
4			* @copyright Copyright (c) 2016, Sander Brand ([email protected])
5			* @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
6			* @license GNU AGPL version 3 or any later version
7			*
8			* This program is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License as
10			* published by the Free Software Foundation, either version 3 of the
11			* License, or (at your option) any later version.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU Affero General Public License for more details.
17			*
18			* You should have received a copy of the GNU Affero General Public License
19			* along with this program. If not, see <http://www.gnu.org/licenses/>.
20			*
21			*/
22
23			// Importers should always start with this
24			/** global: PassmanImporter */
25			var PassmanImporter = PassmanImporter \|\| {};
			1 ignored issue – show Bug introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report The variable `PassmanImporter` seems to be never initialized. Loading history...
26			(function(window, $, PassmanImporter) {
27			'use strict';
28			// Define the importer
29			PassmanImporter.EnPassTXT = {
30			info: {
31			name: 'EnPass text file',
32			id: 'EnPassTXT',
33			description: 'Access your Enpass Database. Select "File" > "Export" > "As Text"'
34			}
35			};
36
37			function parseEnpass(fileData){
38			var lastProperty, matches,loginBlocks;
39			loginBlocks = fileData.replaceAll("Title :","<~passman~>\nTitle :").split('<~passman~>\n').clean("");
40			var regex = /(.) : (.)/;
41			var results = [];
42			for(var l = 0; l < loginBlocks.length; l++){
43			var loginBlock = loginBlocks[l];
44			var lrow = loginBlock.split('\n');
45			var result = {};
46			for(var r = 0; r < lrow.length; r++){
47			var row = lrow[r];
48			matches = regex.exec(row);
49			if(matches){
50			var property = matches[1];
51			result[property] = matches[2];
52			} else {
53			if(lastProperty){
54			result[lastProperty] += "\n" + row;
55			}
56			}
57			lastProperty = property;
			0 ignored issues – show Bug introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report The variable `property` seems to not be initialized for all possible execution paths. Loading history... Bug introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report The variable `property` seems to be used out of scope. This error can usually be fixed by declaring the variable in the scope where it is used: function someFunction() { (function() { var i = 0; })(); // i is not defined. alert(i); } // This can be fixed by moving the var statement to the outer scope. function someFunction() { var i; (function() { i = 1; })(); alert(i); }; Loading history...
58			}
59			results.push(result)
			0 ignored issues – show Coding Style introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
60			}
61			return results
			0 ignored issues – show Coding Style introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
62			}
63
64			PassmanImporter.EnPassTXT.readFile = function (file_data) {
65			var mapper = {
66			'Title': 'label',
67			'Username': 'username',
68			'Password': 'password',
69			'Email': 'email',
70			'Url': 'url',
71			'Note': 'description'
72			};
73
74			var secret_fields = ['cvc', 'pin', 'security answer'];
75
76			return new C_Promise(function(){
			0 ignored issues – show Bug introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report The variable `C_Promise` seems to be never declared. If this is a global, consider adding a `/** global: C_Promise */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
77			var credential_list = [];
78			var credentials = parseEnpass(file_data);
79			for (var i = 0; i < credentials.length; i++) {
80			var enpass_credential = credentials[i];
81			var new_credential = PassmanImporter.newCredential();
82			for(var key in enpass_credential){
83			if(!enpass_credential.hasOwnProperty(key)){
84			continue;
85			}
86
87			if(mapper.hasOwnProperty(key)){
88			var prop = mapper[key];
89			new_credential[prop] = enpass_credential[key];
90			} else {
91			var isSecret = (secret_fields.indexOf(key.toLowerCase()) !== -1) ? 1 : 0;
92			new_credential.custom_fields.push({
93			'label': key,
94			'value': enpass_credential[key],
95			'secret': isSecret
96			})
			0 ignored issues – show Coding Style introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
97			}
98			}
99
100			if(enpass_credential.hasOwnProperty('TOTP')){
101			new_credential.otp.secret = enpass_credential['TOTP'];
			0 ignored issues – show Coding Style introduced 2017-02-17 11:33 UTC by Report Bug Copy Issue Report `['TOTP']` could be written in dot notation. You can rewrite this statement in dot notation: var obj = { }; obj['foo'] = 'bar'; // Bad obj.foo = 'bar'; // Good Loading history...
102			}
103
104			var progress = {
105			percent: i/credentials.length*100,
106			loaded: i,
107			total: credentials.length
108			};
109
110			credential_list.push(new_credential);
111			this.call_progress(progress);
112			}
113			this.call_then(credential_list);
114			});
115			};
116			})(window, $, PassmanImporter);

nextcloud / passman

Branch — v2.1.0 (e76e15)

js/importers/importer-enpass.js B

Complexity

Size

Duplication

Importance

2 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like