IconController::getSingleIcon() - Code Metrics - Inspection of "Merge pull request #534 from nextcloud/fix/noid/ic..." - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9e6673...1d15d2 )

unknown

created 2019-05-12 21:04 UTC

IconController::getSingleIcon() A

↳ Parent: IconController

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
nc	4
nop	1
dl	0
loc	17
ccs	0
cts	9
cp	0
crap	12
rs	9.7
c	0
b	0
f	0

<?php
/**
 * Nextcloud - passman
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Sander Brand <[email protected]>
 * @copyright Sander Brand 2016
 */

namespace OCA\Passman\Controller;

use Doctrine\DBAL\Exception\DriverException;
use OC\App\AppManager;
use OCA\Passman\Service\IconService;
use OCA\Passman\Utility\Utils;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Http\DataDownloadResponse;
use OCP\AppFramework\Http\Response;
use OCP\IConfig;
use OCP\IRequest;
use OCP\AppFramework\Http\JSONResponse;
use OCP\AppFramework\ApiController;
use OCA\Passman\Service\CredentialService;
use \OCP\App;
use OCP\IURLGenerator;

class IconController extends ApiController {
	private $userId;
	private $credentialService;
	private $am;
	private $urlGenerator;

	public function __construct($AppName,
								IRequest $request,
								$UserId,
								CredentialService $credentialService,
								AppManager $am,
								IURLGenerator $urlGenerator
	) {
		parent::__construct(
			$AppName,
			$request,
			'GET, POST, DELETE, PUT, PATCH, OPTIONS',
			'Authorization, Content-Type, Accept',
			86400);
		$this->userId = $UserId;
		$this->credentialService = $credentialService;
		$this->am = $am;
		$this->urlGenerator = $urlGenerator;

	}

	/**
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 */
	public function getSingleIcon($base64Url) {
		$url = base64_decode(str_replace('_','/', $base64Url));
		if (!preg_match("~^(?:f|ht)tps?://~i", $url)) {
			$url = "http://" . $url;
		}


		$icon = new IconService($url);

		if ($icon->icoExists) {
			$icon_json['type']= $icon->icoType;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$icon_json['content']= base64_encode($icon->icoData);
			return new JSONResponse($icon_json);
		}

		return new JSONResponse();
	}

	/**
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 */
	public function getIcon($base64Url, $credentialId) {
		$url = base64_decode(str_replace('_','/', $base64Url));

		if($credentialId) {
			try {
				$credential = $this->credentialService->getCredentialById($credentialId, $this->userId);
				$credential = $credential->jsonSerialize();
			} catch (DoesNotExistException $e){

				// Credential is not found, continue
				$credential = false;
			}
		}

		if (!preg_match("~^(?:f|ht)tps?://~i", $url)) {
			$url = "http://" . $url;
		}

		$icon = new IconService($url);

		$data = base64_decode("iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAABHVBMVEUAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADF3oJhAAAAXnRSTlMAAQIDBAUGBwgJCwwOEBITFBUWFxgaHB4hJCUnKissMDI0ODs9PkFCQ0RNUVJWV1lbXF1hY2Zna2xtcXh7f4KDhYmUm52lq62vsLW3ucHFyszO0dPV197i7/H3+fv9358zuQAAAWdJREFUWMPtldlWwjAURdPWogyKOKM4z0NRQRRHnAdE0QoI1eb/P8OnmzYlSZs+unIes+/ZbdOuFCFuBmc2Dk+qpe18EsVIptTGJJ3jrGR99B4H8jQlUTfOMSM3ZtT+SAsz8z0ZrZ//wZy4S1H6C1iQtfD+tCsS4EJYP9kV9rGTCRE0fMOfxZypITO7++5b/NCE/S3fx7PsLc9/eeuWqK/3vA9ngAJ3BPwmBIIdMnYbvNNLgo4Egg4MvelBpD0D6/F3YYJcJd0PEw7AWa6gCCNnLLoPtMoVPMJIikVNoE2uAN6BzcZ1MPA2wRA+AUIHwHkn1BAM7LH5OvBhjiAFA6tsXgCe4wjSMLDC5nPAx5Xg3wrGylfk1GlcM/MC/KFW6fvRVbBkLuj+omwf401KUJcXtCiBIy+gT4UYfawrgRIogRIogRLwBG4MAfVnsuX7XX8fWfKCU0qgvcr2mwaiDZYtsw/tMtnCP4F4Y01BhTeiAAAAAElFTkSuQmCC");
		$type = 'png';
		
		if ($icon->icoExists) {
			$data = $icon->icoData;
			$type = $icon->icoType;
		}
		if (isset($credential) && $credential['user_id'] == $this->userId) {
			$iconData = [
				'type' => ($type) ? $type : 'x-icon',
				'content' => base64_encode($data)
			];
			$credential['icon'] = json_encode($iconData);
			try {
				if($credential) {
					$this->credentialService->updateCredential($credential);
				}
			} catch (DriverException $exception) {

				/**
				 * @FIXME Syntax error or access violation: 1118 Row size too large
				 * This happens when favicons are quite big.
				 * Githubs one is 33kb and triggers the try catch
				 */
			}
		}


		$offset = 3600 * 24 * 30;
		$contentType = 'image/png';
		$response = new DataDownloadResponse($data, 'icon', $contentType);

		$response->addHeader('Content-Type', $contentType);
		$response->addHeader('Content-Length:', mb_strlen($data));
		$response->addHeader('Expires: ', gmdate("D, d M Y H:i:s", time() + $offset) . " GMT");
		$response->setETag($base64Url);
		$response->cacheFor($offset);

		return $response;
	}

	/**
	 * @NoAdminRequired
	 * @NoCSRFRequired
	 */
	public function getLocalIconList() {
		$dir = $this->am->getAppPath('passman');
		$result = Utils::getDirContents($dir . '/img/icons');

		$icons = [];
		foreach ($result as $icon) {
			$iconPath = $icon;
			$path = explode('passman/', $iconPath);
			$pack = explode('/', $path[1])[2];
			$mime = mime_content_type($iconPath);
			//print_r($path);
			if($mime !== 'directory') {
				$icon = [];
				$icon['mimetype'] = mime_content_type($iconPath);
				$icon['url'] = $this->urlGenerator->linkTo('passman', $path[1]);
				$icon['pack'] = $pack;
				if(!isset($icons[$pack])){
					$icons[$pack] = [];
				}
				$icons[$pack][] = $icon;
			}
		}
		return new JSONResponse($icons);
	}
}

1			<?php
2			/**
3			* Nextcloud - passman
4			*
5			* This file is licensed under the Affero General Public License version 3 or
6			* later. See the COPYING file.
7			*
8			* @author Sander Brand <[email protected]>
9			* @copyright Sander Brand 2016
10			*/
11
12			namespace OCA\Passman\Controller;
13
14			use Doctrine\DBAL\Exception\DriverException;
15			use OC\App\AppManager;
16			use OCA\Passman\Service\IconService;
17			use OCA\Passman\Utility\Utils;
18			use OCP\AppFramework\Db\DoesNotExistException;
19			use OCP\AppFramework\Http\DataDownloadResponse;
20			use OCP\AppFramework\Http\Response;
21			use OCP\IConfig;
22			use OCP\IRequest;
23			use OCP\AppFramework\Http\JSONResponse;
24			use OCP\AppFramework\ApiController;
25			use OCA\Passman\Service\CredentialService;
26			use \OCP\App;
27			use OCP\IURLGenerator;
28
29			class IconController extends ApiController {
30			private $userId;
31			private $credentialService;
32			private $am;
33			private $urlGenerator;
34
35			public function __construct($AppName,
36			IRequest $request,
37			$UserId,
38			CredentialService $credentialService,
39			AppManager $am,
40			IURLGenerator $urlGenerator
41			) {
42			parent::__construct(
43			$AppName,
44			$request,
45			'GET, POST, DELETE, PUT, PATCH, OPTIONS',
46			'Authorization, Content-Type, Accept',
47			86400);
48			$this->userId = $UserId;
49			$this->credentialService = $credentialService;
50			$this->am = $am;
51			$this->urlGenerator = $urlGenerator;
52
53			}
54
55			/**
56			* @NoAdminRequired
57			* @NoCSRFRequired
58			*/
59			public function getSingleIcon($base64Url) {
60			$url = base64_decode(str_replace('_','/', $base64Url));
61			if (!preg_match("~^(?:f\|ht)tps?://~i", $url)) {
62			$url = "http://" . $url;
63			}
64
65
66			$icon = new IconService($url);
67
68			if ($icon->icoExists) {
69			$icon_json['type']= $icon->icoType;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-12-30 20:00 UTC by Report Bug Copy Issue Report `$icon_json` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$icon_json = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
70			$icon_json['content']= base64_encode($icon->icoData);
71			return new JSONResponse($icon_json);
72			}
73
74			return new JSONResponse();
75			}
76
77			/**
78			* @NoAdminRequired
79			* @NoCSRFRequired
80			*/
81			public function getIcon($base64Url, $credentialId) {
82			$url = base64_decode(str_replace('_','/', $base64Url));
83
84			if($credentialId) {
85			try {
86			$credential = $this->credentialService->getCredentialById($credentialId, $this->userId);
87			$credential = $credential->jsonSerialize();
88			} catch (DoesNotExistException $e){
			0 ignored issues – show Bug introduced 2016-12-28 20:04 UTC by Report Bug Copy Issue Report The class `OCP\AppFramework\Db\DoesNotExistException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
89			// Credential is not found, continue
90			$credential = false;
91			}
92			}
93
94			if (!preg_match("~^(?:f\|ht)tps?://~i", $url)) {
95			$url = "http://" . $url;
96			}
97
98			$icon = new IconService($url);
99
100			$data = base64_decode("iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAABHVBMVEUAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADF3oJhAAAAXnRSTlMAAQIDBAUGBwgJCwwOEBITFBUWFxgaHB4hJCUnKissMDI0ODs9PkFCQ0RNUVJWV1lbXF1hY2Zna2xtcXh7f4KDhYmUm52lq62vsLW3ucHFyszO0dPV197i7/H3+fv9358zuQAAAWdJREFUWMPtldlWwjAURdPWogyKOKM4z0NRQRRHnAdE0QoI1eb/P8OnmzYlSZs+unIes+/ZbdOuFCFuBmc2Dk+qpe18EsVIptTGJJ3jrGR99B4H8jQlUTfOMSM3ZtT+SAsz8z0ZrZ//wZy4S1H6C1iQtfD+tCsS4EJYP9kV9rGTCRE0fMOfxZypITO7++5b/NCE/S3fx7PsLc9/eeuWqK/3vA9ngAJ3BPwmBIIdMnYbvNNLgo4Egg4MvelBpD0D6/F3YYJcJd0PEw7AWa6gCCNnLLoPtMoVPMJIikVNoE2uAN6BzcZ1MPA2wRA+AUIHwHkn1BAM7LH5OvBhjiAFA6tsXgCe4wjSMLDC5nPAx5Xg3wrGylfk1GlcM/MC/KFW6fvRVbBkLuj+omwf401KUJcXtCiBIy+gT4UYfawrgRIogRIogRLwBG4MAfVnsuX7XX8fWfKCU0qgvcr2mwaiDZYtsw/tMtnCP4F4Y01BhTeiAAAAAElFTkSuQmCC");
101			$type = 'png';
102
103			if ($icon->icoExists) {
104			$data = $icon->icoData;
105			$type = $icon->icoType;
106			}
107			if (isset($credential) && $credential['user_id'] == $this->userId) {
108			$iconData = [
109			'type' => ($type) ? $type : 'x-icon',
110			'content' => base64_encode($data)
111			];
112			$credential['icon'] = json_encode($iconData);
113			try {
114			if($credential) {
115			$this->credentialService->updateCredential($credential);
116			}
117			} catch (DriverException $exception) {
			0 ignored issues – show Bug introduced 2017-08-13 12:34 UTC by Report Bug Copy Issue Report The class `Doctrine\DBAL\Exception\DriverException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
118			/**
119			* @FIXME Syntax error or access violation: 1118 Row size too large
120			* This happens when favicons are quite big.
121			* Githubs one is 33kb and triggers the try catch
122			*/
123			}
124			}
125
126
127			$offset = 3600 * 24 * 30;
128			$contentType = 'image/png';
129			$response = new DataDownloadResponse($data, 'icon', $contentType);
130
131			$response->addHeader('Content-Type', $contentType);
132			$response->addHeader('Content-Length:', mb_strlen($data));
133			$response->addHeader('Expires: ', gmdate("D, d M Y H:i:s", time() + $offset) . " GMT");
134			$response->setETag($base64Url);
135			$response->cacheFor($offset);
136
137			return $response;
138			}
139
140			/**
141			* @NoAdminRequired
142			* @NoCSRFRequired
143			*/
144			public function getLocalIconList() {
145			$dir = $this->am->getAppPath('passman');
146			$result = Utils::getDirContents($dir . '/img/icons');
147
148			$icons = [];
149			foreach ($result as $icon) {
150			$iconPath = $icon;
151			$path = explode('passman/', $iconPath);
152			$pack = explode('/', $path[1])[2];
153			$mime = mime_content_type($iconPath);
154			//print_r($path);
155			if($mime !== 'directory') {
156			$icon = [];
157			$icon['mimetype'] = mime_content_type($iconPath);
158			$icon['url'] = $this->urlGenerator->linkTo('passman', $path[1]);
159			$icon['pack'] = $pack;
160			if(!isset($icons[$pack])){
161			$icons[$pack] = [];
162			}
163			$icons[$pack][] = $icon;
164			}
165			}
166			return new JSONResponse($icons);
167			}
168			}

nextcloud / passman

Push — master ( 9e6673...1d15d2 )

IconController::getSingleIcon() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like