nextcloud / passman

lib/Db/EntityJSONSerializer.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 trait EntityJSONSerializer {
 	public function serializeFields($properties) {
 		$result = [];
-		foreach($properties as $property) {
+		foreach ($properties as $property) {
 			$result[$property] = $this->$property;
 		}
 		return $result;

lib/Utility/PermissionEntity.php

Spacing +4 added lines, -4 removed lines

@@ -13,11 +13,11 @@
 use OCP\AppFramework\Db\Entity;
 
 class PermissionEntity extends Entity {
-    CONST READ  =   0b00000001;
-    CONST WRITE =   0b00000010;
-    CONST FILES =   0b00000100;
+    CONST READ  = 0b00000001;
+    CONST WRITE = 0b00000010;
+    CONST FILES = 0b00000100;
     CONST HISTORY = 0b00001000;
-    CONST OWNER =   0b10000000;
+    CONST OWNER = 0b10000000;
 
     /**
      * Checks wether a user matches one or more permissions at once

lib/Db/SharingACLMapper.php

Spacing +5 added lines, -5 removed lines

@@ -22,7 +22,7 @@ 
         parent::__construct($db, 'passman_sharing_acl');
     }
 
-    public function createACLEntry(SharingACL $acl){
+    public function createACLEntry(SharingACL $acl) {
         return $this->insert($acl);
     }
 
@@ -33,7 +33,7 @@ 
      * @return SharingACL[]
      */
     public function getVaultEntries($user_id, $vault_id) {
-        $q = "SELECT * FROM ". self::TABLE_NAME ." WHERE user_id = ? AND vault_guid = ?";
+        $q = "SELECT * FROM " . self::TABLE_NAME . " WHERE user_id = ? AND vault_guid = ?";
         return $this->findEntities($q, [$user_id, $vault_id]);
     }
 
@@ -46,7 +46,7 @@ 
     public function getItemACL($user_id, $item_guid) {
         $q = "SELECT * FROM " . self::TABLE_NAME . " WHERE item_guid = ? AND ";
         $filter = [$item_guid];
-        if ($user_id === null){
+        if ($user_id === null) {
             $q .= 'user_id is null';
         }
         else {
@@ -73,11 +73,11 @@ 
      * @return SharingACL[]
      */
     public function getCredentialAclList($item_guid) {
-        $q = "SELECT * FROM ". self::TABLE_NAME ." WHERE item_guid = ?";
+        $q = "SELECT * FROM " . self::TABLE_NAME . " WHERE item_guid = ?";
         return $this->findEntities($q, [$item_guid]);
     }
 
-    public function deleteShareACL(SharingACL $ACL){
+    public function deleteShareACL(SharingACL $ACL) {
     	return $this->delete($ACL);
 	}
 }
\ No newline at end of file

lib/Activity.php

Spacing +1 added lines, -1 removed lines

@@ -241,7 +241,7 @@
 				array(
 					'id' => 'passman',
 					'name' => (string) $l->t('Passwords'),
-					'url' => '',//FIXME: Currenlty we cannot link directly to links, so this needs to be fixed... this->URLGenerator->linkToRoute('activity.Activities.showList', array('filter' => 'passman')),
+					'url' => '', //FIXME: Currenlty we cannot link directly to links, so this needs to be fixed... this->URLGenerator->linkToRoute('activity.Activities.showList', array('filter' => 'passman')),
 				),
 			),
 		);

lib/Db/ShareRequestMapper.php

Spacing +13 added lines, -13 removed lines

@@ -22,7 +22,7 @@ 
         parent::__construct($db, self::TABLE_NAME);
     }
 
-    public function createRequest(ShareRequest $request){
+    public function createRequest(ShareRequest $request) {
         return $this->insert($request);
     }
 
@@ -32,7 +32,7 @@ 
      * @param $target_vault_guid
      * @return ShareRequest
      */
-    public function getRequestByItemAndVaultGuid($item_guid, $target_vault_guid){
+    public function getRequestByItemAndVaultGuid($item_guid, $target_vault_guid) {
         $q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE item_guid = ? AND target_vault_guid = ?";
         return $this->findEntity($q, [$item_guid, $target_vault_guid]);
     }
@@ -42,8 +42,8 @@ 
      * @param $item_guid
      * @return ShareRequest[]
      */
-    public function getRequestsByItemGuidGroupedByUser($item_guid){
-    	if (strtolower($this->db->getDatabasePlatform()->getName()) === 'mysql'){
+    public function getRequestsByItemGuidGroupedByUser($item_guid) {
+    	if (strtolower($this->db->getDatabasePlatform()->getName()) === 'mysql') {
     		$this->db->executeQuery("SET sql_mode = '';");
 		}
         $q = "SELECT *, target_user_id FROM *PREFIX*" . self::TABLE_NAME . " WHERE item_guid = ? GROUP BY target_user_id;";
@@ -56,7 +56,7 @@ 
      * @param $target_user_id   The target user
      * @return \PDOStatement    The result of running the db query
      */
-    public function cleanItemRequestsForUser($item_id, $target_user_id){
+    public function cleanItemRequestsForUser($item_id, $target_user_id) {
 		$q = "DELETE FROM *PREFIX*" . self::TABLE_NAME . " WHERE item_id = ? AND target_user_id = ?";
 		$this->execute($q, [$item_id, $target_user_id]);
         return $this->execute($q, [$item_id, $target_user_id]);
@@ -67,8 +67,8 @@ 
      * @param $user_id
      * @return ShareRequest[]
      */
-    public function getUserPendingRequests($user_id){
-        $q = "SELECT * FROM *PREFIX*". self::TABLE_NAME ." WHERE target_user_id = ?";
+    public function getUserPendingRequests($user_id) {
+        $q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE target_user_id = ?";
         return $this->findEntities($q, [$user_id]);
     }
 
@@ -77,7 +77,7 @@ 
      * @param ShareRequest $shareRequest    Request to delete
      * @return ShareRequest                 The deleted request
      */
-    public function deleteShareRequest(ShareRequest $shareRequest){
+    public function deleteShareRequest(ShareRequest $shareRequest) {
     	return $this->delete($shareRequest);
 	}
 
@@ -87,7 +87,7 @@ 
      * @return ShareRequest
 	 * @throws DoesNotExistException
      */
-	public function getShareRequestById($id){
+	public function getShareRequestById($id) {
 		$q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE id = ?";
 		return $this->findEntity($q, [$id]);
 	}
@@ -97,7 +97,7 @@ 
      * @param $item_guid
      * @return ShareRequest[]
      */
-	public function getShareRequestsByItemGuid($item_guid){
+	public function getShareRequestsByItemGuid($item_guid) {
 		$q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE 	item_guid = ?";
 		return $this->findEntities($q, [$item_guid]);
 	}
@@ -107,7 +107,7 @@ 
      * @param ShareRequest $shareRequest
      * @return ShareRequest
      */
-	public function updateShareRequest(ShareRequest $shareRequest){
+	public function updateShareRequest(ShareRequest $shareRequest) {
 		return $this->update($shareRequest);
 	}
 
@@ -117,7 +117,7 @@ 
      * @param $user_id
      * @return ShareRequest[]
      */
-	public function getPendingShareRequests($item_guid, $user_id){
+	public function getPendingShareRequests($item_guid, $user_id) {
 		$q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE 	item_guid = ? and target_user_id= ?";
 		return $this->findEntities($q, [$item_guid, $user_id]);
 	}
@@ -129,7 +129,7 @@ 
      * @param $permissions      The new permissions to apply
      * @return \PDOStatement    The result of the operation
      */
-	public function updatePendingRequestPermissions($item_guid, $user_id, $permissions){
+	public function updatePendingRequestPermissions($item_guid, $user_id, $permissions) {
 	    $q = "UPDATE *PREFIX*" . self::TABLE_NAME . " SET permissions = ? WHERE item_guid = ? AND target_user_id = ?";
         return $this->execute($q, [$permissions, $item_guid, $user_id]);
     }

lib/Service/CronService.php

Spacing +5 added lines, -5 removed lines

@@ -50,23 +50,23 @@
 	public function expireCredentials() {
 		$this->logger->info('Passman cron test', array('app' => 'passman'));
 		$expired_credentials = $this->credentialService->getExpiredCredentials($this->utils->getTime());
-		foreach($expired_credentials as $credential){
+		foreach ($expired_credentials as $credential) {
 			$link = ''; // @TODO create direct link to credential
 
 			$sql = 'SELECT count(*) as rows from `*PREFIX*notifications` WHERE `subject`= \'credential_expired\' AND object_id=?';
 			$id = $credential->getId();
 			$result = $this->db->executeQuery($sql, array($id));
-			$this->logger->debug($credential->getLabel() .' is expired, checking notifications!', array('app' => 'passman'));
+			$this->logger->debug($credential->getLabel() . ' is expired, checking notifications!', array('app' => 'passman'));
 			$notifications = intval($result->fetch()['rows']);
-			if($notifications === 0) {
-				$this->logger->debug($credential->getLabel() .' is expired, adding notification!', array('app' => 'passman'));
+			if ($notifications === 0) {
+				$this->logger->debug($credential->getLabel() . ' is expired, adding notification!', array('app' => 'passman'));
 				$this->activityService->add(
 					Activity::SUBJECT_ITEM_EXPIRED, array($credential->getLabel(), $credential->getUserId()),
 					'', array(),
 					$link, $credential->getUserId(), Activity::TYPE_ITEM_EXPIRED);
 				$this->notificationService->credentialExpiredNotification($credential);
 			} else {
-				$this->logger->debug($credential->getLabel() .' is expired, already notified!', array('app' => 'passman'));
+				$this->logger->debug($credential->getLabel() . ' is expired, already notified!', array('app' => 'passman'));
 			}
 
 		}

lib/Service/ActivityService.php

Spacing +4 added lines, -4 removed lines

@@ -48,10 +48,10 @@
 	 * @param $type string
 	 * @return array
 	 */
-	public function add($subject,$subjectParams=array(),
-						$message='',$messageParams=array(),
-						$link='',$user=null,$type='') {
-		if($user) {
+	public function add($subject, $subjectParams = array(),
+						$message = '', $messageParams = array(),
+						$link = '', $user = null, $type = '') {
+		if ($user) {
 			$activity = $this->manager->generateEvent();
 			$activity->setType($type);
 			$activity->setApp('passman');

controller/credentialcontroller.php

Spacing +2 added lines, -2 removed lines

@@ -163,13 +163,13 @@
 				$activity . '_self', array($label, $this->userId, $revision_created),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() === 0) && (int)$delete_time > 0) {
+		} else if (($storedCredential->getDeleteTime() === 0) && (int) $delete_time > 0) {
 			$activity = 'item_deleted';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() > 0) && (int)$delete_time === 0) {
+		} else if (($storedCredential->getDeleteTime() > 0) && (int) $delete_time === 0) {
 			$activity = 'item_recovered';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),

controller/filecontroller.php

Spacing +8 added lines, -8 removed lines

@@ -23,7 +23,7 @@ 
 	public function __construct($AppName,
 								IRequest $request,
 								$UserId,
-								FileService $fileService){
+								FileService $fileService) {
 		parent::__construct($AppName, $request);
 		$this->userId = $UserId;
 		$this->fileService = $fileService;
@@ -59,20 +59,20 @@ 
 		return new JSONResponse($this->fileService->deleteFile($file_id, $this->userId));
 	}
 
-	public function updateFile($file_id, $file_data, $filename, $mimetype, $size){
-		try{
+	public function updateFile($file_id, $file_data, $filename, $mimetype, $size) {
+		try {
 			$file = $this->fileService->getFile($file_id, $this->userId);
-		} catch (\Exception $doesNotExistException){
+		} catch (\Exception $doesNotExistException) {
 
 		}
-		if($file){
-			if($file_data) {
+		if ($file) {
+			if ($file_data) {
 				$file->setFileData($file_data);
 			}
-			if($filename) {
+			if ($filename) {
 				$file->setFilename($filename);
 			}
-			if($filename || $file_data){
+			if ($filename || $file_data) {
 				new JSONResponse($this->fileService->updateFile($file));
 			}
 		}