js/importers/importer-randomdata.js - Code Metrics - Inspection of "Use global namespace for importers" - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#113)

by Sander

created 2016-10-15 15:24 UTC

js/importers/importer-randomdata.js B

↳ Parent: js/importers/importer-randomdata.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	2
nop	3
dl	0
loc	95
rs	8.4117

1 Function

Rating	Name	Duplication	Size	Complexity
B	PassmanImporter.randomData.readFile	0	81	1

How to fix Long Method

// Importers should always start with this
var PassmanImporter = PassmanImporter || {};

(function(window, $, PassmanImporter) {
	'use strict';
	// Define the importer

// Define the importer
	PassmanImporter.randomData = {
		info: {
			name: 'Random data',
			id: 'randomData',
			description: 'Create\'s 50 random credentials for testing purposes.'
		}
	};

	PassmanImporter.randomData.readFile = function () {
		return new C_Promise(function () {

			var tags =
				['Social media',
					'Hosting',
					'Forums',
					'Webshops',
					'FTP',
					'SSH',
					'Banking',
					'Applications',
					'Server stuff',
					'mysql',
					'Wifi',
					'Games',
					'Certificate',
					'Serials'
				];
			var label;
			var credential_list = [];
			var _this = this;
			var generateCredential = function (max, i, callback) {
				if (jQuery) {
					var url = OC.generateUrl('apps/passman/api/internal/generate_person');
					$.ajax({
						url: url,
						dataType: 'json',
						success: function (data) {
							if(data) {
								var _credential = PassmanImporter.newCredential();
								label = (Math.random() >= 0.5) ? data.domain : data.email_d + ' - ' + data.email_u;
								_credential.label = label;
								_credential.username = data.username;
								_credential.password = data.password;
								_credential.url = data.url;

								var tag_amount = Math.floor(Math.random() * 5);
								var ta = 0;
								var _tags = [];
								while (ta < tag_amount) {
									var item = tags[Math.floor(Math.random() * tags.length)];
									if (_tags.indexOf(item) === -1) {
										_tags.push(item);
										ta++

									}
								}
								_credential.tags = _tags.map(function (item) {
									if (item) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
										return {text: item}

									}

								}).filter(function (item) {
									return (item);
								});
								credential_list.push(_credential);

								if (i < max) {
									var progress = {
										percent: i / max * 100,
										loaded: i,
										total: max
									};
									_this.call_progress(progress);
									generateCredential(max, i + 1, callback)

								} else {
									callback(credential_list)

								}
							} else {
								generateCredential(max, i , callback)

							}
						}
					});
				}
			};


			generateCredential(50, 1, function (credential_list) {
				_this.call_then(credential_list);
			});
		});
	};
})(window, $, PassmanImporter);

1			// Importers should always start with this
2			var PassmanImporter = PassmanImporter \|\| {};
			1 ignored issue – show Bug introduced 2016-10-15 15:09 UTC by Report Bug Copy Issue Report The variable `PassmanImporter` seems to be never initialized. Loading history...
3			(function(window, $, PassmanImporter) {
4			'use strict';
5			// Define the importer
6
7			// Define the importer
8			PassmanImporter.randomData = {
9			info: {
10			name: 'Random data',
11			id: 'randomData',
12			description: 'Create\'s 50 random credentials for testing purposes.'
13			}
14			};
15
16			PassmanImporter.randomData.readFile = function () {
17			return new C_Promise(function () {
			0 ignored issues – show Bug introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report The variable `C_Promise` seems to be never declared. If this is a global, consider adding a `/** global: C_Promise */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
18			var tags =
19			['Social media',
20			'Hosting',
21			'Forums',
22			'Webshops',
23			'FTP',
24			'SSH',
25			'Banking',
26			'Applications',
27			'Server stuff',
28			'mysql',
29			'Wifi',
30			'Games',
31			'Certificate',
32			'Serials'
33			];
34			var label;
35			var credential_list = [];
36			var _this = this;
37			var generateCredential = function (max, i, callback) {
38			if (jQuery) {
39			var url = OC.generateUrl('apps/passman/api/internal/generate_person');
40			$.ajax({
41			url: url,
42			dataType: 'json',
43			success: function (data) {
44			if(data) {
45			var _credential = PassmanImporter.newCredential();
46			label = (Math.random() >= 0.5) ? data.domain : data.email_d + ' - ' + data.email_u;
47			_credential.label = label;
48			_credential.username = data.username;
49			_credential.password = data.password;
50			_credential.url = data.url;
51
52			var tag_amount = Math.floor(Math.random() * 5);
53			var ta = 0;
54			var _tags = [];
55			while (ta < tag_amount) {
56			var item = tags[Math.floor(Math.random() * tags.length)];
57			if (_tags.indexOf(item) === -1) {
58			_tags.push(item);
59			ta++
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
60			}
61			}
62			_credential.tags = _tags.map(function (item) {
63			if (item) {
			0 ignored issues – show Complexity Best Practice introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report There is no return statement if `item` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
64			return {text: item}
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
65			}
66
67			}).filter(function (item) {
68			return (item);
69			});
70			credential_list.push(_credential);
71
72			if (i < max) {
73			var progress = {
74			percent: i / max * 100,
75			loaded: i,
76			total: max
77			};
78			_this.call_progress(progress);
79			generateCredential(max, i + 1, callback)
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
80			} else {
81			callback(credential_list)
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
82			}
83			} else {
84			generateCredential(max, i , callback)
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
85			}
86			}
87			});
88			}
89			};
90
91
92			generateCredential(50, 1, function (credential_list) {
93			_this.call_then(credential_list);
94			});
95			});
96			};
97			})(window, $, PassmanImporter);

nextcloud / passman

Pull Request — master (#113)

js/importers/importer-randomdata.js B

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like