js/importers/importer-clipperz.js - Code Metrics - Inspection of "Use global namespace for importers" - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#113)

by Sander

created 2016-10-15 15:24 UTC

js/importers/importer-clipperz.js A

↳ Parent: js/importers/importer-clipperz.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	3
dl	0
loc	56
rs	9.7251

1 Function

Rating	Name	Duplication	Size	Complexity
B	PassmanImporter.clippers.readFile	0	45	1

How to fix Long Method

// Importers should always start with this
var PassmanImporter = PassmanImporter || {};

(function(window, $, PassmanImporter) {
	'use strict';
	PassmanImporter.clippers = {
		info: {
			name: 'Clipperz.is',
			id: 'clippers',
			description: 'Go to menu -> Export -> Download HTML + JSON. Fields will be imported as custom fields.'
		}
	};

	PassmanImporter.clippers.readFile = function (file_data) {
		return new C_Promise(function() {

			var credential_list = [];
			var re = /<textarea>(.*?)<\/textarea>/gi;
			var matches = re.exec(file_data);
			if(matches){
				var raw_json = matches[0].substring(10);
				raw_json = PassmanImporter.htmlDecode(raw_json.slice(0, -11));
				var json_objects = PassmanImporter.readJson(raw_json);
				for(var i = 0; i < json_objects.length; i++){
					var card = json_objects[i];
					re = /(\w+)/gi;
					var tags = card.label.match(re);
					card.label = card.label.replace(tags.join(' '), '').trim();
					tags = tags.map(function(item){ return {text: item.replace('', '') }});



					var _credential = PassmanImporter.newCredential();
					_credential.label = card.label;
					_credential.description = card.data.notes;
					_credential.tags = tags;
					for(var field in card.currentVersion.fields){
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
						var field_data = card.currentVersion.fields[field];
						_credential.custom_fields.push(
							{
								'label': field_data.label,
								'value': field_data.value,
								'secret': (field_data.hidden == true)

							}
						)

					}
					if(_credential.label){
						credential_list.push(_credential);
					}
					var progress = {
						percent: i/json_objects.length*100,
						loaded: i,
						total: json_objects.length
					};
					this.call_progress(progress);
				}
			}
			this.call_then(credential_list);
		});
	};
})(window, $, PassmanImporter);


1			// Importers should always start with this
2			var PassmanImporter = PassmanImporter \|\| {};
			1 ignored issue – show Bug introduced 2016-10-15 15:09 UTC by Report Bug Copy Issue Report The variable `PassmanImporter` seems to be never initialized. Loading history...
3			(function(window, $, PassmanImporter) {
4			'use strict';
5			PassmanImporter.clippers = {
6			info: {
7			name: 'Clipperz.is',
8			id: 'clippers',
9			description: 'Go to menu -> Export -> Download HTML + JSON. Fields will be imported as custom fields.'
10			}
11			};
12
13			PassmanImporter.clippers.readFile = function (file_data) {
14			return new C_Promise(function() {
			0 ignored issues – show Bug introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report The variable `C_Promise` seems to be never declared. If this is a global, consider adding a `/** global: C_Promise */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
15			var credential_list = [];
16			var re = /<textarea>(.*?)<\/textarea>/gi;
17			var matches = re.exec(file_data);
18			if(matches){
19			var raw_json = matches[0].substring(10);
20			raw_json = PassmanImporter.htmlDecode(raw_json.slice(0, -11));
21			var json_objects = PassmanImporter.readJson(raw_json);
22			for(var i = 0; i < json_objects.length; i++){
23			var card = json_objects[i];
24			re = /(\w+)/gi;
25			var tags = card.label.match(re);
26			card.label = card.label.replace(tags.join(' '), '').trim();
27			tags = tags.map(function(item){ return {text: item.replace('', '') }});
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
28
29
30			var _credential = PassmanImporter.newCredential();
31			_credential.label = card.label;
32			_credential.description = card.data.notes;
33			_credential.tags = tags;
34			for(var field in card.currentVersion.fields){
			0 ignored issues – show Complexity introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
35			var field_data = card.currentVersion.fields[field];
36			_credential.custom_fields.push(
37			{
38			'label': field_data.label,
39			'value': field_data.value,
40			'secret': (field_data.hidden == true)
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report It is recommended to use `===` to compare with `true`. Generally, it is recommended to use strict comparison whenever possible and not to rely on the weaker type-juggling comparison operator. Read more about comparison operations. Loading history...
41			}
42			)
			0 ignored issues – show Coding Style introduced 2016-10-09 16:44 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
43			}
44			if(_credential.label){
45			credential_list.push(_credential);
46			}
47			var progress = {
48			percent: i/json_objects.length*100,
49			loaded: i,
50			total: json_objects.length
51			};
52			this.call_progress(progress);
53			}
54			}
55			this.call_then(credential_list);
56			});
57			};
58			})(window, $, PassmanImporter);
59

nextcloud / passman

Pull Request — master (#113)

js/importers/importer-clipperz.js A

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like