Failed Conditions
Pull Request — master (#682)
by
unknown
07:29
created
controller/credentialcontroller.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -163,13 +163,13 @@
 block discarded – undo
163 163
 				$activity . '_self', array($label, $this->userId, $revision_created),
164 164
 				'', array(),
165 165
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
166
-		} else if (($storedCredential->getDeleteTime() === 0) && (int)$delete_time > 0) {
166
+		} else if (($storedCredential->getDeleteTime() === 0) && (int) $delete_time > 0) {
167 167
 			$activity = 'item_deleted';
168 168
 			$this->activityService->add(
169 169
 				$activity . '_self', array($label, $this->userId),
170 170
 				'', array(),
171 171
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
172
-		} else if (($storedCredential->getDeleteTime() > 0) && (int)$delete_time === 0) {
172
+		} else if (($storedCredential->getDeleteTime() > 0) && (int) $delete_time === 0) {
173 173
 			$activity = 'item_recovered';
174 174
 			$this->activityService->add(
175 175
 				$activity . '_self', array($label, $this->userId),
Please login to merge, or discard this patch.
controller/admincontroller.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -113,10 +113,10 @@  discard block
 block discarded – undo
113 113
 		return new JSONResponse(array('success' => true));
114 114
 	}
115 115
 
116
-	public function listRequests(){
116
+	public function listRequests() {
117 117
 		$requests = $this->deleteVaultRequestService->getDeleteRequests();
118 118
 		$results = array();
119
-		foreach($requests as $request){
119
+		foreach ($requests as $request) {
120 120
 			$r = $request->jsonSerialize();
121 121
 			$r['displayName'] = Utils::getNameByUid($request->getRequestedBy(), $this->userManager);
122 122
 			array_push($results, $r);
@@ -124,28 +124,28 @@  discard block
 block discarded – undo
124 124
 		return new JSONResponse($results);
125 125
 	}
126 126
 
127
-	public function acceptRequestDeletion($vault_guid, $requested_by){
127
+	public function acceptRequestDeletion($vault_guid, $requested_by) {
128 128
 		$req = $this->deleteVaultRequestService->getDeleteRequestForVault($vault_guid);
129
-		try{
129
+		try {
130 130
 			$vault = $this->vaultService->getByGuid($vault_guid, $requested_by);
131
-		} catch (\Exception $e){
131
+		} catch (\Exception $e) {
132 132
 			//Ignore
133 133
 		}
134 134
 
135
-		if(isset($vault)){
135
+		if (isset($vault)) {
136 136
 			$credentials = $this->credentialService->getCredentialsByVaultId($vault->getId(), $requested_by);
137
-			foreach($credentials as $credential){
137
+			foreach ($credentials as $credential) {
138 138
 				$revisions = $this->revisionService->getRevisions($credential->getId());
139
-				foreach($revisions as $revision){
139
+				foreach ($revisions as $revision) {
140 140
 					$this->revisionService->deleteRevision($revision['revision_id'], $requested_by);
141 141
 				}
142
-				if($credential instanceof Credential){
142
+				if ($credential instanceof Credential) {
143 143
 					$this->credentialService->deleteCredential($credential);
144 144
 				}
145 145
 			}
146 146
 			$this->vaultService->deleteVault($vault_guid, $requested_by);
147 147
 		}
148
-		if($req instanceof DeleteVaultRequest) {
148
+		if ($req instanceof DeleteVaultRequest) {
149 149
 			$this->deleteVaultRequestService->removeDeleteRequestForVault($req);
150 150
 		}
151 151
 
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 	 */
158 158
 	public function requestDeletion($vault_guid, $reason) {
159 159
 		$req = $this->deleteVaultRequestService->getDeleteRequestForVault($vault_guid);
160
-		if($req){
160
+		if ($req) {
161 161
 			return new JSONResponse('Already exists');
162 162
 		}
163 163
 		$vault = $this->vaultService->getByGuid($vault_guid, $this->userId);
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 		$result = false;
183 183
 		try {
184 184
 			$delete_request = $this->deleteVaultRequestService->getDeleteRequestForVault($vault_guid);
185
-		} catch (\Exception $exception){
185
+		} catch (\Exception $exception) {
186 186
 			// Ignore it
187 187
 		}
188 188
 
Please login to merge, or discard this patch.
lib/Settings/Admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 				}
81 81
 
82 82
 				if ($data !== false) {
83
-					$version = (string)$data->version;
83
+					$version = (string) $data->version;
84 84
 				} else {
85 85
 					libxml_clear_errors();
86 86
 				}
Please login to merge, or discard this patch.
lib/Activity.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -267,7 +267,7 @@
 block discarded – undo
267 267
 			'apps' => array(self::FILTER_PASSMAN =>
268 268
 				array(
269 269
 					'id' => 'passman',
270
-					'name' => (string)$l->t('Passwords'),
270
+					'name' => (string) $l->t('Passwords'),
271 271
 					'url' => $this->URLGenerator->linkToRoute('activity.Activities.showList', ['filter' => self::FILTER_PASSMAN]),
272 272
 				),
273 273
 			),
Please login to merge, or discard this patch.
lib/Notifier.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 			// Deal with known subjects
53 53
 			case 'credential_expired':
54 54
 				$notification->setParsedSubject(
55
-					(string)$l->t('Your credential "%s" expired, click here to update the credential.', $notification->getSubjectParameters())
55
+					(string) $l->t('Your credential "%s" expired, click here to update the credential.', $notification->getSubjectParameters())
56 56
 				);
57 57
 
58 58
 				// Deal with the actions for a known subject
@@ -60,13 +60,13 @@  discard block
 block discarded – undo
60 60
 					switch ($action->getLabel()) {
61 61
 						case 'remind':
62 62
 							$action->setParsedLabel(
63
-								(string)$l->t('Remind me later')
63
+								(string) $l->t('Remind me later')
64 64
 							);
65 65
 							break;
66 66
 
67 67
 						case 'ignore':
68 68
 							$action->setParsedLabel(
69
-								(string)$l->t('Ignore')
69
+								(string) $l->t('Ignore')
70 70
 							);
71 71
 							break;
72 72
 					}
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 			case 'credential_shared':
80 80
 				$notification->setParsedSubject(
81
-					(string)$l->t('%s shared "%s" with you. Click here to accept', $notification->getSubjectParameters())
81
+					(string) $l->t('%s shared "%s" with you. Click here to accept', $notification->getSubjectParameters())
82 82
 				);
83 83
 
84 84
 				// Deal with the actions for a known subject
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 					switch ($action->getLabel()) {
87 87
 						case 'decline':
88 88
 							$action->setParsedLabel(
89
-								(string)$l->t('Decline')
89
+								(string) $l->t('Decline')
90 90
 							);
91 91
 							break;
92 92
 					}
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
 
98 98
 			case 'credential_share_denied':
99 99
 				$notification->setParsedSubject(
100
-					(string)$l->t('%s has declined your share request for "%s".', $notification->getSubjectParameters())
100
+					(string) $l->t('%s has declined your share request for "%s".', $notification->getSubjectParameters())
101 101
 				);
102 102
 				return $notification;
103 103
 
104 104
 			case 'credential_share_accepted':
105 105
 				$notification->setParsedSubject(
106
-					(string)$l->t('%s has accepted your share request for "%s".', $notification->getSubjectParameters())
106
+					(string) $l->t('%s has accepted your share request for "%s".', $notification->getSubjectParameters())
107 107
 				);
108 108
 				return $notification;
109 109
 			default:
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -74,18 +74,18 @@  discard block
 block discarded – undo
74 74
 
75 75
 		$context->registerSearchProvider(Provider::class);
76 76
 
77
-		$context->registerService(View::class, function () {
77
+		$context->registerService(View::class, function() {
78 78
 			return new View('');
79 79
 		}, false);
80 80
 
81
-		$context->registerService('isCLI', function () {
81
+		$context->registerService('isCLI', function() {
82 82
 			return \OC::$CLI;
83 83
 		});
84 84
 
85 85
 		$context->registerMiddleware(ShareMiddleware::class);
86 86
 		$context->registerMiddleware(APIMiddleware::class);
87 87
 
88
-		$context->registerService('ShareController', function (ContainerInterface $c) {
88
+		$context->registerService('ShareController', function(ContainerInterface $c) {
89 89
 			/** @var IUserManager $userManager */
90 90
 			$userManager = $c->get(IUserManager::class);
91 91
 			/** @var IGroupManager $groupManager */
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 		});
112 112
 
113 113
 
114
-		$context->registerService('CronService', function (ContainerInterface $c) {
114
+		$context->registerService('CronService', function(ContainerInterface $c) {
115 115
 			return new CronService(
116 116
 				$c->get(CredentialService::class),
117 117
 				$c->get(LoggerInterface::class),
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 			);
123 123
 		});
124 124
 
125
-		$context->registerService('Logger', function (ContainerInterface $c) {
125
+		$context->registerService('Logger', function(ContainerInterface $c) {
126 126
 			return $c->get(ServerContainer::class)->getLogger();
127 127
 		});
128 128
 	}
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 		/** @var INavigationManager $navigationManager */
144 144
 		$navigationManager = $c->get(INavigationManager::class);
145 145
 
146
-		$navigationEntry = function () use ($c) {
146
+		$navigationEntry = function() use ($c) {
147 147
 			/** @var IURLGenerator $urlGenerator */
148 148
 			$urlGenerator = $c->get(IURLGenerator::class);
149 149
 			return [
Please login to merge, or discard this patch.
lib/Utility/Utils.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 	 * @param IUserManager $userManager
59 59
 	 * @return string
60 60
 	 */
61
-	public static function getNameByUid(string $uid, IUserManager $userManager){
61
+	public static function getNameByUid(string $uid, IUserManager $userManager) {
62 62
 		$u = $userManager->get($uid);
63 63
 		return $u->getDisplayName();
64 64
 	}
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
68 68
 	 * @param array $results
69 69
 	 * @return array|mixed
70 70
 	 */
71
-	public static function getDirContents(string $dir, &$results = array()){
71
+	public static function getDirContents(string $dir, &$results = array()) {
72 72
 		$files = scandir($dir);
73 73
 
74
-		foreach($files as $value){
75
-			$path = realpath($dir.DIRECTORY_SEPARATOR.$value);
76
-			if(!is_dir($path)) {
74
+		foreach ($files as $value) {
75
+			$path = realpath($dir . DIRECTORY_SEPARATOR . $value);
76
+			if (!is_dir($path)) {
77 77
 				$results[] = $path;
78
-			} else if($value != "." && $value != "..") {
78
+			} else if ($value != "." && $value != "..") {
79 79
 				Utils::getDirContents($path, $results);
80 80
 				$results[] = $path;
81 81
 			}
Please login to merge, or discard this patch.