nextcloud /
passman
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 25 | class VaultController extends ApiController { |
||
| 26 | private $userId; |
||
| 27 | private $vaultService; |
||
| 28 | private $credentialService; |
||
| 29 | private $settings; |
||
| 30 | |||
| 31 | View Code Duplication | public function __construct($AppName, |
|
|
|
|||
| 32 | IRequest $request, |
||
| 33 | $UserId, |
||
| 34 | VaultService $vaultService, |
||
| 35 | CredentialService $credentialService, |
||
| 36 | SettingsService $settings) { |
||
| 37 | parent::__construct( |
||
| 38 | $AppName, |
||
| 39 | $request, |
||
| 40 | 'GET, POST, DELETE, PUT, PATCH, OPTIONS', |
||
| 41 | 'Authorization, Content-Type, Accept', |
||
| 42 | 86400); |
||
| 43 | $this->userId = $UserId; |
||
| 44 | $this->vaultService = $vaultService; |
||
| 45 | $this->credentialService = $credentialService; |
||
| 46 | $this->settings = $settings; |
||
| 47 | } |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @NoAdminRequired |
||
| 51 | * @NoCSRFRequired |
||
| 52 | */ |
||
| 53 | 1 | public function listVaults() { |
|
| 54 | 1 | $result = array(); |
|
| 55 | 1 | $vaults = $this->vaultService->getByUser($this->userId); |
|
| 56 | |||
| 57 | 1 | $protected_credential_fields = array('getDescription', 'getEmail', 'getUsername', 'getPassword'); |
|
| 58 | 1 | if (isset($vaults)) { |
|
| 59 | foreach ($vaults as $vault) { |
||
| 60 | $credential = $this->credentialService->getRandomCredentialByVaultId($vault->getId(), $this->userId); |
||
| 61 | $secret_field = $protected_credential_fields[array_rand($protected_credential_fields)]; |
||
| 62 | if(isset($credential)) { |
||
| 63 | array_push($result, array( |
||
| 64 | 'vault_id' => $vault->getId(), |
||
| 65 | 'guid' => $vault->getGuid(), |
||
| 66 | 'name' => $vault->getName(), |
||
| 67 | 'created' => $vault->getCreated(), |
||
| 68 | 'public_sharing_key' => $vault->getPublicSharingKey(), |
||
| 69 | 'last_access' => $vault->getlastAccess(), |
||
| 70 | 'challenge_password' => $credential->{$secret_field}(), |
||
| 71 | )); |
||
| 72 | } |
||
| 73 | } |
||
| 74 | } |
||
| 75 | |||
| 76 | 1 | return new JSONResponse($result); |
|
| 77 | } |
||
| 78 | |||
| 79 | /** |
||
| 80 | * @NoAdminRequired |
||
| 81 | * @NoCSRFRequired |
||
| 82 | */ |
||
| 83 | 1 | public function create($vault_name) { |
|
| 87 | |||
| 88 | /** |
||
| 89 | * @NoAdminRequired |
||
| 90 | * @NoCSRFRequired |
||
| 91 | */ |
||
| 92 | 1 | public function get($vault_guid) { |
|
| 93 | 1 | $vault = null; |
|
| 94 | try { |
||
| 95 | 1 | $vault = $this->vaultService->getByGuid($vault_guid, $this->userId); |
|
| 96 | } catch (\Exception $e) { |
||
| 97 | return new NotFoundJSONResponse(); |
||
| 98 | } |
||
| 99 | 1 | $result = array(); |
|
| 100 | 1 | if (isset($vault)) { |
|
| 101 | $credentials = $this->credentialService->getCredentialsByVaultId($vault->getId(), $this->userId); |
||
| 102 | |||
| 103 | $result = array( |
||
| 104 | 'vault_id' => $vault->getId(), |
||
| 105 | 'guid' => $vault->getGuid(), |
||
| 106 | 'name' => $vault->getName(), |
||
| 107 | 'created' => $vault->getCreated(), |
||
| 108 | 'private_sharing_key' => $vault->getPrivateSharingKey(), |
||
| 109 | 'public_sharing_key' => $vault->getPublicSharingKey(), |
||
| 110 | 'sharing_keys_generated' => $vault->getSharingKeysGenerated(), |
||
| 111 | 'vault_settings' => $vault->getVaultSettings(), |
||
| 112 | 'last_access' => $vault->getlastAccess() |
||
| 113 | ); |
||
| 114 | $result['credentials'] = $credentials; |
||
| 115 | |||
| 116 | $this->vaultService->setLastAccess($vault->getId(), $this->userId); |
||
| 117 | } |
||
| 118 | |||
| 119 | |||
| 120 | 1 | return new JSONResponse($result); |
|
| 121 | } |
||
| 122 | |||
| 123 | /** |
||
| 124 | * @NoAdminRequired |
||
| 125 | * @NoCSRFRequired |
||
| 126 | */ |
||
| 127 | 1 | public function update($vault_guid, $name, $vault_settings) { |
|
| 128 | 1 | $vault = $this->vaultService->getByGuid($vault_guid, $this->userId); |
|
| 129 | 1 | if ($name && $vault) { |
|
| 130 | $vault->setName($name); |
||
| 131 | } |
||
| 132 | 1 | if ($vault_settings && $vault) { |
|
| 133 | $vault->setVaultSettings($vault_settings); |
||
| 134 | } |
||
| 135 | 1 | $this->vaultService->updateVault($vault); |
|
| 136 | 1 | } |
|
| 137 | |||
| 138 | /** |
||
| 139 | * @NoAdminRequired |
||
| 140 | * @NoCSRFRequired |
||
| 141 | */ |
||
| 142 | 1 | public function updateSharingKeys($vault_guid, $private_sharing_key, $public_sharing_key) { |
|
| 143 | 1 | $vault = null; |
|
| 144 | try { |
||
| 145 | 1 | $vault = $this->vaultService->getByGuid($vault_guid, $this->userId); |
|
| 146 | } catch (\Exception $e) { |
||
| 147 | // No need to catch the execption |
||
| 148 | } |
||
| 149 | |||
| 150 | 1 | if ($vault) { |
|
| 151 | $this->vaultService->updateSharingKeys($vault->getId(), $private_sharing_key, $public_sharing_key); |
||
| 152 | } |
||
| 153 | |||
| 154 | 1 | return; |
|
| 155 | } |
||
| 156 | |||
| 157 | /** |
||
| 158 | * @NoAdminRequired |
||
| 159 | * @NoCSRFRequired |
||
| 160 | */ |
||
| 161 | 1 | public function delete($vault_guid) { |
|
| 165 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.