Completed
Push — master ( 197620...ce588f )
by Sander
02:30
created
controller/vaultcontroller.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 		try {
80 80
 			$vault = $this->vaultService->getByGuid($vault_guid, $this->userId);
81 81
 		} catch (DoesNotExistException $e) {
82
-            return new NotFoundJSONResponse();
82
+			return new NotFoundJSONResponse();
83 83
 		}
84 84
 		$result = array();
85 85
 		if ($vault) {
Please login to merge, or discard this patch.
controller/sharecontroller.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -409,11 +409,11 @@
 block discarded – undo
409 409
 		//@TODO Check expire date
410 410
 		$acl = $this->shareService->getACL(null, $credential_guid);
411 411
 
412
-        if ($acl->getExpire() > 0 && Utils::getTime() > $acl->getExpire()) {
412
+		if ($acl->getExpire() > 0 && Utils::getTime() > $acl->getExpire()) {
413 413
 			return new NotFoundJSONResponse();
414 414
 		}
415 415
 
416
-        $views = $acl->getExpireViews();
416
+		$views = $acl->getExpireViews();
417 417
 		if ($views === 0) {
418 418
 			return new NotFoundJSONResponse();
419 419
 		} else if ($views != -1) {
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 				$server->getUserManager(),
56 56
  				$c->query('ActivityService'),
57 57
  				$c->query('VaultService'),
58
-                $c->query('ShareService'),
59
-                $c->query('CredentialService'),
60
-                $c->query('NotificationService'),
61
-                $c->query('FileService')
58
+				$c->query('ShareService'),
59
+				$c->query('CredentialService'),
60
+				$c->query('NotificationService'),
61
+				$c->query('FileService')
62 62
 			);
63 63
 		});
64 64
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 		$container->registerAlias('ActivityService', ActivityService::class);
95 95
 		$container->registerAlias('VaultService', VaultService::class);
96 96
 		$container->registerAlias('FileService', FileService::class);
97
-        $container->registerAlias('ShareService', ShareService::class);
97
+		$container->registerAlias('ShareService', ShareService::class);
98 98
 		$container->registerAlias('Utils', Utils::class);
99 99
 	}
100 100
 
Please login to merge, or discard this patch.
lib/Service/CredentialService.php 1 patch
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -23,11 +23,11 @@  discard block
 block discarded – undo
23 23
 class CredentialService {
24 24
 
25 25
 	private $credentialMapper;
26
-    private $sharingACL;
26
+	private $sharingACL;
27 27
 
28 28
 	public function __construct(CredentialMapper $credentialMapper, SharingACLMapper $sharingACL) {
29 29
 		$this->credentialMapper = $credentialMapper;
30
-        $this->sharingACL = $sharingACL;
30
+		$this->sharingACL = $sharingACL;
31 31
 	}
32 32
 
33 33
 	/**
@@ -65,23 +65,23 @@  discard block
 block discarded – undo
65 65
 	}
66 66
 
67 67
 	public function getCredentialById($credential_id, $user_id){
68
-        $credential = $this->credentialMapper->getCredentialById($credential_id);
69
-        if ($credential->getUserId() == $user_id){
70
-            return $credential;
71
-        }
72
-        else {
73
-            $acl = $this->sharingACL->getItemACL($user_id, $credential->getGuid());
74
-            if ($acl->hasPermission(SharingACL::READ));
75
-            return $credential;
76
-        }
77
-
78
-        throw new DoesNotExistException("Did expect one result but found none when executing");
68
+		$credential = $this->credentialMapper->getCredentialById($credential_id);
69
+		if ($credential->getUserId() == $user_id){
70
+			return $credential;
71
+		}
72
+		else {
73
+			$acl = $this->sharingACL->getItemACL($user_id, $credential->getGuid());
74
+			if ($acl->hasPermission(SharingACL::READ));
75
+			return $credential;
76
+		}
77
+
78
+		throw new DoesNotExistException("Did expect one result but found none when executing");
79 79
 	}
80 80
 	public function getCredentialLabelById($credential_id){
81 81
 		return $this->credentialMapper->getCredentialLabelById($credential_id);
82 82
 	}
83 83
 
84 84
 	public function getCredentialByGUID($credential_guid, $user_id = null){
85
-	    return $this->credentialMapper->getCredentialByGUID($credential_guid, $user_id);
86
-    }
85
+		return $this->credentialMapper->getCredentialByGUID($credential_guid, $user_id);
86
+	}
87 87
 }
88 88
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Service/ShareService.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -176,31 +176,31 @@  discard block
 block discarded – undo
176 176
 	}
177 177
 
178 178
 
179
-    /**
180
-     * Deletes a share request by the item ID
181
-     * @param ShareRequest $request
182
-     * @return \PDOStatement
183
-     */
179
+	/**
180
+	 * Deletes a share request by the item ID
181
+	 * @param ShareRequest $request
182
+	 * @return \PDOStatement
183
+	 */
184 184
 	public function cleanItemRequestsForUser(ShareRequest $request) {
185 185
 		return $this->shareRequest->cleanItemRequestsForUser($request->getItemId(), $request->getTargetUserId());
186 186
 	}
187 187
 
188
-    /**
189
-     * Get an share request by id
190
-     * @param $id
191
-     * @return ShareRequest
192
-     */
188
+	/**
189
+	 * Get an share request by id
190
+	 * @param $id
191
+	 * @return ShareRequest
192
+	 */
193 193
 	public function getShareRequestById($id) {
194 194
 		return $this->shareRequest->getShareRequestById($id);
195 195
 	}
196 196
 
197
-    /**
198
-     * Get an share request by $item_guid and $target_vault_guid
199
-     *
200
-     * @param $item_guid
201
-     * @param $target_vault_guid
202
-     * @return ShareRequest
203
-     */
197
+	/**
198
+	 * Get an share request by $item_guid and $target_vault_guid
199
+	 *
200
+	 * @param $item_guid
201
+	 * @param $target_vault_guid
202
+	 * @return ShareRequest
203
+	 */
204 204
 	public function getRequestByGuid($item_guid, $target_vault_guid) {
205 205
 		return $this->shareRequest->getRequestByItemAndVaultGuid($item_guid, $target_vault_guid);
206 206
 	}
@@ -260,11 +260,11 @@  discard block
 block discarded – undo
260 260
 		return $this->sharingACL->deleteShareACL($ACL);
261 261
 	}
262 262
 
263
-    /**
264
-     * Updates the given ACL entry
265
-     * @param SharingACL $sharingACL
266
-     * @return SharingACL
267
-     */
263
+	/**
264
+	 * Updates the given ACL entry
265
+	 * @param SharingACL $sharingACL
266
+	 * @return SharingACL
267
+	 */
268 268
 	public function updateCredentialACL(SharingACL $sharingACL) {
269 269
 		return $this->sharingACL->updateCredentialACL($sharingACL);
270 270
 	}
@@ -286,6 +286,6 @@  discard block
 block discarded – undo
286 286
 
287 287
 
288 288
 	public function updatePendingShareRequestsForCredential($item_guid, $user_id, $permissions){
289
-	    return $this->shareRequest->updatePendinRequestPermissions($item_guid, $user_id, $permissions);
290
-    }
289
+		return $this->shareRequest->updatePendinRequestPermissions($item_guid, $user_id, $permissions);
290
+	}
291 291
 }
292 292
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Db/SharingACL.php 1 patch
Indentation   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -38,50 +38,50 @@
 block discarded – undo
38 38
 class SharingACL extends PermissionEntity implements \JsonSerializable
39 39
 {
40 40
 
41
-    protected
42
-        $itemId,
43
-        $itemGuid,
44
-        $userId,
45
-        $created,
46
-        $expire,
41
+	protected
42
+		$itemId,
43
+		$itemGuid,
44
+		$userId,
45
+		$created,
46
+		$expire,
47 47
 		$expireViews,
48
-        $permissions,
49
-        $vaultId,
50
-        $vaultGuid,
51
-        $sharedKey;
48
+		$permissions,
49
+		$vaultId,
50
+		$vaultGuid,
51
+		$sharedKey;
52 52
 
53 53
 
54
-    public function __construct() {
55
-        // add types in constructor
56
-        $this->addType('itemId', 'integer');
57
-        $this->addType('created', 'integer');
58
-        $this->addType('expire', 'integer');
59
-        $this->addType('expireViews', 'integer');
60
-        $this->addType('permissions', 'integer');
61
-    }
54
+	public function __construct() {
55
+		// add types in constructor
56
+		$this->addType('itemId', 'integer');
57
+		$this->addType('created', 'integer');
58
+		$this->addType('expire', 'integer');
59
+		$this->addType('expireViews', 'integer');
60
+		$this->addType('permissions', 'integer');
61
+	}
62 62
 
63
-    /**
64
-     * Specify data which should be serialized to JSON
65
-     * @link http://php.net/manual/en/jsonserializable.jsonserialize.php
66
-     * @return mixed data which can be serialized by <b>json_encode</b>,
67
-     * which is a value of any type other than a resource.
68
-     * @since 5.4.0
69
-     */
70
-    function jsonSerialize()
71
-    {
72
-        return [
73
-            'acl_id' => $this->getId(),
74
-            'item_id' => $this->getItemId(),
75
-            'item_guid' => $this->getItemGuid(),
76
-            'user_id' => $this->getUserId(),
77
-            'created' => $this->getCreated(),
78
-            'expire' => $this->getExpire(),
79
-            'expire_views' => $this->getExpireViews(),
80
-            'permissions' => $this->getPermissions(),
81
-            'vault_id' => $this->getVaultId(),
82
-            'vault_guid' => $this->getVaultGuid(),
83
-            'shared_key' => $this->getSharedKey(),
84
-            'pending' => false,
85
-        ];
86
-    }
63
+	/**
64
+	 * Specify data which should be serialized to JSON
65
+	 * @link http://php.net/manual/en/jsonserializable.jsonserialize.php
66
+	 * @return mixed data which can be serialized by <b>json_encode</b>,
67
+	 * which is a value of any type other than a resource.
68
+	 * @since 5.4.0
69
+	 */
70
+	function jsonSerialize()
71
+	{
72
+		return [
73
+			'acl_id' => $this->getId(),
74
+			'item_id' => $this->getItemId(),
75
+			'item_guid' => $this->getItemGuid(),
76
+			'user_id' => $this->getUserId(),
77
+			'created' => $this->getCreated(),
78
+			'expire' => $this->getExpire(),
79
+			'expire_views' => $this->getExpireViews(),
80
+			'permissions' => $this->getPermissions(),
81
+			'vault_id' => $this->getVaultId(),
82
+			'vault_guid' => $this->getVaultGuid(),
83
+			'shared_key' => $this->getSharedKey(),
84
+			'pending' => false,
85
+		];
86
+	}
87 87
 }
88 88
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Db/CredentialMapper.php 1 patch
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -44,18 +44,18 @@  discard block
 block discarded – undo
44 44
 		return $this->findEntities($sql, [$timestamp]);
45 45
 	}
46 46
 
47
-    /**
48
-     * @param $credential_id
49
-     * @param null $user_id
50
-     * @return Credential
51
-     */
47
+	/**
48
+	 * @param $credential_id
49
+	 * @param null $user_id
50
+	 * @return Credential
51
+	 */
52 52
 	public function getCredentialById($credential_id, $user_id = null){
53 53
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
54 54
 			'WHERE `id` = ?';
55
-        // If we want to check the owner, add it to the query
55
+		// If we want to check the owner, add it to the query
56 56
 		$params = [$credential_id];
57
-        if ($user_id !== null){
58
-        	$sql .= ' and `user_id` = ? ';
57
+		if ($user_id !== null){
58
+			$sql .= ' and `user_id` = ? ';
59 59
 			array_push($params, $user_id);
60 60
 		}
61 61
 		return $this->findEntity($sql,$params);
@@ -135,18 +135,18 @@  discard block
 block discarded – undo
135 135
 		$this->update($credential);
136 136
 	}
137 137
 
138
-    /**
139
-     * Finds a credential by the given guid
140
-     * @param $credential_guid
141
-     * @return Credential
142
-     */
138
+	/**
139
+	 * Finds a credential by the given guid
140
+	 * @param $credential_guid
141
+	 * @return Credential
142
+	 */
143 143
 	public function getCredentialByGUID($credential_guid, $user_id = null){
144
-	    $q = 'SELECT * FROM `*PREFIX*passman_credentials` WHERE guid = ? ';
144
+		$q = 'SELECT * FROM `*PREFIX*passman_credentials` WHERE guid = ? ';
145 145
 		$params = [$credential_guid];
146 146
 		if ($user_id !== null){
147 147
 			$q .= ' and `user_id` = ? ';
148 148
 			array_push($params, $user_id);
149 149
 		}
150
-        return $this->findEntity($q, $params);
151
-    }
150
+		return $this->findEntity($q, $params);
151
+	}
152 152
 }
153 153
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Db/SharingACLMapper.php 1 patch
Indentation   +67 added lines, -67 removed lines patch added patch discarded remove patch
@@ -16,81 +16,81 @@
 block discarded – undo
16 16
 use OCA\Passman\Utility\Utils;
17 17
 
18 18
 class SharingACLMapper extends Mapper {
19
-    const TABLE_NAME = '*PREFIX*passman_sharing_acl';
19
+	const TABLE_NAME = '*PREFIX*passman_sharing_acl';
20 20
 
21
-    public function __construct(IDBConnection $db, Utils $utils) {
22
-        parent::__construct($db, 'passman_sharing_acl');
23
-        $this->utils = $utils;
24
-    }
21
+	public function __construct(IDBConnection $db, Utils $utils) {
22
+		parent::__construct($db, 'passman_sharing_acl');
23
+		$this->utils = $utils;
24
+	}
25 25
 
26
-    /**
27
-     * Gets all the credential data for the given user
28
-     * @param $userId
29
-     * @param $item_guid
30
-     * @return SharingACL[]
31
-     */
32
-    public function getCredentialPermissions(IUser $userId, $item_guid){
33
-        $sql = "SELECT * FROM ". self::TABLE_NAME ." WHERE user_id = ? AND item_guid = ?";
26
+	/**
27
+	 * Gets all the credential data for the given user
28
+	 * @param $userId
29
+	 * @param $item_guid
30
+	 * @return SharingACL[]
31
+	 */
32
+	public function getCredentialPermissions(IUser $userId, $item_guid){
33
+		$sql = "SELECT * FROM ". self::TABLE_NAME ." WHERE user_id = ? AND item_guid = ?";
34 34
 
35
-        return $this->findEntities($sql, [$userId, $item_guid]);
36
-    }
35
+		return $this->findEntities($sql, [$userId, $item_guid]);
36
+	}
37 37
 
38
-    public function createACLEntry(SharingACL $acl){
39
-        return $this->insert($acl);
40
-    }
38
+	public function createACLEntry(SharingACL $acl){
39
+		return $this->insert($acl);
40
+	}
41 41
 
42
-    /**
43
-     * Gets the currently accepted share requests from the given user for the given vault guid
44
-     * @param $user_id
45
-     * @param $vault_id
46
-     * @return SharingACL[]
47
-     */
48
-    public function getVaultEntries($user_id, $vault_id) {
49
-        $q = "SELECT * FROM ". self::TABLE_NAME ." WHERE user_id = ? AND vault_guid = ?";
50
-        return $this->findEntities($q, [$user_id, $vault_id]);
51
-    }
42
+	/**
43
+	 * Gets the currently accepted share requests from the given user for the given vault guid
44
+	 * @param $user_id
45
+	 * @param $vault_id
46
+	 * @return SharingACL[]
47
+	 */
48
+	public function getVaultEntries($user_id, $vault_id) {
49
+		$q = "SELECT * FROM ". self::TABLE_NAME ." WHERE user_id = ? AND vault_guid = ?";
50
+		return $this->findEntities($q, [$user_id, $vault_id]);
51
+	}
52 52
 
53
-    /**
54
-     * Gets the acl for a given item guid
55
-     * @param $user_id
56
-     * @param $item_guid
57
-     * @return SharingACL
58
-     */
59
-    public function getItemACL($user_id, $item_guid) {
60
-        $q = "SELECT * FROM " . self::TABLE_NAME . " WHERE item_guid = ? AND ";
61
-        $filter = [$item_guid];
62
-        if ($user_id == null){
63
-            $q .= 'user_id is null';
64
-        }
65
-        else {
66
-            $q .= 'user_id = ? ';
67
-            $filter[] = $user_id;
68
-        }
69
-        return $this->findEntity($q, $filter);
70
-    }
53
+	/**
54
+	 * Gets the acl for a given item guid
55
+	 * @param $user_id
56
+	 * @param $item_guid
57
+	 * @return SharingACL
58
+	 */
59
+	public function getItemACL($user_id, $item_guid) {
60
+		$q = "SELECT * FROM " . self::TABLE_NAME . " WHERE item_guid = ? AND ";
61
+		$filter = [$item_guid];
62
+		if ($user_id == null){
63
+			$q .= 'user_id is null';
64
+		}
65
+		else {
66
+			$q .= 'user_id = ? ';
67
+			$filter[] = $user_id;
68
+		}
69
+		return $this->findEntity($q, $filter);
70
+	}
71 71
 
72
-    /**
73
-     * Update the acl for a given item guid
74
-     * @param $user_id
75
-     * @param $item_guid
76
-     * @return SharingACL
77
-     */
78
-    public function updateCredentialACL(SharingACL $sharingACL) {
79
-        return $this->update($sharingACL);
80
-    }
72
+	/**
73
+	 * Update the acl for a given item guid
74
+	 * @param $user_id
75
+	 * @param $item_guid
76
+	 * @return SharingACL
77
+	 */
78
+	public function updateCredentialACL(SharingACL $sharingACL) {
79
+		return $this->update($sharingACL);
80
+	}
81 81
 
82
-    /**
83
-     * Gets the currently accepted share requests from the given user for the given vault guid
84
-     * @param $user_id
85
-     * @param $vault_id
86
-     * @return SharingACL[]
87
-     */
88
-    public function getCredentialAclList($item_guid) {
89
-        $q = "SELECT * FROM ". self::TABLE_NAME ." WHERE item_guid = ?";
90
-        return $this->findEntities($q, [$item_guid]);
91
-    }
82
+	/**
83
+	 * Gets the currently accepted share requests from the given user for the given vault guid
84
+	 * @param $user_id
85
+	 * @param $vault_id
86
+	 * @return SharingACL[]
87
+	 */
88
+	public function getCredentialAclList($item_guid) {
89
+		$q = "SELECT * FROM ". self::TABLE_NAME ." WHERE item_guid = ?";
90
+		return $this->findEntities($q, [$item_guid]);
91
+	}
92 92
 
93
-    public function deleteShareACL(SharingACL $ACL){
94
-    	return $this->delete($ACL);
93
+	public function deleteShareACL(SharingACL $ACL){
94
+		return $this->delete($ACL);
95 95
 	}
96 96
 }
97 97
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Db/File.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 /**
16 16
  * @method integer getId()
17 17
  * @method void setId(integer $value)
18
-  * @method void setGuid(string $value)
18
+ * @method void setGuid(string $value)
19 19
  * @method string getGuid()
20 20
  * @method void setUserId(string $value)
21 21
  * @method string getUserid()
Please login to merge, or discard this patch.