nextcloud / passman

lib/Db/ShareRequest.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
         ];
     }
 
-    function asACLJson(){
+    function asACLJson() {
         return [
             'item_id' => $this->getItemId(),
             'item_guid' => $this->getItemGuid(),

lib/Db/EntityJSONSerializer.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 trait EntityJSONSerializer {
 	public function serializeFields($properties) {
 		$result = [];
-		foreach($properties as $property) {
+		foreach ($properties as $property) {
 			$result[$property] = $this->$property;
 		}
 		return $result;

lib/Utility/PermissionEntity.php

Spacing +4 added lines, -4 removed lines

@@ -13,11 +13,11 @@
 use OCP\AppFramework\Db\Entity;
 
 class PermissionEntity extends Entity {
-    CONST READ  =   0b00000001;
-    CONST WRITE =   0b00000010;
-    CONST FILES =   0b00000100;
+    CONST READ  = 0b00000001;
+    CONST WRITE = 0b00000010;
+    CONST FILES = 0b00000100;
     CONST HISTORY = 0b00001000;
-    CONST OWNER =   0b10000000;
+    CONST OWNER = 0b10000000;
 
     /**
      * Checks wether a user matches one or more permissions at once

lib/Activity.php

Spacing +1 added lines, -1 removed lines

@@ -241,7 +241,7 @@
 				array(
 					'id' => 'passman',
 					'name' => (string) $l->t('Passwords'),
-					'url' => '',//FIXME: Currenlty we cannot link directly to links, so this needs to be fixed... this->URLGenerator->linkToRoute('activity.Activities.showList', array('filter' => 'passman')),
+					'url' => '', //FIXME: Currenlty we cannot link directly to links, so this needs to be fixed... this->URLGenerator->linkToRoute('activity.Activities.showList', array('filter' => 'passman')),
 				),
 			),
 		);

lib/Db/ShareRequestMapper.php

Spacing +13 added lines, -13 removed lines

@@ -22,7 +22,7 @@ 
         parent::__construct($db, self::TABLE_NAME);
     }
 
-    public function createRequest(ShareRequest $request){
+    public function createRequest(ShareRequest $request) {
         return $this->insert($request);
     }
 
@@ -32,7 +32,7 @@ 
      * @param $target_vault_guid
      * @return ShareRequest
      */
-    public function getRequestByItemAndVaultGuid($item_guid, $target_vault_guid){
+    public function getRequestByItemAndVaultGuid($item_guid, $target_vault_guid) {
         $q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE item_guid = ? AND target_vault_guid = ?";
         return $this->findEntity($q, [$item_guid, $target_vault_guid]);
     }
@@ -42,8 +42,8 @@ 
      * @param $item_guid
      * @return ShareRequest[]
      */
-    public function getRequestsByItemGuidGroupedByUser($item_guid){
-    	if (strtolower($this->db->getDatabasePlatform()->getName()) === 'mysql'){
+    public function getRequestsByItemGuidGroupedByUser($item_guid) {
+    	if (strtolower($this->db->getDatabasePlatform()->getName()) === 'mysql') {
     		$this->db->executeQuery("SET sql_mode = '';");
 		}
         $q = "SELECT *, target_user_id FROM *PREFIX*" . self::TABLE_NAME . " WHERE item_guid = ? GROUP BY target_user_id;";
@@ -56,7 +56,7 @@ 
      * @param $target_user_id   The target user
      * @return \PDOStatement    The result of running the db query
      */
-    public function cleanItemRequestsForUser($item_id, $target_user_id){
+    public function cleanItemRequestsForUser($item_id, $target_user_id) {
 		$q = "DELETE FROM *PREFIX*" . self::TABLE_NAME . " WHERE item_id = ? AND target_user_id = ?";
 		$this->execute($q, [$item_id, $target_user_id]);
         return $this->execute($q, [$item_id, $target_user_id]);
@@ -67,8 +67,8 @@ 
      * @param $user_id
      * @return ShareRequest[]
      */
-    public function getUserPendingRequests($user_id){
-        $q = "SELECT * FROM *PREFIX*". self::TABLE_NAME ." WHERE target_user_id = ?";
+    public function getUserPendingRequests($user_id) {
+        $q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE target_user_id = ?";
         return $this->findEntities($q, [$user_id]);
     }
 
@@ -77,7 +77,7 @@ 
      * @param ShareRequest $shareRequest    Request to delete
      * @return ShareRequest                 The deleted request
      */
-    public function deleteShareRequest(ShareRequest $shareRequest){
+    public function deleteShareRequest(ShareRequest $shareRequest) {
     	return $this->delete($shareRequest);
 	}
 
@@ -87,7 +87,7 @@ 
      * @return ShareRequest
 	 * @throws DoesNotExistException
      */
-	public function getShareRequestById($id){
+	public function getShareRequestById($id) {
 		$q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE id = ?";
 		return $this->findEntity($q, [$id]);
 	}
@@ -97,7 +97,7 @@ 
      * @param $item_guid
      * @return ShareRequest[]
      */
-	public function getShareRequestsByItemGuid($item_guid){
+	public function getShareRequestsByItemGuid($item_guid) {
 		$q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE 	item_guid = ?";
 		return $this->findEntities($q, [$item_guid]);
 	}
@@ -107,7 +107,7 @@ 
      * @param ShareRequest $shareRequest
      * @return ShareRequest
      */
-	public function updateShareRequest(ShareRequest $shareRequest){
+	public function updateShareRequest(ShareRequest $shareRequest) {
 		return $this->update($shareRequest);
 	}
 
@@ -117,7 +117,7 @@ 
      * @param $user_id
      * @return ShareRequest[]
      */
-	public function getPendingShareRequests($item_guid, $user_id){
+	public function getPendingShareRequests($item_guid, $user_id) {
 		$q = "SELECT * FROM *PREFIX*" . self::TABLE_NAME . " WHERE 	item_guid = ? and target_user_id= ?";
 		return $this->findEntities($q, [$item_guid, $user_id]);
 	}
@@ -129,7 +129,7 @@ 
      * @param $permissions      The new permissions to apply
      * @return \PDOStatement    The result of the operation
      */
-	public function updatePendingRequestPermissions($item_guid, $user_id, $permissions){
+	public function updatePendingRequestPermissions($item_guid, $user_id, $permissions) {
 	    $q = "UPDATE *PREFIX*" . self::TABLE_NAME . " SET permissions = ? WHERE item_guid = ? AND target_user_id = ?";
         return $this->execute($q, [$permissions, $item_guid, $user_id]);
     }

lib/Service/CredentialService.php

Spacing +5 added lines, -5 removed lines

@@ -75,7 +75,7 @@ 
 	 * @param Credential $credential
 	 * @return \OCP\AppFramework\Db\Entity
 	 */
-	public function deleteCredential(Credential $credential){
+	public function deleteCredential(Credential $credential) {
 		return $this->credentialMapper->deleteCredential($credential);
 	}
 
@@ -116,9 +116,9 @@ 
 	 * @return Credential
 	 * @throws DoesNotExistException
 	 */
-	public function getCredentialById($credential_id, $user_id){
+	public function getCredentialById($credential_id, $user_id) {
         $credential = $this->credentialMapper->getCredentialById($credential_id);
-        if ($credential->getUserId() === $user_id){
+        if ($credential->getUserId() === $user_id) {
             return $credential;
         }
         else {
@@ -135,7 +135,7 @@ 
 	 * @param $credential_id
 	 * @return Credential
 	 */
-	public function getCredentialLabelById($credential_id){
+	public function getCredentialLabelById($credential_id) {
 		return $this->credentialMapper->getCredentialLabelById($credential_id);
 	}
 
@@ -145,7 +145,7 @@ 
 	 * @param null $user_id
 	 * @return Credential
 	 */
-	public function getCredentialByGUID($credential_guid, $user_id = null){
+	public function getCredentialByGUID($credential_guid, $user_id = null) {
 	    return $this->credentialMapper->getCredentialByGUID($credential_guid, $user_id);
     }
 }
\ No newline at end of file

lib/Service/ActivityService.php

Spacing +4 added lines, -4 removed lines

@@ -48,10 +48,10 @@
 	 * @param $type string
 	 * @return array
 	 */
-	public function add($subject,$subjectParams=array(),
-						$message='',$messageParams=array(),
-						$link='',$user=null,$type='') {
-		if($user) {
+	public function add($subject, $subjectParams = array(),
+						$message = '', $messageParams = array(),
+						$link = '', $user = null, $type = '') {
+		if ($user) {
 			$activity = $this->manager->generateEvent();
 			$activity->setType($type);
 			$activity->setApp('passman');

controller/credentialcontroller.php

Spacing +2 added lines, -2 removed lines

@@ -163,13 +163,13 @@
 				$activity . '_self', array($label, $this->userId, $revision_created),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() === 0) && (int)$delete_time > 0) {
+		} else if (($storedCredential->getDeleteTime() === 0) && (int) $delete_time > 0) {
 			$activity = 'item_deleted';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() > 0) && (int)$delete_time === 0) {
+		} else if (($storedCredential->getDeleteTime() > 0) && (int) $delete_time === 0) {
 			$activity = 'item_recovered';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),

lib/Db/CredentialMapper.php

Spacing +14 added lines, -14 removed lines

@@ -57,7 +57,7 @@ 
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `user_id` = ? and vault_id = ? AND shared_key is NULL LIMIT 20';
 		$entities = $this->findEntities($sql, [$user_id, $vault_id]);
-		$count = count($entities)-1;
+		$count = count($entities) - 1;
 		$entities = array_splice($entities, rand(0, $count), 1);
 		return $entities;
 	}
@@ -67,7 +67,7 @@ 
 	 * @param $timestamp
 	 * @return Credential[]
 	 */
-	public function getExpiredCredentials($timestamp){
+	public function getExpiredCredentials($timestamp) {
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `expire_time` > 0 AND `expire_time` < ?';
 		return $this->findEntities($sql, [$timestamp]);
@@ -80,16 +80,16 @@ 
      * @param null $user_id
      * @return Credential
      */
-	public function getCredentialById($credential_id, $user_id = null){
+	public function getCredentialById($credential_id, $user_id = null) {
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `id` = ?';
         // If we want to check the owner, add it to the query
 		$params = [$credential_id];
-        if ($user_id !== null){
+        if ($user_id !== null) {
         	$sql .= ' and `user_id` = ? ';
 			array_push($params, $user_id);
 		}
-		return $this->findEntity($sql,$params);
+		return $this->findEntity($sql, $params);
 	}
 
 	/**
@@ -97,10 +97,10 @@ 
 	 * @param $credential_id
 	 * @return Credential
 	 */
-	public function getCredentialLabelById($credential_id){
+	public function getCredentialLabelById($credential_id) {
 		$sql = 'SELECT id, label FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `id` = ? ';
-		return $this->findEntity($sql,[$credential_id]);
+		return $this->findEntity($sql, [$credential_id]);
 	}
 
 	/**
@@ -108,7 +108,7 @@ 
 	 * @param $raw_credential
 	 * @return Credential
 	 */
-	public function create($raw_credential){
+	public function create($raw_credential) {
 		$credential = new Credential();
 
 		$credential->setGuid($this->utils->GUID());
@@ -131,7 +131,7 @@ 
 		$credential->setCustomFields($raw_credential['custom_fields']);
 		$credential->setOtp($raw_credential['otp']);
 		$credential->setHidden($raw_credential['hidden']);
-		if(isset($raw_credential['shared_key'])) {
+		if (isset($raw_credential['shared_key'])) {
 			$credential->setSharedKey($raw_credential['shared_key']);
 		}
 		return parent::insert($credential);
@@ -142,7 +142,7 @@ 
 	 * @param $raw_credential array An array containing all the credential fields
 	 * @return Credential The updated credential
 	 */
-	public function updateCredential($raw_credential){
+	public function updateCredential($raw_credential) {
 		$original = $this->getCredentialByGUID($raw_credential['guid']);
 		$credential = new Credential();
 		$credential->setId($original->getId());
@@ -170,11 +170,11 @@ 
 		return parent::update($credential);
 	}
 
-	public function deleteCredential(Credential $credential){
+	public function deleteCredential(Credential $credential) {
 		return $this->delete($credential);
 	}
 
-	public function upd(Credential $credential){
+	public function upd(Credential $credential) {
 		$this->update($credential);
 	}
 
@@ -183,10 +183,10 @@ 
      * @param $credential_guid
      * @return Credential
      */
-	public function getCredentialByGUID($credential_guid, $user_id = null){
+	public function getCredentialByGUID($credential_guid, $user_id = null) {
 	    $q = 'SELECT * FROM `*PREFIX*passman_credentials` WHERE guid = ? ';
 		$params = [$credential_guid];
-		if ($user_id !== null){
+		if ($user_id !== null) {
 			$q .= ' and `user_id` = ? ';
 			array_push($params, $user_id);
 		}