Application::register() - Code Metrics - Inspection of "Merge branch 'binsky08-nc22-ready'" - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( a9bae3...93cd59 )

by Marcos

created 2021-03-22 14:15 UTC

Application::register() B

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	56
rs	8.9599
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Nextcloud - passman
 *
 * @copyright Copyright (c) 2016, Sander Brand ([email protected])
 * @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Passman\AppInfo;

use OC\Files\View;
use OC\ServerContainer;
use OCA\Passman\Controller\ShareController;
use OCA\Passman\Middleware\APIMiddleware;
use OCA\Passman\Middleware\ShareMiddleware;
use OCA\Passman\Notifier;
use OCA\Passman\Search\Provider;
use OCA\Passman\Service\ActivityService;
use OCA\Passman\Service\CredentialService;
use OCA\Passman\Service\CronService;
use OCA\Passman\Service\FileService;
use OCA\Passman\Service\NotificationService;
use OCA\Passman\Service\SettingsService;
use OCA\Passman\Service\ShareService;
use OCA\Passman\Service\VaultService;
use OCA\Passman\Utility\Utils;
use OCP\AppFramework\App;
use OCP\AppFramework\Bootstrap\IBootContext;
use OCP\AppFramework\Bootstrap\IBootstrap;
use OCP\AppFramework\Bootstrap\IRegistrationContext;
use OCP\IDBConnection;
use OCP\IL10N;
use OCP\ILogger;
use OCP\Notification\IManager;
use OCP\Util;
use Psr\Container\ContainerInterface;

class Application extends App implements IBootstrap {
	public const APP_ID = 'passman';

	public function __construct() {
		parent::__construct(self::APP_ID);
	}

	public function register(IRegistrationContext $context): void {
		$this->registerNavigationEntry();
		// $this->registerPersonalPage();

		$context->registerEventListener(
			BeforeUserDeletedEvent::class,
			UserDeletedListener::class
		);

		$context->registerSearchProvider(Provider::class);

		$context->registerService(View::class, function () {
			return new View('');
		}, false);

		$context->registerService('isCLI', function () {
			return \OC::$CLI;
		});

		$context->registerMiddleware(ShareMiddleware::class);
		$context->registerMiddleware(APIMiddleware::class);

		$context->registerService('ShareController', function (ContainerInterface $c) {
			$server = $this->getContainer()->getServer();
			return new ShareController(
				$c->get('AppName'),
				$c->get('Request'),
				$server->getUserSession()->getUser(),
				$server->getGroupManager(),
				$server->getUserManager(),
				$c->get(ActivityService::class),
				$c->get(VaultService::class),
				$c->get(ShareService::class),
				$c->get(CredentialService::class),
				$c->get(NotificationService::class),
				$c->get(FileService::class),
				$c->get(SettingsService::class)
			);
		});


		$context->registerService('CronService', function (ContainerInterface $c) {
			return new CronService(
				$c->get(CredentialService::class),
				$c->get(ILogger::class),
				$c->get(Utils::class),
				$c->get(NotificationService::class),
				$c->get(ActivityService::class),
				$c->get(IDBConnection::class)
			);
		});

		$context->registerService('Logger', function (ContainerInterface $c) {
			return $c->get(ServerContainer::class)->getLogger();
		});
	}

	public function boot(IBootContext $context): void {
		$l = \OC::$server->getL10N(self::APP_ID);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		/** @var IManager $manager */
		$manager = $context->getAppContainer()->get(IManager::class);
		$manager->registerNotifierService(Notifier::class);

		Util::addTranslations(self::APP_ID);
		\OCP\App::registerAdmin(self::APP_ID, 'templates/admin.settings');
	}

	/**
	 * Register the navigation entry
	 */
	public function registerNavigationEntry() {
		$c = $this->getContainer();
		$server = $c->getServer();
		$navigationEntry = function () use ($c, $server) {
			return [
				'id' => $c->getAppName(),
				'order' => 10,
				'name' => $c->query(IL10N::class)->t('Passwords'),
				'href' => $server->getURLGenerator()->linkToRoute('passman.page.index'),
				'icon' => $server->getURLGenerator()->imagePath($c->getAppName(), 'app.svg'),
			];
		};
		$server->getNavigationManager()->add($navigationEntry);
	}

	/**
	 * Register personal settings for notifications and emails
	 */
	public function registerPersonalPage() {
		\OCP\App::registerPersonal($this->getContainer()->getAppName(), 'personal');
	}
}


1			<?php
2			/**
3			* Nextcloud - passman
4			*
5			* @copyright Copyright (c) 2016, Sander Brand ([email protected])
6			* @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Passman\AppInfo;
25
26			use OC\Files\View;
27			use OC\ServerContainer;
28			use OCA\Passman\Controller\ShareController;
29			use OCA\Passman\Middleware\APIMiddleware;
30			use OCA\Passman\Middleware\ShareMiddleware;
31			use OCA\Passman\Notifier;
32			use OCA\Passman\Search\Provider;
33			use OCA\Passman\Service\ActivityService;
34			use OCA\Passman\Service\CredentialService;
35			use OCA\Passman\Service\CronService;
36			use OCA\Passman\Service\FileService;
37			use OCA\Passman\Service\NotificationService;
38			use OCA\Passman\Service\SettingsService;
39			use OCA\Passman\Service\ShareService;
40			use OCA\Passman\Service\VaultService;
41			use OCA\Passman\Utility\Utils;
42			use OCP\AppFramework\App;
43			use OCP\AppFramework\Bootstrap\IBootContext;
44			use OCP\AppFramework\Bootstrap\IBootstrap;
45			use OCP\AppFramework\Bootstrap\IRegistrationContext;
46			use OCP\IDBConnection;
47			use OCP\IL10N;
48			use OCP\ILogger;
49			use OCP\Notification\IManager;
50			use OCP\Util;
51			use Psr\Container\ContainerInterface;
52
53			class Application extends App implements IBootstrap {
54			public const APP_ID = 'passman';
55
56			public function __construct() {
57			parent::__construct(self::APP_ID);
58			}
59
60			public function register(IRegistrationContext $context): void {
61			$this->registerNavigationEntry();
62			// $this->registerPersonalPage();
63
64			$context->registerEventListener(
65			BeforeUserDeletedEvent::class,
66			UserDeletedListener::class
67			);
68
69			$context->registerSearchProvider(Provider::class);
70
71			$context->registerService(View::class, function () {
72			return new View('');
73			}, false);
74
75			$context->registerService('isCLI', function () {
76			return \OC::$CLI;
77			});
78
79			$context->registerMiddleware(ShareMiddleware::class);
80			$context->registerMiddleware(APIMiddleware::class);
81
82			$context->registerService('ShareController', function (ContainerInterface $c) {
83			$server = $this->getContainer()->getServer();
84			return new ShareController(
85			$c->get('AppName'),
86			$c->get('Request'),
87			$server->getUserSession()->getUser(),
88			$server->getGroupManager(),
89			$server->getUserManager(),
90			$c->get(ActivityService::class),
91			$c->get(VaultService::class),
92			$c->get(ShareService::class),
93			$c->get(CredentialService::class),
94			$c->get(NotificationService::class),
95			$c->get(FileService::class),
96			$c->get(SettingsService::class)
97			);
98			});
99
100
101			$context->registerService('CronService', function (ContainerInterface $c) {
102			return new CronService(
103			$c->get(CredentialService::class),
104			$c->get(ILogger::class),
105			$c->get(Utils::class),
106			$c->get(NotificationService::class),
107			$c->get(ActivityService::class),
108			$c->get(IDBConnection::class)
109			);
110			});
111
112			$context->registerService('Logger', function (ContainerInterface $c) {
113			return $c->get(ServerContainer::class)->getLogger();
114			});
115			}
116
117			public function boot(IBootContext $context): void {
118			$l = \OC::$server->getL10N(self::APP_ID);
			0 ignored issues – show Unused Code introduced 2021-03-12 16:41 UTC by Report Bug Copy Issue Report `$l` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
119
120			/** @var IManager $manager */
121			$manager = $context->getAppContainer()->get(IManager::class);
122			$manager->registerNotifierService(Notifier::class);
123
124			Util::addTranslations(self::APP_ID);
125			\OCP\App::registerAdmin(self::APP_ID, 'templates/admin.settings');
126			}
127
128			/**
129			* Register the navigation entry
130			*/
131			public function registerNavigationEntry() {
132			$c = $this->getContainer();
133			$server = $c->getServer();
134			$navigationEntry = function () use ($c, $server) {
135			return [
136			'id' => $c->getAppName(),
137			'order' => 10,
138			'name' => $c->query(IL10N::class)->t('Passwords'),
139			'href' => $server->getURLGenerator()->linkToRoute('passman.page.index'),
140			'icon' => $server->getURLGenerator()->imagePath($c->getAppName(), 'app.svg'),
141			];
142			};
143			$server->getNavigationManager()->add($navigationEntry);
144			}
145
146			/**
147			* Register personal settings for notifications and emails
148			*/
149			public function registerPersonalPage() {
150			\OCP\App::registerPersonal($this->getContainer()->getAppName(), 'personal');
151			}
152			}
153

nextcloud / passman

Push — master ( a9bae3...93cd59 )

Application::register() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like