Inspection of "[tx-robot] updated from transifex" - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 0d3cdf...d7033b )

unknown

created 2022-02-24 03:04 UTC

Status

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
 	private $fileService;
 
 	public function __construct(EncryptService $encryptService, IDBConnection $db, LoggerInterface $logger, CredentialService $credentialService, CredentialRevisionService $revisionService,
-	                            FileService $fileService, IConfig $config) {
+								FileService $fileService, IConfig $config) {
 		$this->encryptService = $encryptService;
 		$this->db = $db;
 		$this->logger = $logger;

Please login to merge, or discard this patch.

lib/Utility/Utils.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -26,10 +26,10 @@  discard block
 block discarded – undo
 use OCP\IUserManager;
 
 class Utils {
-    /**
-     * Gets the unix epoch UTC timestamp
-     * @return int
-     */
+	/**
+	 * Gets the unix epoch UTC timestamp
+	 * @return int
+	 */
 	public static function getTime() {
 		return (new \DateTime())->getTimestamp();
 	}
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
 		return microtime(true);
 	}
 
-    /**
-     * Generates a Globally Unique ID
-     * @return string
-     */
+	/**
+	 * Generates a Globally Unique ID
+	 * @return string
+	 */
 	public static function GUID() {
 		if (function_exists('com_create_guid') === true)
 		{

Please login to merge, or discard this patch.

controller/sharecontroller.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -51,18 +51,18 @@
 block discarded – undo
 	private $offset = 0;
 
 	public function __construct($AppName,
-	                            IRequest $request,
-	                            $UserId,
-	                            IGroupManager $groupManager,
-	                            IUserManager $userManager,
-	                            ActivityService $activityService,
-	                            VaultService $vaultService,
-	                            ShareService $shareService,
-	                            CredentialService $credentialService,
-	                            NotificationService $notificationService,
-	                            FileService $fileService,
-	                            SettingsService $config,
-	                            IManager $IManager
+								IRequest $request,
+								$UserId,
+								IGroupManager $groupManager,
+								IUserManager $userManager,
+								ActivityService $activityService,
+								VaultService $vaultService,
+								ShareService $shareService,
+								CredentialService $credentialService,
+								NotificationService $notificationService,
+								FileService $fileService,
+								SettingsService $config,
+								IManager $IManager
 	) {
 		parent::__construct(
 			$AppName,

Please login to merge, or discard this patch.

controller/iconcontroller.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -31,11 +31,11 @@
 block discarded – undo
 	const ICON_CACHE_OFFSET = 2592000;  // 3600 * 24 * 30
 
 	public function __construct($AppName,
-	                            IRequest $request,
-	                            $UserId,
-	                            CredentialService $credentialService,
-	                            AppManager $am,
-	                            IURLGenerator $urlGenerator
+								IRequest $request,
+								$UserId,
+								CredentialService $credentialService,
+								AppManager $am,
+								IURLGenerator $urlGenerator
 	) {
 		parent::__construct(
 			$AppName,

Please login to merge, or discard this patch.

lib/Service/CredentialService.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -45,12 +45,12 @@
 block discarded – undo
 	private $server_key;
 
 	public function __construct(CredentialMapper          $credentialMapper,
-	                            SharingACLMapper          $sharingACL,
-	                            ActivityService           $activityService,
-	                            ShareService              $shareService,
-	                            EncryptService            $encryptService,
-	                            CredentialRevisionService $credentialRevisionService,
-	                            IConfig                   $config) {
+								SharingACLMapper          $sharingACL,
+								ActivityService           $activityService,
+								ShareService              $shareService,
+								EncryptService            $encryptService,
+								CredentialRevisionService $credentialRevisionService,
+								IConfig                   $config) {
 		$this->credentialMapper = $credentialMapper;
 		$this->sharingACL = $sharingACL;
 		$this->activityService = $activityService;

Please login to merge, or discard this patch.

controller/filecontroller.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -24,10 +24,10 @@
 block discarded – undo
 	private $logger;
 
 	public function __construct($AppName,
-	                            IRequest $request,
+								IRequest $request,
 								$UserId,
-		                        FileService $fileService,
-		                        LoggerInterface $logger) {
+								FileService $fileService,
+								LoggerInterface $logger) {
 		parent::__construct(
 			$AppName,
 			$request,

Please login to merge, or discard this patch.

controller/credentialcontroller.php 1 patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -36,13 +36,13 @@  discard block
 block discarded – undo
 	private $settings;
 
 	public function __construct($AppName,
-	                            IRequest $request,
+								IRequest $request,
 								$userId,
-		                        CredentialService $credentialService,
-		                        ActivityService $activityService,
-		                        CredentialRevisionService $credentialRevisionService,
-		                        ShareService $sharingService,
-		                        SettingsService $settings
+								CredentialService $credentialService,
+								ActivityService $activityService,
+								CredentialRevisionService $credentialRevisionService,
+								ShareService $sharingService,
+								SettingsService $settings
 
 	) {
 		parent::__construct(
@@ -65,10 +65,10 @@  discard block
 block discarded – undo
 	 * @NoCSRFRequired
 	 */
 	public function createCredential($changed, $created,
-	                                 $credential_id, $custom_fields, $delete_time,
-	                                 $description, $email, $expire_time, $favicon, $files, $guid,
-	                                 $hidden, $icon, $label, $otp, $password, $renew_interval,
-	                                 $tags, $url, $username, $vault_id, $compromised) {
+									 $credential_id, $custom_fields, $delete_time,
+									 $description, $email, $expire_time, $favicon, $files, $guid,
+									 $hidden, $icon, $label, $otp, $password, $renew_interval,
+									 $tags, $url, $username, $vault_id, $compromised) {
 		$credential = array(
 			'credential_id' => $credential_id,
 			'guid' => $guid,
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
 	 * @NoCSRFRequired
 	 */
 	public function updateCredential($changed, $created,
-	                                 $credential_id, $custom_fields, $delete_time, $credential_guid,
-	                                 $description, $email, $expire_time, $icon, $files, $guid,
-	                                 $hidden, $label, $otp, $password, $renew_interval,
-	                                 $tags, $url, $username, $vault_id, $revision_created, $shared_key, $acl, $unshare_action, $set_share_key, $skip_revision, $compromised) {
+									 $credential_id, $custom_fields, $delete_time, $credential_guid,
+									 $description, $email, $expire_time, $icon, $files, $guid,
+									 $hidden, $label, $otp, $password, $renew_interval,
+									 $tags, $url, $username, $vault_id, $revision_created, $shared_key, $acl, $unshare_action, $set_share_key, $skip_revision, $compromised) {
 
 
 		$storedCredential = $this->credentialService->getCredentialByGUID($credential_guid);

Please login to merge, or discard this patch.

controller/vaultcontroller.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -35,14 +35,14 @@
 block discarded – undo
 	private $deleteVaultRequestService;
 
 	public function __construct($AppName,
-	                            IRequest $request,
+								IRequest $request,
 								$UserId,
-		                        VaultService $vaultService,
-		                        CredentialService $credentialService,
-		                        DeleteVaultRequestService $deleteVaultRequestService,
-		                        SettingsService $settings,
-		                        FileService $fileService,
-		                        LoggerInterface $logger) {
+								VaultService $vaultService,
+								CredentialService $credentialService,
+								DeleteVaultRequestService $deleteVaultRequestService,
+								SettingsService $settings,
+								FileService $fileService,
+								LoggerInterface $logger) {
 		parent::__construct(
 			$AppName,
 			$request,

Please login to merge, or discard this patch.

		@@ -60,7 +60,7 @@
		block discarded – undo
60	60	private $fileService;
61	61
62	62	public function __construct(EncryptService $encryptService, IDBConnection $db, LoggerInterface $logger, CredentialService $credentialService, CredentialRevisionService $revisionService,
63		- FileService $fileService, IConfig $config) {
	63	+ FileService $fileService, IConfig $config) {
64	64	$this->encryptService = $encryptService;
65	65	$this->db = $db;
66	66	$this->logger = $logger;

		@@ -26,10 +26,10 @@ discard block
		block discarded – undo
26	26	use OCP\IUserManager;
27	27
28	28	class Utils {
29		- /**
30		- * Gets the unix epoch UTC timestamp
31		- * @return int
32		- */
	29	+ /**
	30	+ * Gets the unix epoch UTC timestamp
	31	+ * @return int
	32	+ */
33	33	public static function getTime() {
34	34	return (new \DateTime())->getTimestamp();
35	35	}
		@@ -40,10 +40,10 @@ discard block
		block discarded – undo
40	40	return microtime(true);
41	41	}
42	42
43		- /**
44		- * Generates a Globally Unique ID
45		- * @return string
46		- */
	43	+ /**
	44	+ * Generates a Globally Unique ID
	45	+ * @return string
	46	+ */
47	47	public static function GUID() {
48	48	if (function_exists('com_create_guid') === true)
49	49	{

		@@ -51,18 +51,18 @@
		block discarded – undo
51	51	private $offset = 0;
52	52
53	53	public function __construct($AppName,
54		- IRequest $request,
55		- $UserId,
56		- IGroupManager $groupManager,
57		- IUserManager $userManager,
58		- ActivityService $activityService,
59		- VaultService $vaultService,
60		- ShareService $shareService,
61		- CredentialService $credentialService,
62		- NotificationService $notificationService,
63		- FileService $fileService,
64		- SettingsService $config,
65		- IManager $IManager
	54	+ IRequest $request,
	55	+ $UserId,
	56	+ IGroupManager $groupManager,
	57	+ IUserManager $userManager,
	58	+ ActivityService $activityService,
	59	+ VaultService $vaultService,
	60	+ ShareService $shareService,
	61	+ CredentialService $credentialService,
	62	+ NotificationService $notificationService,
	63	+ FileService $fileService,
	64	+ SettingsService $config,
	65	+ IManager $IManager
66	66	) {
67	67	parent::__construct(
68	68	$AppName,

		@@ -31,11 +31,11 @@
		block discarded – undo
31	31	const ICON_CACHE_OFFSET = 2592000; // 3600 * 24 * 30
32	32
33	33	public function __construct($AppName,
34		- IRequest $request,
35		- $UserId,
36		- CredentialService $credentialService,
37		- AppManager $am,
38		- IURLGenerator $urlGenerator
	34	+ IRequest $request,
	35	+ $UserId,
	36	+ CredentialService $credentialService,
	37	+ AppManager $am,
	38	+ IURLGenerator $urlGenerator
39	39	) {
40	40	parent::__construct(
41	41	$AppName,

		@@ -45,12 +45,12 @@
		block discarded – undo
45	45	private $server_key;
46	46
47	47	public function __construct(CredentialMapper $credentialMapper,
48		- SharingACLMapper $sharingACL,
49		- ActivityService $activityService,
50		- ShareService $shareService,
51		- EncryptService $encryptService,
52		- CredentialRevisionService $credentialRevisionService,
53		- IConfig $config) {
	48	+ SharingACLMapper $sharingACL,
	49	+ ActivityService $activityService,
	50	+ ShareService $shareService,
	51	+ EncryptService $encryptService,
	52	+ CredentialRevisionService $credentialRevisionService,
	53	+ IConfig $config) {
54	54	$this->credentialMapper = $credentialMapper;
55	55	$this->sharingACL = $sharingACL;
56	56	$this->activityService = $activityService;

		@@ -24,10 +24,10 @@
		block discarded – undo
24	24	private $logger;
25	25
26	26	public function __construct($AppName,
27		- IRequest $request,
	27	+ IRequest $request,
28	28	$UserId,
29		- FileService $fileService,
30		- LoggerInterface $logger) {
	29	+ FileService $fileService,
	30	+ LoggerInterface $logger) {
31	31	parent::__construct(
32	32	$AppName,
33	33	$request,

		@@ -36,13 +36,13 @@ discard block
		block discarded – undo
36	36	private $settings;
37	37
38	38	public function __construct($AppName,
39		- IRequest $request,
	39	+ IRequest $request,
40	40	$userId,
41		- CredentialService $credentialService,
42		- ActivityService $activityService,
43		- CredentialRevisionService $credentialRevisionService,
44		- ShareService $sharingService,
45		- SettingsService $settings
	41	+ CredentialService $credentialService,
	42	+ ActivityService $activityService,
	43	+ CredentialRevisionService $credentialRevisionService,
	44	+ ShareService $sharingService,
	45	+ SettingsService $settings
46	46
47	47	) {
48	48	parent::__construct(
		@@ -65,10 +65,10 @@ discard block
		block discarded – undo
65	65	* @NoCSRFRequired
66	66	*/
67	67	public function createCredential($changed, $created,
68		- $credential_id, $custom_fields, $delete_time,
69		- $description, $email, $expire_time, $favicon, $files, $guid,
70		- $hidden, $icon, $label, $otp, $password, $renew_interval,
71		- $tags, $url, $username, $vault_id, $compromised) {
	68	+ $credential_id, $custom_fields, $delete_time,
	69	+ $description, $email, $expire_time, $favicon, $files, $guid,
	70	+ $hidden, $icon, $label, $otp, $password, $renew_interval,
	71	+ $tags, $url, $username, $vault_id, $compromised) {
72	72	$credential = array(
73	73	'credential_id' => $credential_id,
74	74	'guid' => $guid,
		@@ -121,10 +121,10 @@ discard block
		block discarded – undo
121	121	* @NoCSRFRequired
122	122	*/
123	123	public function updateCredential($changed, $created,
124		- $credential_id, $custom_fields, $delete_time, $credential_guid,
125		- $description, $email, $expire_time, $icon, $files, $guid,
126		- $hidden, $label, $otp, $password, $renew_interval,
127		- $tags, $url, $username, $vault_id, $revision_created, $shared_key, $acl, $unshare_action, $set_share_key, $skip_revision, $compromised) {
	124	+ $credential_id, $custom_fields, $delete_time, $credential_guid,
	125	+ $description, $email, $expire_time, $icon, $files, $guid,
	126	+ $hidden, $label, $otp, $password, $renew_interval,
	127	+ $tags, $url, $username, $vault_id, $revision_created, $shared_key, $acl, $unshare_action, $set_share_key, $skip_revision, $compromised) {
128	128
129	129
130	130	$storedCredential = $this->credentialService->getCredentialByGUID($credential_guid);

		@@ -35,14 +35,14 @@
		block discarded – undo
35	35	private $deleteVaultRequestService;
36	36
37	37	public function __construct($AppName,
38		- IRequest $request,
	38	+ IRequest $request,
39	39	$UserId,
40		- VaultService $vaultService,
41		- CredentialService $credentialService,
42		- DeleteVaultRequestService $deleteVaultRequestService,
43		- SettingsService $settings,
44		- FileService $fileService,
45		- LoggerInterface $logger) {
	40	+ VaultService $vaultService,
	41	+ CredentialService $credentialService,
	42	+ DeleteVaultRequestService $deleteVaultRequestService,
	43	+ SettingsService $settings,
	44	+ FileService $fileService,
	45	+ LoggerInterface $logger) {
46	46	parent::__construct(
47	47	$AppName,
48	48	$request,

nextcloud / passman

Push — master ( 0d3cdf...d7033b )

Status

Category

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch