nextcloud / passman

lib/Service/ShareService.php

Doc Comments +1 added lines, -2 removed lines

@@ -49,6 +49,7 @@ 
 	 * @param $target_item_guid string      The shared item GUID
 	 * @param $request_array    array
 	 * @param $permissions      integer     Must be created with a bitmask from options on the ShareRequest class
+	 * @param string $credential_owner
 	 * @return array                        Array of sharing requests
 	 */
 	public function createBulkRequests($target_item_id, $target_item_guid, $request_array, $permissions, $credential_owner) {
@@ -253,7 +254,6 @@ 
 	/**
 	 * Delete ACL
 	 *
-	 * @param  ShareRequest $request
 	 * @return \OCA\Passman\Db\ShareRequest[]
 	 */
 	public function deleteShareACL(SharingACL $ACL) {
@@ -277,7 +277,6 @@ 
 	/**
 	 * Get pending share requests by guid and uid
 	 *
-	 * @param  ShareRequest $request
 	 * @return \OCA\Passman\Db\ShareRequest[]
 	 */
 	public function getPendingShareRequestsForCredential($item_guid, $user_id) {

lib/Service/CredentialService.php

Braces +1 added lines, -2 removed lines

@@ -61,8 +61,7 @@
         $filter = [$item_guid];
         if ($user_id == null){
             $q .= 'user_id is null';
-        }
-        else {
+        } else {
             $q .= 'user_id = ? ';
             $filter[] = $user_id;
         }

controller/credentialcontroller.php

Braces +3 added lines, -6 removed lines

@@ -257,21 +257,18 @@
 	public function getRevision($credential_guid) {
 		try {
 			$credential = $this->credentialService->getCredentialByGUID($credential_guid);
-		}
-		catch (DoesNotExistException $ex){
+		} catch (DoesNotExistException $ex){
 			return new NotFoundJSONResponse();
 		}
 
 		// If the request was made by the owner of the credential
 		if ($this->userId === $credential->getUserId()) {
 			$result = $this->credentialRevisionService->getRevisions($credential->getId(), $this->userId);
-		}
-		else {
+		} else {
 			$acl = $this->sharingService->getACL($this->userId, $credential_guid);
 			if ($acl->hasPermission(SharingACL::HISTORY)){
 				$result = $this->credentialRevisionService->getRevisions($credential->getId());
-			}
-			else {
+			} else {
 				return new NotFoundJSONResponse();
 			}
 		}

lib/Db/CredentialMapper.php

Doc Comments +10 added lines

@@ -25,6 +25,7 @@ 
 	/**
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException if not found
 	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException if more than one result
+	 * @param integer $vault_id
 	 */
 	public function getCredentialsByVaultId($vault_id, $user_id) {
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
@@ -32,12 +33,18 @@ 
 		return $this->findEntities($sql, [$user_id, $vault_id]);
 	}
 
+	/**
+	 * @param integer $vault_id
+	 */
 	public function getRandomCredentialByVaultId($vault_id, $user_id) {
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `user_id` = ? and vault_id = ? AND shared_key is NULL ORDER BY RAND() LIMIT 1';
 		return $this->findEntities($sql, [$user_id, $vault_id]);
 	}
 
+	/**
+	 * @param integer $timestamp
+	 */
 	public function getExpiredCredentials($timestamp){
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `expire_time` > 0 AND `expire_time` < ?';
@@ -61,6 +68,9 @@ 
 		return $this->findEntity($sql,$params);
 	}
 
+	/**
+	 * @param integer $credential_id
+	 */
 	public function getCredentialLabelById($credential_id){
 		$sql = 'SELECT id, label FROM `*PREFIX*passman_credentials` ' .
 			'WHERE `id` = ? ';

lib/Db/SharingACLMapper.php

Braces +1 added lines, -2 removed lines

@@ -61,8 +61,7 @@
 		$filter = [$item_guid];
 		if ($user_id === null){
 			$q .= 'user_id is null';
-		}
-		else {
+		} else {
 			$q .= 'user_id = ? ';
 			$filter[] = $user_id;
 		}