nextcloud / passman

lib/Service/ActivityService.php

Spacing +4 added lines, -4 removed lines

@@ -48,10 +48,10 @@
 	 * @param $type string
 	 * @return array
 	 */
-	public function add($subject,$subjectParams=array(),
-						$message='',$messageParams=array(),
-						$link='',$user=null,$type='') {
-		if($user) {
+	public function add($subject, $subjectParams = array(),
+						$message = '', $messageParams = array(),
+						$link = '', $user = null, $type = '') {
+		if ($user) {
 			$activity = $this->manager->generateEvent();
 			$activity->setType($type);
 			$activity->setApp('passman');

controller/credentialcontroller.php

Spacing +2 added lines, -2 removed lines

@@ -163,13 +163,13 @@
 				$activity . '_self', array($label, $this->userId, $revision_created),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() === 0) && (int)$delete_time > 0) {
+		} else if (($storedCredential->getDeleteTime() === 0) && (int) $delete_time > 0) {
 			$activity = 'item_deleted';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() > 0) && (int)$delete_time === 0) {
+		} else if (($storedCredential->getDeleteTime() > 0) && (int) $delete_time === 0) {
 			$activity = 'item_recovered';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),

Indentation +15 added lines, -15 removed lines

@@ -36,13 +36,13 @@ 
 	private $settings;
 
 	public function __construct($AppName,
-	                            IRequest $request,
-	                            $userId,
-	                            CredentialService $credentialService,
-	                            ActivityService $activityService,
-	                            CredentialRevisionService $credentialRevisionService,
-	                            ShareService $sharingService,
-	                            SettingsService $settings
+								IRequest $request,
+								$userId,
+								CredentialService $credentialService,
+								ActivityService $activityService,
+								CredentialRevisionService $credentialRevisionService,
+								ShareService $sharingService,
+								SettingsService $settings
 
 	) {
 		parent::__construct(
@@ -65,10 +65,10 @@ 
 	 * @NoCSRFRequired
 	 */
 	public function createCredential($changed, $created,
-	                                 $credential_id, $custom_fields, $delete_time,
-	                                 $description, $email, $expire_time, $favicon, $files, $guid,
-	                                 $hidden, $icon, $label, $otp, $password, $renew_interval,
-	                                 $tags, $url, $username, $vault_id, $compromised) {
+									 $credential_id, $custom_fields, $delete_time,
+									 $description, $email, $expire_time, $favicon, $files, $guid,
+									 $hidden, $icon, $label, $otp, $password, $renew_interval,
+									 $tags, $url, $username, $vault_id, $compromised) {
 		$credential = array(
 			'credential_id' => $credential_id,
 			'guid' => $guid,
@@ -121,10 +121,10 @@ 
 	 * @NoCSRFRequired
 	 */
 	public function updateCredential($changed, $created,
-	                                 $credential_id, $custom_fields, $delete_time, $credential_guid,
-	                                 $description, $email, $expire_time, $icon, $files, $guid,
-	                                 $hidden, $label, $otp, $password, $renew_interval,
-	                                 $tags, $url, $username, $vault_id, $revision_created, $shared_key, $acl, $unshare_action, $set_share_key, $skip_revision, $compromised) {
+									 $credential_id, $custom_fields, $delete_time, $credential_guid,
+									 $description, $email, $expire_time, $icon, $files, $guid,
+									 $hidden, $label, $otp, $password, $renew_interval,
+									 $tags, $url, $username, $vault_id, $revision_created, $shared_key, $acl, $unshare_action, $set_share_key, $skip_revision, $compromised) {
 
 
 		$storedCredential = $this->credentialService->getCredentialByGUID($credential_guid);

lib/Service/EncryptService.php

Braces +3 added lines, -1 removed lines

@@ -272,7 +272,9 @@
 	protected function unpad($data) {
 		$length = $this->getKeySize();
 		$last = ord($data[strlen($data) - 1]);
-		if ($last > $length) return false;
+		if ($last > $length) {
+			return false;
+		}
 		if (substr($data, -1 * $last) !== str_repeat(chr($last), $last)) {
 			return false;
 		}

middleware/sharemiddleware.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 			$setting = (in_array($methodName, $publicMethods)) ? 'link_sharing_enabled' : 'user_sharing_enabled';
 			$sharing_enabled = ($this->settings->isEnabled($setting));
 
-			if(in_array($methodName, $user_pub_methods)){
+			if (in_array($methodName, $user_pub_methods)) {
 				$sharing_enabled = ($this->settings->isEnabled('link_sharing_enabled') || $this->settings->isEnabled('user_sharing_enabled'));
 			}
 

Braces +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 			$setting = (in_array($methodName, $publicMethods)) ? 'link_sharing_enabled' : 'user_sharing_enabled';
 			$sharing_enabled = ($this->settings->isEnabled($setting));
 
-			if(in_array($methodName, $user_pub_methods)){
+			if(in_array($methodName, $user_pub_methods)) {
 				$sharing_enabled = ($this->settings->isEnabled('link_sharing_enabled') || $this->settings->isEnabled('user_sharing_enabled'));
 			}
 

controller/vaultcontroller.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 			foreach ($vaults as $vault) {
 				$credential = $this->credentialService->getRandomCredentialByVaultId($vault->getId(), $this->userId);
 				$secret_field = $protected_credential_fields[array_rand($protected_credential_fields)];
-				if(isset($credential)) {
+				if (isset($credential)) {
 					array_push($result, array(
 						'vault_id' => $vault->getId(),
 						'guid' => $vault->getGuid(),

middleware/apimiddleware.php

Spacing +2 added lines, -2 removed lines

@@ -16,8 +16,8 @@
 	}
 
 	public function afterController($controller, $methodName, Response $response) {
-		if($response instanceof JSONResponse){
-			if(isset($this->request->server['HTTP_ORIGIN'])) {
+		if ($response instanceof JSONResponse) {
+			if (isset($this->request->server['HTTP_ORIGIN'])) {
 				$response->addHeader('Access-Control-Allow-Origin', $this->request->server['HTTP_ORIGIN']);
 			}
 		}

Braces +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 	}
 
 	public function afterController($controller, $methodName, Response $response) {
-		if($response instanceof JSONResponse){
+		if($response instanceof JSONResponse) {
 			if(isset($this->request->server['HTTP_ORIGIN'])) {
 				$response->addHeader('Access-Control-Allow-Origin', $this->request->server['HTTP_ORIGIN']);
 			}

appinfo/routes.php

Indentation +13 added lines, -13 removed lines

@@ -52,19 +52,19 @@
 		//Sharing stuff
 		['name' => 'share#search', 'url' => '/api/v2/sharing/search', 'verb' => 'POST'],
 		['name' => 'share#getVaultsByUser', 'url' => '/api/v2/sharing/vaults/{user_id}', 'verb' => 'GET'],
-        ['name' => 'share#applyIntermediateShare', 'url' => '/api/v2/sharing/share', 'verb' => 'POST'],
-        ['name' => 'share#savePendingRequest', 'url' => '/api/v2/sharing/save', 'verb' => 'POST'],
-        ['name' => 'share#getPendingRequests', 'url' => '/api/v2/sharing/pending', 'verb' => 'GET'],
-        ['name' => 'share#deleteShareRequest', 'url' => '/api/v2/sharing/decline/{share_request_id}', 'verb' => 'DELETE'],
-        ['name' => 'share#getVaultItems', 'url' => '/api/v2/sharing/vault/{vault_guid}/get', 'verb' => 'GET'],
-        ['name' => 'share#createPublicShare', 'url' => '/api/v2/sharing/public', 'verb' => 'POST'],
-        ['name' => 'share#getPublicCredentialData', 'url' => '/api/v2/sharing/credential/{credential_guid}/public', 'verb' => 'GET'],
-        ['name' => 'share#unshareCredential', 'url' => '/api/v2/sharing/credential/{item_guid}', 'verb' => 'DELETE'],
-        ['name' => 'share#unshareCredentialFromUser', 'url' => '/api/v2/sharing/credential/{item_guid}/{user_id}', 'verb' => 'DELETE'],
-        ['name' => 'share#getRevisions', 'url' => '/api/v2/sharing/credential/{item_guid}/revisions', 'verb' => 'GET'],
-        ['name' => 'share#getItemAcl', 'url' => '/api/v2/sharing/credential/{item_guid}/acl', 'verb' => 'GET'],
-        ['name' => 'share#getFile', 'url' => '/api/v2/sharing/credential/{item_guid}/file/{file_guid}', 'verb' => 'GET'],
-        ['name' => 'share#updateSharedCredentialACL', 'url' => '/api/v2/sharing/credential/{item_guid}/acl', 'verb' => 'PATCH'],
+		['name' => 'share#applyIntermediateShare', 'url' => '/api/v2/sharing/share', 'verb' => 'POST'],
+		['name' => 'share#savePendingRequest', 'url' => '/api/v2/sharing/save', 'verb' => 'POST'],
+		['name' => 'share#getPendingRequests', 'url' => '/api/v2/sharing/pending', 'verb' => 'GET'],
+		['name' => 'share#deleteShareRequest', 'url' => '/api/v2/sharing/decline/{share_request_id}', 'verb' => 'DELETE'],
+		['name' => 'share#getVaultItems', 'url' => '/api/v2/sharing/vault/{vault_guid}/get', 'verb' => 'GET'],
+		['name' => 'share#createPublicShare', 'url' => '/api/v2/sharing/public', 'verb' => 'POST'],
+		['name' => 'share#getPublicCredentialData', 'url' => '/api/v2/sharing/credential/{credential_guid}/public', 'verb' => 'GET'],
+		['name' => 'share#unshareCredential', 'url' => '/api/v2/sharing/credential/{item_guid}', 'verb' => 'DELETE'],
+		['name' => 'share#unshareCredentialFromUser', 'url' => '/api/v2/sharing/credential/{item_guid}/{user_id}', 'verb' => 'DELETE'],
+		['name' => 'share#getRevisions', 'url' => '/api/v2/sharing/credential/{item_guid}/revisions', 'verb' => 'GET'],
+		['name' => 'share#getItemAcl', 'url' => '/api/v2/sharing/credential/{item_guid}/acl', 'verb' => 'GET'],
+		['name' => 'share#getFile', 'url' => '/api/v2/sharing/credential/{item_guid}/file/{file_guid}', 'verb' => 'GET'],
+		['name' => 'share#updateSharedCredentialACL', 'url' => '/api/v2/sharing/credential/{item_guid}/acl', 'verb' => 'PATCH'],
 		['name' => 'internal#getAppVersion', 'url' => '/api/v2/version', 'verb' => 'GET'],
 
 		//Settings

controller/filecontroller.php

Spacing +8 added lines, -8 removed lines

@@ -23,7 +23,7 @@ 
 	public function __construct($AppName,
 								IRequest $request,
 								$UserId,
-								FileService $fileService){
+								FileService $fileService) {
 		parent::__construct(
 			$AppName,
 			$request,
@@ -65,20 +65,20 @@ 
 		return new JSONResponse($this->fileService->deleteFile($file_id, $this->userId));
 	}
 
-	public function updateFile($file_id, $file_data, $filename){
-		try{
+	public function updateFile($file_id, $file_data, $filename) {
+		try {
 			$file = $this->fileService->getFile($file_id, $this->userId);
-		} catch (\Exception $doesNotExistException){
+		} catch (\Exception $doesNotExistException) {
 
 		}
-		if($file){
-			if($file_data) {
+		if ($file) {
+			if ($file_data) {
 				$file->setFileData($file_data);
 			}
-			if($filename) {
+			if ($filename) {
 				$file->setFilename($filename);
 			}
-			if($filename || $file_data){
+			if ($filename || $file_data) {
 				new JSONResponse($this->fileService->updateFile($file));
 			}
 		}

Braces +4 added lines, -4 removed lines

@@ -23,7 +23,7 @@ 
 	public function __construct($AppName,
 								IRequest $request,
 								$UserId,
-								FileService $fileService){
+								FileService $fileService) {
 		parent::__construct(
 			$AppName,
 			$request,
@@ -65,20 +65,20 @@ 
 		return new JSONResponse($this->fileService->deleteFile($file_id, $this->userId));
 	}
 
-	public function updateFile($file_id, $file_data, $filename){
+	public function updateFile($file_id, $file_data, $filename) {
 		try{
 			$file = $this->fileService->getFile($file_id, $this->userId);
 		} catch (\Exception $doesNotExistException){
 
 		}
-		if($file){
+		if($file) {
 			if($file_data) {
 				$file->setFileData($file_data);
 			}
 			if($filename) {
 				$file->setFilename($filename);
 			}
-			if($filename || $file_data){
+			if($filename || $file_data) {
 				new JSONResponse($this->fileService->updateFile($file));
 			}
 		}

lib/Db/DeleteVaultRequest.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
  */
 
 
-class DeleteVaultRequest extends Entity implements  \JsonSerializable{
+class DeleteVaultRequest extends Entity implements  \JsonSerializable {
 
 	use EntityJSONSerializer;
 

Braces +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
  */
 
 
-class DeleteVaultRequest extends Entity implements  \JsonSerializable{
+class DeleteVaultRequest extends Entity implements  \JsonSerializable {
 
 	use EntityJSONSerializer;