nextcloud / passman

lib/Db/SharingACL.php

Braces +2 added lines, -4 removed lines

@@ -35,8 +35,7 @@ 
  * @method string getSharedKey()
  */
 
-class SharingACL extends PermissionEntity implements \JsonSerializable
-{
+class SharingACL extends PermissionEntity implements \JsonSerializable {
 
     protected
         $itemId,
@@ -67,8 +66,7 @@ 
      * which is a value of any type other than a resource.
      * @since 5.4.0
      */
-    function jsonSerialize()
-    {
+    function jsonSerialize() {
         return [
             'acl_id' => $this->getId(),
             'item_id' => $this->getItemId(),

lib/Db/File.php

Braces +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
  */
 
 
-class File extends Entity implements  \JsonSerializable{
+class File extends Entity implements  \JsonSerializable {
 
 	use EntityJSONSerializer;
 

lib/Db/Credential.php

Braces +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
  */
 
 
-class Credential extends Entity implements  \JsonSerializable{
+class Credential extends Entity implements  \JsonSerializable {
 
 	use EntityJSONSerializer;
 

lib/Db/Vault.php

Braces +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
  */
 
 
-class Vault extends Entity implements  \JsonSerializable{
+class Vault extends Entity implements  \JsonSerializable {
 
 	use EntityJSONSerializer;
 

lib/Db/ShareRequest.php

Braces +2 added lines, -3 removed lines

@@ -62,8 +62,7 @@ 
      * which is a value of any type other than a resource.
      * @since 5.4.0
      */
-    function jsonSerialize()
-    {
+    function jsonSerialize() {
         return [
             'req_id' => $this->getId(),
             'item_id' => $this->getItemId(),
@@ -78,7 +77,7 @@ 
         ];
     }
 
-    function asACLJson(){
+    function asACLJson() {
         return [
             'item_id' => $this->getItemId(),
             'item_guid' => $this->getItemGuid(),

controller/pagecontroller.php

Braces +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
 	private $userId;
 
-	public function __construct($AppName, IRequest $request, $UserId){
+	public function __construct($AppName, IRequest $request, $UserId) {
 		parent::__construct($AppName, $request);
 		$this->userId = $UserId;
 	}

lib/Service/EncryptService.php

Braces +3 added lines, -1 removed lines

@@ -272,7 +272,9 @@
 	protected function unpad($data) {
 		$length = $this->getKeySize();
 		$last = ord($data[strlen($data) - 1]);
-		if ($last > $length) return false;
+		if ($last > $length) {
+			return false;
+		}
 		if (substr($data, -1 * $last) !== str_repeat(chr($last), $last)) {
 			return false;
 		}

Doc Comments +7 added lines, -3 removed lines

@@ -206,6 +206,10 @@ 
 		return array($cipherKey, $macKey, $iv);
 	}
 
+	/**
+	 * @param string $a
+	 * @param string $b
+	 */
 	protected function hash_equals($a, $b) {
 		if (function_exists('random_bytes')) {
 			$key = random_bytes(128);
@@ -247,7 +251,7 @@ 
 	/**
 	 * Pad the data with a random char chosen by the pad amount.
 	 *
-	 * @param $data
+	 * @param string $data
 	 * @return string
 	 */
 	protected function pad($data) {
@@ -263,8 +267,8 @@ 
 	/**
 	 * Unpad the the data
 	 *
-	 * @param $data
-	 * @return bool|string
+	 * @param string $data
+	 * @return false|string
 	 */
 	protected function unpad($data) {
 		$length = $this->getKeySize();

middleware/sharemiddleware.php

Braces +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 			$setting = (in_array($methodName, $publicMethods)) ? 'link_sharing_enabled' : 'user_sharing_enabled';
 			$sharing_enabled = ($this->settings->isEnabled($setting));
 
-			if(in_array($methodName, $user_pub_methods)){
+			if(in_array($methodName, $user_pub_methods)) {
 				$sharing_enabled = ($this->settings->isEnabled('link_sharing_enabled') || $this->settings->isEnabled('user_sharing_enabled'));
 			}
 

lib/Service/SettingsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 	/**
 	 * Check if an setting is enabled (value of 1)
 	 *
-	 * @param $setting
+	 * @param string $setting
 	 * @return bool
 	 */
 	public function isEnabled($setting) {