NotificationService - Code Metrics - Inspection of "Merge branch 'binsky08-migrations-2'" - nextcloud/passman - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( e8410d...a45585 )

by Marcos

created 2021-05-16 22:45 UTC

NotificationService A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	23.08 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
c	0
b	0
f	0
lcom	1
cbo	0
dl	18
loc	78
rs	10

How to fix Duplicated Code

<?php
/**
 * Nextcloud - passman
 *
 * @copyright Copyright (c) 2016, Sander Brand ([email protected])
 * @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Passman\Service;


use OCP\IURLGenerator;
use OCP\Notification\IManager;

class NotificationService {

	private IManager $manager;

	private IURLGenerator $urlGenerator;

	public function __construct(IManager $IManager, IURLGenerator $urlGenerator) {
		$this->manager = $IManager;
		$this->urlGenerator = $urlGenerator;
	}

	function credentialExpiredNotification($credential) {

		$link = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman/#/vault/' . $credential->getVaultId() . '/edit/' . $credential->getId()));
		$api = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman'));
		$notification = $this->manager->createNotification();
		$remindAction = $notification->createAction();
		$remindAction->setLabel('remind')
			->setLink($api . '/api/internal/notifications/remind/' . $credential->getId(), 'POST');

		$declineAction = $notification->createAction();
		$declineAction->setLabel('ignore')
			->setLink($api . '/api/internal/notifications/read/' . $credential->getId(), 'DELETE');

		$notification->setApp('passman')
			->setUser($credential->getUserId())
			->setDateTime(new \DateTime())
			->setObject('credential', $credential->getId()) // Set notification type and id
			->setSubject('credential_expired', [$credential->getLabel()]) // set subject and parameters
			->setLink($link)
			->addAction($declineAction)
			->addAction($remindAction);

		$this->manager->notify($notification);
	}


	function credentialSharedNotification($data) {

		$link = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman/#/'));
		$api = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman'));
		$notification = $this->manager->createNotification();

		$declineAction = $notification->createAction();
		$declineAction->setLabel('decline')
			->setLink($api . '/api/v2/sharing/decline/' . $data['req_id'], 'DELETE');

		$notification->setApp('passman')
			->setUser($data['target_user'])
			->setDateTime(new \DateTime())
			->setObject('passman_share_request', $data['req_id']) // type and id
			->setSubject('credential_shared', [$data['from_user'], $data['credential_label']]) // subject and parameters
			->setLink($link)
			->addAction($declineAction);

		$this->manager->notify($notification);
	}


	function credentialDeclinedSharedNotification($data) {

		$notification = $this->manager->createNotification();
		$notification->setApp('passman')
			->setUser($data['target_user'])
			->setDateTime(new \DateTime())
			->setObject('passman_share_request', $data['req_id']) // type and id
			->setSubject('credential_share_denied', [$data['from_user'], $data['credential_label']]); // subject and parameters
		$this->manager->notify($notification);
	}


	function credentialAcceptedSharedNotification($data) {

		$notification = $this->manager->createNotification();
		$notification->setApp('passman')
			->setUser($data['target_user'])
			->setDateTime(new \DateTime())
			->setObject('passman_share_request', $data['req_id']) // type and id
			->setSubject('credential_share_accepted', [$data['from_user'], $data['credential_label']]); // subject and parameters
		$this->manager->notify($notification);
	}

}


1			<?php
2			/**
3			* Nextcloud - passman
4			*
5			* @copyright Copyright (c) 2016, Sander Brand ([email protected])
6			* @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\Passman\Service;
25
26
27			use OCP\IURLGenerator;
28			use OCP\Notification\IManager;
29
30			class NotificationService {
31
32			private IManager $manager;
			0 ignored issues – show Bug introduced 2021-03-22 15:44 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
33			private IURLGenerator $urlGenerator;
34
35			public function __construct(IManager $IManager, IURLGenerator $urlGenerator) {
36			$this->manager = $IManager;
37			$this->urlGenerator = $urlGenerator;
38			}
39
40			function credentialExpiredNotification($credential) {
			0 ignored issues – show Best Practice introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
41			$link = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman/#/vault/' . $credential->getVaultId() . '/edit/' . $credential->getId()));
42			$api = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman'));
43			$notification = $this->manager->createNotification();
44			$remindAction = $notification->createAction();
45			$remindAction->setLabel('remind')
46			->setLink($api . '/api/internal/notifications/remind/' . $credential->getId(), 'POST');
47
48			$declineAction = $notification->createAction();
49			$declineAction->setLabel('ignore')
50			->setLink($api . '/api/internal/notifications/read/' . $credential->getId(), 'DELETE');
51
52			$notification->setApp('passman')
53			->setUser($credential->getUserId())
54			->setDateTime(new \DateTime())
55			->setObject('credential', $credential->getId()) // Set notification type and id
56			->setSubject('credential_expired', [$credential->getLabel()]) // set subject and parameters
57			->setLink($link)
58			->addAction($declineAction)
59			->addAction($remindAction);
60
61			$this->manager->notify($notification);
62			}
63
64
65			function credentialSharedNotification($data) {
			0 ignored issues – show Best Practice introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
66			$link = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman/#/'));
67			$api = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkTo('', 'index.php/apps/passman'));
68			$notification = $this->manager->createNotification();
69
70			$declineAction = $notification->createAction();
71			$declineAction->setLabel('decline')
72			->setLink($api . '/api/v2/sharing/decline/' . $data['req_id'], 'DELETE');
73
74			$notification->setApp('passman')
75			->setUser($data['target_user'])
76			->setDateTime(new \DateTime())
77			->setObject('passman_share_request', $data['req_id']) // type and id
78			->setSubject('credential_shared', [$data['from_user'], $data['credential_label']]) // subject and parameters
79			->setLink($link)
80			->addAction($declineAction);
81
82			$this->manager->notify($notification);
83			}
84
85
86			function credentialDeclinedSharedNotification($data) {
			0 ignored issues – show Best Practice introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
87			$notification = $this->manager->createNotification();
88			$notification->setApp('passman')
89			->setUser($data['target_user'])
90			->setDateTime(new \DateTime())
91			->setObject('passman_share_request', $data['req_id']) // type and id
92			->setSubject('credential_share_denied', [$data['from_user'], $data['credential_label']]); // subject and parameters
93			$this->manager->notify($notification);
94			}
95
96
97			function credentialAcceptedSharedNotification($data) {
			0 ignored issues – show Best Practice introduced 2016-10-07 19:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
98			$notification = $this->manager->createNotification();
99			$notification->setApp('passman')
100			->setUser($data['target_user'])
101			->setDateTime(new \DateTime())
102			->setObject('passman_share_request', $data['req_id']) // type and id
103			->setSubject('credential_share_accepted', [$data['from_user'], $data['credential_label']]); // subject and parameters
104			$this->manager->notify($notification);
105			}
106
107			}
108

nextcloud / passman

Push — master ( e8410d...a45585 )

NotificationService A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like