nextcloud / passman

lib/Service/EncryptService.php

Doc Comments +9 added lines, -5 removed lines

@@ -213,6 +213,10 @@ 
 		return array($cipherKey, $macKey, $iv);
 	}
 
+	/**
+	 * @param string $a
+	 * @param string $b
+	 */
 	function hash_equals($a, $b) {
 		$key = openssl_random_pseudo_bytes(128);
 		return hash_hmac('sha512', $a, $key) === hash_hmac('sha512', $b, $key);
@@ -250,7 +254,7 @@ 
 	/**
 	 * Pad the data with a random char chosen by the pad amount.
 	 *
-	 * @param $data
+	 * @param string $data
 	 * @return string
 	 */
 	protected function pad($data) {
@@ -266,8 +270,8 @@ 
 	/**
 	 * Unpad the the data
 	 *
-	 * @param $data
-	 * @return bool|string
+	 * @param string $data
+	 * @return false|string
 	 */
 	protected function unpad($data) {
 		$length = $this->getKeySize();
@@ -284,7 +288,7 @@ 
 	 * Encrypt a credential
 	 *
 	 * @param array|Credential $credential the credential to decrypt
-	 * @return Credential|array
+	 * @return string
 	 */
 	public function decryptCredential($credential) {
 
@@ -380,7 +384,7 @@ 
 	/**
 	 * Decrypt a file
 	 *
-	 * @param  File|array $file
+	 * @param  File $file
 	 * @return File|array
 	 */
 

migration/serversideencryption.php

Spacing +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
 		}
 	}
 
-	private function fetchAll($sql){
+	private function fetchAll($sql) {
 		return $this->db->executeQuery($sql)->fetchAll();
 	}
 

lib/Service/SettingsService.php

Doc Comments +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
 	 * Get a app setting
 	 *
 	 * @param $key string
-	 * @param null $default_value The default value if key does not exist
+	 * @param string|false $default_value The default value if key does not exist
 	 * @return mixed
 	 */
 	public function getAppSetting($key, $default_value = null) {
@@ -110,7 +110,7 @@ 
 	/**
 	 * Check if an setting is enabled (value of 1)
 	 *
-	 * @param $setting
+	 * @param string $setting
 	 * @return bool
 	 */
 	public function isEnabled($setting) {

controller/credentialcontroller.php

Spacing +3 added lines, -3 removed lines

@@ -167,13 +167,13 @@ 
 				$activity . '_self', array($label, $this->userId, $revision_created),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() === 0) && (int)$delete_time > 0) {
+		} else if (($storedCredential->getDeleteTime() === 0) && (int) $delete_time > 0) {
 			$activity = 'item_deleted';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),
 				'', array(),
 				$link, $this->userId, Activity::TYPE_ITEM_ACTION);
-		} else if (($storedCredential->getDeleteTime() > 0) && (int)$delete_time === 0) {
+		} else if (($storedCredential->getDeleteTime() > 0) && (int) $delete_time === 0) {
 			$activity = 'item_recovered';
 			$this->activityService->add(
 				$activity . '_self', array($label, $this->userId),
@@ -241,7 +241,7 @@ 
 			$credential['shared_key'] = '';
 		}
 
-		if(!isset($credential['shared_key'])){
+		if (!isset($credential['shared_key'])) {
 			$credential['shared_key'] = $storedCredential->getSharedKey();
 		}