nextcloud / passman

lib/Service/ShareService.php

Doc Comments +1 added lines, -2 removed lines

@@ -49,6 +49,7 @@ 
 	 * @param $target_item_guid string      The shared item GUID
 	 * @param $request_array    array
 	 * @param $permissions      integer     Must be created with a bitmask from options on the ShareRequest class
+	 * @param string $credential_owner
 	 * @return array                        Array of sharing requests
 	 */
 	public function createBulkRequests($target_item_id, $target_item_guid, $request_array, $permissions, $credential_owner) {
@@ -253,7 +254,6 @@ 
 	/**
 	 * Delete ACL
 	 *
-	 * @param  ShareRequest $request
 	 * @return \OCA\Passman\Db\ShareRequest[]
 	 */
 	public function deleteShareACL(SharingACL $ACL) {
@@ -277,7 +277,6 @@ 
 	/**
 	 * Get pending share requests by guid and uid
 	 *
-	 * @param  ShareRequest $request
 	 * @return \OCA\Passman\Db\ShareRequest[]
 	 */
 	public function getPendingShareRequestsForCredential($item_guid, $user_id) {

lib/Service/CredentialService.php

Doc Comments +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
 
 	/**
 	 * Get credentials by vault id
-	 * @param $vault_id
+	 * @param integer $vault_id
 	 * @param $user_id
 	 * @return \OCA\Passman\Db\Vault[]
 	 */
@@ -91,7 +91,7 @@ 
 
 	/**
 	 * Get a random credential from given vault
-	 * @param $vault_id
+	 * @param integer $vault_id
 	 * @param $user_id
 	 * @return mixed
 	 */
@@ -102,7 +102,7 @@ 
 
 	/**
 	 * Get expired credentials.
-	 * @param $timestamp
+	 * @param integer $timestamp
 	 * @return \OCA\Passman\Db\Credential[]
 	 */
 	public function getExpiredCredentials($timestamp) {
@@ -132,7 +132,7 @@ 
 
 	/**
 	 * Get credential label by credential id.
-	 * @param $credential_id
+	 * @param integer $credential_id
 	 * @return Credential
 	 */
 	public function getCredentialLabelById($credential_id){

lib/Service/SettingsService.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
 	 * Get a app setting
 	 *
 	 * @param $key string
-	 * @param null $default_value The default value if key does not exist
+	 * @param boolean $default_value The default value if key does not exist
 	 * @return mixed
 	 */
 	public function getAppSetting($key, $default_value = null) {
@@ -110,7 +110,7 @@ 
 	/**
 	 * Check if an setting is enabled (value of 1)
 	 *
-	 * @param $setting
+	 * @param string $setting
 	 * @return bool
 	 */
 	public function isEnabled($setting) {

lib/Service/EncryptService.php

Doc Comments +9 added lines, -5 removed lines

@@ -213,6 +213,10 @@ 
 		return array($cipherKey, $macKey, $iv);
 	}
 
+	/**
+	 * @param string $a
+	 * @param string $b
+	 */
 	function hash_equals($a, $b) {
 		$key = openssl_random_pseudo_bytes(128);
 		return hash_hmac('sha512', $a, $key) === hash_hmac('sha512', $b, $key);
@@ -250,7 +254,7 @@ 
 	/**
 	 * Pad the data with a random char chosen by the pad amount.
 	 *
-	 * @param $data
+	 * @param string $data
 	 * @return string
 	 */
 	protected function pad($data) {
@@ -266,8 +270,8 @@ 
 	/**
 	 * Unpad the the data
 	 *
-	 * @param $data
-	 * @return bool|string
+	 * @param string $data
+	 * @return false|string
 	 */
 	protected function unpad($data) {
 		$length = $this->getKeySize();
@@ -284,7 +288,7 @@ 
 	 * Encrypt a credential
 	 *
 	 * @param array|Credential $credential the credential to decrypt
-	 * @return Credential|array
+	 * @return string
 	 */
 	public function decryptCredential($credential) {
 
@@ -380,7 +384,7 @@ 
 	/**
 	 * Decrypt a file
 	 *
-	 * @param  File|array $file
+	 * @param  File $file
 	 * @return File|array
 	 */