Conditions | 1 |
Paths | 1 |
Total Lines | 60 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | /* global API */ |
||
25 | (function () { |
||
26 | 'use strict'; |
||
27 | |||
28 | /** |
||
29 | * @ngdoc function |
||
30 | * @name passmanApp.controller:MainCtrl |
||
31 | * @description |
||
32 | * # MainCtrl |
||
33 | * Controller of the passmanApp |
||
34 | */ |
||
35 | angular.module('passmanExtension') |
||
36 | .controller('SearchCtrl', ['$scope', function ($scope) { |
||
37 | $scope.app = 'passman'; |
||
38 | var port = API.runtime.connect(null, { |
||
39 | name: "PassmanCommunication" |
||
40 | }); |
||
41 | |||
42 | var messageParser = function (message) { |
||
43 | var e = message.split(':'); |
||
44 | |||
45 | switch (e[0]) { |
||
46 | default: |
||
|
|||
47 | case "credential_amount": |
||
48 | $scope.credential_amount = e[1]; |
||
49 | $scope.refreshing_credentials = false; |
||
50 | } |
||
51 | |||
52 | $scope.$apply(); |
||
53 | }; |
||
54 | port.onMessage.addListener(messageParser); |
||
55 | port.postMessage("credential_amount"); |
||
56 | |||
57 | |||
58 | $scope.lockExtension = function () { |
||
59 | API.runtime.sendMessage(API.runtime.id, {method: "setMasterPassword", args: {password: null}}).then(function () { |
||
60 | window.location = '#!/locked'; |
||
61 | }); |
||
62 | }; |
||
63 | |||
64 | $scope.found_credentials = false; |
||
65 | $scope.searchText = ''; |
||
66 | $scope.search = function () { |
||
67 | API.runtime.sendMessage(API.runtime.id, {'method': 'searchCredential', args: $scope.searchText }).then(function (result) { |
||
68 | $scope.found_credentials = result; |
||
69 | $scope.$apply(); |
||
70 | }); |
||
71 | }; |
||
72 | |||
73 | |||
74 | $scope.goto_settings = function () { |
||
75 | window.location = '#!/settings'; |
||
76 | }; |
||
77 | |||
78 | $scope.goto_search = function () { |
||
79 | window.location = '#!/search'; |
||
80 | }; |
||
81 | |||
82 | |||
83 | }]); |
||
84 | }()); |
||
85 | |||
86 |