Preview::getPreview() - Code Metrics - Inspection of "Make use of the IPreview so we use shared previews" - nextcloud/gallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#187)

by Roeland

created 2017-01-04 12:03 UTC

Preview::getPreview() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	4
crap	2

<?php
/**
 * Gallery
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Olivier Paroz <[email protected]>
 *
 * @copyright Olivier Paroz 2014-2016
 */

namespace OCA\Gallery\Preview;

use OCP\Files\File;
use OCP\Files\NotFoundException;
use OCP\Image;
use OCP\IPreview;

/**
 * Generates previews
 *
 * @package OCA\Gallery\Preview
 */
class Preview {

	/**
	 * @var IPreview
	 */
	private $previewManager;

	/**
	 * Constructor
	 *
	 * @param IPreview $previewManager
	 */
	public function __construct(
		IPreview $previewManager
	) {
		$this->previewManager = $previewManager;
	}

	/**
	 * Returns true if the passed mime type is supported
	 *
	 * @param string $mimeType
	 *
	 * @return boolean
	 */
	public function isMimeSupported($mimeType = '*') {
		return $this->previewManager->isMimeSupported($mimeType);
	}

	/**
	 * @param File $file
	 * @param int $maxX
	 * @param int $maxY
	 * @param bool $keepAspect
	 * @return false|array<string,string|\OC_Image>

	 */
	public function getPreview(File $file, $maxX, $maxY, $keepAspect) {
		try {
			$preview = $this->previewManager->getPreview($file, $maxX, $maxY, !$keepAspect);
		} catch (NotFoundException $e) {

			return false;
		}

		$img = new Image($preview->getContent());
		return [
			'preview'  => $img,
			'mimetype' => $img->mimeType()
		];
	}

}


1		<?php
2		/**
3		* Gallery
4		*
5		* This file is licensed under the Affero General Public License version 3 or
6		* later. See the COPYING file.
7		*
8		* @author Olivier Paroz <[email protected]>
9		*
10		* @copyright Olivier Paroz 2014-2016
11		*/
12
13		namespace OCA\Gallery\Preview;
14
15		use OCP\Files\File;
16		use OCP\Files\NotFoundException;
17		use OCP\Image;
18		use OCP\IPreview;
19
20		/**
21		* Generates previews
22		*
23		* @package OCA\Gallery\Preview
24		*/
25		class Preview {
26
27		/**
28		* @var IPreview
29		*/
30		private $previewManager;
31
32		/**
33		* Constructor
34		*
35		* @param IPreview $previewManager
36		*/
37		public function __construct(
38		IPreview $previewManager
39		) {
40		$this->previewManager = $previewManager;
41		}
42
43		/**
44		* Returns true if the passed mime type is supported
45		*
46		* @param string $mimeType
47		*
48		* @return boolean
49		*/
50		public function isMimeSupported($mimeType = '*') {
51		return $this->previewManager->isMimeSupported($mimeType);
52		}
53
54		/**
55		* @param File $file
56		* @param int $maxX
57		* @param int $maxY
58		* @param bool $keepAspect
59		* @return false\|array<string,string\|\OC_Image>
		0 ignored issues – show Documentation introduced 2017-01-04 13:08 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `false\|array`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
60		*/
61		public function getPreview(File $file, $maxX, $maxY, $keepAspect) {
62		try {
63		$preview = $this->previewManager->getPreview($file, $maxX, $maxY, !$keepAspect);
64		} catch (NotFoundException $e) {
		0 ignored issues – show Bug introduced 2017-01-04 13:08 UTC by Report Bug Copy Issue Report The class `OCP\Files\NotFoundException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
65		return false;
66	35	}
67
68		$img = new Image($preview->getContent());
69		return [
70		'preview' => $img,
71	35	'mimetype' => $img->mimeType()
72	35	];
73	35	}
74	35
75		}
76

nextcloud / gallery

Pull Request — master (#187)

Preview::getPreview() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like