FilePropertiesService::setModifications() - Code Metrics - Inspection of "Rotate functionality" - nextcloud/gallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#490)

unknown

created 2018-12-08 22:24 UTC

FilePropertiesService::setModifications() A

↳ Parent: FilePropertiesService

Complexity

Conditions	2
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	2
nc	4
nop	2

<?php
namespace OCA\Gallery\Service;

use OCA\Gallery\Db\FileProperties;
use OCA\Gallery\Db\FilePropertiesMapper;
use OCP\AppFramework\Db\DoesNotExistException;
use OCA\Gallery\Environment\Environment;
use OCP\ILogger;

class FilePropertiesService extends Service {

	public function __construct(
		$appName,
		Environment $environment,
		ILogger $logger,
		FilePropertiesMapper $mapper
	) {
		parent::__construct($appName, $environment, $logger);
		$this->mapper = $mapper;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	public function getModifications($fileId) {
		try {
			$entity = $this->mapper->find($fileId);
			return $entity->getModifications();
		} catch (DoesNotExistException $ex) {

			return "{}";
		}
	}

	public function setModifications($fileId, $modificationsJson) {
		try {
			$entity = $this->mapper->find($fileId);
			$entity->setModifications($modificationsJson);
			$this->mapper->update($entity);
		} catch (DoesNotExistException $ex) {

			$entity = new FileProperties();
			$entity->setId($fileId);
			$entity->setModifications($modificationsJson);
			$this->mapper->insert($entity);
		}
	}
}


1			<?php
2			namespace OCA\Gallery\Service;
3
4			use OCA\Gallery\Db\FileProperties;
5			use OCA\Gallery\Db\FilePropertiesMapper;
6			use OCP\AppFramework\Db\DoesNotExistException;
7			use OCA\Gallery\Environment\Environment;
8			use OCP\ILogger;
9
10			class FilePropertiesService extends Service {
11
12			public function __construct(
13			$appName,
14			Environment $environment,
15			ILogger $logger,
16			FilePropertiesMapper $mapper
17			) {
18			parent::__construct($appName, $environment, $logger);
19			$this->mapper = $mapper;
			0 ignored issues – show Bug introduced 2018-12-04 21:31 UTC by Report Bug Copy Issue Report The property `mapper` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			}
21
22			public function getModifications($fileId) {
23			try {
24			$entity = $this->mapper->find($fileId);
25			return $entity->getModifications();
26			} catch (DoesNotExistException $ex) {
			0 ignored issues – show Bug introduced 2018-12-04 21:31 UTC by Report Bug Copy Issue Report The class `OCP\AppFramework\Db\DoesNotExistException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
27			return "{}";
28			}
29			}
30
31			public function setModifications($fileId, $modificationsJson) {
32			try {
33			$entity = $this->mapper->find($fileId);
34			$entity->setModifications($modificationsJson);
35			$this->mapper->update($entity);
36			} catch (DoesNotExistException $ex) {
			0 ignored issues – show Bug introduced 2018-12-04 21:31 UTC by Report Bug Copy Issue Report The class `OCP\AppFramework\Db\DoesNotExistException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
37			$entity = new FileProperties();
38			$entity->setId($fileId);
39			$entity->setModifications($modificationsJson);
40			$this->mapper->insert($entity);
41			}
42			}
43			}
44

nextcloud / gallery

Pull Request — master (#490)

FilePropertiesService::setModifications() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like