Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 39 | class ProviderService { |
||
| 40 | |||
| 41 | /** @var AppManager */ |
||
| 42 | private $appManager; |
||
| 43 | |||
| 44 | /** @var ConfigService */ |
||
| 45 | private $configService; |
||
| 46 | |||
| 47 | /** @var MiscService */ |
||
| 48 | private $miscService; |
||
| 49 | |||
| 50 | /** @var IFullTextSearchProvider[] */ |
||
| 51 | private $providers = []; |
||
| 52 | |||
| 53 | /** @var bool */ |
||
| 54 | private $providersLoaded = false; |
||
| 55 | |||
| 56 | |||
| 57 | /** |
||
| 58 | * ProviderService constructor. |
||
| 59 | * |
||
| 60 | * @param AppManager $appManager |
||
| 61 | * @param ConfigService $configService |
||
| 62 | * @param MiscService $miscService |
||
| 63 | * |
||
| 64 | */ |
||
| 65 | public function __construct( |
||
| 72 | |||
| 73 | |||
| 74 | /** |
||
| 75 | * Load all FullTextSearchProviders set in any info.xml file |
||
| 76 | * |
||
| 77 | * @throws Exception |
||
| 78 | */ |
||
| 79 | private function loadProviders() { |
||
| 95 | |||
| 96 | |||
| 97 | /** |
||
| 98 | * @param string $providerId |
||
| 99 | * |
||
| 100 | * @throws ProviderIsNotCompatibleException |
||
| 101 | * @throws ProviderIsNotUniqueException |
||
| 102 | * @throws QueryException |
||
| 103 | */ |
||
| 104 | public function loadProvider($providerId) { |
||
| 120 | |||
| 121 | |||
| 122 | /** |
||
| 123 | * @return IFullTextSearchProvider[] |
||
| 124 | * @throws Exception |
||
| 125 | */ |
||
| 126 | public function getProviders() { |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @return IFullTextSearchProvider[] |
||
| 134 | * @throws Exception |
||
| 135 | */ |
||
| 136 | public function getConfiguredProviders() { |
||
| 148 | |||
| 149 | |||
| 150 | /** |
||
| 151 | * @param array $providerList |
||
| 152 | * |
||
| 153 | * @return IFullTextSearchProvider[] |
||
| 154 | * @throws Exception |
||
| 155 | * @throws ProviderDoesNotExistException |
||
| 156 | */ |
||
| 157 | public function getFilteredProviders($providerList) { |
||
| 174 | |||
| 175 | |||
| 176 | /** |
||
| 177 | * @param string $providerId |
||
| 178 | * |
||
| 179 | * @return IFullTextSearchProvider |
||
| 180 | * @throws Exception |
||
| 181 | * @throws ProviderDoesNotExistException |
||
| 182 | */ |
||
| 183 | public function getProvider($providerId) { |
||
| 194 | |||
| 195 | |||
| 196 | /** |
||
| 197 | * @param string $providerId |
||
| 198 | * |
||
| 199 | * @return bool |
||
| 200 | */ |
||
| 201 | public function isProviderIndexed($providerId) { |
||
| 217 | |||
| 218 | |||
| 219 | public function setProviderAsIndexed(IFullTextSearchProvider $provider, $boolean) { |
||
| 224 | |||
| 225 | |||
| 226 | public function setProvidersAsNotIndexed() { |
||
| 229 | |||
| 230 | |||
| 231 | /** |
||
| 232 | * @param string $appId |
||
| 233 | * |
||
| 234 | * @throws ProviderIsNotCompatibleException |
||
| 235 | * @throws ProviderIsNotUniqueException |
||
| 236 | * @throws QueryException |
||
| 237 | */ |
||
| 238 | private function loadProvidersFromApp($appId) { |
||
| 248 | |||
| 249 | |||
| 250 | /** |
||
| 251 | * @param string|array $providers |
||
| 252 | * |
||
| 253 | * @throws ProviderIsNotCompatibleException |
||
| 254 | * @throws ProviderIsNotUniqueException |
||
| 255 | * @throws QueryException |
||
| 256 | */ |
||
| 257 | private function loadProvidersFromList($providers) { |
||
| 266 | |||
| 267 | |||
| 268 | /** |
||
| 269 | * @param IFullTextSearchProvider $provider |
||
| 270 | * |
||
| 271 | * @throws ProviderIsNotUniqueException |
||
| 272 | */ |
||
| 273 | private function providerIdMustBeUnique(IFullTextSearchProvider $provider) { |
||
| 282 | |||
| 283 | |||
| 284 | /** |
||
| 285 | * @param IFullTextSearchProvider[] $providers |
||
| 286 | * |
||
| 287 | * @return array |
||
| 288 | */ |
||
| 289 | public function serialize($providers) { |
||
| 300 | |||
| 301 | } |