Completed
Pull Request — master (#354)
by Maxence
04:57
created
lib/Model/SearchRequest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
 		$options = ['is', 'show'];
155 155
 
156 156
 		if (in_array($kw, $options)) {
157
-			$this->addOption($kw . '_' . $value, '1');
157
+			$this->addOption($kw.'_'.$value, '1');
158 158
 
159 159
 			return true;
160 160
 		}
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -218,8 +218,8 @@  discard block
 block discarded – undo
218 218
 	}
219 219
 
220 220
 	/**
221
-	 * @param $key
222
-	 * @param $value
221
+	 * @param string $key
222
+	 * @param string $value
223 223
 	 *
224 224
 	 * @return $this
225 225
 	 */
@@ -315,7 +315,6 @@  discard block
 block discarded – undo
315 315
 
316 316
 
317 317
 	/**
318
-	 * @param array $query
319 318
 	 *
320 319
 	 * @return $this
321 320
 	 */
@@ -334,7 +333,6 @@  discard block
 block discarded – undo
334 333
 
335 334
 
336 335
 	/**
337
-	 * @param array $query
338 336
 	 *
339 337
 	 * @return $this
340 338
 	 */
Please login to merge, or discard this patch.
lib/Command/Index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 					continue;
124 124
 				}
125 125
 
126
-				$this->runner->output('indexing ' . $provider->getName() . '.');
126
+				$this->runner->output('indexing '.$provider->getName().'.');
127 127
 				$provider->setRunner($this->runner);
128 128
 				$provider->setIndexOptions($options);
129 129
 				$this->indexProvider($provider, $options);
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 				continue;
158 158
 			}
159 159
 
160
-			$this->runner->output(' USER: ' . $user->getUID());
160
+			$this->runner->output(' USER: '.$user->getUID());
161 161
 			$this->indexService->indexProviderContentFromUser(
162 162
 				$platform, $provider, $user->getUID(), $options
163 163
 			);
Please login to merge, or discard this patch.
lib/Command/Test.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -210,7 +210,7 @@
 block discarded – undo
210 210
 
211 211
 	/**
212 212
 	 * @param string|bool $line
213
-	 * @param $isNewLine
213
+	 * @param boolean $isNewLine
214 214
 	 *
215 215
 	 * @return string
216 216
 	 */
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 			'platform_delay'
139 139
 		) : self::DELAY_STABILIZE_PLATFORM;
140 140
 
141
-		echo '$' . $input->getOption('platform_delay') . '$';
141
+		echo '$'.$input->getOption('platform_delay').'$';
142 142
 		$this->output($output, '.Testing your current setup:');
143 143
 
144 144
 		try {
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 			$output->write(' ', true);
205 205
 		}
206 206
 
207
-		$output->write($line . ' ', false);
207
+		$output->write($line.' ', false);
208 208
 	}
209 209
 
210 210
 
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 		$this->output($output, 'Testing mocked provider: get indexable documents.');
255 255
 		$indexableDocuments =
256 256
 			$testProvider->generateIndexableDocuments(TestService::DOCUMENT_USER1);
257
-		$this->output($output, '(' . sizeof($indexableDocuments) . ' items)', false);
257
+		$this->output($output, '('.sizeof($indexableDocuments).' items)', false);
258 258
 		$this->output($output, true);
259 259
 	}
260 260
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 	private function testLoadingPlatform($output) {
269 269
 		$this->output($output, 'Loading search platform.');
270 270
 		$testPlatform = $this->platformService->getPlatform();
271
-		$this->output($output, '(' . $testPlatform->getName() . ')', false);
271
+		$this->output($output, '('.$testPlatform->getName().')', false);
272 272
 		$this->output($output, true);
273 273
 
274 274
 		$this->output($output, 'Testing search platform.');
@@ -358,13 +358,13 @@  discard block
 block discarded – undo
358 358
 			);
359 359
 
360 360
 			$this->output(
361
-				$output, '(size: ' . $indexDocument->getContentSize() . ')', false
361
+				$output, '(size: '.$indexDocument->getContentSize().')', false
362 362
 			);
363 363
 			$this->output($output, true);
364 364
 		} catch (Exception $e) {
365 365
 			throw new Exception(
366
-				"Issue while getting test document '" . TestService::DOCUMENT_TYPE_LICENSE
367
-				. "' from search platform: " . $e->getMessage()
366
+				"Issue while getting test document '".TestService::DOCUMENT_TYPE_LICENSE
367
+				. "' from search platform: ".$e->getMessage()
368 368
 			);
369 369
 		}
370 370
 
@@ -537,7 +537,7 @@  discard block
 block discarded – undo
537 537
 	) {
538 538
 		$this->output(
539 539
 			$output,
540
-			" - '" . $search . "'" . (($moreOutput === '') ? '' : ' - ' . $moreOutput . ' - ')
540
+			" - '".$search."'".(($moreOutput === '') ? '' : ' - '.$moreOutput.' - ')
541 541
 		);
542 542
 		$request = new SearchRequest();
543 543
 
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 		$searchResult = $testPlatform->searchDocuments($testProvider, $access, $request);
546 546
 		$this->output(
547 547
 			$output,
548
-			'(result: ' . $searchResult->getCount() . ', expected: ' . json_encode($expected) . ')',
548
+			'(result: '.$searchResult->getCount().', expected: '.json_encode($expected).')',
549 549
 			false
550 550
 		);
551 551
 		$this->compareSearchResult($searchResult, $expected);
@@ -609,12 +609,12 @@  discard block
 block discarded – undo
609 609
 	private function compareSearchResult(SearchResult $searchResult, $entries) {
610 610
 		$documents = $searchResult->getDocuments();
611 611
 		if (sizeof($documents) !== sizeof($entries)) {
612
-			throw new \Exception('Unexpected SearchResult: ' . json_encode($searchResult));
612
+			throw new \Exception('Unexpected SearchResult: '.json_encode($searchResult));
613 613
 		}
614 614
 
615 615
 		foreach ($documents as $document) {
616 616
 			if (!in_array($document->getId(), $entries)) {
617
-				throw new \Exception('Unexpected Document: ' . json_encode($document));
617
+				throw new \Exception('Unexpected Document: '.json_encode($document));
618 618
 			}
619 619
 		}
620 620
 	}
@@ -627,7 +627,7 @@  discard block
 block discarded – undo
627 627
 	 * @throws InterruptException
628 628
 	 */
629 629
 	private function pause(OutputInterface $output, $s) {
630
-		$this->output($output, 'Pausing ' . $s . ' seconds');
630
+		$this->output($output, 'Pausing '.$s.' seconds');
631 631
 
632 632
 		for ($i = 1; $i <= $s; $i++) {
633 633
 			if (time_nanosleep(1, 0) !== true) {
Please login to merge, or discard this patch.
lib/Service/TestService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	public function generateIndexDocumentContentLicense(IndexOptions $options = null) {
78 78
 		$indexDocument = $this->generateIndexDocument(self::DOCUMENT_TYPE_LICENSE);
79 79
 
80
-		$content = file_get_contents(__DIR__ . '/../../LICENSE');
80
+		$content = file_get_contents(__DIR__.'/../../LICENSE');
81 81
 		$indexDocument->setContent($content);
82 82
 
83 83
 		if ($options === null) {
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 			$orig = call_user_func([$origIndex, $method]);
135 135
 			$compare = call_user_func([$compareIndex, $method]);
136 136
 			if ($orig !== $compare) {
137
-				throw new \Exception($method . '() orig:' . $orig . ' compare:' . $compare);
137
+				throw new \Exception($method.'() orig:'.$orig.' compare:'.$compare);
138 138
 
139 139
 			};
140 140
 		}
Please login to merge, or discard this patch.