Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
48 | class CoreRequestBuilder { |
||
49 | |||
50 | const TABLE_INDEXES = 'fulltextsearch_indexes'; |
||
51 | const TABLE_TICKS = 'fulltextsearch_ticks'; |
||
52 | |||
53 | /** @var IDBConnection */ |
||
54 | protected $dbConnection; |
||
55 | |||
56 | /** @var IL10N */ |
||
57 | protected $l10n; |
||
58 | |||
59 | /** @var ConfigService */ |
||
60 | protected $configService; |
||
61 | |||
62 | /** @var MiscService */ |
||
63 | protected $miscService; |
||
64 | |||
65 | /** @var string */ |
||
66 | protected $defaultSelectAlias; |
||
67 | |||
68 | |||
69 | /** |
||
70 | * CoreRequestBuilder constructor. |
||
71 | * |
||
72 | * @param IL10N $l10n |
||
73 | * @param IDBConnection $connection |
||
74 | * @param ConfigService $configService |
||
75 | * @param MiscService $miscService |
||
76 | */ |
||
77 | public function __construct( |
||
86 | |||
87 | |||
88 | /** |
||
89 | * Limit the request to the Id |
||
90 | * |
||
91 | * @param IQueryBuilder $qb |
||
92 | * @param int $id |
||
93 | */ |
||
94 | protected function limitToId(IQueryBuilder &$qb, int $id) { |
||
97 | |||
98 | |||
99 | /** |
||
100 | * Limit the request to the OwnerId |
||
101 | * |
||
102 | * @param IQueryBuilder $qb |
||
103 | * @param string $userId |
||
104 | */ |
||
105 | protected function limitToOwnerId(IQueryBuilder &$qb, string $userId) { |
||
108 | |||
109 | |||
110 | /** |
||
111 | * Limit to the providerId |
||
112 | * |
||
113 | * @param IQueryBuilder $qb |
||
114 | * @param string $providerId |
||
115 | */ |
||
116 | protected function limitToProviderId(IQueryBuilder &$qb, string $providerId) { |
||
119 | |||
120 | |||
121 | /** |
||
122 | * Limit to the documentId |
||
123 | * |
||
124 | * @param IQueryBuilder $qb |
||
125 | * @param string $documentId |
||
126 | */ |
||
127 | protected function limitToDocumentId(IQueryBuilder &$qb, string $documentId) { |
||
130 | |||
131 | |||
132 | /** |
||
133 | * Limit to the entry with at least one Error |
||
134 | * |
||
135 | * @param IQueryBuilder $qb |
||
136 | */ |
||
137 | protected function limitToErr(IQueryBuilder &$qb) { |
||
141 | |||
142 | |||
143 | /** |
||
144 | * Limit to the entry with no error |
||
145 | * |
||
146 | * @param IQueryBuilder $qb |
||
147 | */ |
||
148 | protected function limitToNoErr(IQueryBuilder &$qb) { |
||
152 | |||
153 | |||
154 | /** |
||
155 | * Limit to documentIds |
||
156 | * |
||
157 | * @param IQueryBuilder $qb |
||
158 | * @param array $documentIds |
||
159 | */ |
||
160 | protected function limitToDocumentIds(IQueryBuilder &$qb, array $documentIds) { |
||
163 | |||
164 | |||
165 | /** |
||
166 | * Limit the request to source |
||
167 | * |
||
168 | * @param IQueryBuilder $qb |
||
169 | * @param string $source |
||
170 | */ |
||
171 | protected function limitToSource(IQueryBuilder &$qb, string $source) { |
||
174 | |||
175 | |||
176 | /** |
||
177 | * Limit the request to status |
||
178 | * |
||
179 | * @param IQueryBuilder $qb |
||
180 | * @param string $status |
||
181 | */ |
||
182 | protected function limitToStatus(IQueryBuilder &$qb, string $status) { |
||
185 | |||
186 | |||
187 | /** |
||
188 | * @param IQueryBuilder $qb |
||
189 | * @param string $field |
||
190 | * @param string $value |
||
191 | */ |
||
192 | View Code Duplication | private function limitToDBField(IQueryBuilder &$qb, string $field, string $value) { |
|
199 | |||
200 | /** |
||
201 | * @param IQueryBuilder $qb |
||
202 | * @param string $field |
||
203 | * @param int $value |
||
204 | */ |
||
205 | View Code Duplication | private function limitToDBFieldInt(IQueryBuilder &$qb, string $field, int $value) { |
|
212 | |||
213 | |||
214 | /** |
||
215 | * @param IQueryBuilder $qb |
||
216 | * @param string $field |
||
217 | * @param string|integer|array $values |
||
218 | */ |
||
219 | private function limitToDBFieldArray(IQueryBuilder &$qb, string $field, array $values) { |
||
235 | |||
236 | |||
237 | /** |
||
238 | * @param IQueryBuilder $qb |
||
239 | */ |
||
240 | protected function limitToQueuedIndexes(IQueryBuilder &$qb) { |
||
245 | |||
246 | } |
||
247 | |||
250 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.