Issues in public-share.js (master) - Issues in master - nextcloud/files_texteditor - Measure and Improve Code Quality continuously with Scrutinizer

Issues (278)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

js/public-share.js (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

// FIXME: Hack for single public file view since it is not attached to the fileslist
$(document).ready(function(){
	var isPublic = $('#isPublic').val();
	var mimetype = $('#mimetype').val();
	var filesize = $('#filesize').val();

	if (isPublic &&
		mimetype === 'text/markdown' &&
		filesize < 524288) {

		var sharingToken = $('#sharingToken').val();
		var downloadUrl = OC.generateUrl('/s/{token}/download', {token: sharingToken});
		var previewElement = $('#imgframe');
		var renderer = new marked.Renderer();
		renderer.link = function(href, title, text) {
			try {
				var prot = decodeURIComponent(unescape(href))
					.replace(/[^\w:]/g, '')
					.toLowerCase();
			} catch (e) {
				return '';
			}

			if (prot.indexOf('http:') !== 0 && prot.indexOf('https:') !== 0) {
function someFunction() {
    (function() {
        var i = 0;
    })();

    // i is not defined.
    alert(i);
}

// This can be fixed by moving the var statement to the outer scope.

function someFunction() {
    var i;
    (function() {
        i = 1;
    })();

    alert(i);
};
				return '';
			}

			var out = '<a href="' + href + '" rel="noreferrer noopener"';
			if (title) {
				out += ' title="' + title + '"';
			}
			out += '>' + text + '</a>';
			return out;
		};
		renderer.image = function(href, title, text) {
			if (text) {
				return text;
			}
			return title;
		};
		renderer.blockquote = function(quote) {
			return quote;
		};

		previewElement
			.addClass('icon-loading')
			.children().remove();

		$.get(downloadUrl).success(function(content) {
			previewElement
				.removeClass('icon-loading')
				.addClass('preview formatted-text')
				.html(DOMPurify.sanitize(
					marked(content, {
						renderer: renderer,
						gfm: false,
						breaks: false,
						pedantic: false,
						smartLists: true,
						smartypants: false
					}),
					{
						SAFE_FOR_JQUERY: true
					}
				));
		}).fail(function(result){
			previewElement
				.removeClass('icon-loading');
		});
	} else if (isPublic &&
			   mimetype.substr(0, mimetype.indexOf('/')) === 'text') {
		// Based on default text previews from "files_sharing/js/public.js", but
		// using the public endpoint from files_texteditor for better character
		// encoding support.
		var previewElement = $('#imgframe');

		previewElement
			.addClass('icon-loading')
			.children().remove();

		var bottomMargin = 350;
		var previewHeight = $(window).height() - bottomMargin;
		previewHeight = Math.max(200, previewHeight);

		var sharingToken = $('#sharingToken').val();

		$.ajax({
			url: OC.generateUrl('/apps/files_texteditor/public/{token}', { token: sharingToken }),
			headers: {
				'Range': 'bytes=0-524288'
			}
		}).success(function(content) {
			var textDiv = $('<div/>').addClass('text-preview default-overridden');
			textDiv.text(content);

			previewElement
				.removeClass('icon-loading')
				.addClass('preview')
				.append(textDiv);

			var divHeight = textDiv.height();
			if (content.length > 524289) {
				var ellipsis = $('<div/>').addClass('ellipsis');
				ellipsis.html('(&#133;)');
				ellipsis.appendTo('#imgframe');
			}
			if (divHeight > previewHeight) {
				textDiv.height(previewHeight);
			}
		});
	}
});


1			// FIXME: Hack for single public file view since it is not attached to the fileslist
2			$(document).ready(function(){
3			var isPublic = $('#isPublic').val();
4			var mimetype = $('#mimetype').val();
5			var filesize = $('#filesize').val();
6
7			if (isPublic &&
8			mimetype === 'text/markdown' &&
9			filesize < 524288) {
10
11			var sharingToken = $('#sharingToken').val();
12			var downloadUrl = OC.generateUrl('/s/{token}/download', {token: sharingToken});
13			var previewElement = $('#imgframe');
14			var renderer = new marked.Renderer();
15			renderer.link = function(href, title, text) {
16			try {
17			var prot = decodeURIComponent(unescape(href))
18			.replace(/[^\w:]/g, '')
19			.toLowerCase();
20			} catch (e) {
21			return '';
22			}
23
24			if (prot.indexOf('http:') !== 0 && prot.indexOf('https:') !== 0) {
			0 ignored issues – show Bug introduced 2017-07-20 22:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `prot` seems to be used out of scope. This error can usually be fixed by declaring the variable in the scope where it is used: function someFunction() { (function() { var i = 0; })(); // i is not defined. alert(i); } // This can be fixed by moving the var statement to the outer scope. function someFunction() { var i; (function() { i = 1; })(); alert(i); }; Loading history...
25			return '';
26			}
27
28			var out = '<a href="' + href + '" rel="noreferrer noopener"';
29			if (title) {
30			out += ' title="' + title + '"';
31			}
32			out += '>' + text + '</a>';
33			return out;
34			};
35			renderer.image = function(href, title, text) {
36			if (text) {
37			return text;
38			}
39			return title;
40			};
41			renderer.blockquote = function(quote) {
42			return quote;
43			};
44
45			previewElement
46			.addClass('icon-loading')
47			.children().remove();
48
49			$.get(downloadUrl).success(function(content) {
50			previewElement
51			.removeClass('icon-loading')
52			.addClass('preview formatted-text')
53			.html(DOMPurify.sanitize(
54			marked(content, {
55			renderer: renderer,
56			gfm: false,
57			breaks: false,
58			pedantic: false,
59			smartLists: true,
60			smartypants: false
61			}),
62			{
63			SAFE_FOR_JQUERY: true
64			}
65			));
66			}).fail(function(result){
67			previewElement
68			.removeClass('icon-loading');
69			});
70			} else if (isPublic &&
71			mimetype.substr(0, mimetype.indexOf('/')) === 'text') {
72			// Based on default text previews from "files_sharing/js/public.js", but
73			// using the public endpoint from files_texteditor for better character
74			// encoding support.
75			var previewElement = $('#imgframe');
			0 ignored issues – show Bug introduced 2018-02-09 10:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `previewElement` was already defined. Loading history...
76			previewElement
77			.addClass('icon-loading')
78			.children().remove();
79
80			var bottomMargin = 350;
81			var previewHeight = $(window).height() - bottomMargin;
82			previewHeight = Math.max(200, previewHeight);
83
84			var sharingToken = $('#sharingToken').val();
			0 ignored issues – show Bug introduced 2018-02-09 10:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `sharingToken` was already defined. Loading history...
85			$.ajax({
86			url: OC.generateUrl('/apps/files_texteditor/public/{token}', { token: sharingToken }),
87			headers: {
88			'Range': 'bytes=0-524288'
89			}
90			}).success(function(content) {
91			var textDiv = $('<div/>').addClass('text-preview default-overridden');
92			textDiv.text(content);
93
94			previewElement
95			.removeClass('icon-loading')
96			.addClass('preview')
97			.append(textDiv);
98
99			var divHeight = textDiv.height();
100			if (content.length > 524289) {
101			var ellipsis = $('<div/>').addClass('ellipsis');
102			ellipsis.html('()');
103			ellipsis.appendTo('#imgframe');
104			}
105			if (divHeight > previewHeight) {
106			textDiv.height(previewHeight);
107			}
108			});
109			}
110			});
111

nextcloud / files_texteditor

Issues (278)

Security Analysis no request data

js/public-share.js (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like