OCA\Files_Antivirus\Scanner\Local

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

92%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	shutdownScanner()	0	12	1
A	__construct()	0	10	2
A	initScanner()	0	16	2

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <victor.dubiniuk@gmail.com>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;

class Local extends ScannerBase{
	
	/**
	 * @var string
	 */
	protected $avPath;
	
	/**
	 * STDIN and STDOUT descriptors
	 * @var array of resources
	 */
	private $pipes = [];
	
	/**
	 * Process handle
	 * @var resource
	 */
	private $process;
	
	public function __construct(AppConfig $config){
		$this->appConfig = $config;
		// get the path to the executable
		$this->avPath = escapeshellcmd($this->appConfig->getAvPath());

		// check that the executable is available
		if (!file_exists($this->avPath)) {
			throw new \RuntimeException('The antivirus executable could not be found at ' . $this->avPath);
		}
	}
	
	public function initScanner(){
		parent::initScanner();
		
		// using 2>&1 to grab the full command-line output.
		$cmd = $this->avPath . " " . $this->appConfig->getCmdline() ." - 2>&1";
		$descriptorSpec = array(
			0 => ["pipe","r"], // STDIN
			1 => ["pipe","w"]  // STDOUT
		);
		
		$this->process = proc_open($cmd, $descriptorSpec, $this->pipes);
		if (!is_resource($this->process)) {
			throw new \RuntimeException('Error starting process');
		}
		$this->writeHandle = $this->pipes[0];
	}
	
	protected function shutdownScanner(){
		@fclose($this->pipes[0]);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$output = stream_get_contents($this->pipes[1]);
		@fclose($this->pipes[1]);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		
		$result = proc_close($this->process);
		\OC::$server->getLogger()->debug(
			'Exit code :: ' . $result . ' Response :: ' . $output,
			['app' => 'files_antivirus']
		);
		$this->status->parseResponse($output, $result);
	}
}