OCA\Files_Antivirus\Item

Complexity

Total Complexity

24

Size/Duplication

Total Lines	193
Duplicated Lines	6.74 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	1
A	isValid()	0	3	1
B	fread()	0	13	5
A	processInfected()	0	23	3
A	processUnchecked()	0	4	1
A	processClean()	0	20	4
A	feof()	0	9	2
A	getFileHandle()	0	10	2
A	deleteFile()	0	10	3
A	logDebug()	0	6	1
A	logError()	0	7	1

<?php
/**
 * Copyright (c) 2015 Victor Dubiniuk <victor.dubiniuk@gmail.com>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Files_Antivirus;

use OCA\Files_Antivirus\Activity\Provider;
use OCA\Files_Antivirus\AppInfo\Application;
use OCA\Files_Antivirus\Db\ItemMapper;
use OCP\Activity\IManager as ActivityManager;
use OCP\App;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\Files\File;
use OCP\IL10N;
use OCP\ILogger;

class Item implements IScannable{
	/**
	 * file handle, user to read from the file
	 * @var resource
	 */
	protected $fileHandle;

	/** @var IL10N */
	private $l10n;

	/** @var AppConfig */
	private $config;

	/** @var ActivityManager */
	private $activityManager;

	/** @var ItemMapper */
	private $itemMapper;

	/** @var ILogger */
	private $logger;

	/** @var File */
	private $file;

	public function __construct(IL10N $l10n,

This method seems to be duplicated in your project.

								AppConfig $appConfig,
								ActivityManager $activityManager,
								ItemMapper $itemMapper,
								ILogger $logger,
								File $file) {
		$this->l10n = $l10n;
		$this->config = $appConfig;
		$this->activityManager = $activityManager;
		$this->itemMapper = $itemMapper;
		$this->logger = $logger;
		$this->file = $file;
	}

	/**
	 * Is this file good for scanning? 
	 * @return boolean
	 */
	public function isValid() {
		return $this->file->getSize() > 0;
	}

	/**
	 * Reads a file portion by portion until the very end
	 * @return string|boolean
	 */
	public function fread() {
		if (!$this->isValid()) {
			return false;
		}
		if (is_null($this->fileHandle)) {
			$this->getFileHandle();
		}
		
		if (!is_null($this->fileHandle) && !$this->feof()) {
			return fread($this->fileHandle, $this->config->getAvChunkSize());
		}
		return false;
	}

	/**
	 * Action to take if this item is infected
	 * @param Status $status
	 */
	public function processInfected(Status $status) {
		$infectedAction = $this->config->getAvInfectedAction();
		
		$shouldDelete = $infectedAction === 'delete';
		
		$message = $shouldDelete ? Provider::MESSAGE_FILE_DELETED : '';

		$activity = $this->activityManager->generateEvent();
		$activity->setApp(Application::APP_NAME)
			->setSubject(Provider::SUBJECT_VIRUS_DETECTED, [$this->file->getPath(), $status->getDetails()])
			->setMessage($message)
			->setObject('file', $this->file->getId(), $this->file->getPath())
			->setAffectedUser($this->file->getOwner()->getUID())
			->setType(Provider::TYPE_VIRUS_DETECTED);
		$this->activityManager->publish($activity);

		if ($shouldDelete) {
			$this->logError('Infected file deleted. ' . $status->getDetails());
			$this->deleteFile();
		} else {
			$this->logError('File is infected. '  . $status->getDetails());
		}
	}

	/**
	 * Action to take if this item status is unclear
	 * @param Status $status
	 * @param boolean $isBackground

There is no parameter named $isBackground. Was it maybe removed?

	 */
	public function processUnchecked(Status $status) {
		//TODO: Show warning to the user: The file can not be checked
		$this->logError('Not Checked. ' . $status->getDetails());
	}

	/**
	 * Action to take if this item status is not infected
	 * @param Status $status
	 * @param boolean $isBackground
	 */
	public function processClean(Status $status, $isBackground) {

The parameter $status is not used and could be removed.

		if (!$isBackground) {
			return;
		}
		try {
			try {
				$item = $this->itemMapper->findByFileId($this->file->getId());
				$this->itemMapper->delete($item);
			} catch (DoesNotExistException $e) {

The class OCP\AppFramework\Db\DoesNotExistException does not exist. Did you forget a USE statement, or did you not list all dependencies?

				//Just ignore
			}

			$item = new \OCA\Files_Antivirus\Db\Item();
			$item->setFileid($this->file->getId());
			$item->setCheckTime(time());
			$this->itemMapper->insert($item);
		} catch(\Exception $e) {
			$this->logger->error(__METHOD__.', exception: '.$e->getMessage(), ['app' => 'files_antivirus']);
		}
	}

	/**
	 * Check if the end of file is reached
	 * @return boolean
	 */
	private function feof() {
		$isDone = feof($this->fileHandle);
		if ($isDone) {
			$this->logDebug('Scan is done');
			fclose($this->fileHandle);
			$this->fileHandle = null;
		}
		return $isDone;
	}

	/**
	 * Opens a file for reading
	 * @throws \RuntimeException
	 */
	private function getFileHandle() {
		$fileHandle = $this->file->fopen('r');
		if ($fileHandle === false) {
			$this->logError('Can not open for reading.');
			throw new \RuntimeException();
		}

		$this->logDebug('Scan started');
		$this->fileHandle = $fileHandle;
	}

	/**
	 * Delete infected file
	 */
	private function deleteFile() {
		//prevent from going to trashbin
		if (App::isEnabled('files_trashbin')) {
			\OCA\Files_Trashbin\Storage::preRenameHook([]);
		}
		$this->file->delete();
		if (App::isEnabled('files_trashbin')) {
			\OCA\Files_Trashbin\Storage::postRenameHook([]);
		}
	}

	/**
	 * @param string $message
	 */
	public function logDebug($message) {
		$extra = ' File: ' . $this->file->getId()
				. 'Account: ' . $this->file->getOwner()->getUID()
				. ' Path: ' . $this->file->getPath();
		$this->logger->debug($message . $extra, ['app' => 'files_antivirus']);
	}

	/**
	 * @param string $message
	 */
	public function logError($message) {
		$ownerInfo = 'Account: ' . $this->file->getOwner()->getUID();
		$extra = ' File: ' . $this->file->getId()
				. $ownerInfo 
				. ' Path: ' . $this->file->getPath();
		$this->logger->error($message . $extra, ['app' => 'files_antivirus']);
	}
}