ExternalClam::shutdownScanner() - Code Metrics - Inspection of "Merge pull request #160 from nextcloud/kaspersky" - nextcloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b32497...b91e8b )

by Roeland

created 2020-09-01 07:13 UTC

ExternalClam::shutdownScanner() A

↳ Parent: ExternalClam

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	9
cp	0
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;
use OCA\Files_Antivirus\StatusFactory;
use OCP\ILogger;

class ExternalClam extends ScannerBase {
	
	/**
	 * Daemon/socket mode
	 * @var bool
	 */
	private $useSocket;

	/**
	 * External constructor.
	 *
	 * @param AppConfig $config
	 * @param ILogger $logger
	 * @param StatusFactory $statusFactory
	 */
	public function __construct(AppConfig $config, ILogger $logger, StatusFactory $statusFactory) {
		parent::__construct($config, $logger, $statusFactory);
		$this->useSocket = $this->appConfig->getAvMode() === 'socket';
	}
	
	public function initScanner(){
		parent::initScanner();
		
		if ($this->useSocket){
			$avSocket = $this->appConfig->getAvSocket();
			$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
			if (!$this->getWriteHandle()) {
				throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
			}
		} else {
			$avHost = $this->appConfig->getAvHost();
			$avPort = $this->appConfig->getAvPort();
			if (!($avHost && $avPort)) {
				throw new \RuntimeException('The ClamAV port and host are not set up.');
			}
			$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
			if (!$this->getWriteHandle()) {
				throw new \RuntimeException('The ClamAV module is not in daemon mode.');
			}
		}

		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
	}
	
	protected function shutdownScanner(){
		@fwrite($this->getWriteHandle(), pack('N', 0));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$response = fgets($this->getWriteHandle());
		$this->logger->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@fclose($this->getWriteHandle());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		
		$this->status->parseResponse($response);
	}
	
	protected function prepareChunk($data){
		$chunkLength = pack('N', strlen($data));
		return $chunkLength . $data;
	}
}


1		<?php
2		/**
3		* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		use OCA\Files_Antivirus\AppConfig;
13		use OCA\Files_Antivirus\StatusFactory;
14		use OCP\ILogger;
15
16		class ExternalClam extends ScannerBase {
17
18		/**
19		* Daemon/socket mode
20		* @var bool
21		*/
22		private $useSocket;
23
24		/**
25		* External constructor.
26		*
27		* @param AppConfig $config
28		* @param ILogger $logger
29		* @param StatusFactory $statusFactory
30		*/
31	2	public function __construct(AppConfig $config, ILogger $logger, StatusFactory $statusFactory) {
32	2	parent::__construct($config, $logger, $statusFactory);
33	2	$this->useSocket = $this->appConfig->getAvMode() === 'socket';
34	2	}
35
36		public function initScanner(){
37		parent::initScanner();
38
39		if ($this->useSocket){
40		$avSocket = $this->appConfig->getAvSocket();
41		$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
42		if (!$this->getWriteHandle()) {
43		throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
44		}
45		} else {
46		$avHost = $this->appConfig->getAvHost();
47		$avPort = $this->appConfig->getAvPort();
48		if (!($avHost && $avPort)) {
49		throw new \RuntimeException('The ClamAV port and host are not set up.');
50		}
51		$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
52		if (!$this->getWriteHandle()) {
53		throw new \RuntimeException('The ClamAV module is not in daemon mode.');
54		}
55		}
56
57		// request scan from the daemon
58		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
59		}
60
61		protected function shutdownScanner(){
62		@fwrite($this->getWriteHandle(), pack('N', 0));
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
63		$response = fgets($this->getWriteHandle());
64		$this->logger->debug(
65		'Response :: ' . $response,
66		['app' => 'files_antivirus']
67		);
68		@fclose($this->getWriteHandle());
		0 ignored issues – show Security Best Practice introduced 2017-02-07 20:56 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
69
70		$this->status->parseResponse($response);
71		}
72
73		protected function prepareChunk($data){
74		$chunkLength = pack('N', strlen($data));
75		return $chunkLength . $data;
76		}
77		}
78

nextcloud / files_antivirus

Push — master ( b32497...b91e8b )

ExternalClam::shutdownScanner() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like